[sip-comm-dev] Minor error when setting up media streams


#1

Minor error:
If the media is not transmittable, atLeastOneTransmitterStarted still could
be set to true.

In MediaManager.openMediaStreams

                  //START TRANSMISSION
                  try {
                     if (isMediaTransmittable(mediaType)) {
                         ports.add(new Integer(mediaPort));
                         formatSets.add(extractTransmittableJmfFormats(
                             sdpFormats));
                     } else {
                         // gml # if not transmittable, still reported
                         // gml # atLeastOneTransmitterStarted = true
                         continue;
                     }
                 }
                 catch (MediaException ex) {

Gary Levin
Telcordia Technologies

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hello Gary,

Thanks for the report. I've fixed and acknowledged the error. I'll be
applying a bit later this month as we have also integrated firewall
support and it needs more testing

Cheers
Emil

Minor error:
If the media is not transmittable, atLeastOneTransmitterStarted still could
be set to true.

In MediaManager.openMediaStreams

                  //START TRANSMISSION
                  try {
                     if (isMediaTransmittable(mediaType)) {
                         ports.add(new Integer(mediaPort));
                        
formatSets.add(extractTransmittableJmfFormats(
                             sdpFormats));
                     } else {
                         // gml # if not transmittable, still reported
                         // gml # atLeastOneTransmitterStarted = true
                         continue;
                     }
                 }
                 catch (MediaException ex) {

Gary Levin
Telcordia Technologies

---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

Cheers
Emil

http://www.emcho.com

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net