[sip-comm-dev] Midterm Code - Contact Info


#1

Hi Everyone,

Sorry for the delay on this. I spent most of yesterday riding buses to get back home, but now that I've gotten back to my house and to the internet, here's the current version of contact info. It now looks more like what was discussed earlier, and probably more like what it will be like in the end. I'd really appreciate any suggestions both functionality-wise and aesthetically.

If people have the time, I'd really like to talk a bit about how to implement setting contact information. I've started at it a couple of times but I keep restarting just because I can't get settled on an approach to it. I'd like to keep setting contact info simple, but because each protocol may vary a lot in how it's details work, it's hard to keep the design at all abstract. It definitely doesn't make sense to shove every potential field onto the form, but it also would be a problem if they could only alter details that they had set at some point in the past because they would have to keep returning to the protocol specific software or website. So far, my favorite idea is to keep the design as it is with viewing information, and make all of the values editable, but to then add a third tab that will include all additional details that pertain to the current protocol, but it still feels a bit clumsy and I have a problem with knowing exactly what sort of components would be needed to allow the user to properly alter the detail. Any thoughts would be really great.

By the way, at least for me, profile pictures do not seem to display. Damian, I think at one point you mentioned that you were changing the style of how to get contact images so that it would be retrieved from ServerStoredDetails.ImageDetail, but I might have been wrong about that. Is that how it is or is the picture retrieved differently?

Hope it works alright for everyone. Thanks for any comments and suggestions.

Adam

Contact Info 07-10-07.zip (48.2 KB)


#2

Hi Adam,

By the way, at least for me, profile pictures do not seem to display.
Damian, I think at one point you mentioned that you were changing the
style of how to get contact images so that it would be retrieved from
ServerStoredDetails.ImageDetail, but I might have been wrong about that.
Is that how it is or is the picture retrieved differently?

As I know you are working with icq protocol. The images are not
retrieved on request but there is a listener added to the IconService
in joustsim which receives the images from the server. I think this
happens just after registering. So if there is an image in the
ContactIcqImpl when requesting it from the OperationSet it must be
returned.
In jabber there is an separate thread retrieving images if they are
missing. So when the image is retrieved its in the ContactJabberImpl
and ContactPropertyChangeEvent is fired for the change.
In yahoo protocol again image is requested when missing and
ContactPropertyChangeEvent is fired on receive.

I have tested these with the gui and everything is ok.

damencho

ยทยทยท

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net