[sip-comm-dev] Little patch resources languages


#1

Hi,
Just a (very, very) little patch, because the remove contact MessageDialog
have a "bad" (html) look :slight_smile:
(+french translation for this message, ...sorry for the it/bg/de/zh guys).

Regards,
Julien

resources.patch (1.32 KB)


#2

Hi Julien,

thanks for the patch! However before committing it I would like to ask you, are you experiencing problems with the remove dialog yet? Because a week ago I have committed a fix for this one and it's working for me with the <DIV> tag now (I'm on debian with SIPComm build 1032).

Thanks,
Yana

Julien wrote:

路路路

Hi,
Just a (very, very) little patch, because the remove contact MessageDialog
have a "bad" (html) look :slight_smile:
(+french translation for this message, ...sorry for the it/bg/de/zh guys).

Regards,
Julien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Oups...I had an old version (too many versions on my PC), now the new
version accepts <div>
Sorry :s
(however, the translation is still missing for the French version
(removeContactText) )
Thanks

路路路

2008/3/12, Yana Stamcheva <yana@sip-communicator.org>:

Hi Julien,

thanks for the patch! However before committing it I would like to ask
you, are you experiencing problems with the remove dialog yet? Because a
week ago I have committed a fix for this one and it's working for me
with the <DIV> tag now (I'm on debian with SIPComm build 1032).

Thanks,
Yana

Julien wrote:
> Hi,
> Just a (very, very) little patch, because the remove contact
MessageDialog
> have a "bad" (html) look :slight_smile:
> (+french translation for this message, ...sorry for the it/bg/de/zh
guys).
>
> Regards,
> Julien
>
>
>

> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi!

I found following bug: When for some reason the left button is disabled
(e.g. get into the last-dialed-numbers panel and delete the content), it is
not enabled, when an icoming call is received. You cannot accept it.

Cheers, thomas

路路路

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Julien,

yes, I was waiting you to confirm if it's working for you with the DIV, I'm now committing your translation!

Thanks again,
Yana

Julien wrote:

路路路

Oups...I had an old version (too many versions on my PC), now the new
version accepts <div>
Sorry :s
(however, the translation is still missing for the French version
(removeContactText) )
Thanks

2008/3/12, Yana Stamcheva <yana@sip-communicator.org>:

Hi Julien,

thanks for the patch! However before committing it I would like to ask
you, are you experiencing problems with the remove dialog yet? Because a
week ago I have committed a fix for this one and it's working for me
with the <DIV> tag now (I'm on debian with SIPComm build 1032).

Thanks,
Yana

Julien wrote:

Hi,
Just a (very, very) little patch, because the remove contact

MessageDialog

have a "bad" (html) look :slight_smile:
(+french translation for this message, ...sorry for the it/bg/de/zh

guys).

Regards,
Julien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Thomas,

you could have a look in gui.main.call.CallComboBox. The bug should be somewhere in this class. May be in the handleChange() method. Tell me if you find something.

Cheers,
Yana

Thomas Hofer wrote:

路路路

Hi!

I found following bug: When for some reason the left button is disabled
(e.g. get into the last-dialed-numbers panel and delete the content), it is
not enabled, when an icoming call is received. You cannot accept it.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi yana!
I think it's not a bug in the callcombobox, the disabling is ok. But the
button shall be enabled when an incoming call is received.

I'll check that and add the appropriate code, if you (and others) agree

Cheers.

路路路

-----Urspr眉ngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M盲rz 2008 17:53
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

Hi Thomas,

you could have a look in gui.main.call.CallComboBox. The bug should be
somewhere in this class. May be in the handleChange() method. Tell me
if
you find something.

Cheers,
Yana

Thomas Hofer wrote:
> Hi!
>
> I found following bug: When for some reason the left button is
disabled
> (e.g. get into the last-dialed-numbers panel and delete the content),
it is
> not enabled, when an icoming call is received. You cannot accept it.
>
> Cheers, thomas
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Oh, right. This one should be in the CallManager. Thanks Thomas!

Cheers,
Yana

Thomas Hofer wrote:

路路路

Hi yana!
I think it's not a bug in the callcombobox, the disabling is ok. But the
button shall be enabled when an incoming call is received.

I'll check that and add the appropriate code, if you (and others) agree

Cheers.

-----Urspr锟絥gliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M锟絩z 2008 17:53
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

Hi Thomas,

you could have a look in gui.main.call.CallComboBox. The bug should be
somewhere in this class. May be in the handleChange() method. Tell me
if
you find something.

Cheers,
Yana

Thomas Hofer wrote:

Hi!

I found following bug: When for some reason the left button is

disabled

(e.g. get into the last-dialed-numbers panel and delete the content),

it is

not enabled, when an icoming call is received. You cannot accept it.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

No. It's a little more complicated I just found out.

It happens only, when the focus is in the empty call window before the call
arrives. The callmanager enables the button, and the combobox gains the
focus (again). The combobox then checks, that there is no number to dial and
disables the button again.

I'll sleep a night over it to think about, what would be the correct
implementation.

Cheers
thomas

路路路

-----Urspr眉ngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M盲rz 2008 18:09
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

Oh, right. This one should be in the CallManager. Thanks Thomas!

Cheers,
Yana

Thomas Hofer wrote:
> Hi yana!
> I think it's not a bug in the callcombobox, the disabling is ok. But
the
> button shall be enabled when an incoming call is received.
>
> I'll check that and add the appropriate code, if you (and others)
agree
>
> Cheers.
>
>> -----Urspr眉ngliche Nachricht-----
>> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
>> Gesendet: Mittwoch, 12. M盲rz 2008 17:53
>> An: dev@sip-communicator.dev.java.net
>> Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be acceptet
>>
>> Hi Thomas,
>>
>> you could have a look in gui.main.call.CallComboBox. The bug should
be
>> somewhere in this class. May be in the handleChange() method. Tell
me
>> if
>> you find something.
>>
>> Cheers,
>> Yana
>>
>> Thomas Hofer wrote:
>>> Hi!
>>>
>>> I found following bug: When for some reason the left button is
>> disabled
>>> (e.g. get into the last-dialed-numbers panel and delete the
content),
>> it is
>>> not enabled, when an icoming call is received. You cannot accept
it.
>>>
>>> Cheers, thomas
>>>
>>>
>>> -------------------------------------------------------------------
--
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>>> For additional commands, e-mail: dev-help@sip-
>> communicator.dev.java.net
>>>
>> --------------------------------------------------------------------
-
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

My solution I propose for this issue, is

Do not provide the two buttons for other classes, make them private. And
provide the possibility to enable/disable them. The call manager iselft
checks, if the status-change (enable, disable) is ok.

What do you think about it?

路路路

-----Urspr眉ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Mittwoch, 12. M盲rz 2008 18:31
An: dev@sip-communicator.dev.java.net
Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

No. It's a little more complicated I just found out.

It happens only, when the focus is in the empty call window before the
call
arrives. The callmanager enables the button, and the combobox gains the
focus (again). The combobox then checks, that there is no number to
dial and
disables the button again.

I'll sleep a night over it to think about, what would be the correct
implementation.

Cheers
thomas

> -----Urspr眉ngliche Nachricht-----
> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
> Gesendet: Mittwoch, 12. M盲rz 2008 18:09
> An: dev@sip-communicator.dev.java.net
> Betreff: Re: AW: [sip-comm-dev] BUG? Incoming calls cannot be
acceptet
>
> Oh, right. This one should be in the CallManager. Thanks Thomas!
>
> Cheers,
> Yana
>
> Thomas Hofer wrote:
> > Hi yana!
> > I think it's not a bug in the callcombobox, the disabling is ok.
But
> the
> > button shall be enabled when an incoming call is received.
> >
> > I'll check that and add the appropriate code, if you (and others)
> agree
> >
> > Cheers.
> >
> >> -----Urspr眉ngliche Nachricht-----
> >> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
> >> Gesendet: Mittwoch, 12. M盲rz 2008 17:53
> >> An: dev@sip-communicator.dev.java.net
> >> Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be acceptet
> >>
> >> Hi Thomas,
> >>
> >> you could have a look in gui.main.call.CallComboBox. The bug
should
> be
> >> somewhere in this class. May be in the handleChange() method. Tell
> me
> >> if
> >> you find something.
> >>
> >> Cheers,
> >> Yana
> >>
> >> Thomas Hofer wrote:
> >>> Hi!
> >>>
> >>> I found following bug: When for some reason the left button is
> >> disabled
> >>> (e.g. get into the last-dialed-numbers panel and delete the
> content),
> >> it is
> >>> not enabled, when an icoming call is received. You cannot accept
> it.
> >>>
> >>> Cheers, thomas
> >>>
> >>>
> >>> -----------------------------------------------------------------
--
> --
> >>> To unsubscribe, e-mail: dev-unsubscribe@sip-
> communicator.dev.java.net
> >>> For additional commands, e-mail: dev-help@sip-
> >> communicator.dev.java.net
> >>>
> >> ------------------------------------------------------------------
--
> -
> >> To unsubscribe, e-mail: dev-unsubscribe@sip-
> communicator.dev.java.net
> >> For additional commands, e-mail: dev-help@sip-
> communicator.dev.java.net
> >
> >
> > -------------------------------------------------------------------
--
> > To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-
> communicator.dev.java.net
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi Thomas,

sorry for the late reply. I agree! Would you like to make the change or you prefer me to do it?

Cheers,
Yana

Thomas Hofer wrote:

路路路

My solution I propose for this issue, is

Do not provide the two buttons for other classes, make them private. And
provide the possibility to enable/disable them. The call manager iselft
checks, if the status-change (enable, disable) is ok.

What do you think about it?

-----Urspr锟絥gliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Mittwoch, 12. M锟絩z 2008 18:31
An: dev@sip-communicator.dev.java.net
Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

No. It's a little more complicated I just found out.

It happens only, when the focus is in the empty call window before the
call
arrives. The callmanager enables the button, and the combobox gains the
focus (again). The combobox then checks, that there is no number to
dial and
disables the button again.

I'll sleep a night over it to think about, what would be the correct
implementation.

Cheers
thomas

-----Urspr锟絥gliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M锟絩z 2008 18:09
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] BUG? Incoming calls cannot be

acceptet

Oh, right. This one should be in the CallManager. Thanks Thomas!

Cheers,
Yana

Thomas Hofer wrote:

Hi yana!
I think it's not a bug in the callcombobox, the disabling is ok.

But

the

button shall be enabled when an incoming call is received.

I'll check that and add the appropriate code, if you (and others)

agree

Cheers.

-----Urspr锟絥gliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M锟絩z 2008 17:53
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

Hi Thomas,

you could have a look in gui.main.call.CallComboBox. The bug

should

be

somewhere in this class. May be in the handleChange() method. Tell

me

if
you find something.

Cheers,
Yana

Thomas Hofer wrote:

Hi!

I found following bug: When for some reason the left button is

disabled

(e.g. get into the last-dialed-numbers panel and delete the

content),

it is

not enabled, when an icoming call is received. You cannot accept

it.

Cheers, thomas

-----------------------------------------------------------------

--

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net
------------------------------------------------------------------

--

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-------------------------------------------------------------------

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

I found a solution without changing the whole structure of the event
handling:
The handleChange method now adds a check, if a callpanel is displayed and if
so (and the call state is initializing), the call-button is enabled. If not,
the old rules apply.

If it is OK for you, I'll commit it.

聽聽聽聽protected void handleChange()
聽聽聽聽{
聽聽聽聽聽聽聽聽String item = ((CallComboEditor)
this.getEditor()).getItem().toString();

聽聽聽聽聽聽聽聽if (item.length() > 0)
聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽callManager.setCallMetaContact(false);

聽聽聽聽聽聽聽聽聽聽聽聽ContactList clist =
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽this.callManager.getMainFrame().getContactListPanel()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getContactList();

聽聽聽聽聽聽聽聽聽聽聽聽clist.removeSelectionInterval(clist.getSelectedIndex(), clist
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getSelectedIndex());

聽聽聽聽聽聽聽聽聽聽聽聽callManager.getCallButton().setEnabled(true);
聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽else
聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽Object o =
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽callManager.getMainFrame().getContactListPanel()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getContactList().getSelectedValue();

聽聽聽聽聽聽聽聽聽聽聽聽boolean enabled = true;
聽聽聽聽聽聽聽聽聽聽聽聽if (o == null || !(o instanceof MetaContact))
聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// no contact can be called. call button not active
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽enabled = false;
聽聽聽聽聽聽聽聽聽聽聽聽}

聽聽聽聽聽聽聽聽聽聽聽聽Component selectedPanel = callManager.getMainFrame()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getSelectedTab();
聽聽聽聽聽聽聽聽聽聽聽聽if (selectedPanel != null && selectedPanel instanceof CallPanel)
聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// but an incoming call is currently active. enable the
button
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// so that the call can be answered
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽CallState state = ((CallPanel) selectedPanel).getCall()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getCallState();
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽if (state == CallState.CALL_INITIALIZATION)
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽enabled = true;
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽聽聽聽聽callManager.getCallButton().setEnabled(enabled);

聽聽聽聽聽聽聽聽}
聽聽聽聽}

路路路

-----Urspr眉ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 17. M盲rz 2008 12:27
An: dev@sip-communicator.dev.java.net
Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

My solution I propose for this issue, is

Do not provide the two buttons for other classes, make them private.
And
provide the possibility to enable/disable them. The call manager iselft
checks, if the status-change (enable, disable) is ok.

What do you think about it?

> -----Urspr眉ngliche Nachricht-----
> Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
> Gesendet: Mittwoch, 12. M盲rz 2008 18:31
> An: dev@sip-communicator.dev.java.net
> Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be
acceptet
>
> No. It's a little more complicated I just found out.
>
> It happens only, when the focus is in the empty call window before
the
> call
> arrives. The callmanager enables the button, and the combobox gains
the
> focus (again). The combobox then checks, that there is no number to
> dial and
> disables the button again.
>
>
> I'll sleep a night over it to think about, what would be the correct
> implementation.
>
> Cheers
> thomas
>
> > -----Urspr眉ngliche Nachricht-----
> > Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
> > Gesendet: Mittwoch, 12. M盲rz 2008 18:09
> > An: dev@sip-communicator.dev.java.net
> > Betreff: Re: AW: [sip-comm-dev] BUG? Incoming calls cannot be
> acceptet
> >
> > Oh, right. This one should be in the CallManager. Thanks Thomas!
> >
> > Cheers,
> > Yana
> >
> > Thomas Hofer wrote:
> > > Hi yana!
> > > I think it's not a bug in the callcombobox, the disabling is ok.
> But
> > the
> > > button shall be enabled when an incoming call is received.
> > >
> > > I'll check that and add the appropriate code, if you (and others)
> > agree
> > >
> > > Cheers.
> > >
> > >> -----Urspr眉ngliche Nachricht-----
> > >> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
> > >> Gesendet: Mittwoch, 12. M盲rz 2008 17:53
> > >> An: dev@sip-communicator.dev.java.net
> > >> Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be
acceptet
> > >>
> > >> Hi Thomas,
> > >>
> > >> you could have a look in gui.main.call.CallComboBox. The bug
> should
> > be
> > >> somewhere in this class. May be in the handleChange() method.
Tell
> > me
> > >> if
> > >> you find something.
> > >>
> > >> Cheers,
> > >> Yana
> > >>
> > >> Thomas Hofer wrote:
> > >>> Hi!
> > >>>
> > >>> I found following bug: When for some reason the left button is
> > >> disabled
> > >>> (e.g. get into the last-dialed-numbers panel and delete the
> > content),
> > >> it is
> > >>> not enabled, when an icoming call is received. You cannot
accept
> > it.
> > >>>
> > >>> Cheers, thomas
> > >>>
> > >>>
> > >>> ---------------------------------------------------------------
--
> --
> > --
> > >>> To unsubscribe, e-mail: dev-unsubscribe@sip-
> > communicator.dev.java.net
> > >>> For additional commands, e-mail: dev-help@sip-
> > >> communicator.dev.java.net
> > >>>
> > >> ----------------------------------------------------------------
--
> --
> > -
> > >> To unsubscribe, e-mail: dev-unsubscribe@sip-
> > communicator.dev.java.net
> > >> For additional commands, e-mail: dev-help@sip-
> > communicator.dev.java.net
> > >
> > >
> > > -----------------------------------------------------------------
--
> --
> > > To unsubscribe, e-mail: dev-unsubscribe@sip-
> communicator.dev.java.net
> > > For additional commands, e-mail: dev-help@sip-
> > communicator.dev.java.net
> > >
> > >
> >
> > -------------------------------------------------------------------
--
> > To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-
> communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hi Thomas,

looks like a good solution for me! I saw you've already committed it, so that's just to say that I like the solution.

Cheers,
Yana

Thomas Hofer wrote:

路路路

I found a solution without changing the whole structure of the event
handling:
The handleChange method now adds a check, if a callpanel is displayed and if
so (and the call state is initializing), the call-button is enabled. If not,
the old rules apply.

If it is OK for you, I'll commit it.

聽聽聽聽protected void handleChange()
聽聽聽聽{
聽聽聽聽聽聽聽聽String item = ((CallComboEditor)
this.getEditor()).getItem().toString();

聽聽聽聽聽聽聽聽if (item.length() > 0)
聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽callManager.setCallMetaContact(false);

聽聽聽聽聽聽聽聽聽聽聽聽ContactList clist =
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽this.callManager.getMainFrame().getContactListPanel()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getContactList();

聽聽聽聽聽聽聽聽聽聽聽聽clist.removeSelectionInterval(clist.getSelectedIndex(), clist
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getSelectedIndex());

聽聽聽聽聽聽聽聽聽聽聽聽callManager.getCallButton().setEnabled(true);
聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽else
聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽Object o =
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽callManager.getMainFrame().getContactListPanel()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getContactList().getSelectedValue();

聽聽聽聽聽聽聽聽聽聽聽聽boolean enabled = true;
聽聽聽聽聽聽聽聽聽聽聽聽if (o == null || !(o instanceof MetaContact))
聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// no contact can be called. call button not active
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽enabled = false;
聽聽聽聽聽聽聽聽聽聽聽聽}

聽聽聽聽聽聽聽聽聽聽聽聽Component selectedPanel = callManager.getMainFrame()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getSelectedTab();
聽聽聽聽聽聽聽聽聽聽聽聽if (selectedPanel != null && selectedPanel instanceof CallPanel)
聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// but an incoming call is currently active. enable the
button
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽// so that the call can be answered
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽CallState state = ((CallPanel) selectedPanel).getCall()
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽.getCallState();
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽if (state == CallState.CALL_INITIALIZATION)
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽{
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽enabled = true;
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽聽聽聽聽}
聽聽聽聽聽聽聽聽聽聽聽聽callManager.getCallButton().setEnabled(enabled);

聽聽聽聽聽聽聽聽}
聽聽聽聽}

-----Urspr锟絥gliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 17. M锟絩z 2008 12:27
An: dev@sip-communicator.dev.java.net
Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be acceptet

My solution I propose for this issue, is

Do not provide the two buttons for other classes, make them private.
And
provide the possibility to enable/disable them. The call manager iselft
checks, if the status-change (enable, disable) is ok.

What do you think about it?

-----Urspr锟絥gliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Mittwoch, 12. M锟絩z 2008 18:31
An: dev@sip-communicator.dev.java.net
Betreff: AW: AW: [sip-comm-dev] BUG? Incoming calls cannot be

acceptet

No. It's a little more complicated I just found out.

It happens only, when the focus is in the empty call window before

the

call
arrives. The callmanager enables the button, and the combobox gains

the

focus (again). The combobox then checks, that there is no number to
dial and
disables the button again.

I'll sleep a night over it to think about, what would be the correct
implementation.

Cheers
thomas

-----Urspr锟絥gliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M锟絩z 2008 18:09
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] BUG? Incoming calls cannot be

acceptet

Oh, right. This one should be in the CallManager. Thanks Thomas!

Cheers,
Yana

Thomas Hofer wrote:

Hi yana!
I think it's not a bug in the callcombobox, the disabling is ok.

But

the

button shall be enabled when an incoming call is received.

I'll check that and add the appropriate code, if you (and others)

agree

Cheers.

-----Urspr锟絥gliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 12. M锟絩z 2008 17:53
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] BUG? Incoming calls cannot be

acceptet

Hi Thomas,

you could have a look in gui.main.call.CallComboBox. The bug

should

be

somewhere in this class. May be in the handleChange() method.

Tell

me

if
you find something.

Cheers,
Yana

Thomas Hofer wrote:

Hi!

I found following bug: When for some reason the left button is

disabled

(e.g. get into the last-dialed-numbers panel and delete the

content),

it is

not enabled, when an icoming call is received. You cannot

accept

it.

Cheers, thomas

---------------------------------------------------------------

--

--

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net
----------------------------------------------------------------

--

--

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-----------------------------------------------------------------

--

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-------------------------------------------------------------------

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hi! Is it (already) possible to automatically update the status?

e.g. when the screensaver is running, set I to Away.

Cheers, thomas

路路路

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

Ok, after searching for such a plugin, I did not find any. I'll develop it
and publish it then.

Cheers, Thomas

路路路

-----Urspr眉ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 21. April 2008 13:06
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] Automatic Statusupdate

Hi! Is it (already) possible to automatically update the status?

e.g. when the screensaver is running, set I to Away.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Hey Thomas,

I think Chris started working on one and he's probably not far from
completing it. I know he's changing countries right now so he might be
unable to commit it any time soon but he might want to send his work to you
so that you won't have to start from scratch.

Cheers
Emil

路路路

On Tue, Apr 22, 2008 at 7:45 AM, Thomas Hofer < mailinglisten@familie-hofer.net> wrote:

Ok, after searching for such a plugin, I did not find any. I'll develop it
and publish it then.

Cheers, Thomas

> -----Urspr眉ngliche Nachricht-----
> Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
> Gesendet: Montag, 21. April 2008 13:06
> An: dev@sip-communicator.dev.java.net
> Betreff: [sip-comm-dev] Automatic Statusupdate
>
> Hi! Is it (already) possible to automatically update the status?
>
> e.g. when the screensaver is running, set I to Away.
>
> Cheers, thomas
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#17

Hi,

I have checked recently sources of latest jdic and there
have some screensaver detects but must be tested is it working on all supported OS.
Also there is an activity detector, which can detect the last user activity and so we also can set
Away even if no screensaver is detected, as I can remember I have tested this on linux and Mac and it was OK but
I was unable to compile it under windows.

Good luck
damencho

Thomas Hofer wrote:

路路路

Ok, after searching for such a plugin, I did not find any. I'll develop it
and publish it then.

Cheers, Thomas

-----Urspr锟絥gliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 21. April 2008 13:06
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] Automatic Statusupdate

Hi! Is it (already) possible to automatically update the status?

e.g. when the screensaver is running, set I to Away.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
聽聽聽聽
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#18

Hi! After having a short look on it, I think this is a matter of an hour or
so to do this, if you keep it simple. What I聮d do in a first step is just to
detect mouse moves 聳 which can be handled platform independent.
Screensaverdetection would be a lot more complicated.

Chris: what聮s your state of this enhancement? Did you start? If not, I聮ll
make a first version, you can then add your experiences. If you already
started, I聮d complete your code, if you send it to me. As this piece is
rather urgent for me, I聮d not like to wait for a few weeks (sorry).

Cheers, thomas

路路路

Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Dienstag, 22. April 2008 09:14
An: dev@sip-communicator.dev.java.net; Christian Vincenot
Betreff: Re: [sip-comm-dev] Automatic Statusupdate

Hey Thomas,

I think Chris started working on one and he's probably not far from
completing it. I know he's changing countries right now so he might be
unable to commit it any time soon but he might want to send his work to you
so that you won't have to start from scratch.

Cheers
Emil

On Tue, Apr 22, 2008 at 7:45 AM, Thomas Hofer <mailinglisten@familie-hofer.net> wrote:

Ok, after searching for such a plugin, I did not find any. I'll develop it
and publish it then.

Cheers, Thomas

-----Urspr眉ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 21. April 2008 13:06
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] Automatic Statusupdate

Hi! Is it (already) possible to automatically update the status?

e.g. when the screensaver is running, set I to Away.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#19

So. the plugin is finished and tested! I can commit it in the next hours, if
it is of public interest. It is kept simple, checking the mouse position,
all other things like determining, if the screensaver is running or checking
the keyboard can be extended in future versions, as this is not so easy in
java, when other applications have the focus.

Suggestions are welcome.

Two questions are open for me!

1. Where shall I put the menu entry for the configuration? In the
Tools menu?

2. Is it of public interest and shall I commit it?

Cheers, Thomas

路路路

Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Dienstag, 22. April 2008 11:34
An: dev@sip-communicator.dev.java.net; 'Christian Vincenot'
Betreff: AW: [sip-comm-dev] Automatic Statusupdate

Hi! After having a short look on it, I think this is a matter of an hour or
so to do this, if you keep it simple. What I聮d do in a first step is just to
detect mouse moves 聳 which can be handled platform independent.
Screensaverdetection would be a lot more complicated.

Chris: what聮s your state of this enhancement? Did you start? If not, I聮ll
make a first version, you can then add your experiences. If you already
started, I聮d complete your code, if you send it to me. As this piece is
rather urgent for me, I聮d not like to wait for a few weeks (sorry).

Cheers, thomas

Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Dienstag, 22. April 2008 09:14
An: dev@sip-communicator.dev.java.net; Christian Vincenot
Betreff: Re: [sip-comm-dev] Automatic Statusupdate

Hey Thomas,

I think Chris started working on one and he's probably not far from
completing it. I know he's changing countries right now so he might be
unable to commit it any time soon but he might want to send his work to you
so that you won't have to start from scratch.

Cheers
Emil

On Tue, Apr 22, 2008 at 7:45 AM, Thomas Hofer <mailinglisten@familie-hofer.net> wrote:

Ok, after searching for such a plugin, I did not find any. I'll develop it
and publish it then.

Cheers, Thomas

-----Urspr眉ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Montag, 21. April 2008 13:06
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] Automatic Statusupdate

Hi! Is it (already) possible to automatically update the status?

e.g. when the screensaver is running, set I to Away.

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net