[sip-comm-dev] JPopupMenu in Windows


#1

Hi,
I just tested a new system to resolve the issue 603 : The popup menu doesn't
disappear when SC lost focus (ie select another window except SC main
frame).

The patch works perfectly on windows XP but I'm not at home so I can't test
on other versions (Vista and Seven).
It also explain why a java source file and not a svn patch.

Can someone test it ?? (at least on Windows Vista with Java 6)

All the changes are done in the latest inner class (AWTMouseAdapter). So
just replace the content of the class.

Cheers,

Damien

TrayIcon.java (16.2 KB)


#2

Oups I forgot the class package :
net.java.sip.communicator.impl.osdependent

···

2009/8/23 Damien Roth <damien.roth@gmail.com>

Hi,
I just tested a new system to resolve the issue 603 : The popup menu
doesn't disappear when SC lost focus (ie select another window except SC
main frame).

The patch works perfectly on windows XP but I'm not at home so I can't test
on other versions (Vista and Seven).
It also explain why a java source file and not a svn patch.

Can someone test it ?? (at least on Windows Vista with Java 6)

All the changes are done in the latest inner class (AWTMouseAdapter). So
just replace the content of the class.

Cheers,

Damien


#3

Hi

Is there an "elegant" way to disable systray?

Thanks

···

________________________________

From: Damien Roth [mailto:damien.roth@gmail.com]

Sent: domingo, 23 de Agosto de 2009 13:48
To: SIP-Communicator Dev
Subject: [sip-comm-dev] JPopupMenu in Windows

Hi,

I just tested a new system to resolve the issue 603 : The popup menu
doesn't disappear when SC lost focus (ie select another window except SC
main frame).

The patch works perfectly on windows XP but I'm not at home so I can't
test on other versions (Vista and Seven).

It also explain why a java source file and not a svn patch.

Can someone test it ?? (at least on Windows Vista with Java 6)

All the changes are done in the latest inner class (AWTMouseAdapter). So
just replace the content of the class.

Cheers,

Damien


#4

Hi Damien,

Windows 7 RC here and your modified TrayIcon.java still seems to work perfectly.

Best regards,
Lubomir

···

On Sun, Aug 23, 2009 at 3:54 PM, Damien Roth<damien.roth@gmail.com> wrote:

Oups I forgot the class package :
net.java.sip.communicator.impl.osdependent

2009/8/23 Damien Roth <damien.roth@gmail.com>

Hi,
I just tested a new system to resolve the issue 603 : The popup menu
doesn't disappear when SC lost focus (ie select another window except SC
main frame).
The patch works perfectly on windows XP but I'm not at home so I can't
test on other versions (Vista and Seven).
It also explain why a java source file and not a svn patch.
Can someone test it ?? (at least on Windows Vista with Java 6)
All the changes are done in the latest inner class (AWTMouseAdapter). So
just replace the content of the class.
Cheers,
Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi

Is there an "elegant" way to disable systray?

Thanks


#6

Hi Damien,

Great work on this! The systray bug is one that's been bothering me for a
long time. I tested your modification and it works great (in XP). I did
notice a few unused elements that we might want to clean up before this is
committed.

Thanks for fixing this :smiley:

-Alan

···

On Mon, Aug 24, 2009 at 2:01 PM, Lubomir Marinov <lubomir.marinov@gmail.com>wrote:

Hi Damien,

Windows 7 RC here and your modified TrayIcon.java still seems to work
perfectly.

Best regards,
Lubomir

On Sun, Aug 23, 2009 at 3:54 PM, Damien Roth<damien.roth@gmail.com> wrote:
> Oups I forgot the class package :
> net.java.sip.communicator.impl.osdependent
>
>
> 2009/8/23 Damien Roth <damien.roth@gmail.com>
>>
>> Hi,
>> I just tested a new system to resolve the issue 603 : The popup menu
>> doesn't disappear when SC lost focus (ie select another window except SC
>> main frame).
>> The patch works perfectly on windows XP but I'm not at home so I can't
>> test on other versions (Vista and Seven).
>> It also explain why a java source file and not a svn patch.
>> Can someone test it ?? (at least on Windows Vista with Java 6)
>> All the changes are done in the latest inner class (AWTMouseAdapter). So
>> just replace the content of the class.
>> Cheers,
>> Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi,
Thanks Alan. Your're right, it's not my Ready-To-Commit code :stuck_out_tongue:

I found a Windows Vista computer and the patch still works. So after some
cleaning, I will commit.

Bye

···

2009/8/24 Alan Kelly <akoriolesfan@gmail.com>

Hi Damien,

Great work on this! The systray bug is one that's been bothering me for a
long time. I tested your modification and it works great (in XP). I did
notice a few unused elements that we might want to clean up before this is
committed.

Thanks for fixing this :smiley:

-Alan

On Mon, Aug 24, 2009 at 2:01 PM, Lubomir Marinov < > lubomir.marinov@gmail.com> wrote:

Hi Damien,

Windows 7 RC here and your modified TrayIcon.java still seems to work
perfectly.

Best regards,
Lubomir

On Sun, Aug 23, 2009 at 3:54 PM, Damien Roth<damien.roth@gmail.com> >> wrote:
> Oups I forgot the class package :
> net.java.sip.communicator.impl.osdependent
>
>
> 2009/8/23 Damien Roth <damien.roth@gmail.com>
>>
>> Hi,
>> I just tested a new system to resolve the issue 603 : The popup menu
>> doesn't disappear when SC lost focus (ie select another window except
SC
>> main frame).
>> The patch works perfectly on windows XP but I'm not at home so I can't
>> test on other versions (Vista and Seven).
>> It also explain why a java source file and not a svn patch.
>> Can someone test it ?? (at least on Windows Vista with Java 6)
>> All the changes are done in the latest inner class (AWTMouseAdapter).
So
>> just replace the content of the class.
>> Cheers,
>> Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hey Damien, Alan,

Alan Kelly wrote:

I did notice a few unused elements that we might
want to clean up before this is committed.

Could you please describe them? I just noticed Damien committed the fix
but we could still fix them.

Cheers
Emil

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Emil,

I think Alan was talking about a lot of commented code (previous implementation) and one unused import.

If there is something I missed just tell me.

Bye

Damien

Envoyé de mon iPhone

···

Le 25 août 2009 à 15:35, Emil Ivov <emcho@sip-communicator.org> a écrit :

Hey Damien, Alan,

Alan Kelly wrote:

I did notice a few unused elements that we might
want to clean up before this is committed.

Could you please describe them? I just noticed Damien committed the fix
but we could still fix them.

Cheers
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi Emil, Damien,

There was one unused import and an unused variable in the inner class that I
noticed. I will take a look at the new commit and make sure they're gone.

Glad to hear it works on Vista!

-Alan

···

On Tue, Aug 25, 2009 at 11:47 AM, Damien Roth <damien.roth@gmail.com> wrote:

Hi Emil,

I think Alan was talking about a lot of commented code (previous
implementation) and one unused import.

If there is something I missed just tell me.

Bye

Damien

Envoyé de mon iPhone

Le 25 août 2009 à 15:35, Emil Ivov <emcho@sip-communicator.org> a écrit :

Hey Damien, Alan,

Alan Kelly wrote:

I did notice a few unused elements that we might
want to clean up before this is committed.

Could you please describe them? I just noticed Damien committed the fix
but we could still fix them.

Cheers
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Also, should we include this in the 1.0-rc1 branch?

···

On Tue, Aug 25, 2009 at 3:40 PM, Alan Kelly <akoriolesfan@gmail.com> wrote:

Hi Emil, Damien,

There was one unused import and an unused variable in the inner class that
I noticed. I will take a look at the new commit and make sure they're gone.

Glad to hear it works on Vista!

-Alan

On Tue, Aug 25, 2009 at 11:47 AM, Damien Roth <damien.roth@gmail.com>wrote:

Hi Emil,

I think Alan was talking about a lot of commented code (previous
implementation) and one unused import.

If there is something I missed just tell me.

Bye

Damien

Envoyé de mon iPhone

Le 25 août 2009 à 15:35, Emil Ivov <emcho@sip-communicator.org> a écrit :

Hey Damien, Alan,

Alan Kelly wrote:

I did notice a few unused elements that we might
want to clean up before this is committed.

Could you please describe them? I just noticed Damien committed the fix
but we could still fix them.

Cheers
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hi all,

There was one unused import and an unused variable in the inner class that

I noticed. I will take a look at the new commit and make sure they're gone.

Confirmed. :slight_smile:

-Alan


#13

Alan Kelly wrote:

Also, should we include this in the 1.0-rc1 branch?

I'd be reluctant to, but if you (or anyone else?) are maintaining a
custom version based on 1.0 then you can go ahead and commit it there too.

Cheers
Emil

···

On Tue, Aug 25, 2009 at 3:40 PM, Alan Kelly <akoriolesfan@gmail.com > <mailto:akoriolesfan@gmail.com>> wrote:

    Hi Emil, Damien,

    There was one unused import and an unused variable in the inner
    class that I noticed. I will take a look at the new commit and make
    sure they're gone.

    Glad to hear it works on Vista!

    -Alan

    On Tue, Aug 25, 2009 at 11:47 AM, Damien Roth <damien.roth@gmail.com > <mailto:damien.roth@gmail.com>> wrote:

        Hi Emil,

        I think Alan was talking about a lot of commented code (previous
        implementation) and one unused import.

        If there is something I missed just tell me.

        Bye

        Damien

        Envoyé de mon iPhone

        Le 25 août 2009 à 15:35, Emil Ivov <emcho@sip-communicator.org > <mailto:emcho@sip-communicator.org>> a écrit :

            Hey Damien, Alan,

            Alan Kelly wrote:

                I did notice a few unused elements that we might
                want to clean up before this is committed.

            Could you please describe them? I just noticed Damien
            committed the fix
            but we could still fix them.

            Cheers
            Emil

            ---------------------------------------------------------------------
            To unsubscribe, e-mail:
            dev-unsubscribe@sip-communicator.dev.java.net
            <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
            For additional commands, e-mail:
            dev-help@sip-communicator.dev.java.net
            <http://communicator.dev.java.net>

        ---------------------------------------------------------------------
        To unsubscribe, e-mail:
        dev-unsubscribe@sip-communicator.dev.java.net
        <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
        For additional commands, e-mail:
        dev-help@sip-communicator.dev.java.net
        <mailto:dev-help@sip-communicator.dev.java.net>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

I'd like to go ahead and do that unless there's a good reason not too. I
already applied the patch to my local version of 1.0 and it works fine
(although the systray package name is different in 1.0 so I had to make a
few changes).

-Alan

···

On Wed, Aug 26, 2009 at 3:02 AM, Emil Ivov <emcho@sip-communicator.org>wrote:

Alan Kelly wrote:
> Also, should we include this in the 1.0-rc1 branch?

I'd be reluctant to, but if you (or anyone else?) are maintaining a
custom version based on 1.0 then you can go ahead and commit it there too.


#15

Alan Kelly wrote:

    Alan Kelly wrote:
    > Also, should we include this in the 1.0-rc1 branch?

    I'd be reluctant to, but if you (or anyone else?) are maintaining a
    custom version based on 1.0 then you can go ahead and commit it
    there too.

I'd like to go ahead and do that unless there's a good reason not too. I
already applied the patch to my local version of 1.0 and it works fine
(although the systray package name is different in 1.0 so I had to make
a few changes).

OK then, let's also put it in 1.0.

(Which reminds me that we'd probably need to actually build a release
and start 1.0.X builds on cruisecontrol one of these days ... hope we'll
be able to do it before we are ready to even roll a 1.1 :slight_smile: )

Cheers
Emil

···

On Wed, Aug 26, 2009 at 3:02 AM, Emil Ivov <emcho@sip-communicator.org > <mailto:emcho@sip-communicator.org>> wrote:

-Alan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Emil, Damien,

The systray patch has been implemented into the 1.0 branch with r5866. :slight_smile:

(Which reminds me that we'd probably need to actually build a release

and start 1.0.X builds on cruisecontrol one of these days ... hope we'll
be able to do it before we are ready to even roll a 1.1 :slight_smile:

Looking forward to it! A stable, "real" release from which to base my custom
modifications will be great.

-Alan