Hi guys,
first thanks to Sympho for fixing the "setVisible" issue! And Alan, thanks for bringing the favorites menu issue to the mailing list.
One of the problems you point out has already been described in issue #490 "Favorites menu hides top menu popups": https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=490 . As the two of you have noticed the dial history menu appears behind the favorites menu.
As Sympho mentioned, this problem comes from the GlassPane nature of the favorites menu (BTW it's me that called it favorites menu at the beginning, but probably quick menu would be more convenient:)). The glass pane is the top layer in a Frame and will always appear on top of all other components.
(more inline)
sympho wrote:
Hi Alan and thanks for testing,
In fact, I was trying to explain the problem you describe to Emil off list, so thanks for giving an image which is more eloquent.
For the moment, I saw three means to have the favorite menu hidden (other than clicking on the menu button) but each has incovenients :
1/
As it is done in the current svn, I think you have well described the problem
Inconvenients : it hide history combo and stay visible even if we click outside.
Agree that we should modify the current behavior.
2/
listen to focus and hide the menu if it lost focus (it was the first solution)
Inconvenients :the menu doesnt works any more because if we click on a button inside the menu, the focus is lost (since it goes to the button on wich we click) and the glass pane hides. the button on which we clicked doesnt receive its action even and dont perform anything.
Agree with inconvenients.
3/
listen for click on the glass pane and hide it if a click occurs outside the favorite menu, seems to be the best solution but,
Inconvenients : the glass pane covers all the frame (including the menu bar). If we click anywhere inside the main frame, no component under the glasspane will receive the click event because the glasspane is capturing it before hiding. we will then need to click twice to show the file menu for example.
Not possible, as soon as we use glass pane.
4/
I am finding a new solution with no side effect but I think the problem is actually related to the nature of the glass pane which stay on top of anything
http://java.sun.com/docs/books/tutorial/uiswing/components/rootpane.html
we could have the same behavior as for the dial panel, but I think it uses a JDialog and don't know if we could keep the transparency stuff with it.
I think the best solution would be to replace the glass pane with a component that has more similar behavior to what we're looking for. However by using a Dialog we'll certainly loose the transparency. I thought of using a JLayeredPane for the contact list container and using a simple panel for the quick menu. This way we could put the quick menu on top of the contact list and still keep the transparency. It'll be also easy to implement the hiding behavior. What do you think?
Cheers,
Yana
···
Regards.
Sympho
--- En date de : Ven 13.2.09, Alan C Kelly <akelly7@gmu.edu> a �crit :
De: Alan C Kelly <akelly7@gmu.edu>
Objet: Re: [sip-comm-dev] issue 490 favorite menu on top of all components
�: dev@sip-communicator.dev.java.net
Date: Vendredi 13 F�vrier 2009, 21h12
Hi Sympho,
I just tested out your changes to the Favorites menu (nice
work!), and I have a couple of observations:
1) While this is a great improvement, the behavior of the
menu is still a litte weird. I find it a little distracting
that the Favorites menu only closes when I click on another
menu, but clicking on other parts of the window outside of
the menu do not cause the menu to close. It might be
smoother to have it close in any case where the pane loses
focus/the user clicks outside the menu. Thoughts?
2) The Favorites menu does not close when the dial history
popup is opened. At least on my system, the dial history
popup menu sometimes opens upwards and disappears under the
Favorites menu. See the attached screenshot.
Other than that, it looks good 
-Alan
----- Original Message -----
From: sympho <sympho@ebcservice.com>
Date: Thursday, February 12, 2009 6:53 am
Subject: Re: [sip-comm-dev] Re : [sip-comm-dev] issue 490
favorite menu on top of all components
Hi,
--- En date de : Jeu 12.2.09, Emil Ivov
<emcho@sip-
communicator.org> a �crit :
De: Emil Ivov <emcho@sip-communicator.org>
Objet: Re: [sip-comm-dev] Re : [sip-comm-dev]
issue 490 favorite
menu on top of all components
�: dev@sip-communicator.dev.java.net
Date: Jeudi 12 F�vrier 2009, 1h21
Hey Sympho,
sympho wrote:
Hi,
With the attached patch, the favorites menu
is hidden
when it lost
focus. It dont solve the problem which
occurs when the
main window is
resized.
The new patch solves both the issue, using focus
listener, and the
resizing bug, revalidating the glasspane when the main
window is
resized.
Seems ok to me although I don't quite
understand the
second part of the
patch that references other changes in
MainFrame.java.
Could you please
explain these or simply confirm that they are not
going to
be committed?
Thoose changes are unintentional, I will use another
svn tool.
Looking at the code, it seems like a new
glasspane and
a new action
panel instances are created each time we
display/hide
the favorite
menu (even when we click on the button to
hide it, a
new menu is
created to replace the actual then made
invisible).
Am I right on how it works actually ?
I believe you are (Yana could you please correct
us if we
are missing
something.)
If true, wouldn't it better to create
the menu
once for the
application lifetime (the first time it is
showed)
since the favorite
menu is not modified while running ?
OK with me. Only make sure that the first
instance of the
menu is
created when we actually needed as in many cases
users
would probably
not need it at all.
done with the new patch.
++
Sympho
I think it could be done by making the
glasspane a
field of the
mainframe and when the option button will be
pressed
we will just
toggle it visible/invisible. If okay,
someone let me
know and I will
do it.
Yes please.
Cheers
Emil
regards
Sympho
______________________ http://ebcservice.com
--- En date de : Mar 10.2.09, sympho
<sympho@ebcservice.com> a �crit
:
De: sympho <sympho@ebcservice.com>
Objet:
[sip-comm-dev] issue 490
favorite menu on top of all components
�:
"sip comm"
<dev@sip-communicator.dev.java.net> Date:
Mardi 10 F�vrier 2009,
14h23 Hi,
About the issue 490 I discovered there
is another
problem when we
resize the main window : the favorites
menu dont
fit the free space
as expected.
I think the fisrt problem and this one
could both
be solved by
listening for focus on favorite menu and
then
close it when the
focus is lost.
I will try do it give feedbacks.
______________________
http://ebcservice.com
__________________________________________________________________________________________________>
Ne pleurez pas si votre Webmail ferme !
R�cup�rez votre historique
sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
-----------------------------------------------------------------
----
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net For
additional
commands, e-mail:
dev-help@sip-communicator.dev.java.net
__________________________________________________________________________________________________>
Ne pleurez pas si votre Webmail ferme ! R�cup�rez
votre historique
sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
-----------------------------------------------------------------
-------
-----------------------------------------------------------------
----
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net For
additional
commands, e-mail:
dev-help@sip-communicator.dev.java.net
-----------------------------------------------------------------
----
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
__________________________________________________________________________________________________Ne
pleurez pas si votre Webmail ferme ! R�cup�rez votre
historique sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
__________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! R�cup�rez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
