[sip-comm-dev] [Issue 479] Fancy systray tooltips


#1

hi,

attached is a patch which adds new, swing based, popup notifications.

After discussing off list with Emil and Yana we decided to create
a new interface : PopupMessageHandler in the systray packkage.
Every notification handler will then implements the new interface,
making the systray service able to use any provided handler.

So, notifications using systray balloons have been put in a class
implemeting the new interface. The end user has the ability to choose
which handler will be used via tools/parameters (the form need some
aesthetics modifications I will do soon). We can also decide to modify
the used handler for some notification and then restore it on the fly
using new get/setActivePopupMessageHandler methods added to the systray
service.

I tried to modify the growl notification service so that it implements
the new interface. But since I run only on windows, I didn't saw how
things look like for any handler on otherq OS or if I broke something
in growl.

If anyone tries the patch before it is committed and sees any issue,
I will be happy to talk about it.

Regards.

Sympho

notification.patch (77.4 KB)

···

______________________
http://ebcservice.com

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html


#2

Hi,

Here is a new patch including the previous and adding tests for the
PopupMessageHandler interface.

What we test is if the set/getActiveHandler methods work as expected by,
creating dummies handlers and swapping them.
Whe also verify if, when a notification if fired via the notification service with a message, we receive the right message and the message is received by the right handler.

Notice: this patch modify the set of tests which are run to test only the new interface.

regards

Sympho

notification_test.patch (78.6 KB)

···

______________________
http://ebcservice.com

--- En date de : Lun 9.2.09, sympho <sympho@ebcservice.com> a écrit :

De: sympho <sympho@ebcservice.com>
Objet: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: "sip comm" <dev@sip-communicator.dev.java.net>
Date: Lundi 9 Février 2009, 20h20
hi,

attached is a patch which adds new, swing based, popup
notifications.

After discussing off list with Emil and Yana we decided to
create
a new interface : PopupMessageHandler in the systray
packkage.
Every notification handler will then implements the new
interface,
making the systray service able to use any provided
handler.

So, notifications using systray balloons have been put in a
class
implemeting the new interface. The end user has the ability
to choose
which handler will be used via tools/parameters (the form
need some
aesthetics modifications I will do soon). We can also
decide to modify
the used handler for some notification and then restore it
on the fly
using new get/setActivePopupMessageHandler methods added to
the systray
service.

I tried to modify the growl notification service so that it
implements
the new interface. But since I run only on windows, I
didn't saw how
things look like for any handler on otherq OS or if I broke
something
in growl.

If anyone tries the patch before it is committed and sees
any issue,
I will be happy to talk about it.

Regards.

Sympho

______________________
http://ebcservice.com

__________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre
historique sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html


#3

AS: sorry if you received this mail twice, I previously sent it with an address not registered on the ml, and dont know if it was delivered.

Hi,

Here is a new patch including the previous and adding tests for the
PopupMessageHandler interface.

What we test is if the set/getActiveHandler methods work as expected by,
creating dummies handlers and swapping them.
Whe also verify if, when a notification if fired via the notification service with a message, we receive the right message and the message is received by the right handler.

Notice: this patch modify the set of tests which are run to test only the new interface.

regards

Sympho

notification_test.patch (78.6 KB)

···

______________________
http://ebcservice.com

--- En date de : Lun 9.2.09, sympho <sympho@ebcservice.com> a écrit :

De: sympho <sympho@ebcservice.com>
Objet: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: "sip comm" <dev@sip-communicator.dev.java.net>
Date: Lundi 9 Février 2009, 20h20
hi,

attached is a patch which adds new, swing based, popup
notifications.

After discussing off list with Emil and Yana we decided to
create
a new interface : PopupMessageHandler in the systray
packkage.
Every notification handler will then implements the new
interface,
making the systray service able to use any provided
handler.

So, notifications using systray balloons have been put in a
class
implemeting the new interface. The end user has the ability
to choose
which handler will be used via tools/parameters (the form
need some
aesthetics modifications I will do soon). We can also
decide to modify
the used handler for some notification and then restore it
on the fly
using new get/setActivePopupMessageHandler methods added to
the systray
service.

I tried to modify the growl notification service so that it
implements
the new interface. But since I run only on windows, I
didn't saw how
things look like for any handler on otherq OS or if I broke
something
in growl.

If anyone tries the patch before it is committed and sees
any issue,
I will be happy to talk about it.

Regards.

Sympho

______________________
http://ebcservice.com

__________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre
historique sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html


#4

Hey Sympho,

I've reviewed your patch and it seems ok to me with the exception of the
accounts.properties.template that it seems to remove for some reason.
Could you please have a look and comment?

Now, I am wondering what would be the best way to handle its commit. On
the one hand the patch contains a new feature (the new swing popup
notifications) and as such would probably be best committed once we have
forked out our 1.0 branch on svn. On the other hand however, in addition
to the fancy notifications feature scheduled for 2.0 (issue 479) it also
resolves two of the bugs currently on scheduled for 1.0:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532

This could justify committing it sooner without having to wait for the
branch. I'll therefore be experimenting with it these days and see how
it goes. Could anyone else please also try it out so that we could
gather a bit more feedback?

Thanks
Emil

sympho wrote:

···

hi,

attached is a patch which adds new, swing based, popup notifications.

After discussing off list with Emil and Yana we decided to create
a new interface : PopupMessageHandler in the systray packkage.
Every notification handler will then implements the new interface,
making the systray service able to use any provided handler.

So, notifications using systray balloons have been put in a class
implemeting the new interface. The end user has the ability to choose
which handler will be used via tools/parameters (the form need some
aesthetics modifications I will do soon). We can also decide to modify
the used handler for some notification and then restore it on the fly
using new get/setActivePopupMessageHandler methods added to the systray
service.

I tried to modify the growl notification service so that it implements
the new interface. But since I run only on windows, I didn't saw how
things look like for any handler on otherq OS or if I broke something
in growl.

If anyone tries the patch before it is committed and sees any issue,
I will be happy to talk about it.

Regards.

Sympho

______________________
http://ebcservice.com

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Emil,

--- En date de : Jeu 12.2.09, Emil Ivov <emcho@sip-communicator.org> a écrit :

De: Emil Ivov <emcho@sip-communicator.org>
Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: dev@sip-communicator.dev.java.net
Date: Jeudi 12 Février 2009, 1h33
Hey Sympho,

I've reviewed your patch and it seems ok to me with the
exception of the
accounts.properties.template that it seems to remove for
some reason.
Could you please have a look and comment?

Mistakenly deleted while creating my accounts.properties file.

···

++

Sympho.

Now, I am wondering what would be the best way to handle
its commit. On
the one hand the patch contains a new feature (the new
swing popup
notifications) and as such would probably be best committed
once we have
forked out our 1.0 branch on svn. On the other hand
however, in addition
to the fancy notifications feature scheduled for 2.0 (issue
479) it also
resolves two of the bugs currently on scheduled for 1.0:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532

This could justify committing it sooner without having to
wait for the
branch. I'll therefore be experimenting with it these
days and see how
it goes. Could anyone else please also try it out so that
we could
gather a bit more feedback?

Thanks
Emil

sympho wrote:
> hi,
>
> attached is a patch which adds new, swing based, popup
notifications.
>
> After discussing off list with Emil and Yana we
decided to create
> a new interface : PopupMessageHandler in the systray
packkage.
> Every notification handler will then implements the
new interface,
> making the systray service able to use any provided
handler.
>
> So, notifications using systray balloons have been put
in a class
> implemeting the new interface. The end user has the
ability to choose
> which handler will be used via tools/parameters (the
form need some
> aesthetics modifications I will do soon). We can also
decide to modify
> the used handler for some notification and then
restore it on the fly
> using new get/setActivePopupMessageHandler methods
added to the systray
> service.
>
> I tried to modify the growl notification service so
that it implements
> the new interface. But since I run only on windows, I
didn't saw how
> things look like for any handler on otherq OS or if I
broke something
> in growl.
>
> If anyone tries the patch before it is committed and
sees any issue,
> I will be happy to talk about it.
>
> Regards.
>
> Sympho
>
> ______________________
> http://ebcservice.com
>
>
>
>
__________________________________________________________________________________________________
> Ne pleurez pas si votre Webmail ferme ! Récupérez
votre historique sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
>
>
>
------------------------------------------------------------------------
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Sympho,

I tried to modify the growl notification service so that it
implements the new interface. But since I run only on windows, I
didn't saw how things look like for any handler on otherq OS or if I broke
something in growl.

I've applied your patch on my local repository and didn't have any problem with growl so far. I get the notifications through growl when I receive a message. Great job!

Just a little nit in the patch: at line 1716, there's a "\ No newline at end of file" written which breaks the patch.

Cheers,
romain

···

On 2009/02/10, at 12:05, sympho wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hey Sympho,

Just tested your patch on Linux and it looks really promising! The windows
are quite pretty, the animations slick and the feature as a whole works
well. Also tested the configuration and it worked! Very nice!

I did notice a few issues though:

1. Your patch adds to build.xml a new target building the notifications
slick and it contains a reference to

/test/net/java/sip/communicator/slick/popupmessagehandler/popupmessagehandler.slick.manifest.mf

The manifest however is not in the patch (and neither is the slick for that
matter :slight_smile: )

2. When using multiple screens the notifications would appear at weird
locations (see attached ss-notification.png screenshot). This most probably
happens because when calculating the location of a notification we probably
get the size of a different screen than the one we actually show it on.

3. In the GeneralConfigurationPanel you assume that there will be resource
strings corresponding to the class name of the handlers which makes for the
result you see in ss-configuration.png. I think it would be best to make the
handler service define a getName() method that we could display instead.

4. Using radio buttons is probably not a very good choice here since we
don't really know how many handlers we'll have. I'd go for a combo box.

5. (this is more of a feature request but it is important) Currently, with
jdic and java6, it is possible to bring related chat windows to the front
when clicking on them. Could we also implement this with your swing
notifications?

5. (another feature request that I can't resist :wink: ) Could we add the
possibility for having images on the left of the notifications? This way we
could show user avatars for incoming messages.

Cheers
Emil

···

On Thu, Feb 12, 2009 at 1:14 PM, sympho <sympho@ebcservice.com> wrote:

Hi Emil,

--- En date de : Jeu 12.2.09, Emil Ivov <emcho@sip-communicator.org> a
écrit :

> De: Emil Ivov <emcho@sip-communicator.org>
> Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
> À: dev@sip-communicator.dev.java.net
> Date: Jeudi 12 Février 2009, 1h33
> Hey Sympho,
>
> I've reviewed your patch and it seems ok to me with the
> exception of the
> accounts.properties.template that it seems to remove for
> some reason.
> Could you please have a look and comment?
>

Mistakenly deleted while creating my accounts.properties file.

++

Sympho.

> Now, I am wondering what would be the best way to handle
> its commit. On
> the one hand the patch contains a new feature (the new
> swing popup
> notifications) and as such would probably be best committed
> once we have
> forked out our 1.0 branch on svn. On the other hand
> however, in addition
> to the fancy notifications feature scheduled for 2.0 (issue
> 479) it also
> resolves two of the bugs currently on scheduled for 1.0:
>
> https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
> https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532
>
> This could justify committing it sooner without having to
> wait for the
> branch. I'll therefore be experimenting with it these
> days and see how
> it goes. Could anyone else please also try it out so that
> we could
> gather a bit more feedback?
>
> Thanks
> Emil
>
> sympho wrote:
> > hi,
> >
> > attached is a patch which adds new, swing based, popup
> notifications.
> >
> > After discussing off list with Emil and Yana we
> decided to create
> > a new interface : PopupMessageHandler in the systray
> packkage.
> > Every notification handler will then implements the
> new interface,
> > making the systray service able to use any provided
> handler.
> >
> > So, notifications using systray balloons have been put
> in a class
> > implemeting the new interface. The end user has the
> ability to choose
> > which handler will be used via tools/parameters (the
> form need some
> > aesthetics modifications I will do soon). We can also
> decide to modify
> > the used handler for some notification and then
> restore it on the fly
> > using new get/setActivePopupMessageHandler methods
> added to the systray
> > service.
> >
> > I tried to modify the growl notification service so
> that it implements
> > the new interface. But since I run only on windows, I
> didn't saw how
> > things look like for any handler on otherq OS or if I
> broke something
> > in growl.
> >
> > If anyone tries the patch before it is committed and
> sees any issue,
> > I will be happy to talk about it.
> >
> > Regards.
> >
> > Sympho
> >
> > ______________________
> > http://ebcservice.com
> >
> >
> >
> >
>
__________________________________________________________________________________________________
> > Ne pleurez pas si votre Webmail ferme ! Récupérez
> votre historique sur Yahoo! Mail !
> http://fr.docs.yahoo.com/mail/transfert_mails.html
> >
> >
> >
> ------------------------------------------------------------------------
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net

__________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur
Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi Romain

I've applied your patch on my local repository and
didn't have any problem with growl so far. I get the
notifications through growl when I receive a message. Great
job!

Thanks

Just a little nit in the patch: at line 1716, there's a
"\ No newline at end of file" written which
breaks the patch.

My svn settings are someway broken. May be because I copied/moved my trunk folder many times. Got a new tool to creates patch outside the IDE, it seems to work fine.

···

++

Sympho

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Sympho,

I took the liberty to also review your patch and I hope that you don't mind that I updated it to:

- remove the unintentional deletion of account.properties.template,

- fix a possible source of NullPointerException in NotificationServiceImpl which is fixed for your newly-introduced code but then leaves it to happen in the old code right bellow yours.

- remove the List.contains() check before List.remove() because it's performed in a way anyway so it doesn't need to be performed again,

- make as many fields as possible final (where possible),

- fix two introduced warnings (one of which is caused by a new unused method),

- fix some weird formatting (which seems to be left from the old code when it was removed and then the new one was written),

- clean up tiny code here and there.

Anyway, these are really minor and represent my personal view so please feel free to use the changes as you see fit.

Best regards,
Lubo

Emil Ivov wrote:

notification_test.patch (45 KB)

···

Hey Sympho,

Just tested your patch on Linux and it looks really promising! The windows are quite pretty, the animations slick and the feature as a whole works well. Also tested the configuration and it worked! Very nice!

I did notice a few issues though:

1. Your patch adds to build.xml a new target building the notifications slick and it contains a reference to

/test/net/java/sip/communicator/slick/popupmessagehandler/popupmessagehandler.slick.manifest.mf

The manifest however is not in the patch (and neither is the slick for that matter :slight_smile: )

2. When using multiple screens the notifications would appear at weird locations (see attached ss-notification.png screenshot). This most probably happens because when calculating the location of a notification we probably get the size of a different screen than the one we actually show it on.

3. In the GeneralConfigurationPanel you assume that there will be resource strings corresponding to the class name of the handlers which makes for the result you see in ss-configuration.png. I think it would be best to make the handler service define a getName() method that we could display instead.

4. Using radio buttons is probably not a very good choice here since we don't really know how many handlers we'll have. I'd go for a combo box.

5. (this is more of a feature request but it is important) Currently, with jdic and java6, it is possible to bring related chat windows to the front when clicking on them. Could we also implement this with your swing notifications?

5. (another feature request that I can't resist :wink: ) Could we add the possibility for having images on the left of the notifications? This way we could show user avatars for incoming messages.

Cheers
Emil

On Thu, Feb 12, 2009 at 1:14 PM, sympho <sympho@ebcservice.com > <mailto:sympho@ebcservice.com>> wrote:

    Hi Emil,

    --- En date de : Jeu 12.2.09, Emil Ivov <emcho@sip-communicator.org
    <mailto:emcho@sip-communicator.org>> a �crit :

     > De: Emil Ivov <emcho@sip-communicator.org
    <mailto:emcho@sip-communicator.org>>
     > Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
     > �: dev@sip-communicator.dev.java.net
    <mailto:dev@sip-communicator.dev.java.net>
     > Date: Jeudi 12 F�vrier 2009, 1h33
     > Hey Sympho,
     >
     > I've reviewed your patch and it seems ok to me with the
     > exception of the
     > accounts.properties.template that it seems to remove for
     > some reason.
     > Could you please have a look and comment?
     >

    Mistakenly deleted while creating my accounts.properties file.

    ++

    Sympho.

     > Now, I am wondering what would be the best way to handle
     > its commit. On
     > the one hand the patch contains a new feature (the new
     > swing popup
     > notifications) and as such would probably be best committed
     > once we have
     > forked out our 1.0 branch on svn. On the other hand
     > however, in addition
     > to the fancy notifications feature scheduled for 2.0 (issue
     > 479) it also
     > resolves two of the bugs currently on scheduled for 1.0:
     >
     > https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
     > https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532
     >
     > This could justify committing it sooner without having to
     > wait for the
     > branch. I'll therefore be experimenting with it these
     > days and see how
     > it goes. Could anyone else please also try it out so that
     > we could
     > gather a bit more feedback?
     >
     > Thanks
     > Emil
     >
     > sympho wrote:
     > > hi,
     > >
     > > attached is a patch which adds new, swing based, popup
     > notifications.
     > >
     > > After discussing off list with Emil and Yana we
     > decided to create
     > > a new interface : PopupMessageHandler in the systray
     > packkage.
     > > Every notification handler will then implements the
     > new interface,
     > > making the systray service able to use any provided
     > handler.
     > >
     > > So, notifications using systray balloons have been put
     > in a class
     > > implemeting the new interface. The end user has the
     > ability to choose
     > > which handler will be used via tools/parameters (the
     > form need some
     > > aesthetics modifications I will do soon). We can also
     > decide to modify
     > > the used handler for some notification and then
     > restore it on the fly
     > > using new get/setActivePopupMessageHandler methods
     > added to the systray
     > > service.
     > >
     > > I tried to modify the growl notification service so
     > that it implements
     > > the new interface. But since I run only on windows, I
     > didn't saw how
     > > things look like for any handler on otherq OS or if I
     > broke something
     > > in growl.
     > >
     > > If anyone tries the patch before it is committed and
     > sees any issue,
     > > I will be happy to talk about it.
     > >
     > > Regards.
     > >
     > > Sympho
     > >
     > > ______________________
     > > http://ebcservice.com
     > >
     >
    __________________________________________________________________________________________________
     > > Ne pleurez pas si votre Webmail ferme ! R�cup�rez
     > votre historique sur Yahoo! Mail !
     > http://fr.docs.yahoo.com/mail/transfert_mails.html
     > >
     >
    ------------------------------------------------------------------------
     > >
     > ---------------------------------------------------------------------
     > > To unsubscribe, e-mail:
     > dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
     > > For additional commands, e-mail:
     > dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
     >
     > ---------------------------------------------------------------------
     > To unsubscribe, e-mail:
     > dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
     > For additional commands, e-mail:
     > dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

            __________________________________________________________________________________________________
    Ne pleurez pas si votre Webmail ferme ! R�cup�rez votre historique
    sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

    ---------------------------------------------------------------------
    To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

------------------------------------------------------------------------

------------------------------------------------------------------------

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi,

--- En date de : Jeu 12.2.09, Emil Ivov <emcho@sip-communicator.org> a écrit :

De: Emil Ivov <emcho@sip-communicator.org>
Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: dev@sip-communicator.dev.java.net
Date: Jeudi 12 Février 2009, 17h41
Hey Sympho,

Just tested your patch on Linux and it looks really
promising! The windows
are quite pretty, the animations slick and the feature as a
whole works
well. Also tested the configuration and it worked! Very
nice!

I did notice a few issues though:

1. Your patch adds to build.xml a new target building the
notifications
slick and it contains a reference to

/test/net/java/sip/communicator/slick/popupmessagehandler/popupmessagehandler.slick.manifest.mf

The manifest however is not in the patch (and neither is
the slick for that
matter :slight_smile: )

Fixed

2. When using multiple screens the notifications would
appear at weird
locations (see attached ss-notification.png screenshot).
This most probably
happens because when calculating the location of a
notification we probably
get the size of a different screen than the one we actually
show it on.

Still searching.

3. In the GeneralConfigurationPanel you assume that there
will be resource
strings corresponding to the class name of the handlers
which makes for the
result you see in ss-configuration.png. I think it would be
best to make the
handler service define a getName() method that we could
display instead.

It was temporary. Now done...

4. Using radio buttons is probably not a very good choice
here since we
don't really know how many handlers we'll have.
I'd go for a combo box.

...using a combo box. Rather than adding a getName method, I just overrided the toString since it is what JCombo use to get the string to
display.

5. (this is more of a feature request but it is important)
Currently, with
jdic and java6, it is possible to bring related chat
windows to the front
when clicking on them. Could we also implement this with
your swing
notifications?

In fact it was intented to work as you describe. It should be the case now.

5. (another feature request that I can't resist :wink: )
Could we add the
possibility for having images on the left of the
notifications? This way we
could show user avatars for incoming messages.

Partially done. The default contact icon will always been displayed for the moment.

To get things right, we have to decide how the image will reach the systray service, since the NotificationService#fireNotification provides only message title and message body. Do we had multiple fireNotification methods or one which will looks like

NotificationService#fireNotification(String eventType, Object data);

the data object will then be handled by notification handler (the handler for popup notification could expects to have an instance of PopupMessage as the data Object for example.

notfication_test.patch (92.4 KB)

···

++

Sympho

Cheers
Emil

On Thu, Feb 12, 2009 at 1:14 PM, sympho > <sympho@ebcservice.com> wrote:

> Hi Emil,
>
>
> --- En date de : Jeu 12.2.09, Emil Ivov
<emcho@sip-communicator.org> a
> écrit :
>
> > De: Emil Ivov <emcho@sip-communicator.org>
> > Objet: Re: [sip-comm-dev] [Issue 479] Fancy
systray tooltips
> > À: dev@sip-communicator.dev.java.net
> > Date: Jeudi 12 Février 2009, 1h33
> > Hey Sympho,
> >
> > I've reviewed your patch and it seems ok to
me with the
> > exception of the
> > accounts.properties.template that it seems to
remove for
> > some reason.
> > Could you please have a look and comment?
> >
>
> Mistakenly deleted while creating my
accounts.properties file.
>
> ++
>
> Sympho.
>
> > Now, I am wondering what would be the best way to
handle
> > its commit. On
> > the one hand the patch contains a new feature
(the new
> > swing popup
> > notifications) and as such would probably be best
committed
> > once we have
> > forked out our 1.0 branch on svn. On the other
hand
> > however, in addition
> > to the fancy notifications feature scheduled for
2.0 (issue
> > 479) it also
> > resolves two of the bugs currently on scheduled
for 1.0:
> >
> >
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
> >
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532
> >
> > This could justify committing it sooner without
having to
> > wait for the
> > branch. I'll therefore be experimenting with
it these
> > days and see how
> > it goes. Could anyone else please also try it out
so that
> > we could
> > gather a bit more feedback?
> >
> > Thanks
> > Emil
> >
> > sympho wrote:
> > > hi,
> > >
> > > attached is a patch which adds new, swing
based, popup
> > notifications.
> > >
> > > After discussing off list with Emil and Yana
we
> > decided to create
> > > a new interface : PopupMessageHandler in the
systray
> > packkage.
> > > Every notification handler will then
implements the
> > new interface,
> > > making the systray service able to use any
provided
> > handler.
> > >
> > > So, notifications using systray balloons
have been put
> > in a class
> > > implemeting the new interface. The end user
has the
> > ability to choose
> > > which handler will be used via
tools/parameters (the
> > form need some
> > > aesthetics modifications I will do soon). We
can also
> > decide to modify
> > > the used handler for some notification and
then
> > restore it on the fly
> > > using new get/setActivePopupMessageHandler
methods
> > added to the systray
> > > service.
> > >
> > > I tried to modify the growl notification
service so
> > that it implements
> > > the new interface. But since I run only on
windows, I
> > didn't saw how
> > > things look like for any handler on otherq
OS or if I
> > broke something
> > > in growl.
> > >
> > > If anyone tries the patch before it is
committed and
> > sees any issue,
> > > I will be happy to talk about it.
> > >
> > > Regards.
> > >
> > > Sympho
> > >
> > > ______________________
> > > http://ebcservice.com
> > >
> > >
> > >
> > >
> >
>
__________________________________________________________________________________________________
> > > Ne pleurez pas si votre Webmail ferme !
Récupérez
> > votre historique sur Yahoo! Mail !
> >
http://fr.docs.yahoo.com/mail/transfert_mails.html
> > >
> > >
> > >
> >
------------------------------------------------------------------------
> > >
> > >
> >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail:
> > dev-help@sip-communicator.dev.java.net
> >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> > dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
> > dev-help@sip-communicator.dev.java.net
>
>
>
>
__________________________________________________________________________________________________
> Ne pleurez pas si votre Webmail ferme ! Récupérez
votre historique sur
> Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html


#11

Sympho,

I'm sorry I forgot to include the following in my previous e-mail:

PopupMessageHandlerSwingImpl.showPopupMessage() is more than a hundred lines long and defines three nested classes which makes the reading of the code difficult (for me) because of, at the very least, the multiple indentations. The culprit for me here is the "duplication" of new Thread(new Runnable()).start() which perform the animated appearing and disappearing of notificationWindow. I think it would be an improvement to handle these two in a single, separate method thus shortening PopupMessageHandlerSwingImpl.showPopupMessage() and extracting the animation part in a single place with an appropriate (method) name which makes the purpose of the many lines obvious.

Just as before, please feel free to ignore the above as you see fit.

Best regards,
Lubo

Lubomir Marinov wrote:

···

Hi Sympho,

I took the liberty to also review your patch and I hope that you don't mind that I updated it to:

- remove the unintentional deletion of account.properties.template,

- fix a possible source of NullPointerException in NotificationServiceImpl which is fixed for your newly-introduced code but then leaves it to happen in the old code right bellow yours.

- remove the List.contains() check before List.remove() because it's performed in a way anyway so it doesn't need to be performed again,

- make as many fields as possible final (where possible),

- fix two introduced warnings (one of which is caused by a new unused method),

- fix some weird formatting (which seems to be left from the old code when it was removed and then the new one was written),

- clean up tiny code here and there.

Anyway, these are really minor and represent my personal view so please feel free to use the changes as you see fit.

Best regards,
Lubo

Emil Ivov wrote:

Hey Sympho,

Just tested your patch on Linux and it looks really promising! The windows are quite pretty, the animations slick and the feature as a whole works well. Also tested the configuration and it worked! Very nice!

I did notice a few issues though:

1. Your patch adds to build.xml a new target building the notifications slick and it contains a reference to

/test/net/java/sip/communicator/slick/popupmessagehandler/popupmessagehandler.slick.manifest.mf

The manifest however is not in the patch (and neither is the slick for that matter :slight_smile: )

2. When using multiple screens the notifications would appear at weird locations (see attached ss-notification.png screenshot). This most probably happens because when calculating the location of a notification we probably get the size of a different screen than the one we actually show it on.

3. In the GeneralConfigurationPanel you assume that there will be resource strings corresponding to the class name of the handlers which makes for the result you see in ss-configuration.png. I think it would be best to make the handler service define a getName() method that we could display instead.

4. Using radio buttons is probably not a very good choice here since we don't really know how many handlers we'll have. I'd go for a combo box.

5. (this is more of a feature request but it is important) Currently, with jdic and java6, it is possible to bring related chat windows to the front when clicking on them. Could we also implement this with your swing notifications?

5. (another feature request that I can't resist :wink: ) Could we add the possibility for having images on the left of the notifications? This way we could show user avatars for incoming messages.

Cheers
Emil

On Thu, Feb 12, 2009 at 1:14 PM, sympho <sympho@ebcservice.com >> <mailto:sympho@ebcservice.com>> wrote:

    Hi Emil,

    --- En date de : Jeu 12.2.09, Emil Ivov <emcho@sip-communicator.org
    <mailto:emcho@sip-communicator.org>> a �crit :

     > De: Emil Ivov <emcho@sip-communicator.org
    <mailto:emcho@sip-communicator.org>>
     > Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
     > �: dev@sip-communicator.dev.java.net
    <mailto:dev@sip-communicator.dev.java.net>
     > Date: Jeudi 12 F�vrier 2009, 1h33
     > Hey Sympho,
     >
     > I've reviewed your patch and it seems ok to me with the
     > exception of the
     > accounts.properties.template that it seems to remove for
     > some reason.
     > Could you please have a look and comment?
     >

    Mistakenly deleted while creating my accounts.properties file.

    ++

    Sympho.

     > Now, I am wondering what would be the best way to handle
     > its commit. On
     > the one hand the patch contains a new feature (the new
     > swing popup
     > notifications) and as such would probably be best committed
     > once we have
     > forked out our 1.0 branch on svn. On the other hand
     > however, in addition
     > to the fancy notifications feature scheduled for 2.0 (issue
     > 479) it also
     > resolves two of the bugs currently on scheduled for 1.0:
     >
     > https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
     > https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532
     >
     > This could justify committing it sooner without having to
     > wait for the
     > branch. I'll therefore be experimenting with it these
     > days and see how
     > it goes. Could anyone else please also try it out so that
     > we could
     > gather a bit more feedback?
     >
     > Thanks
     > Emil
     >
     > sympho wrote:
     > > hi,
     > >
     > > attached is a patch which adds new, swing based, popup
     > notifications.
     > >
     > > After discussing off list with Emil and Yana we
     > decided to create
     > > a new interface : PopupMessageHandler in the systray
     > packkage.
     > > Every notification handler will then implements the
     > new interface,
     > > making the systray service able to use any provided
     > handler.
     > >
     > > So, notifications using systray balloons have been put
     > in a class
     > > implemeting the new interface. The end user has the
     > ability to choose
     > > which handler will be used via tools/parameters (the
     > form need some
     > > aesthetics modifications I will do soon). We can also
     > decide to modify
     > > the used handler for some notification and then
     > restore it on the fly
     > > using new get/setActivePopupMessageHandler methods
     > added to the systray
     > > service.
     > >
     > > I tried to modify the growl notification service so
     > that it implements
     > > the new interface. But since I run only on windows, I
     > didn't saw how
     > > things look like for any handler on otherq OS or if I
     > broke something
     > > in growl.
     > >
     > > If anyone tries the patch before it is committed and
     > sees any issue,
     > > I will be happy to talk about it.
     > >
     > > Regards.
     > >
     > > Sympho
     > >
     > > ______________________
     > > http://ebcservice.com
     > >
     >
    __________________________________________________________________________________________________

     > > Ne pleurez pas si votre Webmail ferme ! R�cup�rez
     > votre historique sur Yahoo! Mail !
     > http://fr.docs.yahoo.com/mail/transfert_mails.html
     > >
     >
    ------------------------------------------------------------------------
     > >
     > ---------------------------------------------------------------------
     > > To unsubscribe, e-mail:
     > dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
     > > For additional commands, e-mail:
     > dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
     >
     > ---------------------------------------------------------------------
     > To unsubscribe, e-mail:
     > dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
     > For additional commands, e-mail:
     > dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

            __________________________________________________________________________________________________

    Ne pleurez pas si votre Webmail ferme ! R�cup�rez votre historique
    sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

    ---------------------------------------------------------------------
    To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

------------------------------------------------------------------------

------------------------------------------------------------------------

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hey Sympho,

> 2. When using multiple screens the notifications would
> appear at weird
> locations (see attached ss-notification.png screenshot).
> This most probably
> happens because when calculating the location of a
> notification we probably
> get the size of a different screen than the one we actually
> show it on.
>

Still searching.

We already discussed this off list but for the record: You might want
to have a look at the javadoc example here:
http://java.sun.com/javase/6/docs/api/index.html?java/awt/GraphicsDevice.html

> 5. (another feature request that I can't resist :wink: )
> Could we add the
> possibility for having images on the left of the
> notifications? This way we
> could show user avatars for incoming messages.
>

Partially done. The default contact icon will always been displayed for the moment.

To get things right, we have to decide how the image will reach the systray service, since the NotificationService#fireNotification provides only message title and message body. Do we had multiple fireNotification methods or one which will looks like

NotificationService#fireNotification(String eventType, Object data);

Good point. Let's think this over a bit more.

In the mean time, could you please commit your changes to trunk?

It is true that we are already past the point where new features
should be integrated or at least not before we fork our our 1.0
branch. The fancy systray popups however definitely deserve an
exception since they would resolve two of the existing rc1 issues
(#431 and #532).

I have therefore rescheduled issue #479 to rc1. If anyone has a
problem with this then please bring it up here so that we can discuss
it.

Cheers
Emil

···

On Mon, Feb 16, 2009 at 6:06 PM, sympho <sympho@ebcservice.com> wrote:


#13

Hi Lubomir,

Thanks for your review :slight_smile:

I think I integrated all your changes in my working copy.
If not, it is just because I missed something, since I havent found anything on wich I disagree.

I will submit a new patch ASAP.

regards

Sympho.

--- En date de : Jeu 12.2.09, Lubomir Marinov <lubomir.marinov@gmail.com> a écrit :

···

De: Lubomir Marinov <lubomir.marinov@gmail.com>
Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: dev@sip-communicator.dev.java.net
Date: Jeudi 12 Février 2009, 18h57
Sympho,

I'm sorry I forgot to include the following in my
previous e-mail:

PopupMessageHandlerSwingImpl.showPopupMessage() is more
than a hundred lines long and defines three nested classes
which makes the reading of the code difficult (for me)
because of, at the very least, the multiple indentations.
The culprit for me here is the "duplication" of
new Thread(new Runnable()).start() which perform the
animated appearing and disappearing of notificationWindow. I
think it would be an improvement to handle these two in a
single, separate method thus shortening
PopupMessageHandlerSwingImpl.showPopupMessage() and
extracting the animation part in a single place with an
appropriate (method) name which makes the purpose of the
many lines obvious.

Just as before, please feel free to ignore the above as you
see fit.

Best regards,
Lubo

Lubomir Marinov wrote:
> Hi Sympho,
>
> I took the liberty to also review your patch and I
hope that you don't mind that I updated it to:
>
> - remove the unintentional deletion of
account.properties.template,
>
> - fix a possible source of NullPointerException in
NotificationServiceImpl which is fixed for your
newly-introduced code but then leaves it to happen in the
old code right bellow yours.
>
> - remove the List.contains() check before
List.remove() because it's performed in a way anyway so
it doesn't need to be performed again,
>
> - make as many fields as possible final (where
possible),
>
> - fix two introduced warnings (one of which is caused
by a new unused method),
>
> - fix some weird formatting (which seems to be left
from the old code when it was removed and then the new one
was written),
>
> - clean up tiny code here and there.
>
> Anyway, these are really minor and represent my
personal view so please feel free to use the changes as you
see fit.
>
> Best regards,
> Lubo
>
> Emil Ivov wrote:
>> Hey Sympho,
>>
>> Just tested your patch on Linux and it looks
really promising! The windows are quite pretty, the
animations slick and the feature as a whole works well. Also
tested the configuration and it worked! Very nice!
>>
>> I did notice a few issues though:
>>
>> 1. Your patch adds to build.xml a new target
building the notifications slick and it contains a reference
to
>>
>>
/test/net/java/sip/communicator/slick/popupmessagehandler/popupmessagehandler.slick.manifest.mf

>>
>> The manifest however is not in the patch (and
neither is the slick for that matter :slight_smile: )
>>
>> 2. When using multiple screens the notifications
would appear at weird locations (see attached
ss-notification.png screenshot). This most probably happens
because when calculating the location of a notification we
probably get the size of a different screen than the one we
actually show it on.
>>
>> 3. In the GeneralConfigurationPanel you assume
that there will be resource strings corresponding to the
class name of the handlers which makes for the result you
see in ss-configuration.png. I think it would be best to
make the handler service define a getName() method that we
could display instead.
>>
>> 4. Using radio buttons is probably not a very good
choice here since we don't really know how many handlers
we'll have. I'd go for a combo box.
>>
>> 5. (this is more of a feature request but it is
important) Currently, with jdic and java6, it is possible to
bring related chat windows to the front when clicking on
them. Could we also implement this with your swing
notifications?
>>
>> 5. (another feature request that I can't
resist :wink: ) Could we add the possibility for having images
on the left of the notifications? This way we could show
user avatars for incoming messages.
>>
>> Cheers
>> Emil
>>
>> On Thu, Feb 12, 2009 at 1:14 PM, sympho > <sympho@ebcservice.com > <mailto:sympho@ebcservice.com>> wrote:
>>
>> Hi Emil,
>>
>>
>> --- En date de : Jeu 12.2.09, Emil Ivov
<emcho@sip-communicator.org
>> <mailto:emcho@sip-communicator.org>>
a écrit :
>>
>> > De: Emil Ivov
<emcho@sip-communicator.org
>> <mailto:emcho@sip-communicator.org>>
>> > Objet: Re: [sip-comm-dev] [Issue 479]
Fancy systray tooltips
>> > À: dev@sip-communicator.dev.java.net
>>
<mailto:dev@sip-communicator.dev.java.net>
>> > Date: Jeudi 12 Février 2009, 1h33
>> > Hey Sympho,
>> >
>> > I've reviewed your patch and it
seems ok to me with the
>> > exception of the
>> > accounts.properties.template that it
seems to remove for
>> > some reason.
>> > Could you please have a look and
comment?
>> >
>>
>> Mistakenly deleted while creating my
accounts.properties file.
>>
>> ++
>>
>> Sympho.
>>
>> > Now, I am wondering what would be the
best way to handle
>> > its commit. On
>> > the one hand the patch contains a new
feature (the new
>> > swing popup
>> > notifications) and as such would
probably be best committed
>> > once we have
>> > forked out our 1.0 branch on svn. On the
other hand
>> > however, in addition
>> > to the fancy notifications feature
scheduled for 2.0 (issue
>> > 479) it also
>> > resolves two of the bugs currently on
scheduled for 1.0:
>> >
>> >
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=431
>> >
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=532
>> >
>> > This could justify committing it sooner
without having to
>> > wait for the
>> > branch. I'll therefore be
experimenting with it these
>> > days and see how
>> > it goes. Could anyone else please also
try it out so that
>> > we could
>> > gather a bit more feedback?
>> >
>> > Thanks
>> > Emil
>> >
>> > sympho wrote:
>> > > hi,
>> > >
>> > > attached is a patch which adds new,
swing based, popup
>> > notifications.
>> > >
>> > > After discussing off list with Emil
and Yana we
>> > decided to create
>> > > a new interface :
PopupMessageHandler in the systray
>> > packkage.
>> > > Every notification handler will
then implements the
>> > new interface,
>> > > making the systray service able to
use any provided
>> > handler.
>> > >
>> > > So, notifications using systray
balloons have been put
>> > in a class
>> > > implemeting the new interface. The
end user has the
>> > ability to choose
>> > > which handler will be used via
tools/parameters (the
>> > form need some
>> > > aesthetics modifications I will do
soon). We can also
>> > decide to modify
>> > > the used handler for some
notification and then
>> > restore it on the fly
>> > > using new
get/setActivePopupMessageHandler methods
>> > added to the systray
>> > > service.
>> > >
>> > > I tried to modify the growl
notification service so
>> > that it implements
>> > > the new interface. But since I run
only on windows, I
>> > didn't saw how
>> > > things look like for any handler on
otherq OS or if I
>> > broke something
>> > > in growl.
>> > >
>> > > If anyone tries the patch before it
is committed and
>> > sees any issue,
>> > > I will be happy to talk about it.
>> > >
>> > > Regards.
>> > >
>> > > Sympho
>> > >
>> > > ______________________
>> > > http://ebcservice.com
>> > >
>> > >
>> > >
>> > >
>> >
>>
__________________________________________________________________________________________________

>> > > Ne pleurez pas si votre Webmail
ferme ! Récupérez
>> > votre historique sur Yahoo! Mail !
>> >
http://fr.docs.yahoo.com/mail/transfert_mails.html
>> > >
>> > >
>> > >
>> >
>>
------------------------------------------------------------------------
>> > >
>> > >
>> >
---------------------------------------------------------------------
>> > > To unsubscribe, e-mail:
>> >
dev-unsubscribe@sip-communicator.dev.java.net
>>
<mailto:dev-unsubscribe@sip-communicator.dev.java.net>
>> > > For additional commands, e-mail:
>> > dev-help@sip-communicator.dev.java.net
>>
<mailto:dev-help@sip-communicator.dev.java.net>
>> >
>> >
>> >
>> >
>> >
---------------------------------------------------------------------
>> > To unsubscribe, e-mail:
>> >
dev-unsubscribe@sip-communicator.dev.java.net
>>
<mailto:dev-unsubscribe@sip-communicator.dev.java.net>
>> > For additional commands, e-mail:
>> > dev-help@sip-communicator.dev.java.net
>>
<mailto:dev-help@sip-communicator.dev.java.net>
>>
>>
>>
__________________________________________________________________________________________________

>> Ne pleurez pas si votre Webmail ferme !
Récupérez votre historique
>> sur Yahoo! Mail !
http://fr.docs.yahoo.com/mail/transfert_mails.html
>>
>>
---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> dev-unsubscribe@sip-communicator.dev.java.net
>>
<mailto:dev-unsubscribe@sip-communicator.dev.java.net>
>> For additional commands, e-mail:
>> dev-help@sip-communicator.dev.java.net
>>
<mailto:dev-help@sip-communicator.dev.java.net>
>>
>>
>>
>>
------------------------------------------------------------------------
>>
>>
>>
------------------------------------------------------------------------
>>
>>
>>
------------------------------------------------------------------------
>>
>>
---------------------------------------------------------------------
>> To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

      __________________________________________________________________________________________________
Ne pleurez pas si votre Webmail ferme ! Récupérez votre historique sur Yahoo! Mail ! http://fr.docs.yahoo.com/mail/transfert_mails.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hi Sympho,

In the mean time, could you please commit your changes to trunk?

Now that your changes have made it to the trunk, let me tell you I
really like the new notification popup.

I've noticed that when displaying a long message which doesn't fit in
the popup, it isn't cut correctly. The middle of the message is shown
where I would expect to only see the beginning (screenshot attached).

Also, as you can see in the screenshot, the "Someone has sent you ..."
message is so much cut, that you can't even guess the sentence. I do not
propose to make the popup bigger, but we could just display the name of
the contact with a speech bubble.

Probably not related to your changes, when using XMPP to test the new
notifications, the chat window was flooded with such messages (about one every
10s):

jabber_user at 12:09:56 [This is part of an encrypted session. If you see this
message, something went wrong.]

...and no errors on the log side.

Cheers,

···

On Mon, Feb 16, 2009 at 06:40:54PM +0100, Emil Ivov wrote:

--
Sébastien Mazy


#15

Hi Sébastien,

And thanks for your reports

more inline

--- En date de : Jeu 19.2.09, Sébastien Mazy <smazy@dev.java.net> a écrit :

De: Sébastien Mazy <smazy@dev.java.net>
Objet: Re: [sip-comm-dev] [Issue 479] Fancy systray tooltips
À: dev@sip-communicator.dev.java.net
Date: Jeudi 19 Février 2009, 12h14
Hi Sympho,

> In the mean time, could you please commit your changes
to trunk?

Now that your changes have made it to the trunk, let me
tell you I
really like the new notification popup.

I've noticed that when displaying a long message which
doesn't fit in
the popup, it isn't cut correctly. The middle of the
message is shown
where I would expect to only see the beginning (screenshot
attached).

Emil reported the same problem and i made some small modifications about the popup layout. Please, tell me if it is still the case now.

Also, as you can see in the screenshot, the "Someone
has sent you ..."
message is so much cut, that you can't even guess the
sentence. I do not
propose to make the popup bigger, but we could just display
the name of
the contact with a speech bubble.

I agree with you on displaying only the contact name (or email address). I talked with Emil about that. As the message title is set out of the systray service we agreed the modification will be done where it is set, later. For the moment, the title could take up 2 rows now.

Probably not related to your changes, when using XMPP to
test the new
notifications, the chat window was flooded with such
messages (about one every
10s):

jabber_user at 12:09:56 [This is part of an encrypted
session. If you see this
message, something went wrong.]

I also use XMPP but, I have'nt a clue about that since I didn't seen this kind of message. I guess only people who use encryption could have some idea about that.

regards,
Sympho

···

On Mon, Feb 16, 2009 at 06:40:54PM +0100, Emil Ivov wrote:

...and no errors on the log side.

Cheers,

--
Sébastien Mazy
---------------------------------------------------------------------
To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Hi Sympho,

I tested again with SVN revision 5047.

> I've noticed that when displaying a long message which doesn't fit
> in the popup, it isn't cut correctly. The middle of the message is
> shown where I would expect to only see the beginning (screenshot
> attached).

Emil reported the same problem and i made some small modifications
about the popup layout. Please, tell me if it is still the case now.

Unfortunately the beginning of the message still isn't shown in the
notification popup. I attached a new screenshot for which the message
was "This is a very very long message, so long it doesn't fit the
notification popup, it really never ends". As you can see, only "long
message, so long it doesn't fit the notification popup, it" is
displayed.

> Also, as you can see in the screenshot, the "Someone has sent you
> ..." message is so much cut, that you can't even guess the sentence.
> I do not propose to make the popup bigger, but we could just display
> the name of the contact with a speech bubble.

I agree with you on displaying only the contact name (or email
address). I talked with Emil about that. As the message title is set
out of the systray service we agreed the modification will be done
where it is set, later. For the moment, the title could take up 2 rows
now.

Thanks, 2 rows seems enough for the new message notification.

Cheers,

···

On Fri, Feb 20, 2009 at 06:32:45PM +0000, sympho wrote:

--
Sébastien Mazy


#17

Hi Sébastien

Unfortunately the beginning of the message still isn't
shown in the
notification popup.

I tested with your text and I note that the layout isn't the same on all platform since the message fit the popup on windows vista. You can see a screenshot here :

http://ebcservice.com/tmp/notif_vista

I will try to look on linux soon.

···

++
Sympho

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#18

Hi Sympho!

> Unfortunately the beginning of the message still isn't shown in the
> notification popup.

I tested with your text and I note that the layout isn't the same on
all platform since the message fit the popup on windows vista.

Yet another case of Swing's platform inconsistency... thanks for the
confirmation.

I will try to look on linux soon.

Take your time, it's just a minor problem. I could also open an issue
for it if you prefer.

Cheers,

···

On Mon, Feb 23, 2009 at 10:03:56AM +0000, sympho wrote:

--
Sébastien Mazy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#19

Hi again,

I have just committed some layout improvements (revision 5061), that should also fix the problem described here. Please feel free to test.

Cheers,
Yana

Yana Stamcheva wrote:

···

Hi Seb, Sympho,

just a note to let you know that I'm currently working on the issue. Will ping you as soon as I have something ready for testing!

Cheers,
Yana

Sébastien Mazy wrote:

Hi Sympho!

On Mon, Feb 23, 2009 at 10:03:56AM +0000, sympho wrote:

Unfortunately the beginning of the message still isn't shown in the
notification popup.

I tested with your text and I note that the layout isn't the same on
all platform since the message fit the popup on windows vista.

Yet another case of Swing's platform inconsistency... thanks for the
confirmation.

I will try to look on linux soon.

Take your time, it's just a minor problem. I could also open an issue
for it if you prefer.

Cheers,

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net