[sip-comm-dev] Issue #462 Audio notifications for ZRTP status.


#1

Hi Werner,

I've just committed some minor improvements to zrtp audio notifications (r5083 and r5085) and have took the time to test them under windows and mac. Everything is working fine for me, so I was wondering if we could now close issue #462 "Audio notifications for ZRTP status" or you had something more in mind there?

Regards,
Yana

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Yana,

just by looking at the code I saw that you play the ALERT tone
on "securOff" event. Well, the idea behind the sound notifications
is:

- play the secureOn tone (the short tone) if security is switched
  on. This may remind the user to look at the screen to check the
  actual status of the security data

- the ALERT tone (sounds like a police/fire brigade) should be played
  in case of real problems, i.e. security cannot be established during
  ZRTP processing, for example wrong data, possible MitM detected etc.
  This tone was not meant to signal "call end". Currently the user
  cannot switch off security during a call and hangup ends the call
  completely.

I'll have a more in-depth look to it tomorrow and check it. I then
try to fix it according to above description and test it (to do so
I need some special modifications to force erroneous behavior of
the ZRTP protocol).

Regards,
Werner

Yana Stamcheva schrieb:

···

Hi Werner,

I've just committed some minor improvements to zrtp audio notifications
(r5083 and r5085) and have took the time to test them under windows and
mac. Everything is working fine for me, so I was wondering if we could
now close issue #462 "Audio notifications for ZRTP status" or you had
something more in mind there?

Regards,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Yana,

the security message event does not have a field to explicitly
indicate the severeness of the message. This could be somehow
determined by analyzing the event type but for further processing
it is IMHO easier to add a filed (integer) that indicates if
it is a WARNING, SEVERE error, or ZRTP error.

Thoughts?

Regards,
Werner

Werner Dittmann schrieb:

···

Yana,

just by looking at the code I saw that you play the ALERT tone
on "securOff" event. Well, the idea behind the sound notifications
is:

- play the secureOn tone (the short tone) if security is switched
  on. This may remind the user to look at the screen to check the
  actual status of the security data

- the ALERT tone (sounds like a police/fire brigade) should be played
  in case of real problems, i.e. security cannot be established during
  ZRTP processing, for example wrong data, possible MitM detected etc.
  This tone was not meant to signal "call end". Currently the user
  cannot switch off security during a call and hangup ends the call
  completely.

I'll have a more in-depth look to it tomorrow and check it. I then
try to fix it according to above description and test it (to do so
I need some special modifications to force erroneous behavior of
the ZRTP protocol).

Regards,
Werner

Yana Stamcheva schrieb:

Hi Werner,

I've just committed some minor improvements to zrtp audio notifications
(r5083 and r5085) and have took the time to test them under windows and
mac. Everything is working fine for me, so I was wondering if we could
now close issue #462 "Audio notifications for ZRTP status" or you had
something more in mind there?

Regards,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Yana,

yet another addition: I'm just reworking the security messaging stuff.
Not how it work in terms of sending events etc but how the SecurityEventManager
populates the event fields and how the CallPanel uses them to display
messages.

This is mainly to distinguish between the various severity levels of
the messages and how they may be presented to the user. In a first
step I adapt the text massages, make them more suited to the actual
event severity.

Regards,
Werner

Werner Dittmann schrieb:

···

Yana,

the security message event does not have a field to explicitly
indicate the severeness of the message. This could be somehow
determined by analyzing the event type but for further processing
it is IMHO easier to add a filed (integer) that indicates if
it is a WARNING, SEVERE error, or ZRTP error.

Thoughts?

Regards,
Werner

Werner Dittmann schrieb:

Yana,

just by looking at the code I saw that you play the ALERT tone
on "securOff" event. Well, the idea behind the sound notifications
is:

- play the secureOn tone (the short tone) if security is switched
  on. This may remind the user to look at the screen to check the
  actual status of the security data

- the ALERT tone (sounds like a police/fire brigade) should be played
  in case of real problems, i.e. security cannot be established during
  ZRTP processing, for example wrong data, possible MitM detected etc.
  This tone was not meant to signal "call end". Currently the user
  cannot switch off security during a call and hangup ends the call
  completely.

I'll have a more in-depth look to it tomorrow and check it. I then
try to fix it according to above description and test it (to do so
I need some special modifications to force erroneous behavior of
the ZRTP protocol).

Regards,
Werner

Yana Stamcheva schrieb:

Hi Werner,

I've just committed some minor improvements to zrtp audio notifications
(r5083 and r5085) and have took the time to test them under windows and
mac. Everything is working fine for me, so I was wondering if we could
now close issue #462 "Audio notifications for ZRTP status" or you had
something more in mind there?

Regards,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Werner,

I was looking at issue #462 "Audio notifications for ZRTP status" and was wondering if we can now close it. Could you please confirm?

Cheers,
Yana

Werner Dittmann wrote:

···

Yana,

yet another addition: I'm just reworking the security messaging stuff.
Not how it work in terms of sending events etc but how the SecurityEventManager
populates the event fields and how the CallPanel uses them to display
messages.

This is mainly to distinguish between the various severity levels of
the messages and how they may be presented to the user. In a first
step I adapt the text massages, make them more suited to the actual
event severity.

Regards,
Werner

Werner Dittmann schrieb:

Yana,

the security message event does not have a field to explicitly
indicate the severeness of the message. This could be somehow
determined by analyzing the event type but for further processing
it is IMHO easier to add a filed (integer) that indicates if
it is a WARNING, SEVERE error, or ZRTP error.

Thoughts?

Regards,
Werner

Werner Dittmann schrieb:

Yana,

just by looking at the code I saw that you play the ALERT tone
on "securOff" event. Well, the idea behind the sound notifications
is:

- play the secureOn tone (the short tone) if security is switched
  on. This may remind the user to look at the screen to check the
  actual status of the security data

- the ALERT tone (sounds like a police/fire brigade) should be played
  in case of real problems, i.e. security cannot be established during
  ZRTP processing, for example wrong data, possible MitM detected etc.
  This tone was not meant to signal "call end". Currently the user
  cannot switch off security during a call and hangup ends the call
  completely.

I'll have a more in-depth look to it tomorrow and check it. I then
try to fix it according to above description and test it (to do so
I need some special modifications to force erroneous behavior of
the ZRTP protocol).

Regards,
Werner

Yana Stamcheva schrieb:

Hi Werner,

I've just committed some minor improvements to zrtp audio notifications
(r5083 and r5085) and have took the time to test them under windows and
mac. Everything is working fine for me, so I was wondering if we could
now close issue #462 "Audio notifications for ZRTP status" or you had
something more in mind there?

Regards,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Yana,

IMHO we can close that issue - last time I testest ZRTP the "ping" sound
was ok, also the alert sound.

Regards,
Werner

Yana Stamcheva schrieb:

···

Hi Werner,

I was looking at issue #462 "Audio notifications for ZRTP status" and
was wondering if we can now close it. Could you please confirm?

Cheers,
Yana

Werner Dittmann wrote:

Yana,

yet another addition: I'm just reworking the security messaging stuff.
Not how it work in terms of sending events etc but how the
SecurityEventManager
populates the event fields and how the CallPanel uses them to display
messages.

This is mainly to distinguish between the various severity levels of
the messages and how they may be presented to the user. In a first
step I adapt the text massages, make them more suited to the actual
event severity.

Regards,
Werner

Werner Dittmann schrieb:

Yana,

the security message event does not have a field to explicitly
indicate the severeness of the message. This could be somehow
determined by analyzing the event type but for further processing
it is IMHO easier to add a filed (integer) that indicates if
it is a WARNING, SEVERE error, or ZRTP error.

Thoughts?

Regards,
Werner

Werner Dittmann schrieb:

Yana,

just by looking at the code I saw that you play the ALERT tone
on "securOff" event. Well, the idea behind the sound notifications
is:

- play the secureOn tone (the short tone) if security is switched
  on. This may remind the user to look at the screen to check the
  actual status of the security data

- the ALERT tone (sounds like a police/fire brigade) should be played
  in case of real problems, i.e. security cannot be established during
  ZRTP processing, for example wrong data, possible MitM detected etc.
  This tone was not meant to signal "call end". Currently the user
  cannot switch off security during a call and hangup ends the call
  completely.

I'll have a more in-depth look to it tomorrow and check it. I then
try to fix it according to above description and test it (to do so
I need some special modifications to force erroneous behavior of
the ZRTP protocol).

Regards,
Werner

Yana Stamcheva schrieb:

Hi Werner,

I've just committed some minor improvements to zrtp audio
notifications
(r5083 and r5085) and have took the time to test them under windows
and
mac. Everything is working fine for me, so I was wondering if we could
now close issue #462 "Audio notifications for ZRTP status" or you had
something more in mind there?

Regards,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net