[sip-comm-dev] Integrating SpellChecker with the Latest Build


#1

Hello Folks

I had a talk with emcho regarding the integration of SpellChecker in
the latest SIP build. The code of which has already been written
during gsoc 2008 by Damain.

The code resides in a package "net.java.sip.communicator.plugin.spellchecker".

For now I was following a BlackBox Approach towards the code. Not
realising "how" the code does it but just "what" the code does.
As the core code stays the same but as the GUI of the project has
evolved,my Approach till now has been:

   1. Separate the core from GUI dependent code
   2. Use all the core code(As it should work )
   3. Rewrite the GUI code.

While doing this I realized some new listener and other code needs to
be added in the other clases as well.

This seems to be a good working approach but then I finally I stumbled
on the class "net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager".
The design of this class is different in the trunk branch.

The constructor is default which in the spellcheck version took a
"net.java.sip.communicator.impl.gui.main.MainFrame" as an argument.
Now there is a default constrcutor.

Some other changes are there as well.

I wonder if I am following the right approach of getting the job done?
Or should I figure out "how" exactly Damain's code does the job and
then work on my code in the latest build?

Some experience developers could please help me with this. :slight_smile:

Regards
Nitish

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Nitish,

Hello Folks

I had a talk with emcho regarding the integration of SpellChecker in
the latest SIP build. The code of which has already been written
during gsoc 2008 by Damain.

The code resides in a package "net.java.sip.communicator.plugin.spellchecker".

For now I was following a BlackBox Approach towards the code. Not
realising "how" the code does it but just "what" the code does.
As the core code stays the same but as the GUI of the project has
evolved,my Approach till now has been:

  1. Separate the core from GUI dependent code
  2. Use all the core code(As it should work )
  3. Rewrite the GUI code.

It seems the right approach for me. You can even use some parts from the gui related code too, you'll just need to re-factor them a little in order to make them fit the new gui architecture in trunk.

While doing this I realized some new listener and other code needs to
be added in the other clases as well.

You mean in the core spellcheck classes?

This seems to be a good working approach but then I finally I stumbled
on the class "net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager".
The design of this class is different in the trunk branch.

The constructor is default which in the spellcheck version took a
"net.java.sip.communicator.impl.gui.main.MainFrame" as an argument.
Now there is a default constrcutor.

Just to be sure, you're moving all spellcheck related code from the spellcheck branch to the trunk, right? What is the code related to spellcheck in ChatWindowManager, which bothers you?

Some other changes are there as well.

I wonder if I am following the right approach of getting the job done?
Or should I figure out "how" exactly Damain's code does the job and
then work on my code in the latest build?

I believe that you're following the right approach and in my opinion this should be the easiest way to integrate the spellchecker.

Cheers,
Yana

···

On Aug 18, 2010, at 8:33 AM, Nitish Upreti wrote:

Some experience developers could please help me with this. :slight_smile:

Regards
Nitish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net