[sip-comm-dev] Implementation: SIP URI Service Discovery


#1

Hello SC Devs,
I have been working on implementing the Internet-Draft SIP URI Service Discovery.
Find attached the patch file for my implementation. The project report that I submitted is attached as well. The patch was built against source snapshot: sip-communicator-src-1.0-alpha3-nightly.build.1616

Note that this implementation is affected by Issue # 467 (link) and that fix might need to be merged as well.

Regards,
Akshat Sikarwar

SIP Bonjour Project Report.pdf (307 KB)

sipbonjour.patch (266 KB)


#2

Hey Akshat,

That's a neat piece of code! I would like us to integrate it so we just
need to figure out the right time.

Folks, you are probably all aware that we are preparing the 1.0-rc1
release. In order to do this properly we would need to spin off a 1.0
branch on svn and make sure that we only commit fixes there (i.e. no new
features).

I'll therefore create this branch before the end of the week so that we
could integrate patches like the one Akshat is submitting here.

Akshat, in the mean time, could you please create an issue for your
service discovery implementation so that we make sure we don't forget
about it.

Now, the most tricky part about having a branch comes from needing to
commit some fixes in both this branch and in trunk. I believe we could
do this automatically though. I am thinking we could run an extra
instance of cruise control that would automatically merge modifications
to our 1.0 branch into the trunk. We'll see how this works.

More coming later

Cheers
Emil

Akshat Sikarwar wrote:

···

Hello SC Devs,
I have been working on implementing the Internet-Draft *SIP URI Service
Discovery.*
Find attached the patch file for my implementation. The project report
that I submitted is attached as well. The patch was built against source
snapshot: sip-communicator-src-1.0-alpha3-nightly.build.1616

Note that this implementation is affected by Issue # 467 (link
<https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=467>) and
that fix might need to be merged as well.

Regards,
Akshat Sikarwar

------------------------------------------------------------------------

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey Akshat,

I've finally found the time to review your code. I like the feature and
think it could be quite useful in various occasions. We would probably
need to spend some more time on it before it's ready for integration
which is why I've scheduled it for 2.0.

One of the major changes that would probably need to be applied would
require making the feature a part of the Bonjour bundle rather than the
SIP one. We could then implement a telephony OperationSet in Bonjour
that would allow it to wrap around the op set of an existing SIP provider.

Is this something that you'd be interested in working on?

Cheers
Emil

Emil Ivov wrote:

···

Hey Akshat,

That's a neat piece of code! I would like us to integrate it so we just
need to figure out the right time.

Folks, you are probably all aware that we are preparing the 1.0-rc1
release. In order to do this properly we would need to spin off a 1.0
branch on svn and make sure that we only commit fixes there (i.e. no new
features).

I'll therefore create this branch before the end of the week so that we
could integrate patches like the one Akshat is submitting here.

Akshat, in the mean time, could you please create an issue for your
service discovery implementation so that we make sure we don't forget
about it.

Now, the most tricky part about having a branch comes from needing to
commit some fixes in both this branch and in trunk. I believe we could
do this automatically though. I am thinking we could run an extra
instance of cruise control that would automatically merge modifications
to our 1.0 branch into the trunk. We'll see how this works.

More coming later

Cheers
Emil

Akshat Sikarwar wrote:

Hello SC Devs,
I have been working on implementing the Internet-Draft *SIP URI Service
Discovery.*
Find attached the patch file for my implementation. The project report
that I submitted is attached as well. The patch was built against source
snapshot: sip-communicator-src-1.0-alpha3-nightly.build.1616

Note that this implementation is affected by Issue # 467 (link
<https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=467>) and
that fix might need to be merged as well.

Regards,
Akshat Sikarwar

------------------------------------------------------------------------

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net