[sip-comm-dev] .impl.audionotifier vs .impl.neomedia.notify


#1

Hi devs,

Why do we still have .impl.audionotifier in trunk given that it has been
functionally replaced by .impl.neomedia.notify? (Yana Stamcheva
initially alerted me to the two AudioNotifierService implementations.)
Is it OK to remove it?

Regards,
Lubomir

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi,

I think I'm responsible for this. It was at the time when we
introduced the first implementation of portaudio in the old media. In
order to switch and the notifications to different devices we had to
move it into the media package. And finally the old one was left which
can be removed. The strange thing is that it is still running (bundle
is build).

Thanks
damencho

···

On Thu, Sep 9, 2010 at 10:14 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

Hi devs,

Why do we still have .impl.audionotifier in trunk given that it has been
functionally replaced by .impl.neomedia.notify? (Yana Stamcheva
initially alerted me to the two AudioNotifierService implementations.)
Is it OK to remove it?

Regards,
Lubomir

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Thank you, damencho!

Is it safe to remove the audionotifier bundle given that it has been
installed and started by current users? I'm asking just in case you have
previous experience; otherwise, I'll try to find the answer by testing
locally.

···

On Fri, 2010-09-10 at 09:10 +0300, Damian Minkov wrote:

And finally the old one was left which
can be removed. The strange thing is that it is still running (bundle
is build).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi,

I remember there was some issue with removing media service bundle but
I cannot remember the actual problem and its resolution.
Or it was maybe that it is in the cache and will continue starting,
which in current situation is not a problem, cause it is actually
starting without bringing any issues.

Regards
damencho

···

On Fri, Sep 10, 2010 at 9:55 AM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

On Fri, 2010-09-10 at 09:10 +0300, Damian Minkov wrote:

And finally the old one was left which
can be removed. The strange thing is that it is still running (bundle
is build).

Thank you, damencho!

Is it safe to remove the audionotifier bundle given that it has been
installed and started by current users? I'm asking just in case you have
previous experience; otherwise, I'll try to find the answer by testing
locally.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net