[sip-comm-dev] Hover-indistinguishable contacts with the same display name in the contact list


#1

I believe this was an issue a long time ago, then either I or someone
else fixed it and now it seems to be back: I have two Gmail contacts
in my SIP Communicator contact list who have one and the same display
name (well, they appear as a single contact in Google Contacts),
different e-mail addresses/Jabber IDs and appear next to each other in
the contact list. I hover on one of them and wait for the tooltip to
appear, then I move the mouse cursor to the other and the tooltip of
the first one stays, it doesn't change to display the information of
the newly-hovered one.

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Lubo,

Thanks for the report! Could you please log an issue and I'll try to have a look at it later today or tomorrow if someone else doesn't resolve it until then:)

Thanks!
Yana

···

On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:

I believe this was an issue a long time ago, then either I or someone
else fixed it and now it seems to be back: I have two Gmail contacts
in my SIP Communicator contact list who have one and the same display
name (well, they appear as a single contact in Google Contacts),
different e-mail addresses/Jabber IDs and appear next to each other in
the contact list. I hover on one of them and wait for the tooltip to
appear, then I move the mouse cursor to the other and the tooltip of
the first one stays, it doesn't change to display the information of
the newly-hovered one.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Thank you, Yana! I created issue #831
(https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
with the text of my initial e-mail. (I couldn't find an old issue to
reopen.)

···

On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:

I believe this was an issue a long time ago, then either I or someone
else fixed it and now it seems to be back: I have two Gmail contacts
in my SIP Communicator contact list who have one and the same display
name (well, they appear as a single contact in Google Contacts),
different e-mail addresses/Jabber IDs and appear next to each other in
the contact list. I hover on one of them and wait for the tooltip to
appear, then I move the mouse cursor to the other and the tooltip of
the first one stays, it doesn't change to display the information of
the newly-hovered one.

On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva <yana@sip-communicator.org> wrote:

Could you please log an issue and I'll try to have a look at it later today or tomorrow if someone else doesn't resolve it until then:)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hello,

Also there is an issue (NullPointerException) when display name is null. It
is possible for SIP protocol.
The problem is in the MetaContactImpl.compareTo method (in bold):

return ( (10 - isOnline) - (10 - targetIsOnline)) * 100000000
            + *getDisplayName()*
.compareToIgnoreCase(target.getDisplayName())
            * 10000
            + getMetaUID().compareTo(target.getMetaUID());

Thanks, Grigorii

···

2010/6/24 Lubomir Marinov <lubo@sip-communicator.org>

> On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:
>> I believe this was an issue a long time ago, then either I or someone
>> else fixed it and now it seems to be back: I have two Gmail contacts
>> in my SIP Communicator contact list who have one and the same display
>> name (well, they appear as a single contact in Google Contacts),
>> different e-mail addresses/Jabber IDs and appear next to each other in
>> the contact list. I hover on one of them and wait for the tooltip to
>> appear, then I move the mouse cursor to the other and the tooltip of
>> the first one stays, it doesn't change to display the information of
>> the newly-hovered one.

On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva > <yana@sip-communicator.org> wrote:
> Could you please log an issue and I'll try to have a look at it later
today or tomorrow if someone else doesn't resolve it until then:)

Thank you, Yana! I created issue #831
(https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
with the text of my initial e-mail. (I couldn't find an old issue to
reopen.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Grigorii,

Excuse me if I'm missing something, but can we just return the contact address if we cannot obtain a display name for the SIP protocol ? I mean, all over the user interface we really expect that we have a display name and I think it would be easier (if possible of course) to fix this problem in the protocol. WDYT?

Cheers,
Yana

···

On Jun 24, 2010, at 11:13 AM, Grigorii Balutsel wrote:

Hello,

Also there is an issue (NullPointerException) when display name is null. It is possible for SIP protocol.
The problem is in the MetaContactImpl.compareTo method (in bold):

return ( (10 - isOnline) - (10 - targetIsOnline)) * 100000000
            + getDisplayName().compareToIgnoreCase(target.getDisplayName())
            * 10000
            + getMetaUID().compareTo(target.getMetaUID());

Thanks, Grigorii

2010/6/24 Lubomir Marinov <lubo@sip-communicator.org>
> On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:
>> I believe this was an issue a long time ago, then either I or someone
>> else fixed it and now it seems to be back: I have two Gmail contacts
>> in my SIP Communicator contact list who have one and the same display
>> name (well, they appear as a single contact in Google Contacts),
>> different e-mail addresses/Jabber IDs and appear next to each other in
>> the contact list. I hover on one of them and wait for the tooltip to
>> appear, then I move the mouse cursor to the other and the tooltip of
>> the first one stays, it doesn't change to display the information of
>> the newly-hovered one.

On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva > <yana@sip-communicator.org> wrote:
> Could you please log an issue and I'll try to have a look at it later today or tomorrow if someone else doesn't resolve it until then:)

Thank you, Yana! I created issue #831
(https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
with the text of my initial e-mail. (I couldn't find an old issue to
reopen.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Yana,

Yes it is possible moreover I've already use it. I've just written about it
because if user has null displayName on the UI it shows as "Unknown User" so
I thought that that it is possible to have users with empty display name.

Thanks, Grigorii

···

2010/6/24 Yana Stamcheva <yana@sip-communicator.org>

Hi Grigorii,

Excuse me if I'm missing something, but can we just return the contact
address if we cannot obtain a display name for the SIP protocol ? I mean,
all over the user interface we really expect that we have a display name and
I think it would be easier (if possible of course) to fix this problem in
the protocol. WDYT?

Cheers,
Yana

On Jun 24, 2010, at 11:13 AM, Grigorii Balutsel wrote:

> Hello,
>
> Also there is an issue (NullPointerException) when display name is null.
It is possible for SIP protocol.
> The problem is in the MetaContactImpl.compareTo method (in bold):
>
> return ( (10 - isOnline) - (10 - targetIsOnline)) * 100000000
> +
getDisplayName().compareToIgnoreCase(target.getDisplayName())
> * 10000
> + getMetaUID().compareTo(target.getMetaUID());
>
> Thanks, Grigorii
>
> 2010/6/24 Lubomir Marinov <lubo@sip-communicator.org>
> > On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:
> >> I believe this was an issue a long time ago, then either I or someone
> >> else fixed it and now it seems to be back: I have two Gmail contacts
> >> in my SIP Communicator contact list who have one and the same display
> >> name (well, they appear as a single contact in Google Contacts),
> >> different e-mail addresses/Jabber IDs and appear next to each other in
> >> the contact list. I hover on one of them and wait for the tooltip to
> >> appear, then I move the mouse cursor to the other and the tooltip of
> >> the first one stays, it doesn't change to display the information of
> >> the newly-hovered one.
>
> On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva > > <yana@sip-communicator.org> wrote:
> > Could you please log an issue and I'll try to have a look at it later
today or tomorrow if someone else doesn't resolve it until then:)
>
> Thank you, Yana! I created issue #831
> (https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
> with the text of my initial e-mail. (I couldn't find an old issue to
> reopen.)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi Grigorii,

Hi Yana,

Yes it is possible moreover I've already use it. I've just written about it because if user has null displayName on the UI it shows as "Unknown User" so I thought that that it is possible to have users with empty display name.

Sorry, but I'm not sure to understand. What is the exact situation, in which you experience the null display name ? As I see in the MetaContactListServiceImpl the meta contact display name comes from the contained contact display name, which is set in the protocol implementation and for SIP, for example, I see that if the display name is null we set the address (which is always non null I think):

displayName = contactAddress.getDisplayName();

        if(displayName == null || displayName.trim().length() == 0)
            displayName = getAddress();

Could you please explain what bothers you in this scheme?

Cheers,
Yana

···

On Jun 24, 2010, at 12:09 PM, Grigorii Balutsel wrote:

Thanks, Grigorii

2010/6/24 Yana Stamcheva <yana@sip-communicator.org>
Hi Grigorii,

Excuse me if I'm missing something, but can we just return the contact address if we cannot obtain a display name for the SIP protocol ? I mean, all over the user interface we really expect that we have a display name and I think it would be easier (if possible of course) to fix this problem in the protocol. WDYT?

Cheers,
Yana

On Jun 24, 2010, at 11:13 AM, Grigorii Balutsel wrote:

> Hello,
>
> Also there is an issue (NullPointerException) when display name is null. It is possible for SIP protocol.
> The problem is in the MetaContactImpl.compareTo method (in bold):
>
> return ( (10 - isOnline) - (10 - targetIsOnline)) * 100000000
> + getDisplayName().compareToIgnoreCase(target.getDisplayName())
> * 10000
> + getMetaUID().compareTo(target.getMetaUID());
>
> Thanks, Grigorii
>
> 2010/6/24 Lubomir Marinov <lubo@sip-communicator.org>
> > On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:
> >> I believe this was an issue a long time ago, then either I or someone
> >> else fixed it and now it seems to be back: I have two Gmail contacts
> >> in my SIP Communicator contact list who have one and the same display
> >> name (well, they appear as a single contact in Google Contacts),
> >> different e-mail addresses/Jabber IDs and appear next to each other in
> >> the contact list. I hover on one of them and wait for the tooltip to
> >> appear, then I move the mouse cursor to the other and the tooltip of
> >> the first one stays, it doesn't change to display the information of
> >> the newly-hovered one.
>
> On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva > > <yana@sip-communicator.org> wrote:
> > Could you please log an issue and I'll try to have a look at it later today or tomorrow if someone else doesn't resolve it until then:)
>
> Thank you, Yana! I created issue #831
> (https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
> with the text of my initial e-mail. (I couldn't find an old issue to
> reopen.)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hey Yana, Grigorii,

I guess one thing we could do here is add a note in the
Contact.getDisplayName() method that clearly states that the method MUST
NOT return null.

Cheers,
Emil

На 24.06.10 11:33, Yana Stamcheva написа:

···

Hi Grigorii,

On Jun 24, 2010, at 12:09 PM, Grigorii Balutsel wrote:

Hi Yana,

Yes it is possible moreover I've already use it. I've just written about it because if user has null displayName on the UI it shows as "Unknown User" so I thought that that it is possible to have users with empty display name.

Sorry, but I'm not sure to understand. What is the exact situation, in which you experience the null display name ? As I see in the MetaContactListServiceImpl the meta contact display name comes from the contained contact display name, which is set in the protocol implementation and for SIP, for example, I see that if the display name is null we set the address (which is always non null I think):

displayName = contactAddress.getDisplayName();

        if(displayName == null || displayName.trim().length() == 0)
            displayName = getAddress();

Could you please explain what bothers you in this scheme?

Cheers,
Yana

Thanks, Grigorii

2010/6/24 Yana Stamcheva <yana@sip-communicator.org>
Hi Grigorii,

Excuse me if I'm missing something, but can we just return the contact address if we cannot obtain a display name for the SIP protocol ? I mean, all over the user interface we really expect that we have a display name and I think it would be easier (if possible of course) to fix this problem in the protocol. WDYT?

Cheers,
Yana

On Jun 24, 2010, at 11:13 AM, Grigorii Balutsel wrote:

Hello,

Also there is an issue (NullPointerException) when display name is null. It is possible for SIP protocol.
The problem is in the MetaContactImpl.compareTo method (in bold):

return ( (10 - isOnline) - (10 - targetIsOnline)) * 100000000
            + getDisplayName().compareToIgnoreCase(target.getDisplayName())
            * 10000
            + getMetaUID().compareTo(target.getMetaUID());

Thanks, Grigorii

2010/6/24 Lubomir Marinov <lubo@sip-communicator.org>

On Jun 24, 2010, at 9:37 AM, Lubomir Marinov wrote:

I believe this was an issue a long time ago, then either I or someone
else fixed it and now it seems to be back: I have two Gmail contacts
in my SIP Communicator contact list who have one and the same display
name (well, they appear as a single contact in Google Contacts),
different e-mail addresses/Jabber IDs and appear next to each other in
the contact list. I hover on one of them and wait for the tooltip to
appear, then I move the mouse cursor to the other and the tooltip of
the first one stays, it doesn't change to display the information of
the newly-hovered one.

On Thu, Jun 24, 2010 at 10:13 AM, Yana Stamcheva >>> <yana@sip-communicator.org> wrote:

Could you please log an issue and I'll try to have a look at it later today or tomorrow if someone else doesn't resolve it until then:)

Thank you, Yana! I created issue #831
(https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=831)
with the text of my initial e-mail. (I couldn't find an old issue to
reopen.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net