[sip-comm-dev] GSoC introduction


#1

Hello everybody,

My name is Anthony Schmitt and I live in France. I'm glad to participate in
this open source project and in GSoC!

I have also subscribed in the dev mailing list and I'm interested in the
project in java.net. My username is: *4nth0ny* (with a zero).

I have created a blog: http://gsoc08-e4.blogspot.com/ and it will be
updating the most often I can.

I think this project will be very interesting and enriching. I hope improve
my skills in programming and my English.

I wish good luck to all participants.

Cheers,

Anthony Schmitt.


#2

Hi all,

I'm Sébastien Mazy, also a French student, from Lyon. This is my first
participation at GSoC.

I'll work on the LDAP support project :
http://www.sip-communicator.org/index.php/Development/LDAP. Actually,
I already started coding a sample LDAP connexion dialog during the
application process that can be found here :
http://mazy.fr/gsoc2008/20080418.patch. I'll put next updates on a
java.net project svn.

I'll post progress news on this ML and there : http://mazy.fr/blog/
(just setup, empty for the moment)
My java.net id :smazy

I wish good luck to all participants.

Thanks. With the 15 projects, we will be able to achieve noticeable
improvements for SIP communicator's users.

@Fellow GSoCers: maybe we should keep introductions in one thread, to
avoid flooding that ML like google-summer-of-code-students-list :wink:

Cheers,

Sébastien

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Anthony.
I am very glad to see you here and reading a bit about yourself. As
you probably have already figured out, I am your mentor.
Maybe a lot of the other mentors will know you in person as you are a
student at the university in Strasbourg. However, I am working at the
University of Tartu in Estonia, so we have some thousands of
kilometers between us and need to rely a lot on digital communication.

I think it would be nice if you would compile a little of your efforts
on the google web app together and put it on your blog, so others also
know, what you do and will do in the near future related to your file
transfer project.

Anyway, at first a warm welcome from my side.

If you want to know more about me or need to find my contact
information, also i.m. contact, feel free to browse my page at
http://ulno.net

Best,
Uli

···

On Wed, Apr 23, 2008 at 4:04 PM, Anthony Schmitt <anthony.schmittt@gmail.com> wrote:

Hello everybody,

My name is Anthony Schmitt and I live in France. I'm glad to participate in
this open source project and in GSoC!

I have also subscribed in the dev mailing list and I'm interested in the
project in java.net. My username is: 4nth0ny (with a zero).

I have created a blog: http://gsoc08-e4.blogspot.com/ and it will be
updating the most often I can.

I think this project will be very interesting and enriching. I hope improve
my skills in programming and my English.

I wish good luck to all participants.

Cheers,

Anthony Schmitt.

--
title+name: Dr. Ulrich Norbisrath
web: http://ulno.net; address+phone+fax: http://ulno.net/contact
google:unorbisrath@gmail.com; icq:46786247
mailto:u@ulno.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi S�bastien,

Thank you for this introduction.

As promised on Jabber I have made this following short (short, because I have focused on general points) review of your patch (version 20080418 for svn release 3583). First even if a lot a things have to be done, I want to give you my congratulations for all the work already done :slight_smile:

Here are the comments :
1) It is a very good point that your whole code use 4 spaces and no tabs.
2) The most part of your code is well documented, but some are not (for functions or/and the parameters and/or return). I pretty sure that you are already convinced that a good code begin with a good documentation :slight_smile: . I have pick up the following ones:
* src/net/java/sip/communicator/plugin/ldaptools/LdapConfigDialog.java
  - public void itemStateChanged(ItemEvent e)
  - public void actionPerformed(ActionEvent e)
* src/net/java/sip/communicator/plugin/ldaptools/LdapToolsComponent.java
  - public LdapToolsComponent()
  - public void actionPerformed(ActionEvent e)
  - public Object getComponent()
  - public String getConstraints()
  - public Container getContainer()
  - public String getName()
  - public void setCurrentContact(MetaContact metaContact)
  - public void setCurrentContactGroup(MetaContactGroup metaGroup)
* src/net/java/sip/communicator/impl/ldap/LdapEventManager.java
  - protected void fireLdapStateChanged(LdapService source, int previousState, int newState)
  - protected void fireLdapStateChanged(LdapService source, int previousState, int newState, int error)
* src/net/java/sip/communicator/impl/ldap/LdapServiceImpl.java
  - private void setEnv(String hostname, String port, String baseDN, int method, String bindDN, char[] password) throws RuntimeException
  - public void connect(String host, String port, String baseDN, int method, String bindDN, char[] password) throws RuntimeException
  - public int getConnectionStatus() throws RuntimeException
  - public void stop(BundleContext bundleContext)
3) I think that you have forgotten to include all your files (i.e the file containing the class LdapConstants) into your patch. This is maybe cause due to some missing "svn add". To correct this check the "?" when doing a "svn status".

I will end my first review for ldap here. Once all these points are corrected, we can start pointing specific implementation points :wink: Once again I want to point that your code is clear and readable.

Cheers,
Vincent

S�bastien Mazy wrote:

···

Hi all,

I'm S�bastien Mazy, also a French student, from Lyon. This is my first
participation at GSoC.

I'll work on the LDAP support project :
http://www.sip-communicator.org/index.php/Development/LDAP. Actually,
I already started coding a sample LDAP connexion dialog during the
application process that can be found here :
http://mazy.fr/gsoc2008/20080418.patch. I'll put next updates on a
java.net project svn.

I'll post progress news on this ML and there : http://mazy.fr/blog/
(just setup, empty for the moment)
My java.net id :smazy

I wish good luck to all participants.

Thanks. With the 15 projects, we will be able to achieve noticeable
improvements for SIP communicator's users.

@Fellow GSoCers: maybe we should keep introductions in one thread, to
avoid flooding that ML like google-summer-of-code-students-list :wink:

Cheers,

S�bastien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Vincent,

2) The most part of your code is well documented, but some are not (for
functions or/and the parameters and/or return). I pretty sure that you are
already convinced that a good code begin with a good documentation :slight_smile: .

Thanks for your review. I'll take care of that. By the way, the
existing documentation helped me a lot to get started.

3) I think that you have forgotten to include all your files (i.e the file
containing the class LdapConstants) into your patch. This is maybe cause due
to some missing "svn add". To correct this check the "?" when doing a "svn
status".

Sorry, I forgot this file.

Concerning future revisions, I was thinking about publishing them in a
public git repository. That way I would be able to keep my code in
sync with sip-communicator changes.

Cheers,

···

On Thu, May 15, 2008 at 3:27 PM, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

--
Sébastien Mazy

GPG 07F20C6A (pgp.mit.edu)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net