[sip-comm-dev] [GS0C 09] Update Avatar-Progress


#1

Hi all,
         Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

···

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org


#2

Hi Shashank,

I have a couple quick suggestions and comments after looking at your
screenshot (Nice work BTW).

*Where to write names for the sliders used?

For the horizontal slider (which I'm guessing is the brightness?), it
would make sense to put an identifying label at the left end of the
slider. I'm not sure what to suggest for the vertical one. Perhaps try
using a tooltip?

*Should I go for contrast also?

Brightness and contrast settings are often paired with each other, so
if you want to be really complete, my personal opinion would be yes.

Also, you may want to try applying the setOpaque(false) property to
the sliders so that they will blend into our blue background better,
instead of having that grey box behind them.

-Alan

···

On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:

Hi all,
         Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey folks,

First of all, Shashank, thanks for your update! I like the way this
project is moving forward, so keep up the good work!

I was wondering however whether we'd really want to have things like
brightness and contrast in there. I am really not sure about this so
please chime in in case you have a personal preference. Yet they kind of
complicate the interface and I am not sure that there are many among us
who have felt the need to actually change them on images they upload online.

Again, this is only a personal thought so I'd love to hear other opinions.

Cheers
Emil

Alan Kelly wrote:

···

Hi Shashank,

I have a couple quick suggestions and comments after looking at your
screenshot (Nice work BTW).

*Where to write names for the sliders used?

For the horizontal slider (which I'm guessing is the brightness?), it
would make sense to put an identifying label at the left end of the
slider. I'm not sure what to suggest for the vertical one. Perhaps try
using a tooltip?

*Should I go for contrast also?

Brightness and contrast settings are often paired with each other, so
if you want to be really complete, my personal opinion would be yes.

Also, you may want to try applying the setOpaque(false) property to
the sliders so that they will blend into our blue background better,
instead of having that grey box behind them.

-Alan

On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:

Hi all,
         Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi,

I have a couple quick suggestions and comments after looking at your
screenshot (Nice work BTW).

thanks

*Where to write names for the sliders used?

For the horizontal slider (which I'm guessing is the brightness?), it
would make sense to put an identifying label at the left end of the
slider. I'm not sure what to suggest for the vertical one. Perhaps try
using a tooltip?

tooltip sounds nice. will try that. and horizontal one is for cropping

*Should I go for contrast also?

Brightness and contrast settings are often paired with each other, so
if you want to be really complete, my personal opinion would be yes.

will do that

Also, you may want to try applying the setOpaque(false) property to
the sliders so that they will blend into our blue background better,
instead of having that grey box behind them.

-Alan

Hi all,
         Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

···

On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Shashank,

It looks very nice! By the way, did you already commit your changes to the branch? I tried to run it from source in order to try the edit tool, but didn't find the edit button (tried also double click on image, but it didn't work) :frowning:

Otherwise I like the "text links"! Just one small advice here, you can make them underlined and blue all the time, not only on mouse over. This way it would be clearer for the user that these are active links, not only labels. I thought also it could be a good idea to align the "browse for new" link to "clear all", which should make the form tidier.

I also agree with others that brightness and contrast would just complicate the user experience and we could keep this feature aside for now.

Something else I've noticed is that my images are never saved in "recently used" and as I see on your screenshot this should be working, have you an idea what could be the problem?

Cheers,
Yana

Otherwise I agree with others that the contrast is not

···

On Jul 27, 2009, at 3:14 PM, Shashank Tyagi wrote:

Hi all,
         Have added functions to allow users to edit the selected image. Only cropping and brightness for now. Few thing in which I can use some suggestions:
*Where to write names for the sliders used? Mean which slider for cropping and which is for brightness. Have skipIped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed cursor) but still its not looking that attractive. When I used buttons it filled the whole space so used text links. Any other suggestion which I could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

<printscrn.jpg>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi guys,

To answer Emil's call for opinions, I personally find the brightness
and contrast controls too complicated for the case of changing my
avatar. (Well, I also find the vertical resizing slider too unclear
and complicated in comparison to the way Gmail allows me to set my
adatar... but I guess I'm in the minority here.)

Anyway, my opinion is not necessarily an example of common perception
so I'm interested in how this feature is implemented in popular
instant messaging and telephony clients. Shashank, do you have such a
comparison on file to share with us?

Best regards,
Lubomir

···

On Mon, Jul 27, 2009 at 8:16 PM, Emil Ivov<emcho@sip-communicator.org> wrote:

Hey folks,

First of all, Shashank, thanks for your update! I like the way this
project is moving forward, so keep up the good work!

I was wondering however whether we'd really want to have things like
brightness and contrast in there. I am really not sure about this so
please chime in in case you have a personal preference. Yet they kind of
complicate the interface and I am not sure that there are many among us
who have felt the need to actually change them on images they upload online.

Again, this is only a personal thought so I'd love to hear other opinions.

Cheers
Emil

Alan Kelly wrote:

Hi Shashank,

I have a couple quick suggestions and comments after looking at your
screenshot (Nice work BTW).

*Where to write names for the sliders used?

For the horizontal slider (which I'm guessing is the brightness?), it
would make sense to put an identifying label at the left end of the
slider. I'm not sure what to suggest for the vertical one. Perhaps try
using a tooltip?

*Should I go for contrast also?

Brightness and contrast settings are often paired with each other, so
if you want to be really complete, my personal opinion would be yes.

Also, you may want to try applying the setOpaque(false) property to
the sliders so that they will blend into our blue background better,
instead of having that grey box behind them.

-Alan

On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:

Hi all,
Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi,
   My personal opinion is that cropping is a must but can live without
brightness and contrast. For this even I will wait for others opinion before
moving forward on this part. Adding contrast wont be much of a problem as
its very similar to brightness implementation except for changing the
kernel.

I am moving forward with webcam implementation (which is a major part).

Also some views on how to give links on the main select image panel?

···

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Mon, Jul 27, 2009 at 10:46 PM, Emil Ivov <emcho@sip-communicator.org>wrote:

Hey folks,

First of all, Shashank, thanks for your update! I like the way this
project is moving forward, so keep up the good work!

I was wondering however whether we'd really want to have things like
brightness and contrast in there. I am really not sure about this so
please chime in in case you have a personal preference. Yet they kind of
complicate the interface and I am not sure that there are many among us
who have felt the need to actually change them on images they upload
online.

Again, this is only a personal thought so I'd love to hear other opinions.

Cheers
Emil

Alan Kelly wrote:
> Hi Shashank,
>
> I have a couple quick suggestions and comments after looking at your
> screenshot (Nice work BTW).
>
>> *Where to write names for the sliders used?
>
> For the horizontal slider (which I'm guessing is the brightness?), it
> would make sense to put an identifying label at the left end of the
> slider. I'm not sure what to suggest for the vertical one. Perhaps try
> using a tooltip?
>
>> *Should I go for contrast also?
>
> Brightness and contrast settings are often paired with each other, so
> if you want to be really complete, my personal opinion would be yes.
>
> Also, you may want to try applying the setOpaque(false) property to
> the sliders so that they will blend into our blue background better,
> instead of having that grey box behind them.
>
> -Alan
>
> On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:
>> Hi all,
>> Have added functions to allow users to edit the selected image.
>> Only cropping and brightness for now. Few thing in which I can use some
>> suggestions:
>> *Where to write names for the sliders used? Mean which slider for
cropping
>> and which is for brightness. Have skipped it for now.
>> *Should I go for contrast also?
>> *In the main image select panel have used text links (have also changed
>> cursor) but still its not looking that attractive. When I used buttons
it
>> filled the whole space so used text links. Any other suggestion which I
>> could try? Also what should be the text in the links?
>>
>> Any implementation changes in code are also welcome.
>>
>> Have attached the printscreen for edit image panel.
>>
>>
https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars
>>
>> -----
>> Shashank Tyagi,
>> Computer Science(IDD),
>> Part IV,
>> Institute of Technology,
>> Banaras Hindu University,
>> India.
>> +91-9651422932
>> +91-9235600751
>> shashank.tyagi.cse06@itbhu.ac.in
>> shashankt@acm.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi,

First of all sorry had forgotten to commit. Was a little tired yesterday!
Now committed.

@Alan: the feature of having dragging controls in the crop frma would have
been good but I was finding it a little hard to implement. So for now I will
skip that.

@Romain: Having a image to zoom and slide will also have the limitation of
square cropping which the current implementation has.

I was thinking that with no one exactly wanting brightness can we have two
sliders for cropping? X direction and Y direction? A little complicated but
much more control over cropping.

@Yana: I was initially planning to align browse and webcam in one line but
they turned out to be long links. Will align browse and clear now. For the
previous pictures I have still now used FileAccessService so not working
unless you manually create a folder. It will be recitified obviously. Tried
by having the links as blue color always but was looking a little odd. will
make changes for review though.

···

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Tue, Jul 28, 2009 at 4:26 AM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Hi Shashank,

It looks very nice! By the way, did you already commit your changes to the
branch? I tried to run it from source in order to try the edit tool, but
didn't find the edit button (tried also double click on image, but it didn't
work) :frowning:

Otherwise I like the "text links"! Just one small advice here, you can make
them underlined and blue all the time, not only on mouse over. This way it
would be clearer for the user that these are active links, not only labels.
I thought also it could be a good idea to align the "browse for new" link to
"clear all", which should make the form tidier.

I also agree with others that brightness and contrast would just complicate
the user experience and we could keep this feature aside for now.

Something else I've noticed is that my images are never saved in "recently
used" and as I see on your screenshot this should be working, have you an
idea what could be the problem?

Cheers,
Yana

Otherwise I agree with others that the contrast is not
On Jul 27, 2009, at 3:14 PM, Shashank Tyagi wrote:

Hi all,

        Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipIped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

<printscrn.jpg>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi guys,

The brightness and contrast controls, while a nice feature, aren't a
feature I'm personally ever likely to use. Since we don't want to
over-complicate things, and it's not a feature I've ever seen in
another IM client, I'm not sure how necessary/useful they actually
are.

I do think the cropping tool is a good idea. However, I'm having
trouble picturing how a slider would be used as a control for the
cropping feature. It's good for an initial implementation, but in the
future would there be a way we could use a more standardized control
for this? Perhaps a control that allows the user to draw a box over
the desired part of the image, or to drag re-sizing handles attached
to each side or corner of the image (a la Facebook)? While this would
be more challenging to implement, I think that would give us a more
intuitive UI.

-Alan

···

On 7/27/09, shashank <aug21st@gmail.com> wrote:

Hi,
   My personal opinion is that cropping is a must but can live without
brightness and contrast. For this even I will wait for others opinion before
moving forward on this part. Adding contrast wont be much of a problem as
its very similar to brightness implementation except for changing the
kernel.

I am moving forward with webcam implementation (which is a major part).

Also some views on how to give links on the main select image panel?

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Mon, Jul 27, 2009 at 10:46 PM, Emil Ivov > <emcho@sip-communicator.org>wrote:

Hey folks,

First of all, Shashank, thanks for your update! I like the way this
project is moving forward, so keep up the good work!

I was wondering however whether we'd really want to have things like
brightness and contrast in there. I am really not sure about this so
please chime in in case you have a personal preference. Yet they kind of
complicate the interface and I am not sure that there are many among us
who have felt the need to actually change them on images they upload
online.

Again, this is only a personal thought so I'd love to hear other opinions.

Cheers
Emil

Alan Kelly wrote:
> Hi Shashank,
>
> I have a couple quick suggestions and comments after looking at your
> screenshot (Nice work BTW).
>
>> *Where to write names for the sliders used?
>
> For the horizontal slider (which I'm guessing is the brightness?), it
> would make sense to put an identifying label at the left end of the
> slider. I'm not sure what to suggest for the vertical one. Perhaps try
> using a tooltip?
>
>> *Should I go for contrast also?
>
> Brightness and contrast settings are often paired with each other, so
> if you want to be really complete, my personal opinion would be yes.
>
> Also, you may want to try applying the setOpaque(false) property to
> the sliders so that they will blend into our blue background better,
> instead of having that grey box behind them.
>
> -Alan
>
> On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:
>> Hi all,
>> Have added functions to allow users to edit the selected
>> image.
>> Only cropping and brightness for now. Few thing in which I can use some
>> suggestions:
>> *Where to write names for the sliders used? Mean which slider for
cropping
>> and which is for brightness. Have skipped it for now.
>> *Should I go for contrast also?
>> *In the main image select panel have used text links (have also changed
>> cursor) but still its not looking that attractive. When I used buttons
it
>> filled the whole space so used text links. Any other suggestion which I
>> could try? Also what should be the text in the links?
>>
>> Any implementation changes in code are also welcome.
>>
>> Have attached the printscreen for edit image panel.
>>
>>
https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars
>>
>> -----
>> Shashank Tyagi,
>> Computer Science(IDD),
>> Part IV,
>> Institute of Technology,
>> Banaras Hindu University,
>> India.
>> +91-9651422932
>> +91-9235600751
>> shashank.tyagi.cse06@itbhu.ac.in
>> shashankt@acm.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi,

I would not use features such as brightness and contrast, however resizing the picture is a nice feature. It could be done with a slider to zoom in the picture, and with the possibility to move the picture (using the mouse) in the frame in order to select the desired area (pretty much as it is done in the MacOSX address book).

Cheers,
romain

···

On 2009/07/27, at 19:32, Lubomir Marinov wrote:

Hi guys,

To answer Emil's call for opinions, I personally find the brightness
and contrast controls too complicated for the case of changing my
avatar. (Well, I also find the vertical resizing slider too unclear
and complicated in comparison to the way Gmail allows me to set my
adatar... but I guess I'm in the minority here.)

Anyway, my opinion is not necessarily an example of common perception
so I'm interested in how this feature is implemented in popular
instant messaging and telephony clients. Shashank, do you have such a
comparison on file to share with us?

Best regards,
Lubomir

On Mon, Jul 27, 2009 at 8:16 PM, Emil Ivov<emcho@sip- > communicator.org> wrote:

Hey folks,

First of all, Shashank, thanks for your update! I like the way this
project is moving forward, so keep up the good work!

I was wondering however whether we'd really want to have things like
brightness and contrast in there. I am really not sure about this so
please chime in in case you have a personal preference. Yet they kind of
complicate the interface and I am not sure that there are many among us
who have felt the need to actually change them on images they upload online.

Again, this is only a personal thought so I'd love to hear other opinions.

Cheers
Emil

Alan Kelly wrote:

Hi Shashank,

I have a couple quick suggestions and comments after looking at your
screenshot (Nice work BTW).

*Where to write names for the sliders used?

For the horizontal slider (which I'm guessing is the brightness?), it
would make sense to put an identifying label at the left end of the
slider. I'm not sure what to suggest for the vertical one. Perhaps try
using a tooltip?

*Should I go for contrast also?

Brightness and contrast settings are often paired with each other, so
if you want to be really complete, my personal opinion would be yes.

Also, you may want to try applying the setOpaque(false) property to
the sliders so that they will blend into our blue background better,
instead of having that grey box behind them.

-Alan

On 7/27/09, Shashank Tyagi <shashank.tyagi.cse06@itbhu.ac.in> wrote:

Hi all,
         Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for cropping
and which is for brightness. Have skipped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi Shashank,

First of all sorry had forgotten to commit. Was a little tired yesterday! Now committed.

@Alan: the feature of having dragging controls in the crop frma would have been good but I was finding it a little hard to implement. So for now I will skip that.

@Romain: Having a image to zoom and slide will also have the limitation of square cropping which the current implementation has.

I'm not sure I made myself clear, let me explain with a few screenshots below. If you zoom in the picture (picture 2) and you're able to move it in the frame (picture 3), it'll give the same effect as cropping.

Cheers,
romain

···

On 2009/07/28, at 4:14, shashank wrote:

I was thinking that with no one exactly wanting brightness can we have two sliders for cropping? X direction and Y direction? A little complicated but much more control over cropping.

@Yana: I was initially planning to align browse and webcam in one line but they turned out to be long links. Will align browse and clear now. For the previous pictures I have still now used FileAccessService so not working unless you manually create a folder. It will be recitified obviously. Tried by having the links as blue color always but was looking a little odd. will make changes for review though.

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Tue, Jul 28, 2009 at 4:26 AM, Yana Stamcheva <yana@sip-communicator.org > > wrote:
Hi Shashank,

It looks very nice! By the way, did you already commit your changes to the branch? I tried to run it from source in order to try the edit tool, but didn't find the edit button (tried also double click on image, but it didn't work) :frowning:

Otherwise I like the "text links"! Just one small advice here, you can make them underlined and blue all the time, not only on mouse over. This way it would be clearer for the user that these are active links, not only labels. I thought also it could be a good idea to align the "browse for new" link to "clear all", which should make the form tidier.

I also agree with others that brightness and contrast would just complicate the user experience and we could keep this feature aside for now.

Something else I've noticed is that my images are never saved in "recently used" and as I see on your screenshot this should be working, have you an idea what could be the problem?

Cheers,
Yana

Otherwise I agree with others that the contrast is not

On Jul 27, 2009, at 3:14 PM, Shashank Tyagi wrote:

Hi all,
        Have added functions to allow users to edit the selected image. Only cropping and brightness for now. Few thing in which I can use some suggestions:
*Where to write names for the sliders used? Mean which slider for cropping and which is for brightness. Have skipIped it for now.

*Should I go for contrast also?
*In the main image select panel have used text links (have also changed cursor) but still its not looking that attractive. When I used buttons it filled the whole space so used text links. Any other suggestion which I could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

<printscrn.jpg>---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hi Shashank,

Hi,

First of all sorry had forgotten to commit. Was a little tired yesterday! Now committed.

@Alan: the feature of having dragging controls in the crop frma would have been good but I was finding it a little hard to implement. So for now I will skip that.

@Romain: Having a image to zoom and slide will also have the limitation of square cropping which the current implementation has.

Having tried the apple's edit image tool by myself, I should say that there's one important advantage over our edit tool and it's that apple's tool allows to zoom the image to it's original size, while ours permits only to move the square over the already scaled image. This is how apple's crop slider works:

1. In the initial position - The slider is in the right left corner. The selection square is set to a fixed maximum size and the image is scaled, *by keeping the initial ratio*, in this square.
2. When we move the slider to the right - The square stays the same size and the image is zoomed until it reaches its initial size. Then the stays the same size and the square starts to diminish until it reaches its minimum fixed size.
3. At any moment we're able to move the image in order to center the desired object in the selection square.

There are two things that caught my attention in this behavior, when comparing it to the ours. First is that the initial image in the above algorithm keeps its ratio, while in ours it's scaled to fill the square.

The second thing is the zoom feature. Actually, because of this zoom feature they've decided to move the image and not the square itself. This way they're able to zoom, while not showing the full size picture, but just the part that is centered in the image area. Then you're able to move the image and adjust the object you desire in the selection square.

Actually I think that your implementation is quite similar to this one and just needs some little adjustments in order to become a very functional edit tool.

I was thinking that with no one exactly wanting brightness can we have two sliders for cropping? X direction and Y direction? A little complicated but much more control over cropping.

@Yana: I was initially planning to align browse and webcam in one line but they turned out to be long links. Will align browse and clear now. For the previous pictures I have still now used FileAccessService so not working unless you manually create a folder. It will be recitified obviously. Tried by having the links as blue color always but was looking a little odd. will make changes for review though.

I understand. For the links you should try to change the font size and make them smaller. I think that this could ameliorate the look.

Cheers,
Yana

···

On Jul 28, 2009, at 4:14 AM, shashank wrote:

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Tue, Jul 28, 2009 at 4:26 AM, Yana Stamcheva <yana@sip-communicator.org > > wrote:
Hi Shashank,

It looks very nice! By the way, did you already commit your changes to the branch? I tried to run it from source in order to try the edit tool, but didn't find the edit button (tried also double click on image, but it didn't work) :frowning:

Otherwise I like the "text links"! Just one small advice here, you can make them underlined and blue all the time, not only on mouse over. This way it would be clearer for the user that these are active links, not only labels. I thought also it could be a good idea to align the "browse for new" link to "clear all", which should make the form tidier.

I also agree with others that brightness and contrast would just complicate the user experience and we could keep this feature aside for now.

Something else I've noticed is that my images are never saved in "recently used" and as I see on your screenshot this should be working, have you an idea what could be the problem?

Cheers,
Yana

Otherwise I agree with others that the contrast is not

On Jul 27, 2009, at 3:14 PM, Shashank Tyagi wrote:

Hi all,
        Have added functions to allow users to edit the selected image. Only cropping and brightness for now. Few thing in which I can use some suggestions:
*Where to write names for the sliders used? Mean which slider for cropping and which is for brightness. Have skipIped it for now.

*Should I go for contrast also?
*In the main image select panel have used text links (have also changed cursor) but still its not looking that attractive. When I used buttons it filled the whole space so used text links. Any other suggestion which I could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

<printscrn.jpg>---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hi,

No I got your point. But it has the same limitation of having the crop frame
of fixed shape that is a square. So not much advantage in changing the
implementation. Best implementation obviously would be having a resiziable
recantangle which can be extended on all sides, but I am leaving that for
now as will require complicated mouse handling.

···

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

On Tue, Jul 28, 2009 at 1:03 PM, Romain KUNTZ <kuntz@lsiit.u-strasbg.fr>wrote:

Hi Shashank,

On 2009/07/28, at 4:14, shashank wrote:

First of all sorry had forgotten to commit. Was a little tired yesterday!
Now committed.

@Alan: the feature of having dragging controls in the crop frma would have
been good but I was finding it a little hard to implement. So for now I will
skip that.

@Romain: Having a image to zoom and slide will also have the limitation of
square cropping which the current implementation has.

I'm not sure I made myself clear, let me explain with a few screenshots
below. If you zoom in the picture (picture
2) and you're able to move it in the frame (picture
3), it'll give the same effect as cropping.

Cheers,
romain

I was thinking that with no one exactly wanting brightness can we have two
sliders for cropping? X direction and Y direction? A little complicated but
much more control over cropping.

@Yana: I was initially planning to align browse and webcam in one line but
they turned out to be long links. Will align browse and clear now. For the
previous pictures I have still now used FileAccessService so not working
unless you manually create a folder. It will be recitified obviously. Tried
by having the links as blue color always but was looking a little odd. will
make changes for review though.

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

Sent from Varanasi, UP, India

On Tue, Jul 28, 2009 at 4:26 AM, Yana Stamcheva <yana@sip-communicator.org > > wrote:

Hi Shashank,

It looks very nice! By the way, did you already commit your changes to the
branch? I tried to run it from source in order to try the edit tool, but
didn't find the edit button (tried also double click on image, but it didn't
work) :frowning:

Otherwise I like the "text links"! Just one small advice here, you can
make them underlined and blue all the time, not only on mouse over. This way
it would be clearer for the user that these are active links, not only
labels. I thought also it could be a good idea to align the "browse for new"
link to "clear all", which should make the form tidier.

I also agree with others that brightness and contrast would just
complicate the user experience and we could keep this feature aside for now.

Something else I've noticed is that my images are never saved in "recently
used" and as I see on your screenshot this should be working, have you an
idea what could be the problem?

Cheers,
Yana

Otherwise I agree with others that the contrast is not
On Jul 27, 2009, at 3:14 PM, Shashank Tyagi wrote:

Hi all,

        Have added functions to allow users to edit the selected image.
Only cropping and brightness for now. Few thing in which I can use some
suggestions:
*Where to write names for the sliders used? Mean which slider for
cropping and which is for brightness. Have skipIped it for now.
*Should I go for contrast also?
*In the main image select panel have used text links (have also changed
cursor) but still its not looking that attractive. When I used buttons it
filled the whole space so used text links. Any other suggestion which I
could try? Also what should be the text in the links?

Any implementation changes in code are also welcome.

Have attached the printscreen for edit image panel.

https://sip-communicator.dev.java.net/svn/sip-communicator/branches/gsoc09/myavatars

-----
Shashank Tyagi,
Computer Science(IDD),
Part IV,
Institute of Technology,
Banaras Hindu University,
India.
+91-9651422932
+91-9235600751
shashank.tyagi.cse06@itbhu.ac.in
shashankt@acm.org

<printscrn.jpg>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hi,

Hi,

No I got your point. But it has the same limitation of having the crop frame of fixed shape that is a square. So not much advantage in changing the implementation. Best implementation obviously would be having a resiziable recantangle which can be extended on all sides, but I am leaving that for now as will require complicated mouse handling.

What is wrong with square-shaped avatars? When I hear a word "avatar", I associate it with a square-shaped image because avatars everywhere are square-shaped :wink: I don't think that allowing rectangular avatars is a good idea because they would allow inconsistent shape among avatars, and that would look quite messy in the same window.

Cheers,
Egidijus

···

On 28 Jul 2009, at 09:49, shashank wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

Hi,

What is wrong with square-shaped avatars? When I hear a word "avatar", I
associate it with a square-shaped image because avatars everywhere are
square-shaped :wink: I don't think that allowing rectangular avatars is a good
idea because they would allow inconsistent shape among avatars, and that
would look quite messy in the same window.

I think either Yana or Emil mentioned it in an offline conversation
that the cropping slider was much easier to the user than the free
resizing the rectangle with the mouse when cropping from a large
picture. (I don't agree with the ease of the approach but anyway the
example is great.) It makes me think that if one is cropping from a
large picture, then they may not be able to crop a square piece of it.
For example, if it's a photo of a group of people with their faces
close to each other (say, a photo of friends at a party), a square
which captures the face may very well include parts of the face of
another person and it may be undesirable. It's of course a personal
opinion of mine and I'd vote for removing the square restraint.

Regards,
Lubomir

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net