[sip-comm-dev] Generic message filters


#1

Hi all,
we have now a first prototype for our friend-to-friend-computing plugin
(very pre-alpha, but you can have a look at f2f.ulno.net) for
sip-communicator.
As we use the communication-channels for exchanging information between
the f2f-clients a lot of encrypted messages will pop up in the normal
chat-windows of sip-communicator. This is really annoying.
Of course we can just hack the sip-communicator-code to honor the
f2f-plugin, but this is probably not the way to go.
Would it make sense to offer a filter-interface to listen to all
messages in fireMessageEvent(EventObject evt) and let only these
messages through which the filter allows?
Or is there any other clean way to hook into the event-chain?
We are also willing to do these changes in my group, but we would like
to find a community-compliant solution.

Cheers,
Ulrich

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi!
I just finished my work on the about-dialog and I'm running through the
check-in procedure. I encountered following error on the cc-build:

I think, that the build (tests) is already broken, isn't it?

Cheers, THomas

     [java] 13:27:25.794 INFO: impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] ERROR: EventDispatcher: Error during dispatch.
(java.lang.NullPointerException)
     [java] java.lang.NullPointerException
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createProtoCont
actGroupNode(MclStorageManager.java:963)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createMetaConta
ctGroupNode(MclStorageManager.java:1051)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.metaContactGrou
pModified(MclStorageManager.java:1466)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.fireMe
taContactGroupEvent(MetaContactListServiceImpl.java:2680)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.remove
ContactGroupFromMetaContactGroup(MetaContactListServiceImpl.java:1162)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.handle
ProviderRemoved(MetaContactListServiceImpl.java:1563)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.servic
eChanged(MetaContactListServiceImpl.java:1815)
     [java] at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallbac
k(EventDispatcher.java:765)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDi
spatcher.java:623)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispat
cher.java:554)
     [java] at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:3525)
     [java] at
org.apache.felix.framework.Felix.access$000(Felix.java:36)
     [java] at
org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:593)
     [java] at
org.apache.felix.framework.ServiceRegistry.fireServiceChanged(ServiceRegistr
y.java:435)
     [java] at
org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceRegistry
.java:86)
     [java] at
org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRegistr
ationImpl.java:99)
     [java] at
net.java.sip.communicator.impl.protocol.rss.ProtocolProviderFactoryRssImpl.u
ninstallAccount(ProtocolProviderFactoryRssImpl.java:206)
     [java] at
net.java.sip.communicator.slick.protocol.rss.TestAccountUninstallation.testU
ninstallAccount(TestAccountUninstallation.java:187)
     [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
     [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
     [java] at java.lang.reflect.Method.invoke(Method.java:597)
     [java] at junit.framework.TestCase.runTest(TestCase.java:154)
     [java] at junit.framework.TestCase.runBare(TestCase.java:127)
     [java] at junit.framework.TestResult$1.protect(TestResult.java:106)
     [java] at
junit.framework.TestResult.runProtected(TestResult.java:124)
     [java] at junit.framework.TestResult.run(TestResult.java:109)
     [java] at junit.framework.TestCase.run(TestCase.java:118)
     [java] at junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.java:
104)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.java:
94)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.run(ScTestRunner.java:56
)
     [java] at
net.java.sip.communicator.slick.runner.SipCommunicatorSlickRunner.start(SipC
ommunicatorSlickRunner.java:150)
     [java] at
org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.jav
     [java] at
org.apache.felix.framework.Felix._startBundle(Felix.java:1536)
     [java] at
org.apache.felix.framework.Felix.startBundle(Felix.java:1470)
     [java] at
org.apache.felix.framework.Felix.setFrameworkStartLevel(Felix.java:1065)
     [java] at
org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:258)
     [java] at java.lang.Thread.run(Thread.java:619)
     [java] 13:27:25.826 INFO: impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.935 INFO: impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().159
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().160

···

a:589)

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().161 We ran 200 tests and
encountered 107 errors and failures.
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().164

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().165
     [java] 13:27:25.935 INFO: impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.951 INFO:
impl.protocol.gibberish.GibberishActivator.stop().115 Gibberish protocol
implementation [STOPPED].
     [java] 13:27:25.951 FEINER:
impl.protocol.sip.ProtocolProviderFactorySipImpl.stop().269 Preparing to
stop all SIP protocol providers.
     [java] 13:27:25.951 INFO:
impl.netaddr.NetworkAddressManagerServiceImpl.stop().102 Network Address
Manager Service ...[STOPPED]
     [java] 13:27:25.951 INFO:
impl.configuration.ConfigurationServiceImpl.stop().60 The
ConfigurationService stop method has been called.
     [java] Java Result: -1
     [echo] Generating HTML test reports ...
     [echo] Done.
     [echo] Test results available in ./test-reports/html/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hmm, strange. It seems on cruisecontrol, that there is everything ok.

···

-----Ursprüngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Donnerstag, 29. November 2007 13:43
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] tests broken?

Hi!
I just finished my work on the about-dialog and I'm running through the
check-in procedure. I encountered following error on the cc-build:

I think, that the build (tests) is already broken, isn't it?

Cheers, THomas

     [java] 13:27:25.794 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] ERROR: EventDispatcher: Error during dispatch.
(java.lang.NullPointerException)
     [java] java.lang.NullPointerException
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createProt
oCont
actGroupNode(MclStorageManager.java:963)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createMeta
Conta
ctGroupNode(MclStorageManager.java:1051)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.metaContac
tGrou
pModified(MclStorageManager.java:1466)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.f
ireMe
taContactGroupEvent(MetaContactListServiceImpl.java:2680)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.r
emove
ContactGroupFromMetaContactGroup(MetaContactListServiceImpl.java:1162)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.h
andle
ProviderRemoved(MetaContactListServiceImpl.java:1563)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.s
ervic
eChanged(MetaContactListServiceImpl.java:1815)
     [java] at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCa
llbac
k(EventDispatcher.java:765)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(Ev
entDi
spatcher.java:623)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventD
ispat
cher.java:554)
     [java] at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:3525)
     [java] at
org.apache.felix.framework.Felix.access$000(Felix.java:36)
     [java] at
org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:593)
     [java] at
org.apache.felix.framework.ServiceRegistry.fireServiceChanged(ServiceRe
gistr
y.java:435)
     [java] at
org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceReg
istry
..java:86)
     [java] at
org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRe
gistr
ationImpl.java:99)
     [java] at
net.java.sip.communicator.impl.protocol.rss.ProtocolProviderFactoryRssI
mpl.u
ninstallAccount(ProtocolProviderFactoryRssImpl.java:206)
     [java] at
net.java.sip.communicator.slick.protocol.rss.TestAccountUninstallation.
testU
ninstallAccount(TestAccountUninstallation.java:187)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
va:39
)
     [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
rImpl
..java:25)
     [java] at java.lang.reflect.Method.invoke(Method.java:597)
     [java] at
junit.framework.TestCase.runTest(TestCase.java:154)
     [java] at
junit.framework.TestCase.runBare(TestCase.java:127)
     [java] at
junit.framework.TestResult$1.protect(TestResult.java:106)
     [java] at
junit.framework.TestResult.runProtected(TestResult.java:124)
     [java] at
junit.framework.TestResult.run(TestResult.java:109)
     [java] at junit.framework.TestCase.run(TestCase.java:118)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
104)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
94)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.run(ScTestRunner.ja
va:56
)
     [java] at
net.java.sip.communicator.slick.runner.SipCommunicatorSlickRunner.start
(SipC
ommunicatorSlickRunner.java:150)
     [java] at
org.apache.felix.framework.util.SecureAction.startActivator(SecureActio
n.jav
a:589)
     [java] at
org.apache.felix.framework.Felix._startBundle(Felix.java:1536)
     [java] at
org.apache.felix.framework.Felix.startBundle(Felix.java:1470)
     [java] at
org.apache.felix.framework.Felix.setFrameworkStartLevel(Felix.java:1065
)
     [java] at
org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:258)
     [java] at java.lang.Thread.run(Thread.java:619)
     [java] 13:27:25.826 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().159
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().160

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().161 We ran 200 tests
and
encountered 107 errors and failures.
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().164

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().165
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.951 INFO:
impl.protocol.gibberish.GibberishActivator.stop().115 Gibberish
protocol
implementation [STOPPED].
     [java] 13:27:25.951 FEINER:
impl.protocol.sip.ProtocolProviderFactorySipImpl.stop().269 Preparing
to
stop all SIP protocol providers.
     [java] 13:27:25.951 INFO:
impl.netaddr.NetworkAddressManagerServiceImpl.stop().102 Network
Address
Manager Service ...[STOPPED]
     [java] 13:27:25.951 INFO:
impl.configuration.ConfigurationServiceImpl.stop().60 The
ConfigurationService stop method has been called.
     [java] Java Result: -1
     [echo] Generating HTML test reports ...
     [echo] Done.
     [echo] Test results available in ./test-reports/html/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi all,
this is the way how we 'cut off' messages that are sent between f2f-peers at the moment:
1)
Insert following line
   if (ee.ut.f2f.comm.sip.SipCommunicationProvider.isF2FMessage(evt)) return;
as first line into method
   private void fireMessageEvent(EventObject evt)
of classes that implement OperationSetBasicInstantMessaging interface and have that method.
(for classes that do not have this method, the line has to be inserted to some other place,
the idea is to cut off the f2f-message before it is sent to SC message listeners)
I did it in following classes:
   OperationSetBasicInstantMessagingIcqImpl,
   OperationSetBasicInstantMessagingJabberImpl,
   OperationSetBasicInstantMessagingMsnImpl,
   OperationSetBasicInstantMessagingSipImpl,
   OperationSetBasicInstantMessagingYahooImpl.

2)
Add the package ee.ut.f2f.comm.sip to be imported to the manifest file of those bundles that were changed.
I did it in following files:
   icq.provider.manifest.mf,
   jabber.provider.manifest.mf,
   msn.provider.manifest.mf,
   sip.provider.manifest.mf,
   yahoo.provider.manifest.mf.

3)
Change build.xml of SC project so that path compile.class.path includes F2F.jar.
I added following lines:
   <fileset dir="../F2F/build">
       <include name="F2F.jar"/>
   </fileset>

After completing these steps, we are able to run successfully 'make' target in SC build script, and changed bundles do not show f2f-messages in SC chat windows.

As you see, this approach is a hack and we would like to do it in a better way.

Best,
Keio Kraaner

···

----- Original Message -----

From: "Ulrich Norbisrath (sip-communicator)" <sipcom@ulno.net>

To: <dev@sip-communicator.dev.java.net>
Sent: Thursday, November 29, 2007 2:05 PM
Subject: [sip-comm-dev] Generic message filters

Hi all,
we have now a first prototype for our friend-to-friend-computing plugin
(very pre-alpha, but you can have a look at f2f.ulno.net) for
sip-communicator.
As we use the communication-channels for exchanging information between
the f2f-clients a lot of encrypted messages will pop up in the normal
chat-windows of sip-communicator. This is really annoying.
Of course we can just hack the sip-communicator-code to honor the
f2f-plugin, but this is probably not the way to go.
Would it make sense to offer a filter-interface to listen to all
messages in fireMessageEvent(EventObject evt) and let only these
messages through which the filter allows?
Or is there any other clean way to hook into the event-chain?
We are also willing to do these changes in my group, but we would like
to find a community-compliant solution.

Cheers,
Ulrich

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hello Thomas,

The tests are indeed OK, and I guess that there must have been a problem
with your own environment for them to fail this way (107 errors and
failures generally mean a problem with the test configuration).

However there seems to be another problem with the commit. It seems
impossible to open a chat window in the latest nightly build. When I try
to do so I get the following exception:

java.lang.IllegalArgumentException: The container that you specified is not supported by this UIService implementation.
        at net.java.sip.communicator.impl.gui.UIServiceImpl.getComponentsForContainer(UIServiceImpl.java:293)
        at net.java.sip.communicator.impl.gui.main.chat.menus.HelpMenu.initPluginComponents(HelpMenu.java:63)
        at net.java.sip.communicator.impl.gui.main.chat.menus.HelpMenu.<init>(HelpMenu.java:55)
        at net.java.sip.communicator.impl.gui.main.chat.menus.MessageWindowMenuBar.<init>(MessageWindowMenuBar.java:46)
        at net.java.sip.communicator.impl.gui.main.chat.MenusPanel.<init>(MenusPanel.java:46)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindow.<init>(ChatWindow.java:63)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.createChat(ChatWindowManager.java:531)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.getContactChat(ChatWindowManager.java:339)
        at net.java.sip.communicator.impl.gui.main.contactlist.ContactListPanel.messageReceived(ContactListPanel.java:247)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.fireMessageReceived(OperationSetBasicInstantMessagingRssImpl.java:369)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.submitRssQuery(OperationSetBasicInstantMessagingRssImpl.java:219)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.refreshAllRssFeeds(OperationSetBasicInstantMessagingRssImpl.java:236)
        at net.java.sip.communicator.impl.protocol.rss.RssTimerRefreshFeed.run(RssTimerRefreshFeed.java:45)
        at java.util.TimerThread.mainLoop(Timer.java:512)
        at java.util.TimerThread.run(Timer.java:462)

Any ideas?

Emil

P.S. Sorry for not answering on MSN, ... the thing is that I upgraded my
local copy of SIP Communicator and now can't send messages because of
this issue :).

Thomas Hofer wrote:

···

Hmm, strange. It seems on cruisecontrol, that there is everything ok.

-----Urspr�ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Donnerstag, 29. November 2007 13:43
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] tests broken?

Hi!
I just finished my work on the about-dialog and I'm running through the
check-in procedure. I encountered following error on the cc-build:

I think, that the build (tests) is already broken, isn't it?

Cheers, THomas

     [java] 13:27:25.794 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] ERROR: EventDispatcher: Error during dispatch.
(java.lang.NullPointerException)
     [java] java.lang.NullPointerException
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createProt
oCont
actGroupNode(MclStorageManager.java:963)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createMeta
Conta
ctGroupNode(MclStorageManager.java:1051)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.metaContac
tGrou
pModified(MclStorageManager.java:1466)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.f
ireMe
taContactGroupEvent(MetaContactListServiceImpl.java:2680)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.r
emove
ContactGroupFromMetaContactGroup(MetaContactListServiceImpl.java:1162)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.h
andle
ProviderRemoved(MetaContactListServiceImpl.java:1563)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.s
ervic
eChanged(MetaContactListServiceImpl.java:1815)
     [java] at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCa
llbac
k(EventDispatcher.java:765)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(Ev
entDi
spatcher.java:623)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventD
ispat
cher.java:554)
     [java] at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:3525)
     [java] at
org.apache.felix.framework.Felix.access$000(Felix.java:36)
     [java] at
org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:593)
     [java] at
org.apache.felix.framework.ServiceRegistry.fireServiceChanged(ServiceRe
gistr
y.java:435)
     [java] at
org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceReg
istry
..java:86)
     [java] at
org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRe
gistr
ationImpl.java:99)
     [java] at
net.java.sip.communicator.impl.protocol.rss.ProtocolProviderFactoryRssI
mpl.u
ninstallAccount(ProtocolProviderFactoryRssImpl.java:206)
     [java] at
net.java.sip.communicator.slick.protocol.rss.TestAccountUninstallation.
testU
ninstallAccount(TestAccountUninstallation.java:187)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
va:39
)
     [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
rImpl
..java:25)
     [java] at java.lang.reflect.Method.invoke(Method.java:597)
     [java] at
junit.framework.TestCase.runTest(TestCase.java:154)
     [java] at
junit.framework.TestCase.runBare(TestCase.java:127)
     [java] at
junit.framework.TestResult$1.protect(TestResult.java:106)
     [java] at
junit.framework.TestResult.runProtected(TestResult.java:124)
     [java] at
junit.framework.TestResult.run(TestResult.java:109)
     [java] at junit.framework.TestCase.run(TestCase.java:118)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
104)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
94)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.run(ScTestRunner.ja
va:56
)
     [java] at
net.java.sip.communicator.slick.runner.SipCommunicatorSlickRunner.start
(SipC
ommunicatorSlickRunner.java:150)
     [java] at
org.apache.felix.framework.util.SecureAction.startActivator(SecureActio
n.jav
a:589)
     [java] at
org.apache.felix.framework.Felix._startBundle(Felix.java:1536)
     [java] at
org.apache.felix.framework.Felix.startBundle(Felix.java:1470)
     [java] at
org.apache.felix.framework.Felix.setFrameworkStartLevel(Felix.java:1065
)
     [java] at
org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:258)
     [java] at java.lang.Thread.run(Thread.java:619)
     [java] 13:27:25.826 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().159
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().160

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().161 We ran 200 tests
and
encountered 107 errors and failures.
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().164

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().165
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.951 INFO:
impl.protocol.gibberish.GibberishActivator.stop().115 Gibberish
protocol
implementation [STOPPED].
     [java] 13:27:25.951 FEINER:
impl.protocol.sip.ProtocolProviderFactorySipImpl.stop().269 Preparing
to
stop all SIP protocol providers.
     [java] 13:27:25.951 INFO:
impl.netaddr.NetworkAddressManagerServiceImpl.stop().102 Network
Address
Manager Service ...[STOPPED]
     [java] 13:27:25.951 INFO:
impl.configuration.ConfigurationServiceImpl.stop().60 The
ConfigurationService stop method has been called.
     [java] Java Result: -1
     [echo] Generating HTML test reports ...
     [echo] Done.
     [echo] Test results available in ./test-reports/html/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Ulrich,

I apologise for the delay.

Implementing a filter interface seems like a good idea. Probably the way
to go would be to first create an operation set that allows you to do
this. We can either define a new OperationSetMessageFiltering that
allows you to install new filters, or add an installFilter method in the
existing OperationSetBasicInstantMessaging.

The former would be easier to integrate to the project since it could be
done gradually, that is, we could add implementations for the different
protocols as they are being created (though most of the time we would
probably have the same mechanism). Another good point here is that we
could actually create the operation set as an abstract class and
implement most of the functionality it is supposed to provide directly
inside it, and then simply add (almost) empty implementations for the
different protocols.

The latter, on the other hand, might be better because installing
message filters only makes sense when you have an instant messaging
operation set.

Either way we would be interested in integrating this in SIP
Communicator, should you choose to contribute it of course, and I
believe it would be a very useful feature.

Thanks for bringing it up!
Emil

Ulrich Norbisrath (sip-communicator) wrote:

···

Hi all,
we have now a first prototype for our friend-to-friend-computing plugin
(very pre-alpha, but you can have a look at f2f.ulno.net) for
sip-communicator.
As we use the communication-channels for exchanging information between
the f2f-clients a lot of encrypted messages will pop up in the normal
chat-windows of sip-communicator. This is really annoying.
Of course we can just hack the sip-communicator-code to honor the
f2f-plugin, but this is probably not the way to go.
Would it make sense to offer a filter-interface to listen to all
messages in fireMessageEvent(EventObject evt) and let only these
messages through which the filter allows?
Or is there any other clean way to hook into the event-chain?
We are also willing to do these changes in my group, but we would like
to find a community-compliant solution.

Cheers,
Ulrich

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi Emil, Thomas,

I have experienced the same problem and have just committed a fix. The problem was coming from the fact that chat help menu wasn't added in the supported containers. I have just added one line in the UIServiceImpl and it's ok now.

There's something else that bothers me though. We seem to have a problem with the background of the loading panel in the splash screen (it's gray, instead of the main background). We should have a look on this one also.

Cheers,
Yana

Emil Ivov wrote:

···

Hello Thomas,

The tests are indeed OK, and I guess that there must have been a problem
with your own environment for them to fail this way (107 errors and
failures generally mean a problem with the test configuration).

However there seems to be another problem with the commit. It seems
impossible to open a chat window in the latest nightly build. When I try
to do so I get the following exception:

java.lang.IllegalArgumentException: The container that you specified is not supported by this UIService implementation.
        at net.java.sip.communicator.impl.gui.UIServiceImpl.getComponentsForContainer(UIServiceImpl.java:293)
        at net.java.sip.communicator.impl.gui.main.chat.menus.HelpMenu.initPluginComponents(HelpMenu.java:63)
        at net.java.sip.communicator.impl.gui.main.chat.menus.HelpMenu.<init>(HelpMenu.java:55)
        at net.java.sip.communicator.impl.gui.main.chat.menus.MessageWindowMenuBar.<init>(MessageWindowMenuBar.java:46)
        at net.java.sip.communicator.impl.gui.main.chat.MenusPanel.<init>(MenusPanel.java:46)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindow.<init>(ChatWindow.java:63)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.createChat(ChatWindowManager.java:531)
        at net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.getContactChat(ChatWindowManager.java:339)
        at net.java.sip.communicator.impl.gui.main.contactlist.ContactListPanel.messageReceived(ContactListPanel.java:247)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.fireMessageReceived(OperationSetBasicInstantMessagingRssImpl.java:369)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.submitRssQuery(OperationSetBasicInstantMessagingRssImpl.java:219)
        at net.java.sip.communicator.impl.protocol.rss.OperationSetBasicInstantMessagingRssImpl.refreshAllRssFeeds(OperationSetBasicInstantMessagingRssImpl.java:236)
        at net.java.sip.communicator.impl.protocol.rss.RssTimerRefreshFeed.run(RssTimerRefreshFeed.java:45)
        at java.util.TimerThread.mainLoop(Timer.java:512)
        at java.util.TimerThread.run(Timer.java:462)

Any ideas?

Emil

P.S. Sorry for not answering on MSN, ... the thing is that I upgraded my
local copy of SIP Communicator and now can't send messages because of
this issue :).

Thomas Hofer wrote:

Hmm, strange. It seems on cruisecontrol, that there is everything ok.

-----Urspr�ngliche Nachricht-----
Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Donnerstag, 29. November 2007 13:43
An: dev@sip-communicator.dev.java.net
Betreff: [sip-comm-dev] tests broken?

Hi!
I just finished my work on the about-dialog and I'm running through the
check-in procedure. I encountered following error on the cc-build:

I think, that the build (tests) is already broken, isn't it?

Cheers, THomas

     [java] 13:27:25.794 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] ERROR: EventDispatcher: Error during dispatch.
(java.lang.NullPointerException)
     [java] java.lang.NullPointerException
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createProt
oCont
actGroupNode(MclStorageManager.java:963)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.createMeta
Conta
ctGroupNode(MclStorageManager.java:1051)
     [java] at
net.java.sip.communicator.impl.contactlist.MclStorageManager.metaContac
tGrou
pModified(MclStorageManager.java:1466)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.f
ireMe
taContactGroupEvent(MetaContactListServiceImpl.java:2680)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.r
emove
ContactGroupFromMetaContactGroup(MetaContactListServiceImpl.java:1162)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.h
andle
ProviderRemoved(MetaContactListServiceImpl.java:1563)
     [java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.s
ervic
eChanged(MetaContactListServiceImpl.java:1815)
     [java] at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCa
llbac
k(EventDispatcher.java:765)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(Ev
entDi
spatcher.java:623)
     [java] at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventD
ispat
cher.java:554)
     [java] at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:3525)
     [java] at
org.apache.felix.framework.Felix.access$000(Felix.java:36)
     [java] at
org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:593)
     [java] at
org.apache.felix.framework.ServiceRegistry.fireServiceChanged(ServiceRe
gistr
y.java:435)
     [java] at
org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceReg
istry
..java:86)
     [java] at
org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRe
gistr
ationImpl.java:99)
     [java] at
net.java.sip.communicator.impl.protocol.rss.ProtocolProviderFactoryRssI
mpl.u
ninstallAccount(ProtocolProviderFactoryRssImpl.java:206)
     [java] at
net.java.sip.communicator.slick.protocol.rss.TestAccountUninstallation.
testU
ninstallAccount(TestAccountUninstallation.java:187)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
va:39
)
     [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
rImpl
..java:25)
     [java] at java.lang.reflect.Method.invoke(Method.java:597)
     [java] at
junit.framework.TestCase.runTest(TestCase.java:154)
     [java] at
junit.framework.TestCase.runBare(TestCase.java:127)
     [java] at
junit.framework.TestResult$1.protect(TestResult.java:106)
     [java] at
junit.framework.TestResult.runProtected(TestResult.java:124)
     [java] at
junit.framework.TestResult.run(TestResult.java:109)
     [java] at junit.framework.TestCase.run(TestCase.java:118)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
junit.framework.TestSuite.runTest(TestSuite.java:208)
     [java] at junit.framework.TestSuite.run(TestSuite.java:203)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
104)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.doRun(ScTestRunner.
java:
94)
     [java] at
net.java.sip.communicator.slick.runner.ScTestRunner.run(ScTestRunner.ja
va:56
)
     [java] at
net.java.sip.communicator.slick.runner.SipCommunicatorSlickRunner.start
(SipC
ommunicatorSlickRunner.java:150)
     [java] at
org.apache.felix.framework.util.SecureAction.startActivator(SecureActio
n.jav
a:589)
     [java] at
org.apache.felix.framework.Felix._startBundle(Felix.java:1536)
     [java] at
org.apache.felix.framework.Felix.startBundle(Felix.java:1470)
     [java] at
org.apache.felix.framework.Felix.setFrameworkStartLevel(Felix.java:1065
)
     [java] at
org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:258)
     [java] at java.lang.Thread.run(Thread.java:619)
     [java] 13:27:25.826 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.start().75 RSS
protocol implementation [STARTED].
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().159
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().160

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().161 We ran 200 tests
and
encountered 107 errors and failures.
     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().164

     [java] 13:27:25.935 INFO:
slick.runner.SipCommunicatorSlickRunner.start().165
     [java] 13:27:25.935 INFO:
impl.protocol.rss.RssActivator.stop().121 RSS
protocol implementation [STOPPED].
     [java] 13:27:25.951 INFO:
impl.protocol.gibberish.GibberishActivator.stop().115 Gibberish
protocol
implementation [STOPPED].
     [java] 13:27:25.951 FEINER:
impl.protocol.sip.ProtocolProviderFactorySipImpl.stop().269 Preparing
to
stop all SIP protocol providers.
     [java] 13:27:25.951 INFO:
impl.netaddr.NetworkAddressManagerServiceImpl.stop().102 Network
Address
Manager Service ...[STOPPED]
     [java] 13:27:25.951 INFO:
impl.configuration.ConfigurationServiceImpl.stop().60 The
ConfigurationService stop method has been called.
     [java] Java Result: -1
     [echo] Generating HTML test reports ...
     [echo] Done.
     [echo] Test results available in ./test-reports/html/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi,

I implemented the filtering by adding two new methods to the interface OperationSetBasicInstantMessaging. New methods are addEventFilter and removeEventFilter.
Actual filtering is at the moment implemented in these implementations of OperationSetBasicInstantMessaging that have the method fireMessageEvent (others have just empty addEventFilter/removeEventFilter and no filtering is happening).
The changes to the SIP Communicator source are in the attached patch-file.
Please check it and let me know, what do you think.

Cheers,
Keio

SIP Communicator patch.txt (17.3 KB)

···

----- Original Message -----

From: "Emil Ivov" <emcho@sip-communicator.org>

To: <dev@sip-communicator.dev.java.net>
Sent: Tuesday, December 04, 2007 8:24 PM
Subject: Re: [sip-comm-dev] Generic message filters

Hi Ulrich,

I apologise for the delay.

Implementing a filter interface seems like a good idea. Probably the way
to go would be to first create an operation set that allows you to do
this. We can either define a new OperationSetMessageFiltering that
allows you to install new filters, or add an installFilter method in the
existing OperationSetBasicInstantMessaging.

The former would be easier to integrate to the project since it could be
done gradually, that is, we could add implementations for the different
protocols as they are being created (though most of the time we would
probably have the same mechanism). Another good point here is that we
could actually create the operation set as an abstract class and
implement most of the functionality it is supposed to provide directly
inside it, and then simply add (almost) empty implementations for the
different protocols.

The latter, on the other hand, might be better because installing
message filters only makes sense when you have an instant messaging
operation set.

Either way we would be interested in integrating this in SIP
Communicator, should you choose to contribute it of course, and I
believe it would be a very useful feature.

Thanks for bringing it up!
Emil

Ulrich Norbisrath (sip-communicator) wrote:

Hi all,
we have now a first prototype for our friend-to-friend-computing plugin
(very pre-alpha, but you can have a look at f2f.ulno.net) for
sip-communicator.
As we use the communication-channels for exchanging information between
the f2f-clients a lot of encrypted messages will pop up in the normal
chat-windows of sip-communicator. This is really annoying.
Of course we can just hack the sip-communicator-code to honor the
f2f-plugin, but this is probably not the way to go.
Would it make sense to offer a filter-interface to listen to all
messages in fireMessageEvent(EventObject evt) and let only these
messages through which the filter allows?
Or is there any other clean way to hook into the event-chain?
We are also willing to do these changes in my group, but we would like
to find a community-compliant solution.

Cheers,
Ulrich

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

See Inline..

Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Donnerstag, 29. November 2007 15:08
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] tests broken?

Hi Emil, Thomas,

I have experienced the same problem and have just committed a fix. The
problem was coming from the fact that chat help menu wasn't added in
the
supported containers. I have just added one line in the UIServiceImpl
and it's ok now.

Oh, sorry, my fault!

There's something else that bothers me though. We seem to have a
problem
with the background of the loading panel in the splash screen (it's
gray, instead of the main background). We should have a look on this
one
also.

Hmm, strange. I did not change anything in the splashscreen. I' will have a
look at this.

Thomas

···

-----Ursprüngliche Nachricht-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hallo Keio,

Sorry it took so long before you got a reply. I am trying to wrap up a
thesis so I've got very few cycles left for SC for a month or two.

Thanks for sending your patch over. I've already mentioned previously
that I consider this a useful feature for the PP service so I'll try to
have a look at it. Unfortunately, since I am quite busy now, it might
take a while (unless another developer decides to take it up), so please
bear with me.

Cheers
Emil

Keio Kraaner wrote:

···

Hi,

I implemented the filtering by adding two new methods to the interface
OperationSetBasicInstantMessaging. New methods are addEventFilter and
removeEventFilter.
Actual filtering is at the moment implemented in these implementations of
OperationSetBasicInstantMessaging that have the method fireMessageEvent
(others have just empty addEventFilter/removeEventFilter and no filtering is
happening).
The changes to the SIP Communicator source are in the attached patch-file.
Please check it and let me know, what do you think.

Cheers,
Keio

----- Original Message -----
From: "Emil Ivov" <emcho@sip-communicator.org>
To: <dev@sip-communicator.dev.java.net>
Sent: Tuesday, December 04, 2007 8:24 PM
Subject: Re: [sip-comm-dev] Generic message filters

Hi Ulrich,

I apologise for the delay.

Implementing a filter interface seems like a good idea. Probably the way
to go would be to first create an operation set that allows you to do
this. We can either define a new OperationSetMessageFiltering that
allows you to install new filters, or add an installFilter method in the
existing OperationSetBasicInstantMessaging.

The former would be easier to integrate to the project since it could be
done gradually, that is, we could add implementations for the different
protocols as they are being created (though most of the time we would
probably have the same mechanism). Another good point here is that we
could actually create the operation set as an abstract class and
implement most of the functionality it is supposed to provide directly
inside it, and then simply add (almost) empty implementations for the
different protocols.

The latter, on the other hand, might be better because installing
message filters only makes sense when you have an instant messaging
operation set.

Either way we would be interested in integrating this in SIP
Communicator, should you choose to contribute it of course, and I
believe it would be a very useful feature.

Thanks for bringing it up!
Emil

Ulrich Norbisrath (sip-communicator) wrote:

Hi all,
we have now a first prototype for our friend-to-friend-computing plugin
(very pre-alpha, but you can have a look at f2f.ulno.net) for
sip-communicator.
As we use the communication-channels for exchanging information between
the f2f-clients a lot of encrypted messages will pop up in the normal
chat-windows of sip-communicator. This is really annoying.
Of course we can just hack the sip-communicator-code to honor the
f2f-plugin, but this is probably not the way to go.
Would it make sense to offer a filter-interface to listen to all
messages in fireMessageEvent(EventObject evt) and let only these
messages through which the filter allows?
Or is there any other clean way to hook into the event-chain?
We are also willing to do these changes in my group, but we would like
to find a community-compliant solution.

Cheers,
Ulrich

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

My fault!

···

> -----Ursprüngliche Nachricht-----
> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
> There's something else that bothers me though. We seem to have a
> problem
> with the background of the loading panel in the splash screen (it's
> gray, instead of the main background). We should have a look on this
> one
> also.

When I copied the sources, I took the wrong picture (It is the picture from
the about-dialg and this picture is smaller :frowning:

Fixed...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hi!

In the splashscreen-bundle there is a class WindowTransparentBackground. But
it is not used from anywhere. Initially checked in by yanas in January.
Should we remove it?

Cheers, thomas

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hi Thomas,

Yes, you could removed it.

Cheers,
Yana

Thomas Hofer wrote:

···

Hi!

In the splashscreen-bundle there is a class WindowTransparentBackground. But
it is not used from anywhere. Initially checked in by yanas in January.
Should we remove it?

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net