[sip-comm-dev] Final patch for the online dictionary plugin


#1

Hi everybody

Hello everyone,

Here is the patch (revision 3651) containing the plug-in. It is ready
for integration, Vincent made the necessary checks.

We thank you once again for the help you have given us during this project.

Cheers

Cédric, Damien

dict_protocole_final_patch.diff (226 KB)


#2

Hi Cédric, Damien and all,

I have just applied your patch (without the part of the OperationSet)
for the DICT protocol and acknowledged your work on the "Team and
Contributors" page.

Then, if someone wants to try it, you have to:
1) Creat a "dict account".
2) Add a new contact with one of the dictionaries listed at the bottom
of the following page:
http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The DICT plugin provides you a simple way to get definitions of words or translations for more than 20 languages.

Have fun,
Vincent

Damien Roth wrote:

···

Hi everybody

Hello everyone,

Here is the patch (revision 3651) containing the plug-in. It is ready
for integration, Vincent made the necessary checks.

We thank you once again for the help you have given us during this project.

Cheers

Cédric, Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

I just gave a try to the dictionnary plugin, it's really amazing! Congratulations!
Just one comment: I experienced a bug when adding a dictionnary that does not exists and when trying to use it:

   me at 09:07:17
     SHOW DB
   trial at 09:07:17
     Invalid database, use SHOW DB for list of databases
   me at 09:07:25
     show db
   trial at 09:07:25
     Invalid database, use SHOW DB for list of databases

Actually, I did not understand at first that the dictionary identifier is supposed to be one listed in the documentation, I thought I could first enter a name for that dictionary. Maybe it could be more explicit in the wizard, or let the user select the dictionary within a list displayed in the wizard.

http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The documentation is really good. Actually we should think about putting it in the user documentation instead (http://www.sip-communicator.org/index.php/Documentation/UserDocumentation) and maybe list there all the available plugin in SC with some documentation/information to the users. I think this is currently lacking on the website.

Cheers,
romain

···

On 2008/05/27, at 1:08, Vincent Lucas wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Romain,

(see comments inline)

Romain KUNTZ wrote:

Hi,

I just gave a try to the dictionnary plugin, it's really amazing! Congratulations!

Indeed, Damien and C�dric have done a great plugin.

Just one comment: I experienced a bug when adding a dictionnary that does not exists and when trying to use it:

  me at 09:07:17
    SHOW DB
  trial at 09:07:17
    Invalid database, use SHOW DB for list of databases
  me at 09:07:25
    show db
  trial at 09:07:25
    Invalid database, use SHOW DB for list of databases

Actually, I did not understand at first that the dictionary identifier is supposed to be one listed in the documentation, I thought I could first enter a name for that dictionary. Maybe it could be more explicit in the wizard, or let the user select the dictionary within a list displayed in the wizard.

In fact, the final goal is to create an "Add contact" frame using a combo box filled with the list of all the dictionaries available on the server.
To deliver the list to the gui, the idea was to use a non-specific OperationSetDirectory (which was done by C�dric and Damien) shared between the DICT protocol and the LDAP one (comming for the end of this GSoC). This part has not been committed, because after a recent debate with Emil, we have decided to separate each protocol interface and to provide a Service or a Plugin in order of the OperationSet.

http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The documentation is really good. Actually we should think about putting it in the user documentation instead (http://www.sip-communicator.org/index.php/Documentation/UserDocumentation) and maybe list there all the available plugin in SC with some documentation/information to the users. I think this is currently lacking on the website.

I like the idea and confirm that feeling concerning the lack of user documentation on the website.

Thank you for the report,
Vincent

···

On 2008/05/27, at 1:08, Vincent Lucas wrote:

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Romain,

I just gave a try to the dictionnary plugin, it's really amazing!
Congratulations!

Indeed, Damien and Cédric have done a great plugin.

Thanks a lot, we hope that this plug in will be very useful in the future.

Just one comment: I experienced a bug when adding a dictionnary that does
not exists and when trying to use it:

me at 09:07:17
   SHOW DB
trial at 09:07:17
   Invalid database, use SHOW DB for list of databases
me at 09:07:25
   show db
trial at 09:07:25
   Invalid database, use SHOW DB for list of databases

Actually, I did not understand at first that the dictionary identifier is
supposed to be one listed in the documentation, I thought I could first
enter a name for that dictionary. Maybe it could be more explicit in the
wizard, or let the user select the dictionary within a list displayed in the
wizard.

In fact, the final goal is to create an "Add contact" frame using a combo
box filled with the list of all the dictionaries available on the server.
To deliver the list to the gui, the idea was to use a non-specific
OperationSetDirectory (which was done by Cédric and Damien) shared between
the DICT protocol and the LDAP one (comming for the end of this GSoC). This
part has not been committed, because after a recent debate with Emil, we
have decided to separate each protocol interface and to provide a Service or
a Plugin in order of the OperationSet.

As Vincent say, the "Add contact" frame will be change in a near
future. But this error might also appears with the combo box system,
for example if the server remove a dictionary that is in our contact
list.

Since we don't allow system commands, we should change the return
text. I will do the necessary in the next few days.

http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The documentation is really good. Actually we should think about putting
it in the user documentation instead
(http://www.sip-communicator.org/index.php/Documentation/UserDocumentation)
and maybe list there all the available plugin in SC with some
documentation/information to the users. I think this is currently lacking on
the website.

I like the idea and confirm that feeling concerning the lack of user
documentation on the website.

Thank you for the report,
Vincent

In fact, the documentation in the developer part is our oral
presentation translated in the HTML format. Most of our presentation
is based on : how work the protocol and how we implement it in SC.
Which is not really important for the lambda user, they may just want
us to explain how to add a dictionary and how to get definitions. It's
totally different from the documentation in the developer
documentation.

At the end of our presentation, we said we're going to write the user
documentation. Since our exams are near, the might be available after
them.

Thanks a lot,

Damien

···

On 2008/05/27, at 1:08, Vincent Lucas wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi all

Here is the diff which correct this problem.

Cedric,Damien

Damien Roth <damien.roth@gmail.com> a écrit :

dict_plugin.diff (3.19 KB)

···

Hi Romain,

I just gave a try to the dictionnary plugin, it's really amazing!
Congratulations!

Indeed, Damien and Cédric have done a great plugin.

Thanks a lot, we hope that this plug in will be very useful in the future.

Just one comment: I experienced a bug when adding a dictionnary that does
not exists and when trying to use it:

me at 09:07:17
   SHOW DB
trial at 09:07:17
   Invalid database, use SHOW DB for list of databases
me at 09:07:25
   show db
trial at 09:07:25
   Invalid database, use SHOW DB for list of databases

Actually, I did not understand at first that the dictionary identifier is
supposed to be one listed in the documentation, I thought I could first
enter a name for that dictionary. Maybe it could be more explicit in the
wizard, or let the user select the dictionary within a list displayed in the
wizard.

In fact, the final goal is to create an "Add contact" frame using a combo
box filled with the list of all the dictionaries available on the server.
To deliver the list to the gui, the idea was to use a non-specific
OperationSetDirectory (which was done by Cédric and Damien) shared between
the DICT protocol and the LDAP one (comming for the end of this GSoC). This
part has not been committed, because after a recent debate with Emil, we
have decided to separate each protocol interface and to provide a Service or
a Plugin in order of the OperationSet.

As Vincent say, the "Add contact" frame will be change in a near
future. But this error might also appears with the combo box system,
for example if the server remove a dictionary that is in our contact
list.

Since we don't allow system commands, we should change the return
text. I will do the necessary in the next few days.

On 2008/05/27, at 1:08, Vincent Lucas wrote:

http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The documentation is really good. Actually we should think about putting
it in the user documentation instead
(http://www.sip-communicator.org/index.php/Documentation/UserDocumentation)
and maybe list there all the available plugin in SC with some
documentation/information to the users. I think this is currently lacking on
the website.

I like the idea and confirm that feeling concerning the lack of user
documentation on the website.

Thank you for the report,
Vincent

In fact, the documentation in the developer part is our oral
presentation translated in the HTML format. Most of our presentation
is based on : how work the protocol and how we implement it in SC.
Which is not really important for the lambda user, they may just want
us to explain how to add a dictionary and how to get definitions. It's
totally different from the documentation in the developer
documentation.

At the end of our presentation, we said we're going to write the user
documentation. Since our exams are near, the might be available after
them.

Thanks a lot,

Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi Cédric,

I have just applied your patch, which provides a pleasant warning to the user when this one wants to query a database unavailable on the server.

Thank you,
Vincent

PS: I have commited another improvement which creates a default contact for each new DICT account.

···

Cedric.Litzelmann@ulp.u-strasbg.fr wrote:

Hi all

Here is the diff which correct this problem.

Cedric,Damien

Damien Roth <damien.roth@gmail.com> a écrit :

Hi Romain,

I just gave a try to the dictionnary plugin, it's really amazing!
Congratulations!

Indeed, Damien and Cédric have done a great plugin.

Thanks a lot, we hope that this plug in will be very useful in the future.

Just one comment: I experienced a bug when adding a dictionnary that does
not exists and when trying to use it:

me at 09:07:17
   SHOW DB
trial at 09:07:17
   Invalid database, use SHOW DB for list of databases
me at 09:07:25
   show db
trial at 09:07:25
   Invalid database, use SHOW DB for list of databases

Actually, I did not understand at first that the dictionary identifier is
supposed to be one listed in the documentation, I thought I could first
enter a name for that dictionary. Maybe it could be more explicit in the
wizard, or let the user select the dictionary within a list displayed in the
wizard.

In fact, the final goal is to create an "Add contact" frame using a combo
box filled with the list of all the dictionaries available on the server.
To deliver the list to the gui, the idea was to use a non-specific
OperationSetDirectory (which was done by Cédric and Damien) shared between
the DICT protocol and the LDAP one (comming for the end of this GSoC). This
part has not been committed, because after a recent debate with Emil, we
have decided to separate each protocol interface and to provide a Service or
a Plugin in order of the OperationSet.

As Vincent say, the "Add contact" frame will be change in a near
future. But this error might also appears with the combo box system,
for example if the server remove a dictionary that is in our contact
list.

Since we don't allow system commands, we should change the return
text. I will do the necessary in the next few days.

On 2008/05/27, at 1:08, Vincent Lucas wrote:

http://www.sip-communicator.org/index.php/Documentation/DictProtocol

The documentation is really good. Actually we should think about putting
it in the user documentation instead
(http://www.sip-communicator.org/index.php/Documentation/UserDocumentation)

and maybe list there all the available plugin in SC with some
documentation/information to the users. I think this is currently lacking on
the website.

I like the idea and confirm that feeling concerning the lack of user
documentation on the website.

Thank you for the report,
Vincent

In fact, the documentation in the developer part is our oral
presentation translated in the HTML format. Most of our presentation
is based on : how work the protocol and how we implement it in SC.
Which is not really important for the lambda user, they may just want
us to explain how to add a dictionary and how to get definitions. It's
totally different from the documentation in the developer
documentation.

At the end of our presentation, we said we're going to write the user
documentation. Since our exams are near, the might be available after
them.

Thanks a lot,

Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net