[sip-comm-dev] File Transfer implementation small detail


#1

Hi Joao,

You're absolutely right about the progress field type. It's actually 'long' in the AbstractFileTransfer, but for some unknown reason it's converted to int when passed to the event. It should be ok in revision 5547.

Very good catch!! Thanks!

Cheers,
Yana

Jo�o Antunes (Gmail) wrote:

···

Hi!

While i was implementing the SIP file transfer feature i noticed and i got confused about a small detail:

@ the class:
net.java.sip.communicator.service.protocol.event.FileTransferProgressEvent

related with the field:

/**
    * Indicates the progress of a file transfer in bytes.
    */
private int progress;

Is this progress the number of total bytes sent of the file? if so, shouldn't it be a long? if it's the difference of bytes sent between progress events, I would change the comments on the constructor and the present above on the field.

Cheers,
Jo�o Antunes

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net