[sip-comm-dev] facebook protocol


#1

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Edgar,

As I see there are no responses from developers working on the
Facebook support, I suppose it's appropriate for me to chime in.

Thank you for you interest in the Facebook support and in SIP
Communicator in general!

Our Facebook plug-ins were developed by Dai Zhiwei during Google
Summer of Code 2008 and I was his mentor for the second part of the
program. I recently integrated his work into trunk. As an year has
passed since the plug-ins were originally developed and as you have
noticed, they are a little out of shape. We also put a warning in the
account registration wizard for the Facebook protocol to convey this
state.

Judging by the fact that there are still no answers from developers
working on the Facebook support and not knowing of anyone working on
it myself, I guess that there are no such developers apart from you
and that you can safely continue your work.

I'd like to assure you that your contribution will be greatly valued
and that I will myself look into integrating it into trunk as soon as
possible.

Regards,
Lubomir

···

On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

Thank you very much for your feedback, I'm working on it now and I'll
create an issue with the patch soon.

br,
edgar

···

On Mon, Aug 31, 2009 at 8:56 PM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

As I see there are no responses from developers working on the
Facebook support, I suppose it's appropriate for me to chime in.

Thank you for you interest in the Facebook support and in SIP
Communicator in general!

Our Facebook plug-ins were developed by Dai Zhiwei during Google
Summer of Code 2008 and I was his mentor for the second part of the
program. I recently integrated his work into trunk. As an year has
passed since the plug-ins were originally developed and as you have
noticed, they are a little out of shape. We also put a warning in the
account registration wizard for the Facebook protocol to convey this
state.

Judging by the fact that there are still no answers from developers
working on the Facebook support and not knowing of anyone working on
it myself, I guess that there are no such developers apart from you
and that you can safely continue your work.

I'd like to assure you that your contribution will be greatly valued
and that I will myself look into integrating it into trunk as soon as
possible.

Regards,
Lubomir

On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

···

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

Thank you very much for your feedback, I'm working on it now and I'll
create an issue with the patch soon.

br,
edgar

On Mon, Aug 31, 2009 at 8:56 PM, Lubomir > Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

As I see there are no responses from developers working on the
Facebook support, I suppose it's appropriate for me to chime in.

Thank you for you interest in the Facebook support and in SIP
Communicator in general!

Our Facebook plug-ins were developed by Dai Zhiwei during Google
Summer of Code 2008 and I was his mentor for the second part of the
program. I recently integrated his work into trunk. As an year has
passed since the plug-ins were originally developed and as you have
noticed, they are a little out of shape. We also put a warning in the
account registration wizard for the Facebook protocol to convey this
state.

Judging by the fact that there are still no answers from developers
working on the Facebook support and not knowing of anyone working on
it myself, I guess that there are no such developers apart from you
and that you can safely continue your work.

I'd like to assure you that your contribution will be greatly valued
and that I will myself look into integrating it into trunk as soon as
possible.

Regards,
Lubomir

On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies to
sip-communicator which allow to access Facebook chat service through http.

I have a little suggestion to separate completely the protocol layer and SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication of
classes and facilitate maintenance of the protocol.

Bye

Damien

···

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:
> Hi,
>
> Thank you very much for your feedback, I'm working on it now and I'll
> create an issue with the patch soon.
>
> br,
> edgar
>
> On Mon, Aug 31, 2009 at 8:56 PM, Lubomir > > Marinov<lubomir.marinov@gmail.com> wrote:
>> Hi Edgar,
>>
>> As I see there are no responses from developers working on the
>> Facebook support, I suppose it's appropriate for me to chime in.
>>
>> Thank you for you interest in the Facebook support and in SIP
>> Communicator in general!
>>
>> Our Facebook plug-ins were developed by Dai Zhiwei during Google
>> Summer of Code 2008 and I was his mentor for the second part of the
>> program. I recently integrated his work into trunk. As an year has
>> passed since the plug-ins were originally developed and as you have
>> noticed, they are a little out of shape. We also put a warning in the
>> account registration wizard for the Facebook protocol to convey this
>> state.
>>
>> Judging by the fact that there are still no answers from developers
>> working on the Facebook support and not knowing of anyone working on
>> it myself, I guess that there are no such developers apart from you
>> and that you can safely continue your work.
>>
>> I'd like to assure you that your contribution will be greatly valued
>> and that I will myself look into integrating it into trunk as soon as
>> possible.
>>
>> Regards,
>> Lubomir
>>
>> On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:
>>> Hi,
>>>
>>> First of all thanks for the good work!. My name is Edgar and I am a
>>> new user of sip-communicator, I'm trying to use the Facebook protocol
>>> and I'm having some problems. The protocol doesn't connect correctly,
>>> apparently the Facebook API changed and sip-communicator is no longer
>>> able to connect. I made some changes against the trunk and now it
>>> connects successfully, however now it's not able to get the buddy
>>> list. Before going further trying to prepare a patch I'd like to know
>>> if anyone is already working on this protocol.
>>>
>>> br,
>>> Edgar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Damien,

thanks for your comments. I think it's a good idea. What's the common
practice in the project, keeping the sources in a subproject of
sip-communicator or create a project in e.g. google code and include
only the binary dependency in sip-communicator?

br,
Edgar

···

On Thu, Sep 3, 2009 at 6:22 PM, Damien Roth<damien.roth@gmail.com> wrote:

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies to
sip-communicator which allow to access Facebook chat service through http.

I have a little suggestion to separate completely the protocol layer and SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication of
classes and facilitate maintenance of the protocol.

Bye

Damien

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:
> Hi,
>
> Thank you very much for your feedback, I'm working on it now and I'll
> create an issue with the patch soon.
>
> br,
> edgar
>
> On Mon, Aug 31, 2009 at 8:56 PM, Lubomir >> > Marinov<lubomir.marinov@gmail.com> wrote:
>> Hi Edgar,
>>
>> As I see there are no responses from developers working on the
>> Facebook support, I suppose it's appropriate for me to chime in.
>>
>> Thank you for you interest in the Facebook support and in SIP
>> Communicator in general!
>>
>> Our Facebook plug-ins were developed by Dai Zhiwei during Google
>> Summer of Code 2008 and I was his mentor for the second part of the
>> program. I recently integrated his work into trunk. As an year has
>> passed since the plug-ins were originally developed and as you have
>> noticed, they are a little out of shape. We also put a warning in the
>> account registration wizard for the Facebook protocol to convey this
>> state.
>>
>> Judging by the fact that there are still no answers from developers
>> working on the Facebook support and not knowing of anyone working on
>> it myself, I guess that there are no such developers apart from you
>> and that you can safely continue your work.
>>
>> I'd like to assure you that your contribution will be greatly valued
>> and that I will myself look into integrating it into trunk as soon as
>> possible.
>>
>> Regards,
>> Lubomir
>>
>> On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:
>>> Hi,
>>>
>>> First of all thanks for the good work!. My name is Edgar and I am a
>>> new user of sip-communicator, I'm trying to use the Facebook protocol
>>> and I'm having some problems. The protocol doesn't connect correctly,
>>> apparently the Facebook API changed and sip-communicator is no longer
>>> able to connect. I made some changes against the trunk and now it
>>> connects successfully, however now it's not able to get the buddy
>>> list. Before going further trying to prepare a patch I'd like to know
>>> if anyone is already working on this protocol.
>>>
>>> br,
>>> Edgar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hello Edgar,

Hi Damien,

thanks for your comments. I think it's a good idea. What's the common
practice in the project, keeping the sources in a subproject of
sip-communicator or create a project in e.g. google code and include
only the binary dependency in sip-communicator?

This really depends on what you need. Right now, I am not quite sure I
understand what it is that you have and that you are wondering about.
Is it a) an implementation of the facebook protocol that is completely
different from ours but that you'd like to use in your own SC fork or
b) improvements to our existing version that you'd like to get
integrated into SC or c) something between the two.

In case of a) then you are of course free to host whatever you wish
wherever you wish, as long as it remains open source, so simply pick
what works best for you. If we are in case b) then it would be best to
send a patch here so that we could apply it to our existing
implementation.

If we are in case c) then we'd need to know more about what it is you
need and would like to achieve.

Cheers,
Emil

···

On Thu, Sep 3, 2009 at 10:59 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

br,
Edgar

On Thu, Sep 3, 2009 at 6:22 PM, Damien Roth<damien.roth@gmail.com> wrote:

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies to
sip-communicator which allow to access Facebook chat service through http.

I have a little suggestion to separate completely the protocol layer and SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication of
classes and facilitate maintenance of the protocol.

Bye

Damien

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:
> Hi,
>
> Thank you very much for your feedback, I'm working on it now and I'll
> create an issue with the patch soon.
>
> br,
> edgar
>
> On Mon, Aug 31, 2009 at 8:56 PM, Lubomir >>> > Marinov<lubomir.marinov@gmail.com> wrote:
>> Hi Edgar,
>>
>> As I see there are no responses from developers working on the
>> Facebook support, I suppose it's appropriate for me to chime in.
>>
>> Thank you for you interest in the Facebook support and in SIP
>> Communicator in general!
>>
>> Our Facebook plug-ins were developed by Dai Zhiwei during Google
>> Summer of Code 2008 and I was his mentor for the second part of the
>> program. I recently integrated his work into trunk. As an year has
>> passed since the plug-ins were originally developed and as you have
>> noticed, they are a little out of shape. We also put a warning in the
>> account registration wizard for the Facebook protocol to convey this
>> state.
>>
>> Judging by the fact that there are still no answers from developers
>> working on the Facebook support and not knowing of anyone working on
>> it myself, I guess that there are no such developers apart from you
>> and that you can safely continue your work.
>>
>> I'd like to assure you that your contribution will be greatly valued
>> and that I will myself look into integrating it into trunk as soon as
>> possible.
>>
>> Regards,
>> Lubomir
>>
>> On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:
>>> Hi,
>>>
>>> First of all thanks for the good work!. My name is Edgar and I am a
>>> new user of sip-communicator, I'm trying to use the Facebook protocol
>>> and I'm having some problems. The protocol doesn't connect correctly,
>>> apparently the Facebook API changed and sip-communicator is no longer
>>> able to connect. I made some changes against the trunk and now it
>>> connects successfully, however now it's not able to get the buddy
>>> list. Before going further trying to prepare a patch I'd like to know
>>> if anyone is already working on this protocol.
>>>
>>> br,
>>> Edgar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#8

Hi Edgar,

I'm a bit hesitant at recommending that start of a completely new project to implement the Facebook chat protocol in Java. The one thing that stops me is the facebook-java-api at http://code.google.com/p/facebook-java-api/ which we've looked at in 2008 but my memory currently doesn't serve me well wrt the problem it had back then. It seems to be very active now and, most importantly, it's listed as the most complete Java implementation on the official Facebook site. Have you looked at it and evaluated it as a possible alternative? I mean it sounds somewhat nice to join an existing project rather than starting a new one. I'm completely oblivious to licenses and I don't know whether the MIT license lives OK with the LGPL...

Regards,
Lubomir

Edgar Poce написа:

···

Hi Damien,

thanks for your comments. I think it's a good idea. What's the common
practice in the project, keeping the sources in a subproject of
sip-communicator or create a project in e.g. google code and include
only the binary dependency in sip-communicator?

br,
Edgar

On Thu, Sep 3, 2009 at 6:22 PM, Damien Roth<damien.roth@gmail.com> wrote:

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies to
sip-communicator which allow to access Facebook chat service through http.

I have a little suggestion to separate completely the protocol layer and SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication of
classes and facilitate maintenance of the protocol.

Bye

Damien

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

Thank you very much for your feedback, I'm working on it now and I'll
create an issue with the patch soon.

br,
edgar

On Mon, Aug 31, 2009 at 8:56 PM, Lubomir >>>> Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

As I see there are no responses from developers working on the
Facebook support, I suppose it's appropriate for me to chime in.

Thank you for you interest in the Facebook support and in SIP
Communicator in general!

Our Facebook plug-ins were developed by Dai Zhiwei during Google
Summer of Code 2008 and I was his mentor for the second part of the
program. I recently integrated his work into trunk. As an year has
passed since the plug-ins were originally developed and as you have
noticed, they are a little out of shape. We also put a warning in the
account registration wizard for the Facebook protocol to convey this
state.

Judging by the fact that there are still no answers from developers
working on the Facebook support and not knowing of anyone working on
it myself, I guess that there are no such developers apart from you
and that you can safely continue your work.

I'd like to assure you that your contribution will be greatly valued
and that I will myself look into integrating it into trunk as soon as
possible.

Regards,
Lubomir

On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Emil,

I don't have a personal preference about the packaging of the Facebook
protocol, I just wanted to contribute a modification to the current
implementation in order to use it myself. It was suggested to
"separate completely the protocol layer and SC" and I wanted to know
what is the common practice in the project to do such separation.

Btw, the sources are already uploaded to the issue tracker, I didn't
prepare a patch because there were many changes that would probably be
difficult to review in a single diff file. However, if you prefer a
diff file I can create one.

br,
Edgar

···

On Thu, Sep 3, 2009 at 11:34 PM, Emil Ivov<emcho@sip-communicator.org> wrote:

Hello Edgar,

On Thu, Sep 3, 2009 at 10:59 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi Damien,

thanks for your comments. I think it's a good idea. What's the common
practice in the project, keeping the sources in a subproject of
sip-communicator or create a project in e.g. google code and include
only the binary dependency in sip-communicator?

This really depends on what you need. Right now, I am not quite sure I
understand what it is that you have and that you are wondering about.
Is it a) an implementation of the facebook protocol that is completely
different from ours but that you'd like to use in your own SC fork or
b) improvements to our existing version that you'd like to get
integrated into SC or c) something between the two.

In case of a) then you are of course free to host whatever you wish
wherever you wish, as long as it remains open source, so simply pick
what works best for you. If we are in case b) then it would be best to
send a patch here so that we could apply it to our existing
implementation.

If we are in case c) then we'd need to know more about what it is you
need and would like to achieve.

Cheers,
Emil

br,
Edgar

On Thu, Sep 3, 2009 at 6:22 PM, Damien Roth<damien.roth@gmail.com> wrote:

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies to
sip-communicator which allow to access Facebook chat service through http.

I have a little suggestion to separate completely the protocol layer and SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication of
classes and facilitate maintenance of the protocol.

Bye

Damien

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:
> Hi,
>
> Thank you very much for your feedback, I'm working on it now and I'll
> create an issue with the patch soon.
>
> br,
> edgar
>
> On Mon, Aug 31, 2009 at 8:56 PM, Lubomir >>>> > Marinov<lubomir.marinov@gmail.com> wrote:
>> Hi Edgar,
>>
>> As I see there are no responses from developers working on the
>> Facebook support, I suppose it's appropriate for me to chime in.
>>
>> Thank you for you interest in the Facebook support and in SIP
>> Communicator in general!
>>
>> Our Facebook plug-ins were developed by Dai Zhiwei during Google
>> Summer of Code 2008 and I was his mentor for the second part of the
>> program. I recently integrated his work into trunk. As an year has
>> passed since the plug-ins were originally developed and as you have
>> noticed, they are a little out of shape. We also put a warning in the
>> account registration wizard for the Facebook protocol to convey this
>> state.
>>
>> Judging by the fact that there are still no answers from developers
>> working on the Facebook support and not knowing of anyone working on
>> it myself, I guess that there are no such developers apart from you
>> and that you can safely continue your work.
>>
>> I'd like to assure you that your contribution will be greatly valued
>> and that I will myself look into integrating it into trunk as soon as
>> possible.
>>
>> Regards,
>> Lubomir
>>
>> On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> wrote:
>>> Hi,
>>>
>>> First of all thanks for the good work!. My name is Edgar and I am a
>>> new user of sip-communicator, I'm trying to use the Facebook protocol
>>> and I'm having some problems. The protocol doesn't connect correctly,
>>> apparently the Facebook API changed and sip-communicator is no longer
>>> able to connect. I made some changes against the trunk and now it
>>> connects successfully, however now it's not able to get the buddy
>>> list. Before going further trying to prepare a patch I'd like to know
>>> if anyone is already working on this protocol.
>>>
>>> br,
>>> Edgar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi Lubomir,

thanks for the info, I didn't know of the existence of that project,
with a quick search I haven't found support to chat, I'll look into it
tomorrow. If it does it probably make sense to integrate that library
instead of the current implementation which still has some rough
edges. If it doesn't I'm okay with the current location of the sources
or whatever you prefer.

br,
Edgar

···

On Fri, Sep 4, 2009 at 12:05 AM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

I'm a bit hesitant at recommending that start of a completely new project to
implement the Facebook chat protocol in Java. The one thing that stops me is
the facebook-java-api at http://code.google.com/p/facebook-java-api/ which
we've looked at in 2008 but my memory currently doesn't serve me well wrt
the problem it had back then. It seems to be very active now and, most
importantly, it's listed as the most complete Java implementation on the
official Facebook site. Have you looked at it and evaluated it as a possible
alternative? I mean it sounds somewhat nice to join an existing project
rather than starting a new one. I'm completely oblivious to licenses and I
don't know whether the MIT license lives OK with the LGPL...

Regards,
Lubomir

Edgar Poce написа:

Hi Damien,

thanks for your comments. I think it's a good idea. What's the common
practice in the project, keeping the sources in a subproject of
sip-communicator or create a project in e.g. google code and include
only the binary dependency in sip-communicator?

br,
Edgar

On Thu, Sep 3, 2009 at 6:22 PM, Damien Roth<damien.roth@gmail.com> wrote:

Hi Edgar,

Good work with the Facebook protocol.

In the issue (722) you wrote : Creation of classes without dependencies
to
sip-communicator which allow to access Facebook chat service through
http.

I have a little suggestion to separate completely the protocol layer and
SC
: you can extract all the classes and place them in a jar.

I've done this with the DICT protocol. It will help to avoid replication
of
classes and facilitate maintenance of the protocol.

Bye

Damien

2009/9/3 Edgar Poce <edgarpoce@gmail.com>

Hi Lubomir,

I've been working in the Facebook protocol, I have a working version
which is a rewrite of the protocol implementation. Despite it wasn't
my initial intention I decided to modify most of the classes in the
package in order to facilitate testing and debugging in a standalone
way.

I'm not sure how the integrate the tests into the build, it's
something pending. However I managed to make the tests to take the
username and password from lib/contacts.properties.

In order to facilitate the review I wrote a summary of the changes in
the issue #722.

br,
edgar

On Tue, Sep 1, 2009 at 9:29 AM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

Thank you very much for your feedback, I'm working on it now and I'll
create an issue with the patch soon.

br,
edgar

On Mon, Aug 31, 2009 at 8:56 PM, Lubomir >>>>> Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

As I see there are no responses from developers working on the
Facebook support, I suppose it's appropriate for me to chime in.

Thank you for you interest in the Facebook support and in SIP
Communicator in general!

Our Facebook plug-ins were developed by Dai Zhiwei during Google
Summer of Code 2008 and I was his mentor for the second part of the
program. I recently integrated his work into trunk. As an year has
passed since the plug-ins were originally developed and as you have
noticed, they are a little out of shape. We also put a warning in the
account registration wizard for the Facebook protocol to convey this
state.

Judging by the fact that there are still no answers from developers
working on the Facebook support and not knowing of anyone working on
it myself, I guess that there are no such developers apart from you
and that you can safely continue your work.

I'd like to assure you that your contribution will be greatly valued
and that I will myself look into integrating it into trunk as soon as
possible.

Regards,
Lubomir

On Mon, Aug 31, 2009 at 3:01 PM, Edgar Poce<edgarpoce@gmail.com> >>>>>> wrote:

Hi,

First of all thanks for the good work!. My name is Edgar and I am a
new user of sip-communicator, I'm trying to use the Facebook protocol
and I'm having some problems. The protocol doesn't connect correctly,
apparently the Facebook API changed and sip-communicator is no longer
able to connect. I made some changes against the trunk and now it
connects successfully, however now it's not able to get the buddy
list. Before going further trying to prepare a patch I'd like to know
if anyone is already working on this protocol.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi Lubo,

Just like what Edgar said, facebook-java-api does not support facebook
chat protocol.

@Edgar
IF you have any trouble with 'hacking' facebook chat protocol,
you can refer to this project:
http://code.google.com/p/pidgin-facebookchat/
and this:
http://trac.adium.im/wiki/GettingNewestAdiumSource

Regards,
Dai

···

On Fri, Sep 4, 2009 at 7:05 AM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

I'm a bit hesitant at recommending that start of a completely new project to
implement the Facebook chat protocol in Java. The one thing that stops me is
the facebook-java-api at http://code.google.com/p/facebook-java-api/ which
we've looked at in 2008 but my memory currently doesn't serve me well wrt
the problem it had back then. It seems to be very active now and, most
importantly, it's listed as the most complete Java implementation on the
official Facebook site. Have you looked at it and evaluated it as a possible
alternative? I mean it sounds somewhat nice to join an existing project
rather than starting a new one. I'm completely oblivious to licenses and I
don't know whether the MIT license lives OK with the LGPL...

Regards,
Lubomir

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hi Dai,

  thanks for the tips.

best regards,
Edgar

···

On Fri, Sep 4, 2009 at 6:11 AM, DaiZW<shinysky1986@gmail.com> wrote:

Hi Lubo,

Just like what Edgar said, facebook-java-api does not support facebook
chat protocol.

@Edgar
IF you have any trouble with 'hacking' facebook chat protocol,
you can refer to this project:
http://code.google.com/p/pidgin-facebookchat/
and this:
http://trac.adium.im/wiki/GettingNewestAdiumSource

Regards,
Dai

On Fri, Sep 4, 2009 at 7:05 AM, Lubomir > Marinov<lubomir.marinov@gmail.com> wrote:

Hi Edgar,

I'm a bit hesitant at recommending that start of a completely new project to
implement the Facebook chat protocol in Java. The one thing that stops me is
the facebook-java-api at http://code.google.com/p/facebook-java-api/ which
we've looked at in 2008 but my memory currently doesn't serve me well wrt
the problem it had back then. It seems to be very active now and, most
importantly, it's listed as the most complete Java implementation on the
official Facebook site. Have you looked at it and evaluated it as a possible
alternative? I mean it sounds somewhat nice to join an existing project
rather than starting a new one. I'm completely oblivious to licenses and I
don't know whether the MIT license lives OK with the LGPL...

Regards,
Lubomir

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net