[sip-comm-dev] facebook protocol, new patch


#1

Hi,

I've been using the facebook protocol and I found some issues, I'll
submit a new patch in a few days.

br,
Edgar

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi,

I submitted a new zip today, please feel free to review it and let me
know if you find issues which require further work.

br,
Edgar

···

On Sat, Sep 5, 2009 at 12:19 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

I've been using the facebook protocol and I found some issues, I'll
submit a new patch in a few days.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Edgar,

Thank you for your contribution! I'll review it in a few days.

In the meantime, should any other developer with commit rights be willing to perform the review and the possible integration into trunk, please feel free to do it and just drop a line here so that we don't duplicate the effort.

Regards,
Lubomir

···

On 7.09.2009 19:05, Edgar Poce wrote:

Hi,

  I submitted a new zip today, please feel free to review it and let me
know if you find issues which require further work.

br,
Edgar

On Sat, Sep 5, 2009 at 12:19 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

I've been using the facebook protocol and I found some issues, I'll
submit a new patch in a few days.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hello Edgar,

Thank you for the contribution! I've committed 20090907-facebook.zip
as r6002 and acknowledged it on our Team and Contributors page.

Since your modifications didn't adhere to our coding convention,
please refer to the Developer Documentation page. Our convention
covers topics such as placement of the opening curly brace, using a
maximum of 80 chars per line, requirement of Javadoc comments.

Wherever I could figure it out, I pasted "@author Edgar Poce". If I've
missed some file or I've gotten it wrong, please send a patch to
correct your authorship.

Because I mostly had to deal with the formatting and the merging of
your modifications with changes to trunk after you submitted your
code, I couldn't completely review the code for correctness, lack of
duplication, optimum performance, etc. but it already took me three
nights so I was anxious to get it in and take a breath. As I noted in
the commit comment of r6002, I fixed an exception thrown upon
application shutdown after it was started with a Facebook account
which was offline and I reapplied a change for releasing an
unnecessary and large retaining of memory caused by
String#substring().

Regards,
Lubomir

···

On Tue, Sep 8, 2009 at 1:21 PM, Lubomir Marinov <lubomir.marinov@gmail.com> wrote:

Hi Edgar,

Thank you for your contribution! I'll review it in a few days.

In the meantime, should any other developer with commit rights be willing to
perform the review and the possible integration into trunk, please feel free
to do it and just drop a line here so that we don't duplicate the effort.

Regards,
Lubomir

On 7.09.2009 19:05, Edgar Poce wrote:

Hi,

I submitted a new zip today, please feel free to review it and let me
know if you find issues which require further work.

br,
Edgar

On Sat, Sep 5, 2009 at 12:19 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

I've been using the facebook protocol and I found some issues, I'll
submit a new patch in a few days.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hello Lubomir,

I'm sincerely sorry about the coding convention, please don't hesitate
to let me know if there's something wrong in a patch before investing
so much effort. I have just downloaded the eclipse coding style from
the website so I hope future contributions to be compliant with the
project conventions, there are a few things I'd like to improve in the
facebook protocol, e.g. persisting buddies in local groups if
possible.
Thanks for the fixes and for your effort!

Best regards,
Edgar

···

On Sun, Sep 20, 2009 at 12:07 AM, Lubomir Marinov <lubomir.marinov@gmail.com> wrote:

Hello Edgar,

Thank you for the contribution! I've committed 20090907-facebook.zip
as r6002 and acknowledged it on our Team and Contributors page.

Since your modifications didn't adhere to our coding convention,
please refer to the Developer Documentation page. Our convention
covers topics such as placement of the opening curly brace, using a
maximum of 80 chars per line, requirement of Javadoc comments.

Wherever I could figure it out, I pasted "@author Edgar Poce". If I've
missed some file or I've gotten it wrong, please send a patch to
correct your authorship.

Because I mostly had to deal with the formatting and the merging of
your modifications with changes to trunk after you submitted your
code, I couldn't completely review the code for correctness, lack of
duplication, optimum performance, etc. but it already took me three
nights so I was anxious to get it in and take a breath. As I noted in
the commit comment of r6002, I fixed an exception thrown upon
application shutdown after it was started with a Facebook account
which was offline and I reapplied a change for releasing an
unnecessary and large retaining of memory caused by
String#substring().

Regards,
Lubomir

On Tue, Sep 8, 2009 at 1:21 PM, Lubomir Marinov > <lubomir.marinov@gmail.com> wrote:

Hi Edgar,

Thank you for your contribution! I'll review it in a few days.

In the meantime, should any other developer with commit rights be willing to
perform the review and the possible integration into trunk, please feel free
to do it and just drop a line here so that we don't duplicate the effort.

Regards,
Lubomir

On 7.09.2009 19:05, Edgar Poce wrote:

Hi,

I submitted a new zip today, please feel free to review it and let me
know if you find issues which require further work.

br,
Edgar

On Sat, Sep 5, 2009 at 12:19 PM, Edgar Poce<edgarpoce@gmail.com> wrote:

Hi,

I've been using the facebook protocol and I found some issues, I'll
submit a new patch in a few days.

br,
Edgar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net