[sip-comm-dev] Extended Call History Search


#1

Hello Max, and Thomas,

I just saw that I had forgotten to ack your effort on our Team and Contributors page so I just did so.

Thanks!
Emil

···

max.bourdon@laposte.net wrote:

heya !

I finally got time to answer your comments. I want to thank
you for your advices.

have a good summer :slight_smile:

Maxime & Thomas.

Hi guys,

thanks for the contribution ! I have tested your plug-in and

it works good.

I have already committed you code on the cvs and just wanted

to let you know

the changes I've made in order to make your code fit better

to Java and SIP

Communicator conventions.

Here are the modifications:

- Added the ExtendedCallHistorySearchMenuItem to the

CONTAINER_TOOLS_MENU -

It wasn't fitting very well in the Call list panel and after

a discussion

with Emil I decided to move it in the Tools menu.

- Added a mnemonic key for the above menu item - To do this

without any

damage to the internationalization I had to change the

Resources file, by

adding a getMnemonic method and changing the existing

getString method.

- Renamed the ExtendedCallHistorySearchPanel to
ExtendedCallHistorySearchDialog, as it extends JDialog and

not JPanel.

- In the ExtendedCallHistorySearchDialog.actionPefrormed

method I have

invoked the history search in a separate thread - The

search operation

could be very slow if we have many records in history, so

it's not a good

idea to block the gui, while waiting for the search to complete.

- In the ExtendedCallHistorySearchDialog removed the

participantName method

- it is replaced by matches(regular expression) method in

class String.

- Refresh call history records each time when the extended

call history

window is shown - when a new call is made the list of

records doesn't

refresh, even if you close the window and reopen it, so I

made a little

enhancement, I refresh the list each time user opens the

window. In the

future we should refresh the list, each time a call is

received or emitted.

- Renamed the callType method to checkCallType - the method

name need to

indicate the action performed in this method.

- have made the search button non expandable - the search

button was getting

all the place on the right when we resize the window and it

wasn't very

nice, so I made it non expandable

- Added some javadoc comments where needed and replaced all

simple comments

for classes and methods by javadoc comments.

I think that's all.

Keep up the good work.

Yana

On 5/25/07, max.bourdon@laposte.net > <max.bourdon@laposte.net> wrote:

Hey guys !

I made a plugin which permits to do a search on the call List
with more options. Have a look below if you want some details.

I. Presentation of the plug-in

The goal of this plugin is to add an extended call history
search option to the call history panel. This extended search
permits to search by dates(since & until), by participant name
and by call direction (incoming / outcoming). You can see the
details here :

"http://www.sip-communicator.org/index.php/Development/CallHistory".

So i'm now going to explain a bit more the plugin :slight_smile:

II. Implementation

I use 2 services. The GUI service and the callHistory service
to get the informations on the calls made by the user. I use
the call history service to get the callRecord only (it
contains the call informations).
In the part III, i explain that it might be great to take more
use of the callHistory service.

I also use a datepicker. After having done searches on the
internet, I have chosen JCalendar (found it here :
"http://www.toedter.com/en/jcalendar/"). It's easy to use and
it looks great (you only need to write a single line
"JDateChooser varName= new JDateChooser();").

Explanation of the classes :

ExtendedCallHistorySearchPanel :

This is our main class plugin in which we configure the search
panel and do search operations.

The other classes are not really interresting. I used and
modified the classes made by Yana for the callList in order to
adapt them to our plugin. So they work as the CallList already
implemented in SC.

III. Things to improve.

I think that one major thing could be improved. I implemented
our own search methods. I mean that there are methods "not
implemented yet" in the call history service as "public
Collection findByPeriod(MetaContact contact, Date startDate,
Date endDate)". It might be a good thing to implement and use
it in the plugin.

I think that there are two more things that can be added. The
first one is a progress search bar on the extended call search
panel. The second one is to add the auto-completion on the
contact name text field.

IV. How to use it?

Look at the file TODO.txt in the archive.

Finally , if you have any advices on our code implementation,
tell us. We need to improve our java skills. :smiley:

Thanks for your time,

Maxime and Thomas

Cr�ez votre adresse �lectronique prenom.nom@laposte.net
1 Go d'espace de stockage, anti-spam et anti-virus int�gr�s.

---------------------------------------------------------------------

To unsubscribe, e-mail:

dev-unsubscribe@sip-communicator.dev.java.net

For additional commands, e-mail:

dev-help@sip-communicator.dev.java.net

See you soon !

Cr�ez votre adresse �lectronique prenom.nom@laposte.net 1 Go d'espace de stockage, anti-spam et anti-virus int�gr�s.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net