[sip-comm-dev] contactList, MetaContacts


#1

Hi,

I have written a plugin, that loads all the contacts of our company's
address books into the contactList of SC (as SIP contacts).

There are now many contacts (persons) that have more then one number.

I have added them as MetaContacts to the list, each with their different
numbers as contacts of this MetaContact. Those numbers are all shown on
the UI (in the toolTip an on right-click).

Now, how can I choose which one I want to call? Is there an option
anywhere? I think if I just press the "call" button, the "default" one
is chosen (by MetaContact.getDefaultContact). But it is not clear
(visible) to the user, which account this will be (until the number is
dialled and it is shown in the call panel).

A second question: Is it right, that I cannot add two contacts that have
the same contactID? For example, I have two persons working at a
company. Both of them have an entry in my address book, both with the
same number. Now I can add the first person, but not the second one, as
the contactID (the phone number) already exists.
Is it somehow possible to have two contacts with the same contactID?

Thanks,
Sebastian

···

--
/**
* Sebastian Heib
* Software Developer
*
* Synyx GmbH & Co. KG
* Business in Components
* Karlstr. 68
* 76137 Karlsruhe
*
* phone +49(0)721 66 24 866
* fax +49(0)721 66 48 877
* eMail heib@synyx.de
* www http://www.synyx.de
* irc irc.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 4793
* USt-IdNr.: DE249264296
*
* Komplement�rin: Elatech Verwaltungs GmbH
* Sitz der Gesellschaft: Karlsruhe
* Gesch�ftsf�hrer: Markus Daniel
* Registergericht: Mannheim
* Handelsregisternummer: HRB 7250
*/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi,

Now, how can I choose which one I want to call? Is there an option
anywhere?

I have written a patch for that purpose.

Now instead of the "call" menu item in the contactRightButtonMenu, a
subMenu is shown (similar to the "removeContact" submenu) , where the
user can choose which actual contact (of this metaContact) should be called.

See the patch attached to this email :slight_smile:

Regards,
Sebastian

ContactRightButtonMenu.java.patch (6 KB)

···

--
/**
* Sebastian Heib
* Software Developer
*
* Synyx GmbH & Co. KG
* Business in Components
* Karlstr. 68
* 76137 Karlsruhe
*
* phone +49(0)721 66 24 866
* fax +49(0)721 66 48 877
* eMail heib@synyx.de
* www http://www.synyx.de
* irc irc.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 4793
* USt-IdNr.: DE249264296
*
* Komplement�rin: Elatech Verwaltungs GmbH
* Sitz der Gesellschaft: Karlsruhe
* Gesch�ftsf�hrer: Markus Daniel
* Registergericht: Mannheim
* Handelsregisternummer: HRB 7250
*/


#3

Hey Sebastien,

I guess I missed this one back when you first sent it. Sounds quite
cool! What kind of address book are you using? Are you interested in
contributing it?

Cheers
Emil

Sebastian Heib написа:

···

Hi,

I have written a plugin, that loads all the contacts of our company's
address books into the contactList of SC (as SIP contacts).

There are now many contacts (persons) that have more then one number.

I have added them as MetaContacts to the list, each with their different
numbers as contacts of this MetaContact. Those numbers are all shown on
the UI (in the toolTip an on right-click).

Now, how can I choose which one I want to call? Is there an option
anywhere? I think if I just press the "call" button, the "default" one
is chosen (by MetaContact.getDefaultContact). But it is not clear
(visible) to the user, which account this will be (until the number is
dialled and it is shown in the call panel).

A second question: Is it right, that I cannot add two contacts that have
the same contactID? For example, I have two persons working at a
company. Both of them have an entry in my address book, both with the
same number. Now I can add the first person, but not the second one, as
the contactID (the phone number) already exists.
Is it somehow possible to have two contacts with the same contactID?

Thanks,
Sebastian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hey Sebastian,

I am currently going through uncommitted patches and I stumbled on this
one (about time wasn't it :wink: ). Thanks for sending it over! The idea is
quite nice so I was wondering whether you'd like to take it a bit further:

1. A user can only call subcontacts which come from a protocol provider
that supports the OperationSetBasicTelephony. It is therefore better to
only include such contacts in your submenu.

2. The submenu is only necessary in case we have more than one callable
contact in a meta contact. In cases where there is only one such contact
it would be nice if we placed it directly into the top level menu. If
there are more we add the submenu.

Interested in implementing this?

Cheers
Emil

Sebastian Heib написа:

···

Hi,

Now, how can I choose which one I want to call? Is there an option
anywhere?

I have written a patch for that purpose.

Now instead of the "call" menu item in the contactRightButtonMenu, a
subMenu is shown (similar to the "removeContact" submenu) , where the
user can choose which actual contact (of this metaContact) should be called.

See the patch attached to this email :slight_smile:

Regards,
Sebastian

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Emil Ivov schrieb:

Hey Sebastian,

I am currently going through uncommitted patches and I stumbled on this
one (about time wasn't it :wink: ). Thanks for sending it over! The idea is
quite nice so I was wondering whether you'd like to take it a bit further:

1. A user can only call subcontacts which come from a protocol provider
that supports the OperationSetBasicTelephony. It is therefore better to
only include such contacts in your submenu.

2. The submenu is only necessary in case we have more than one callable
contact in a meta contact. In cases where there is only one such contact
it would be nice if we placed it directly into the top level menu. If
there are more we add the submenu.

Interested in implementing this?

I'll have a look at it and send another patch as soon as I get the time
to implement and test it.

Sebastian

···

Cheers
Emil

Sebastian Heib написа:

Hi,

Now, how can I choose which one I want to call? Is there an option
anywhere?

I have written a patch for that purpose.

Now instead of the "call" menu item in the contactRightButtonMenu, a
subMenu is shown (similar to the "removeContact" submenu) , where the
user can choose which actual contact (of this metaContact) should be called.

See the patch attached to this email :slight_smile:

Regards,
Sebastian

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
/**
* Sebastian Heib
* Software Developer
*
* Synyx GmbH & Co. KG
* Business in Components
* Karlstr. 68
* 76137 Karlsruhe
*
* phone +49(0)721 66 24 866
* fax +49(0)721 66 48 877
* eMail heib@synyx.de
* www http://www.synyx.de
* irc irc.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 4793
* USt-IdNr.: DE249264296
*
* Komplementärin: Elatech Verwaltungs GmbH
* Sitz der Gesellschaft: Karlsruhe
* Geschäftsführer: Markus Daniel
* Registergericht: Mannheim
* Handelsregisternummer: HRB 7250
*/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi,

here is the new patch for the contactRightButtonMenu. It now only
includes subcontacts in the call menu that support the
OperationSetBasicTelephony. If there is only one subcontact that
supports it the call item is in the top level menu (just as it is at the
moment)

Sebastian

Emil Ivov schrieb:

ContactRightButtonMenu.java.patch (4.42 KB)

···

Thanks!

Sebastian Heib написа:

Emil Ivov schrieb:

Hey Sebastian,

I am currently going through uncommitted patches and I stumbled on this
one (about time wasn't it :wink: ). Thanks for sending it over! The idea is
quite nice so I was wondering whether you'd like to take it a bit further:

1. A user can only call subcontacts which come from a protocol provider
that supports the OperationSetBasicTelephony. It is therefore better to
only include such contacts in your submenu.

2. The submenu is only necessary in case we have more than one callable
contact in a meta contact. In cases where there is only one such contact
it would be nice if we placed it directly into the top level menu. If
there are more we add the submenu.

Interested in implementing this?

I'll have a look at it and send another patch as soon as I get the time
to implement and test it.

Sebastian

Cheers
Emil

Sebastian Heib написа:

Hi,

Now, how can I choose which one I want to call? Is there an option
anywhere?

I have written a patch for that purpose.

Now instead of the "call" menu item in the contactRightButtonMenu, a
subMenu is shown (similar to the "removeContact" submenu) , where the
user can choose which actual contact (of this metaContact) should be called.

See the patch attached to this email :slight_smile:

Regards,
Sebastian

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
/**
* Sebastian Heib
* Software Developer
*
* Synyx GmbH & Co. KG
* Business in Components
* Karlstr. 68
* 76137 Karlsruhe
*
* phone +49(0)721 66 24 866
* fax +49(0)721 66 48 877
* eMail heib@synyx.de
* www http://www.synyx.de
* irc irc.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 4793
* USt-IdNr.: DE249264296
*
* Komplementärin: Elatech Verwaltungs GmbH
* Sitz der Gesellschaft: Karlsruhe
* Geschäftsführer: Markus Daniel
* Registergericht: Mannheim
* Handelsregisternummer: HRB 7250
*/


#7

Hey Sebastian,

Just tested it and it works just fine! Thanks for contributing!

Applied, committed and acked.

Cheers
Emil

Sebastian Heib написа:

···

Hi,

here is the new patch for the contactRightButtonMenu. It now only
includes subcontacts in the call menu that support the
OperationSetBasicTelephony. If there is only one subcontact that
supports it the call item is in the top level menu (just as it is at the
moment)

Sebastian

Emil Ivov schrieb:

Thanks!

Sebastian Heib написа:

Emil Ivov schrieb:

Hey Sebastian,

I am currently going through uncommitted patches and I stumbled on this
one (about time wasn't it :wink: ). Thanks for sending it over! The idea is
quite nice so I was wondering whether you'd like to take it a bit further:

1. A user can only call subcontacts which come from a protocol provider
that supports the OperationSetBasicTelephony. It is therefore better to
only include such contacts in your submenu.

2. The submenu is only necessary in case we have more than one callable
contact in a meta contact. In cases where there is only one such contact
it would be nice if we placed it directly into the top level menu. If
there are more we add the submenu.

Interested in implementing this?

I'll have a look at it and send another patch as soon as I get the time
to implement and test it.

Sebastian

Cheers
Emil

Sebastian Heib написа:

Hi,

Now, how can I choose which one I want to call? Is there an option
anywhere?

I have written a patch for that purpose.

Now instead of the "call" menu item in the contactRightButtonMenu, a
subMenu is shown (similar to the "removeContact" submenu) , where the
user can choose which actual contact (of this metaContact) should be called.

See the patch attached to this email :slight_smile:

Regards,
Sebastian

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net