[sip-comm-dev] Compilation Warnings


#1

Dear SIP Communicator developers,

I'm looking at the compilation warnings in Eclipse SDK 3.4M6a with
compiler compliance level set to 1.5 and I see there're thousands of
them. I ignored a great deal i.e. the ones related to usage of raw
types but there're others warning about null pointer access, variable
assignments with no effect, unread fields, etc. Regarding the
legitimate warnings, I have the following questions:

- Is there interest in fixing them?

- If they're to be fixed, how should the patches be separated: by
modified file, by warning type or some other rule?

Thanks,
Lubomir Marinov

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Liubo,

Lubomir Marinov wrote:

Dear SIP Communicator developers,

I'm looking at the compilation warnings in Eclipse SDK 3.4M6a with
compiler compliance level set to 1.5 and I see there're thousands of
them. I ignored a great deal i.e. the ones related to usage of raw
types but there're others warning about null pointer access, variable
assignments with no effect, unread fields, etc. Regarding the
legitimate warnings, I have the following questions:

- Is there interest in fixing them?

Yes, absolutely. These have been causing a lot of confusion lately and I remember seeing at least three lated posts on dev during the last month.

- If they're to be fixed, how should the patches be separated: by
modified file, by warning type or some other rule?

Well, we generally expect people to send them all in a single file (as mentioned here: http://www.sip-communicator.org/index.php/Documentation/FAQ#patch ) but we don't really mind if they come in separate files so it's mostly up to you.

Cheers,
Yana

···

Thanks,
Lubomir Marinov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net