[sip-comm-dev] CANCEL bug


#1

Jeroen,

Thanks for your answer. You are saying that "the client should not insert the header in the first place".
As far as I understand this is done in Suns reference implementation of SIP. In OperationSetBasicTelephonySipImpl, in the method sayCancel (ClientTransaction is part of the reference implementation):
            Request cancel = clientTransaction.createCancel();
            ClientTransaction cancelTransaction = callParticipant
                .getJainSipProvider().getNewClientTransaction(cancel);
            cancelTransaction.sendRequest();

So, do you think this bug should be addressed there (https://jain-sip.dev.java.net/)?

Regards,

Hans

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hans,

I submitted the bug, fixed the code and updated jain-sip CVS. Please update your jain-sip library to the latest source to check if this resolves your issue

Regards,
Jeroen

Hans Holmlund wrote:

···

Jeroen,

Thanks for your answer. You are saying that "the client should not insert the header in the first place".
As far as I understand this is done in Suns reference implementation of SIP. In OperationSetBasicTelephonySipImpl, in the method sayCancel (ClientTransaction is part of the reference implementation):
           Request cancel = clientTransaction.createCancel();
           ClientTransaction cancelTransaction = callParticipant
               .getJainSipProvider().getNewClientTransaction(cancel);
           cancelTransaction.sendRequest();

So, do you think this bug should be addressed there (https://jain-sip.dev.java.net/)?

Regards,

Hans

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Just did and it seemed to work for me here (i.e. no authorization ). Can
anyone please else confirm that the issue is resolved?

Emil

Jeroen van Bemmel написа:

···

Hans,

I submitted the bug, fixed the code and updated jain-sip CVS. Please
update your jain-sip library to the latest source to check if this
resolves your issue

Regards,
Jeroen

Hans Holmlund wrote:

Jeroen,

Thanks for your answer. You are saying that "the client should not
insert the header in the first place".
As far as I understand this is done in Suns reference implementation
of SIP. In OperationSetBasicTelephonySipImpl, in the method sayCancel
(ClientTransaction is part of the reference implementation):
           Request cancel = clientTransaction.createCancel();
           ClientTransaction cancelTransaction = callParticipant
               .getJainSipProvider().getNewClientTransaction(cancel);
           cancelTransaction.sendRequest();

So, do you think this bug should be addressed there
(https://jain-sip.dev.java.net/)?

Regards,

Hans

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hit send too early,

By "just did it" I meant to say that I've just committed jain-sip's
latest version and you would be using it with builds 1022 and on.

It would still be nice if someone else could confirm though.

Cheers
EMil

Emil Ivov написа:

···

Just did and it seemed to work for me here (i.e. no authorization ). Can
anyone please else confirm that the issue is resolved?

Emil

Jeroen van Bemmel написа:

Hans,

I submitted the bug, fixed the code and updated jain-sip CVS. Please
update your jain-sip library to the latest source to check if this
resolves your issue

Regards,
Jeroen

Hans Holmlund wrote:

Jeroen,

Thanks for your answer. You are saying that "the client should not
insert the header in the first place".
As far as I understand this is done in Suns reference implementation
of SIP. In OperationSetBasicTelephonySipImpl, in the method sayCancel
(ClientTransaction is part of the reference implementation):
           Request cancel = clientTransaction.createCancel();
           ClientTransaction cancelTransaction = callParticipant
               .getJainSipProvider().getNewClientTransaction(cancel);
           cancelTransaction.sendRequest();

So, do you think this bug should be addressed there
(https://jain-sip.dev.java.net/)?

Regards,

Hans

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net