[sip-comm-dev] CallParticipantPanel and secure button


#1

Hi Lubomir,

In order to add the secure button to the Call panel, I've modified CallParticipantPanel.java. I especially modify some attributes (contactPanel, photoLabel and namePanel sizes) in:
"public CallParticipantPanel(CallParticipant callParticipant)"

that were initialized in:
"public CallParticipantPanel(String participantName)"

I had to do this trick because the secure button and label are only added if the OperationSetSecureTelephony is set, but I cannot test this easily from the latter. Let me know if it sounds OK to you.

Cheers,

···

--
Romain KUNTZ
kuntz@lsiit.u-strasbg.fr
LSIIT - Networks and Protocols Team
http://clarinet.u-strasbg.fr/~kuntz/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Romain,

Thank you for asking!

While I certainly don't consider myself an authority on the subject,
the changes seem OK to me.

The only glitch I see, though I'm still not sure it's related to your
changes, is the non-transparent background around and between the
transfer and secure buttons as shown in the attached call.png. It can
easily be seen by looking for the image underneath these buttons. The
other two buttons don't seem to have this problem and the image can be
seen between them while the image cannot be ween between the transfer
and secure buttons.

Best regards,
Lubo

···

On Tue, Oct 7, 2008 at 12:28 PM, Romain KUNTZ <kuntz@lsiit.u-strasbg.fr> wrote:

Hi Lubomir,

In order to add the secure button to the Call panel, I've modified
CallParticipantPanel.java. I especially modify some attributes
(contactPanel, photoLabel and namePanel sizes) in:
"public CallParticipantPanel(CallParticipant callParticipant)"

that were initialized in:
"public CallParticipantPanel(String participantName)"

I had to do this trick because the secure button and label are only added if
the OperationSetSecureTelephony is set, but I cannot test this easily from
the latter. Let me know if it sounds OK to you.

Cheers,
--
Romain KUNTZ
kuntz@lsiit.u-strasbg.fr
LSIIT - Networks and Protocols Team
http://clarinet.u-strasbg.fr/~kuntz/


#3

Hi Lubomir,

While I certainly don't consider myself an authority on the subject,
the changes seem OK to me.

Ok thanks, so I'll leave it as it is for now.

The only glitch I see, though I'm still not sure it's related to your
changes, is the non-transparent background around and between the
transfer and secure buttons as shown in the attached call.png. It can
easily be seen by looking for the image underneath these buttons. The
other two buttons don't seem to have this problem and the image can be
seen between them while the image cannot be ween between the transfer
and secure buttons.

That is weird, I don't have such glitch on MacOSX (see the enclosed picture). Does any one on Linux/windows can tell us if the problem appears on their side?

Cheers,
romain

···

On 2008/10/07, at 12:13, Lubomir Marinov wrote: