[sip-comm-dev] build.xml cleanup (was: Mystery plugin error)


#1

Hi,

I haven't timed it, but
deploying a few JARs from one directory to another shouldn't be too
costly. Moreover, it would avoid to have the same classes twice in the
svn repo.

Agreed. Would you like to change build.xml so that generation of the
log4j bundle would be executed on every make?

Yes. Actually that was already in the 'build_xml_fixes.patch', in the
new target 'deploy-lib-bundles'. Attached is the same patch but:
- updated for trunk revision 4403
- without the "no bundle name" manifest fix you've already committed
- the 'ant clean' part is commented out since the targets
'bundle-servicebinder' and 'bundle-architectureviewer' are broken
(missing JARs).

Besides, we seem to be
including the lib in some of our other bundles which is redundant and
they should also be using the standalone bundle. Want to change this too?

OK. I'll take care of that in another patch to come.

However, as it's a different issue, I've attached a patch which only
solves the "no bundle name" problem. Don't forget to run "ant
bundle-log4j" after you apply it ;). Tested on svn revision 4398.

Commited and acked! Thanks Seb!

It seems you forgot "ant bundle-log4j" :wink:

Cheers,

regenerate_lib_bundle.patch (3.03 KB)

···

On Mon, Sep 8, 2008 at 2:48 PM, Emil Ivov <emcho@sip-communicator.org> wrote:

--
Sébastien Mazy


#2

Hey Seb,

Sébastien Mazy написа:

Hi,

I haven't timed it, but
deploying a few JARs from one directory to another shouldn't be too
costly. Moreover, it would avoid to have the same classes twice in the
svn repo.

Agreed. Would you like to change build.xml so that generation of the
log4j bundle would be executed on every make?

Yes. Actually that was already in the 'build_xml_fixes.patch',
in the new target 'deploy-lib-bundles'. Attached is the same patch but:

I am sorry, I wasn't clear enough. lib/bundle was meant to contain
bundles that are provided by third parties and that should live on SVN.
It is in other words a somewhat "static" directory. All bundles that we
generate during our build process should go to sip-communicator/sc-bundles.

- updated for trunk revision 4403

It appears that Yana submitted her changes some 20 minutes before your
patch came in so it's currently out of sync. Could you please regenerate
it against the latest revision? Also, you don't need an extra target for
these bundles and can simply include them as a dependancy for the
bundles target like all the other bundles.

- without the "no bundle name" manifest fix you've already committed
- the 'ant clean' part is commented out since the targets
'bundle-servicebinder' and 'bundle-architectureviewer' are broken
(missing JARs).

You can remove the targets that deal with these two.

Besides, we seem to be
including the lib in some of our other bundles which is redundant and
they should also be using the standalone bundle. Want to change this too?

OK. I'll take care of that in another patch to come.

Thanks!

It seems you forgot "ant bundle-log4j" :wink:

We don't really need to do this since we are now supposed to have it
regenerated on every build, do we?

Cheers
Emil

···

On Mon, Sep 8, 2008 at 2:48 PM, Emil Ivov <emcho@sip-communicator.org> wrote:

Cheers,

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net