I haven't timed it, but
deploying a few JARs from one directory to another shouldn't be too
costly. Moreover, it would avoid to have the same classes twice in the
Agreed. Would you like to change build.xml so that generation of the
log4j bundle would be executed on every make?
Yes. Actually that was already in the 'build_xml_fixes.patch', in the
new target 'deploy-lib-bundles'. Attached is the same patch but:
- updated for trunk revision 4403
- without the "no bundle name" manifest fix you've already committed
- the 'ant clean' part is commented out since the targets
'bundle-servicebinder' and 'bundle-architectureviewer' are broken
Besides, we seem to be
including the lib in some of our other bundles which is redundant and
they should also be using the standalone bundle. Want to change this too?
OK. I'll take care of that in another patch to come.
However, as it's a different issue, I've attached a patch which only
solves the "no bundle name" problem. Don't forget to run "ant
bundle-log4j" after you apply it ;). Tested on svn revision 4398.
Commited and acked! Thanks Seb!
It seems you forgot "ant bundle-log4j"
regenerate_lib_bundle.patch (3.03 KB)
On Mon, Sep 8, 2008 at 2:48 PM, Emil Ivov <email@example.com> wrote: