[sip-comm-dev] Bug with the SC call records ??


#1

Good evening,

I noticed while I was trying to make a patch in order to implement some
empty methods of the CallPanel which makes it act as a
CallParticipantListener that there might be a serious bug in the
CallRecords ; namely I think there is a difference between the records
from the call history and those from the GUI, so that the call history
takes the participant addresses in consideration, while the ones
generated by the GUI take the participant names in consideration.

This leads to a display difference in the call list after a Sip
Communicator restart in the old version I currently develop on.

Even if I noticed this behavior on an old version, the clues that drew
my attention are still present in the current CVS code :
impl.gui.main.call.CallPanel.java : new
GuiCallParticipantRecord(participantPanel.getParticipantName()....
impl.callhistory.CallHistoryServiceImpl.java : new
CallParticipantRecordImpl(callParticipant.getAddress()....

So I think that it would be better that someone who better knows these
implementations than I (poorly) do could look if I'm right.

Moreover, I noticed sometimes the same kind of disagreements on call
durations (I mean before/after SC restart), but I'm not sure that it
doesn't come from my IAX stack yet.

Sincerely,

Jean-Marie HEITZ

PS : If someone has an idea about why Asterisk provides an empty (length
0) Calling number Information Element in a NEW message while the caller
that makes the call transit through Asterisk provides this information,
please let me know... thanks.

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hello Jean-Marie,

HEITZ Jean-Marie wrote:

Good evening,

I noticed while I was trying to make a patch in order to implement some
empty methods of the CallPanel which makes it act as a
CallParticipantListener that there might be a serious bug in the
CallRecords ; namely I think there is a difference between the records
from the call history and those from the GUI, so that the call history
takes the participant addresses in consideration, while the ones
generated by the GUI take the participant names in consideration.

Good catch!

This leads to a display difference in the call list after a Sip
Communicator restart in the old version I currently develop on.

Even if I noticed this behavior on an old version, the clues that drew
my attention are still present in the current CVS code :
impl.gui.main.call.CallPanel.java : new
GuiCallParticipantRecord(participantPanel.getParticipantName()....
impl.callhistory.CallHistoryServiceImpl.java : new
CallParticipantRecordImpl(callParticipant.getAddress()....

In fact the problem isn't exactly in these two lines, as you could see the GuiCallParticipantRecord takes the "participantName" from the participantPanel, which is different from the callParticipant object. I mean that the "participantName" in the participant panel is just a String that is set from outside. The problem was coming from the fact that when creating the call participant panel in the gui we take the callParticipant.getDisplayName(). I've just changed that and the problem is fixed now.

Thanks for the note:)

Regards,
Yana

···

So I think that it would be better that someone who better knows these
implementations than I (poorly) do could look if I'm right.

Moreover, I noticed sometimes the same kind of disagreements on call
durations (I mean before/after SC restart), but I'm not sure that it
doesn't come from my IAX stack yet.

Sincerely,

Jean-Marie HEITZ

PS : If someone has an idea about why Asterisk provides an empty (length
0) Calling number Information Element in a NEW message while the caller
that makes the call transit through Asterisk provides this information,
please let me know... thanks.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net