Hi,
Summary:
Libjitsi_notFix_proof_of_concept_to_get_green_icon_when_launching_multi_stream_video_and_audio.patch (1.78 KB)
···
-------------
I have the same issue as presented in this post
http://lists.jitsi.org/pipermail/users/2013-May/003995.html
Once the first ZRTP session as been confirmed by both party:
Actual behavior:
Launching a video call show zrtp green then *yellow*.
Launching an audio call show zrtp green, adding the video show zrtp green
Expected behavior:
Launching a Video call show zrtp green.
Launching an audio call show zrtp green, adding the video show zrtp green
Attached screenshot and proof of concept patch.
I'd be happy to work on a proper pull request for this issue with some help
if it is a real bug (reproduced).
Best Regards,
Jean-Philippe.
Details:
------------
I just started using Jitsi.
What i discovered so far (to take with a grain of salt as my
setup/understanding might not be correct):
We both setup Jitsi, and called each other for the 1st time.
I think we did what was asked: Exchange sas, confirm and the lock was
showing green for both of us.
From then on every times we video called each others, the lock icon was
yellow, and could only become green by clicking 'Clear' then confirm.
(I also reproduced this behavior between a debug session in eclipse and my
normal jitsi on the same windows computer)
It is now my understanding that this is not Jitsi's expected behavior.
It is quite confusing particularly for new users.
There is a potential work around:
- When Launching a conversation (voice only) => ZRTP green
- "Upgrading" it to add video => ZRTP remain green.
Too much details:
------------------------
I've attached a patch with context. When running this new code, the zrtp
icon remain green, but it most likely break something (maybe SDES).
It is a partial revert of jitsi change
7e4b28aabf4d5dfc42e698832171499a43c91ecf
(it was not yet in the libjitsi at the time)
What lead me to this patch is the comment that appears at the top of the
patch's context, as well as the code being the same in the two branches of
the if.
I'd be very happy to contribute a proper pull request on github, but i'll
most likely need quite a bit of help to be sure I am not breaking security.