[jitsi-users] User login with dot


#1

Hi,

Jitsi meet is working pretty well, thanks for that job !

Unfortunately i have raised a issue (#1063) :
When a user have a login with dot inside like "firstName.lastName@domain"
and when another user login then an exception is raised.

In the browser console :
Logger.js:89 [JitsiMeetJS.js] <Object.getGlobalOnErrorHandler>: UnhandledError: null Script: null Line: null Column: null StackTrace: Error: Strophe: error: Cannot read property 'querySelector' of undefined
and
Logger.js:89[modules/xmpp/strophe.util.js] <Object.Strophe.log>: Strophe: error: Cannot read property 'querySelector' of undefined
TypeError: Cannot read property 'querySelector' of undefined
at a.setDisplayName (https://advid.ovh/libs/app.bundle.min.js?v=1338:40:29355)

The error is located near :
i.className="displayname",$("#"+this.videoSpanId)[0].querySelector(".videocontainer....
I expect that the jQuery selector does not retrieve $("#"+this.videoSpanId) because jQuery interprets the dot (may looking for a class).

I think the dot must be escaped.

I can help to correct that.
I just don't know how to construct my dev environment.

Thanks


#2

Hi,

The dot problem is known and we will work on fixing it, but I cannot
give an estimate. Patches are welcome.

To setup dev environment:
1. apt-get install jitsi-meet
2. Confirm it works
3. Checkout jitsi-meet
4. npm install
5. make
6. Change in you nginx config the root to point to your checkout
jitsi-meet, not /usr/share/jitsi-meet and restart nginx.

Regards
damencho

···

On Fri, Oct 28, 2016 at 7:24 AM, David MARQUET <marquetd@gmail.com> wrote:

Hi,

Jitsi meet is working pretty well, thanks for that job !

Unfortunately i have raised a issue (#1063) :
When a user have a login with dot inside like "firstName.lastName@domain"
and when another user login then an exception is raised.

In the browser console :
Logger.js:89 [JitsiMeetJS.js] <Object.getGlobalOnErrorHandler>:
UnhandledError: null Script: null Line: null Column: null StackTrace:
Error: Strophe: error: Cannot read property 'querySelector' of undefined
and
Logger.js:89[modules/xmpp/strophe.util.js] <Object.Strophe.log>: Strophe:
error: Cannot read property 'querySelector' of undefined
TypeError: Cannot read property 'querySelector' of undefined
    at a.setDisplayName
(https://advid.ovh/libs/app.bundle.min.js?v=1338:40:29355)

The error is located near :
i.className="displayname",$("#"+this.videoSpanId)[0].querySelector(".videocontainer....
I expect that the jQuery selector does not retrieve $("#"+this.videoSpanId)
because jQuery interprets the dot (may looking for a class).

I think the dot must be escaped.

I can help to correct that.
I just don't know how to construct my dev environment.

Thanks

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users


#3

Hi Damencho,

thanks for your response.

I have a fix (it works after that but i don't know if there is any other impact)

In RemoteVideo.js, i just add the line :
this.videoSpanId = this.videoSpanId.replace(/\./g, '-');

just after :
this.videoSpanId = `participant_${this.id}`;

I appreciate your background to measure the impact.

Thanks

David MARQUET
Hi,

The dot problem is known and we will work on fixing it, but I cannot
give an estimate. Patches are welcome.

To setup dev environment:
1. apt-get install jitsi-meet
2. Confirm it works
3. Checkout jitsi-meet
4. npm install
5. make
6. Change in you nginx config the root to point to your checkout
jitsi-meet, not /usr/share/jitsi-meet and restart nginx.

Regards
damencho

···

Le 28/10/2016 19:18:29, Damian Minkov <damencho@jitsi.org> a écrit :

On Fri, Oct 28, 2016 at 7:24 AM, David MARQUET wrote:

Hi,

Jitsi meet is working pretty well, thanks for that job !

Unfortunately i have raised a issue (#1063) :
When a user have a login with dot inside like "firstName.lastName@domain"
and when another user login then an exception is raised.

In the browser console :
Logger.js:89 [JitsiMeetJS.js] :
UnhandledError: null Script: null Line: null Column: null StackTrace:
Error: Strophe: error: Cannot read property 'querySelector' of undefined
and
Logger.js:89[modules/xmpp/strophe.util.js] : Strophe:
error: Cannot read property 'querySelector' of undefined
TypeError: Cannot read property 'querySelector' of undefined
at a.setDisplayName
(https://advid.ovh/libs/app.bundle.min.js?v=1338:40:29355)

The error is located near :
i.className="displayname",$("#"+this.videoSpanId)[0].querySelector(".videocontainer....
I expect that the jQuery selector does not retrieve $("#"+this.videoSpanId)
because jQuery interprets the dot (may looking for a class).

I think the dot must be escaped.

I can help to correct that.
I just don't know how to construct my dev environment.

Thanks

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users


#4

Hi Damencho,

i have a last question.
Is it possible to use a non-minimize and non aggregated js scripts in my development environnement in order to debug it easily ?

Thanks,

David MARQUET
Hi Damencho,

thanks for your response.

I have a fix (it works after that but i don't know if there is any other impact)

In RemoteVideo.js, i just add the line :
this.videoSpanId = this.videoSpanId.replace(/\./g, '-');

just after :
this.videoSpanId = `participant_${this.id}`;

I appreciate your background to measure the impact.

Thanks

David MARQUET
Hi,

The dot problem is known and we will work on fixing it, but I cannot
give an estimate. Patches are welcome.

To setup dev environment:
1. apt-get install jitsi-meet
2. Confirm it works
3. Checkout jitsi-meet
4. npm install
5. make
6. Change in you nginx config the root to point to your checkout
jitsi-meet, not /usr/share/jitsi-meet and restart nginx.

Regards
damencho

···

Le 28/10/2016 19:29:05, David MARQUET <marquetd@gmail.com> a écrit :
Le 28/10/2016 19:18:29, Damian Minkov <damencho@jitsi.org> a écrit :

On Fri, Oct 28, 2016 at 7:24 AM, David MARQUET wrote:

Hi,

Jitsi meet is working pretty well, thanks for that job !

Unfortunately i have raised a issue (#1063) :
When a user have a login with dot inside like "firstName.lastName@domain"
and when another user login then an exception is raised.

In the browser console :
Logger.js:89 [JitsiMeetJS.js] :
UnhandledError: null Script: null Line: null Column: null StackTrace:
Error: Strophe: error: Cannot read property 'querySelector' of undefined
and
Logger.js:89[modules/xmpp/strophe.util.js] : Strophe:
error: Cannot read property 'querySelector' of undefined
TypeError: Cannot read property 'querySelector' of undefined
at a.setDisplayName
(https://advid.ovh/libs/app.bundle.min.js?v=1338:40:29355)

The error is located near :
i.className="displayname",$("#"+this.videoSpanId)[0].querySelector(".videocontainer....
I expect that the jQuery selector does not retrieve $("#"+this.videoSpanId)
because jQuery interprets the dot (may looking for a class).

I think the dot must be escaped.

I can help to correct that.
I just don't know how to construct my dev environment.

Thanks

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users


#5

Hi,

Yep, you can. You can remove from "-p" of webpack in
lib-jitsi-meet(package.json) and jitsi-meet(Makefile) and you also
need to modify the index.html to use those files, but not the
minimized.

Regards
damencho

···

On Sun, Nov 6, 2016 at 11:55 AM, David MARQUET <marquetd@gmail.com> wrote:

Hi Damencho,

i have a last question.
Is it possible to use a non-minimize and non aggregated js scripts in my
development environnement in order to debug it easily ?

Thanks,

David MARQUET

Le 28/10/2016 19:29:05, David MARQUET <marquetd@gmail.com> a écrit :

Hi Damencho,

thanks for your response.

I have a fix (it works after that but i don't know if there is any other
impact)

In RemoteVideo.js, i just add the line :
this.videoSpanId = this.videoSpanId.replace(/\./g, '-');

just after :
this.videoSpanId = `participant_${this.id}`;

I appreciate your background to measure the impact.

Thanks

David MARQUET

Le 28/10/2016 19:18:29, Damian Minkov <damencho@jitsi.org> a écrit :

Hi,

The dot problem is known and we will work on fixing it, but I cannot
give an estimate. Patches are welcome.

To setup dev environment:
1. apt-get install jitsi-meet
2. Confirm it works
3. Checkout jitsi-meet
4. npm install
5. make
6. Change in you nginx config the root to point to your checkout
jitsi-meet, not /usr/share/jitsi-meet and restart nginx.

Regards
damencho

On Fri, Oct 28, 2016 at 7:24 AM, David MARQUET wrote:

Hi,

Jitsi meet is working pretty well, thanks for that job !

Unfortunately i have raised a issue (#1063) :
When a user have a login with dot inside like "firstName.lastName@domain"
and when another user login then an exception is raised.

In the browser console :
Logger.js:89 [JitsiMeetJS.js] :
UnhandledError: null Script: null Line: null Column: null StackTrace:
Error: Strophe: error: Cannot read property 'querySelector' of undefined
and
Logger.js:89[modules/xmpp/strophe.util.js] : Strophe:
error: Cannot read property 'querySelector' of undefined
TypeError: Cannot read property 'querySelector' of undefined
at a.setDisplayName
(https://advid.ovh/libs/app.bundle.min.js?v=1338:40:29355)

The error is located near :

i.className="displayname",$("#"+this.videoSpanId)[0].querySelector(".videocontainer....
I expect that the jQuery selector does not retrieve
$("#"+this.videoSpanId)
because jQuery interprets the dot (may looking for a class).

I think the dot must be escaped.

I can help to correct that.
I just don't know how to construct my dev environment.

Thanks

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users

_______________________________________________
users mailing list
users@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/users