[jitsi-users] phone numbers with spaces within


#1

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the text box.
Some users need to copy/paste numbers from other apps and occasionally these numbers may contain spaces within. Jitsi fails on a dial with spaced numbers. Could Jitsi ignore the spaces or trim them out?

eg: copy/pasted number: 123 456 789
    Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a future build?

Thanks,

Vieri


#2

Hey Vieri,

На 29.05.11 00:54, Vieri написа:

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the
text box. Some users need to copy/paste numbers from other apps and
occasionally these numbers may contain spaces within. Jitsi fails on
a dial with spaced numbers. Could Jitsi ignore the spaces or trim
them out?

eg: copy/pasted number: 123 456 789 Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a
future build?

It's been on our todo list for a while actually. We'll probably be
handling it at some point.

Cheers,
Emil


#3

Hi guys,

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field. This means that numbers such as: + (33) 123 456 789 would be formatted to 33123456789 when dialed. You can disable this behavior by un-checking the "Remove special symbols before callng phone numbers" check box in the General configuration form (Options/General/ Call).

Please give it a try and report problems here.

Cheers,
Yana

···

On May 30, 2011, at 5:00 PM, Emil Ivov wrote:

Hey Vieri,

На 29.05.11 00:54, Vieri написа:

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the
text box. Some users need to copy/paste numbers from other apps and
occasionally these numbers may contain spaces within. Jitsi fails on
a dial with spaced numbers. Could Jitsi ignore the spaces or trim
them out?

eg: copy/pasted number: 123 456 789 Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a
future build?

It's been on our todo list for a while actually. We'll probably be
handling it at some point.

Cheers,
Emil


#4

Thanks Yana

···

-----Original Message-----
From: Yana Stamcheva [mailto:yana@jitsi.org]
Sent: Wednesday, June 01, 2011 11:31 AM
To: users@jitsi.java.net
Cc: Vieri
Subject: [jitsi-users] Re: phone numbers with spaces within

Hi guys,

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field. This means that numbers such as: + (33) 123 456 789 would be formatted to 33123456789 when dialed. You can disable this behavior by un-checking the "Remove special symbols before callng phone numbers" check box in the General configuration form (Options/General/ Call).

Please give it a try and report problems here.

Cheers,
Yana

On May 30, 2011, at 5:00 PM, Emil Ivov wrote:

Hey Vieri,

На 29.05.11 00:54, Vieri написа:

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the
text box. Some users need to copy/paste numbers from other apps and
occasionally these numbers may contain spaces within. Jitsi fails on
a dial with spaced numbers. Could Jitsi ignore the spaces or trim
them out?

eg: copy/pasted number: 123 456 789 Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a
future build?

It's been on our todo list for a while actually. We'll probably be
handling it at some point.

Cheers,
Emil


#5

Lovely!.

What about my suggestion to include a "dial pad" icon that invokes the
dial pad straight from the main window, to make calls using any of the
configured SIP accounts (if any).

I sent the suggestion the other day (including a mock-up screenshot),
but didn´t get any feedback, whether possitive or negative.

If you guys missed it, I can re-send it...
FC

···

On Wed, Jun 1, 2011 at 12:31, Yana Stamcheva <yana@jitsi.org> wrote:

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field.


#6

Forgot to cc the dev list.

···

Begin forwarded message:

From: Yana Stamcheva <yana@jitsi.org>
Date: June 1, 2011 6:31:09 PM GMT+03:00
To: users@jitsi.java.net
Cc: Vieri <rentorbuy@yahoo.com>
Subject: Re: [jitsi-users] Re: phone numbers with spaces within

Hi guys,

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field. This means that numbers such as: + (33) 123 456 789 would be formatted to 33123456789 when dialed. You can disable this behavior by un-checking the "Remove special symbols before callng phone numbers" check box in the General configuration form (Options/General/ Call).

Please give it a try and report problems here.

Cheers,
Yana

On May 30, 2011, at 5:00 PM, Emil Ivov wrote:

Hey Vieri,

На 29.05.11 00:54, Vieri написа:

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the
text box. Some users need to copy/paste numbers from other apps and
occasionally these numbers may contain spaces within. Jitsi fails on
a dial with spaced numbers. Could Jitsi ignore the spaces or trim
them out?

eg: copy/pasted number: 123 456 789 Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a
future build?

It's been on our todo list for a while actually. We'll probably be
handling it at some point.

Cheers,
Emil


#7

Hey Fernando,

На 01.06.11 19:11, Fernando Cassia написа:

···

On Wed, Jun 1, 2011 at 12:31, Yana Stamcheva <yana@jitsi.org> wrote:

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field.

Lovely!.

What about my suggestion to include a "dial pad" icon that invokes the
dial pad straight from the main window, to make calls using any of the
configured SIP accounts (if any).

I sent the suggestion the other day (including a mock-up screenshot),
but didn´t get any feedback, whether possitive or negative.

You did actually :slight_smile:

http://java.net/nonav/projects/jitsi/lists/users/archive/2011-05/message/43

Cheers,
Emil


#8

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?

Thanks,

Mike

···

-----Original Message-----
From: Yana Stamcheva [mailto:yana@jitsi.org]
Sent: Wednesday, June 01, 2011 11:31 AM
To: users@jitsi.java.net
Cc: Vieri
Subject: [jitsi-users] Re: phone numbers with spaces within

Hi guys,

I've committed some code today (build 3511) that is supposed to deal with the described problem. We now remove all special characters from phone numbers dialed directly from the search field. This means that numbers such as: + (33) 123 456 789 would be formatted to 33123456789 when dialed. You can disable this behavior by un-checking the "Remove special symbols before callng phone numbers" check box in the General configuration form (Options/General/ Call).

Please give it a try and report problems here.

Cheers,
Yana

On May 30, 2011, at 5:00 PM, Emil Ivov wrote:

Hey Vieri,

На 29.05.11 00:54, Vieri написа:

Hi,

I'm using Jitsi with Asterisk and I usually dial plain numbers in the
text box. Some users need to copy/paste numbers from other apps and
occasionally these numbers may contain spaces within. Jitsi fails on
a dial with spaced numbers. Could Jitsi ignore the spaces or trim
them out?

eg: copy/pasted number: 123 456 789 Jitsi should dial: 123456789

Can this be done or could you please take it into consideration for a
future build?

It's been on our todo list for a while actually. We'll probably be
handling it at some point.

Cheers,
Emil


#9

Valid point. We use Jitsi in our company to connect to Asterisk. I do not want to think about how bad my day would be when no one can check voicemail (*97) without going to the conference room... :slight_smile:

      Lee

···

On 06/01/2011 11:19 PM, Michael L. Bredeweg wrote:

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?


#10

На 02.06.11 15:45, Lee Sharp написа:

···

On 06/01/2011 11:19 PM, Michael L. Bredeweg wrote:

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?

Valid point. We use Jitsi in our company to connect to Asterisk. I do
not want to think about how bad my day would be when no one can check
voicemail (*97) without going to the conference room... :slight_smile:

Hmmm ... could you guys maybe send us numbers that you are having the
problem with? * and # are indeed not supposed to be removed and they
seem to pass OK in our local tests.

Cheers,
Emil


#11

I have not yet seen the problem as we have not yet done any updates. Just voicing concern when Michael posted. I am paid to be paranoid. :slight_smile:

      Lee

···

On 06/02/2011 09:50 AM, Emil Ivov wrote:

Hmmm ... could you guys maybe send us numbers that you are having the
problem with? * and # are indeed not supposed to be removed and they
seem to pass OK in our local tests.


#12

Hi Emil,

They are being stripped out when doing number lookups from my Outlook 2010 address book. For example, just add a contact to Outlook with a phone number like *98, and when that contact is searched, the '*' is stripped out when the number is dialed.

-- Mike

···

________________________________________

From: Emil Ivov [emcho@jitsi.org]

Sent: Thursday, June 02, 2011 9:50 AM
To: users@jitsi.java.net
Cc: Lee Sharp
Subject: [jitsi-users] Re: phone numbers with spaces within

На 02.06.11 15:45, Lee Sharp написа:

On 06/01/2011 11:19 PM, Michael L. Bredeweg wrote:

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?

Valid point. We use Jitsi in our company to connect to Asterisk. I do
not want to think about how bad my day would be when no one can check
voicemail (*97) without going to the conference room... :slight_smile:

Hmmm ... could you guys maybe send us numbers that you are having the
problem with? * and # are indeed not supposed to be removed and they
seem to pass OK in our local tests.

Cheers,
Emil


#13

Hi Mike,

Actually our last changes were concerning only numbers dialed through the small phone icon in the search field and the "Call button", appearing when no search results are available.

Anyways, I was able to reproduce your problem with MacOSX Address Book and found out where the problem comes from. We'll commit a solution very soon, just need to make some more tests.

Cheers,
Yana

···

On Jun 2, 2011, at 5:03 PM, Michael L. Bredeweg wrote:

Hi Emil,

They are being stripped out when doing number lookups from my Outlook 2010 address book. For example, just add a contact to Outlook with a phone number like *98, and when that contact is searched, the '*' is stripped out when the number is dialed.

-- Mike

________________________________________
From: Emil Ivov [emcho@jitsi.org]
Sent: Thursday, June 02, 2011 9:50 AM
To: users@jitsi.java.net
Cc: Lee Sharp
Subject: [jitsi-users] Re: phone numbers with spaces within

На 02.06.11 15:45, Lee Sharp написа:

On 06/01/2011 11:19 PM, Michael L. Bredeweg wrote:

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?

Valid point. We use Jitsi in our company to connect to Asterisk. I do
not want to think about how bad my day would be when no one can check
voicemail (*97) without going to the conference room... :slight_smile:

Hmmm ... could you guys maybe send us numbers that you are having the
problem with? * and # are indeed not supposed to be removed and they
seem to pass OK in our local tests.

Cheers,
Emil


#14

Thank you, Yana.

-- Mike

···

________________________________________

From: Yana Stamcheva [yana@jitsi.org]

Sent: Thursday, June 02, 2011 11:07 AM
To: users@jitsi.java.net
Cc: dev@jitsi.java.net
Subject: [jitsi-users] Re: phone numbers with spaces within

Hi Mike,

Actually our last changes were concerning only numbers dialed through the small phone icon in the search field and the "Call button", appearing when no search results are available.

Anyways, I was able to reproduce your problem with MacOSX Address Book and found out where the problem comes from. We'll commit a solution very soon, just need to make some more tests.

Cheers,
Yana

On Jun 2, 2011, at 5:03 PM, Michael L. Bredeweg wrote:

Hi Emil,

They are being stripped out when doing number lookups from my Outlook 2010 address book. For example, just add a contact to Outlook with a phone number like *98, and when that contact is searched, the '*' is stripped out when the number is dialed.

-- Mike

________________________________________
From: Emil Ivov [emcho@jitsi.org]
Sent: Thursday, June 02, 2011 9:50 AM
To: users@jitsi.java.net
Cc: Lee Sharp
Subject: [jitsi-users] Re: phone numbers with spaces within

На 02.06.11 15:45, Lee Sharp написа:

On 06/01/2011 11:19 PM, Michael L. Bredeweg wrote:

Hi Yana,

I like this feature, but it may go a bit too far. The '*' and '#' characters are valid characters on the phone pad, but these are being removed on lookup as well. I have a couple of numbers that use these characters, but they are being stripped out. Can we leave the '*' and '#' characters in when removing special characters?

Valid point. We use Jitsi in our company to connect to Asterisk. I do
not want to think about how bad my day would be when no one can check
voicemail (*97) without going to the conference room... :slight_smile:

Hmmm ... could you guys maybe send us numbers that you are having the
problem with? * and # are indeed not supposed to be removed and they
seem to pass OK in our local tests.

Cheers,
Emil