[jitsi-users] Audio/video call dropdown menu doesn't show XMPP resource


#1

Hi,

In Jitsi desktop version, in the case of Jabber/XMPP accounts (specifically
Google Talk), if a contact is signed in through multiple clients, each
client has a unique resource ID. (For Jitsi, jitsi-xxxxx and for Hangouts,
Messaging-xxxxxx)

When clicked, the audio/video call button will show a dropdown menu with
the list of different XMPP addresses, but only the main address is shown
(user@servername - e.g sandy.8925@gmail.com) - the resource portion
(jitsi-xxxx,Messaging-xxxx) is not shown. (see attached picture)

So, when attempting to start an audio/video call through Jitsi, it is
difficult to identify which endpoint/client needs to be selected since the
resource is not shown - instead a list of multiple copies of the same email
address is shown (although status may help here).

I request that changes be made to also display XMPP resource in the drop
down menu.

- Sandeep


#2

Bump. Does anyone know which portion of code I would need to look at to
change this?

Would it be ChatWindow or ChatPanel class?

Thanks,
Sandeep

···

On Tue, May 27, 2014 at 11:17 PM, Sandeep <sandy.8925@gmail.com> wrote:

Hi,

In Jitsi desktop version, in the case of Jabber/XMPP accounts
(specifically Google Talk), if a contact is signed in through multiple
clients, each client has a unique resource ID. (For Jitsi, jitsi-xxxxx and
for Hangouts, Messaging-xxxxxx)

When clicked, the audio/video call button will show a dropdown menu with
the list of different XMPP addresses, but only the main address is shown
(user@servername - e.g sandy.8925@gmail.com) - the resource portion
(jitsi-xxxx,Messaging-xxxx) is not shown. (see attached picture)

So, when attempting to start an audio/video call through Jitsi, it is
difficult to identify which endpoint/client needs to be selected since the
resource is not shown - instead a list of multiple copies of the same email
address is shown (although status may help here).

I request that changes be made to also display XMPP resource in the drop
down menu.

- Sandeep


#3

Ok, I figured out that ChatWindow refers to the chat window overall,
ChatPanel represents the conversation + message typing panels.

MainToolBar is the class that represents the toolbar at the top - this
includes the buttons for "Add contact to chat", "Audio call", "Video call",
"Share Desktop" etc.

The relevant code was in the method : call(boolean isVideo, boolean
isDesktopSharing). The email address I saw comes from the
ChatTransport.getName method.

Next, I need to figure out how to get the resource portion of XMPP address.

- Sandeep

···

On Mon, Jun 9, 2014 at 1:16 PM, Sandeep <sandy.8925@gmail.com> wrote:

Bump. Does anyone know which portion of code I would need to look at to
change this?

Would it be ChatWindow or ChatPanel class?

Thanks,
Sandeep

On Tue, May 27, 2014 at 11:17 PM, Sandeep <sandy.8925@gmail.com> wrote:

Hi,

In Jitsi desktop version, in the case of Jabber/XMPP accounts
(specifically Google Talk), if a contact is signed in through multiple
clients, each client has a unique resource ID. (For Jitsi, jitsi-xxxxx and
for Hangouts, Messaging-xxxxxx)

When clicked, the audio/video call button will show a dropdown menu with
the list of different XMPP addresses, but only the main address is shown
(user@servername - e.g sandy.8925@gmail.com) - the resource portion
(jitsi-xxxx,Messaging-xxxx) is not shown. (see attached picture)

So, when attempting to start an audio/video call through Jitsi, it is
difficult to identify which endpoint/client needs to be selected since the
resource is not shown - instead a list of multiple copies of the same email
address is shown (although status may help here).

I request that changes be made to also display XMPP resource in the drop
down menu.

- Sandeep


#4

ChatTransport class has a method - getResourceName - that returns the XMPP
address' resource string.

Using my email address as an example for Google Talk (XMPP/Jabber protocol)

The dropdown shows 3 entries:
One is for the user in general i.e sandy.8925@gmail.com

The other two identify 2 different endpoints/clients connected to the
server, with differing resource strings.

I've also noticed that there is a small dropdown box in the chat message
typing area, which shows the same information, but in hierarchical manner,
with the contact address displayed as an entry, and the two
client/endpoints shown as sub-entries for the main contact entry.

It would be good if the same dropdown can be shown for the audio and video
call buttons' dropdown menu, since it will be easy to select the right
endpoint for the call.

- Sandeep

···

On Mon, Jun 9, 2014 at 2:47 PM, Sandeep <sandy.8925@gmail.com> wrote:

Ok, I figured out that ChatWindow refers to the chat window overall,
ChatPanel represents the conversation + message typing panels.

MainToolBar is the class that represents the toolbar at the top - this
includes the buttons for "Add contact to chat", "Audio call", "Video call",
"Share Desktop" etc.

The relevant code was in the method : call(boolean isVideo, boolean
isDesktopSharing). The email address I saw comes from the
ChatTransport.getName method.

Next, I need to figure out how to get the resource portion of XMPP address.

- Sandeep

On Mon, Jun 9, 2014 at 1:16 PM, Sandeep <sandy.8925@gmail.com> wrote:

Bump. Does anyone know which portion of code I would need to look at to
change this?

Would it be ChatWindow or ChatPanel class?

Thanks,
Sandeep

On Tue, May 27, 2014 at 11:17 PM, Sandeep <sandy.8925@gmail.com> wrote:

Hi,

In Jitsi desktop version, in the case of Jabber/XMPP accounts
(specifically Google Talk), if a contact is signed in through multiple
clients, each client has a unique resource ID. (For Jitsi, jitsi-xxxxx and
for Hangouts, Messaging-xxxxxx)

When clicked, the audio/video call button will show a dropdown menu with
the list of different XMPP addresses, but only the main address is shown
(user@servername - e.g sandy.8925@gmail.com) - the resource portion
(jitsi-xxxx,Messaging-xxxx) is not shown. (see attached picture)

So, when attempting to start an audio/video call through Jitsi, it is
difficult to identify which endpoint/client needs to be selected since the
resource is not shown - instead a list of multiple copies of the same email
address is shown (although status may help here).

I request that changes be made to also display XMPP resource in the drop
down menu.

- Sandeep


#5

I have created a pull request here: https://github.com/jitsi/jitsi/pull/35

It would be nice if Jitsi developers could include this feature in mainline
Jitsi.

Thanks,
Sandeep

···

On Mon, Jun 9, 2014 at 2:57 PM, Sandeep <sandy.8925@gmail.com> wrote:

ChatTransport class has a method - getResourceName - that returns the XMPP
address' resource string.

Using my email address as an example for Google Talk (XMPP/Jabber protocol)

The dropdown shows 3 entries:
One is for the user in general i.e sandy.8925@gmail.com

The other two identify 2 different endpoints/clients connected to the
server, with differing resource strings.

I've also noticed that there is a small dropdown box in the chat message
typing area, which shows the same information, but in hierarchical manner,
with the contact address displayed as an entry, and the two
client/endpoints shown as sub-entries for the main contact entry.

It would be good if the same dropdown can be shown for the audio and video
call buttons' dropdown menu, since it will be easy to select the right
endpoint for the call.

- Sandeep

On Mon, Jun 9, 2014 at 2:47 PM, Sandeep <sandy.8925@gmail.com> wrote:

Ok, I figured out that ChatWindow refers to the chat window overall,
ChatPanel represents the conversation + message typing panels.

MainToolBar is the class that represents the toolbar at the top - this
includes the buttons for "Add contact to chat", "Audio call", "Video call",
"Share Desktop" etc.

The relevant code was in the method : call(boolean isVideo, boolean
isDesktopSharing). The email address I saw comes from the
ChatTransport.getName method.

Next, I need to figure out how to get the resource portion of XMPP
address.

- Sandeep

On Mon, Jun 9, 2014 at 1:16 PM, Sandeep <sandy.8925@gmail.com> wrote:

Bump. Does anyone know which portion of code I would need to look at to
change this?

Would it be ChatWindow or ChatPanel class?

Thanks,
Sandeep

On Tue, May 27, 2014 at 11:17 PM, Sandeep <sandy.8925@gmail.com> wrote:

Hi,

In Jitsi desktop version, in the case of Jabber/XMPP accounts
(specifically Google Talk), if a contact is signed in through multiple
clients, each client has a unique resource ID. (For Jitsi, jitsi-xxxxx and
for Hangouts, Messaging-xxxxxx)

When clicked, the audio/video call button will show a dropdown menu
with the list of different XMPP addresses, but only the main address is
shown (user@servername - e.g sandy.8925@gmail.com) - the resource
portion (jitsi-xxxx,Messaging-xxxx) is not shown. (see attached picture)

So, when attempting to start an audio/video call through Jitsi, it is
difficult to identify which endpoint/client needs to be selected since the
resource is not shown - instead a list of multiple copies of the same email
address is shown (although status may help here).

I request that changes be made to also display XMPP resource in the
drop down menu.

- Sandeep