Jitsi-meet-torture and non-english default language

bug.spencor · June 10, 2022, 9:01am

Hi,

I’m testing jitsi-meet-torture with a Jitsi instance which has german configured as default language:

in jitsi-config.js:

    // Default language for the user interface.
    defaultLanguage: 'de',

and in interface_config.js:

    LANG_DETECTION: true, // Allow i18n to detect the system language

With these settings I get many errors like:

org.openqa.selenium.NoSuchElementException: No element found for:[aria-label="More actions"]
For documentation on this error, please visit: https://www.seleniumhq.org/exceptions/no_such_element.html

I found the workaround to revert commit feat: Forces en-us as chrome language. · jitsi/jitsi-meet-torture@6274e4c · GitHub which resolves these errors.

Is there a better way to make torture work with a non-english Jitsi instance?

saghul · June 10, 2022, 10:39am

All the tests are written to find elements in English, if you revert that commit things would fail, wouldn’t they?

bug.spencor · June 13, 2022, 1:27pm

I don’t fully understand what the commit changes; but as a matter of fact reverting the commit works for me; language related test errors are gone.

When looking into the issue just now I found an interesting behaviour (the Jitsi Meet instance: https://treffen.vtirol.gv.at; my system language and browser language is english):

In Chrome:

non-incognito mode (all browser data cleared): Jitsi Meet is displayed in english
incognito mode: Jitsi Meet is displayed in german (initially shown in english, then quickly changed to german)

In Firefox:

both in private and non-private mode: Jitsi Meet is displayed in english

So what I see is: the default language from config.js is not applied, only when connecting from Chrome incognito mode or when using Jitsi Torture.

When is the default-language applied? Maybe it is overridden by browser-language detection, which maybe has no effect in incognito mode and torture?

damencho · June 13, 2022, 1:36pm

Once you have loaded a default language, that is stored in localstorage till you change it in local storage on client change, any change in default language on backend will not take affect to those already load the previous default.
Incognito and torture start with clean profile for every new session.

bug.spencor · June 13, 2022, 1:42pm

I have cleared local storage for Chrome and Firefox; still it does not apply the configured defaultLanguage. Same with Firefox private mode.

damencho · June 13, 2022, 1:44pm

Do you see it being applied in the local storage?
How are you cleaning it, while being in the page? If you open the page and clear it from there, sometimes it stores what’s in the memory of the page on close, overriding.

bug.spencor · June 13, 2022, 2:00pm

I tried different methods:

Clearing local storage from DevTools when page is shown
Clearing all browser data while page is closed

Edit: In method 1. I saw that local storage is emptied until next reload.

damencho · June 13, 2022, 2:47pm

I think this is because LANG_DETECTION: true from interface_config, kicks in before the default language. If you disable that and clear again, it should work.

bug.spencor · June 14, 2022, 8:48am

Yes that’s true. When setting LANG_DETECTION: false, all browsers display Jitsi Meet in german, regardless of the configured browser language.

Inversely, when setting browser language ‘de’, LANG_DETECTION: true and no defaultLanguage in config.js, all browsers display Jitse Meet in german.

So coming back to my first post, there seems to be case, with LANGUAGE_DETECTION: true, defaultLanguage: ‘de’, where language selection from commit feat: Forces en-us as chrome language. · jitsi/jitsi-meet-torture@6274e4c · GitHub doesn’t work and jitsi torture does not override the default language and/or browser language detection does not kick in. Does that make sense?

bug.spencor · June 23, 2022, 11:04am

Coming back to that topic (probably lost in the backlog): Do you consider the observed behaviour (see above) a bug? Should I open a issue in GitHub for Jitsi Meet?

damencho · June 23, 2022, 12:46pm

This is in jitsi-meet-torture, probably the code should force LANGUAGE_DETECTION to true and default language to be en. You can open an issue there and any PRs are welcome.

bug.spencor · August 18, 2022, 7:37am

Can you give me a hint how LANG_DETECTION (from interface_config.js) can be forced to true in Torture?

damencho · August 18, 2022, 1:24pm

github.com

jitsi/jitsi-meet-torture/blob/adc41dae2a08be48a220b9c27adb23d346d36d24/src/test/java/org/jitsi/meet/test/web/WebParticipant.java#L65


      
                  + "&config.callStatsID=false"
                  + "&config.alwaysVisibleToolbar=true"
                  + "&config.p2p.enabled=false"
                  + "&config.p2p.useStunTurn=false"
                  + "&config.pcStatsInterval=1500"
                  + "&config.prejoinConfig.enabled=false"
                  + (DISABLE_UNIFIED ? "&config.p2p.enableUnifiedOnChrome=false&config.enableUnifiedOnChrome=false" : "")
                  + "&config.gatherStats=true"
                  + "&config.disable1On1Mode=true"
                  + "&config.analytics.disabled=true"
                  + "&interfaceConfig.SHOW_CHROME_EXTENSION_BANNER=false"
                  + "&interfaceConfig.DISABLE_FOCUS_INDICATOR=true";
          
          
/**
           * The javascript code which returns {@code true} if we are joined in
           * the muc.
           */
          private static final String IS_MUC_JOINED =
              "return APP.conference.isJoined();";
          
          
/**

bug.spencor · February 7, 2023, 3:04pm

Setting interface_config.LANGUAGE_DETECTION and config.defaultLanguage didn’t solve the problem, but after more research I tried setting accepted_languages to “en,en-US” in jitsi-meet-torture/WebParticipantFactory.java at master · jitsi/jitsi-meet-torture · GitHub which worked for my installation.

Here is the pull request for the fix: Add "en" to accepted_languages by bugspencor · Pull Request #566 · jitsi/jitsi-meet-torture · GitHub