no no, do not misunderstand me, it was just a joke. First of all I am
thankful for the review - I did not know about the ScreenInformation, I
agree that hardcoded strings comparison is ugly, I do not like Jitsi code
formatting and prefer standard Java code conventions, but hey - your
project, your rules We have a constant flow of tweaks and modifications
that we apply here and there - hence the specific comments - it is just
easier to trace what was modified by us. I frankly did not consider that
such requirements like positioning the window somewhere will make sense for
the wide audience until it popped up here, on the mailing list as an idea
from someone else (it was required by us because we have call agents
getting calls uninterruptedly and working with other apps in the
foreground, so it just spares a lot of unnecessary windows shifting). I now
have a better picture of what are the conventions for submitting the
patches and will definitely consider doing so for some useful functionality
that we might add (or might have already added).
By the way, yesterday I have sent an email to the dev list describing a
possible fix for what I consider being a bug : "Contact list is not
refreshed when XMPP status message is updated". I will appreciate you input
on that matter (the questions that interest are included in that email) and
will consider patching it, if we find a common ground.
2013/3/7 Emil Ivov <firstname.lastname@example.org>
You seem to be frustrated and I am sorry you feel this way. Still, I am
not sure exactly how you expect things to work. Ingo has taken the time to
review your patch and given you very specific details about things that we
would see as problematic. If you care about your patch being in Jitsi, you
could address them. If you don't have the time or the interest to pursue
this effort you could simply say so. However,you seem to imply some unfair
treatment which I can't quite grasp.
--sent from my mobile
Hey Martin, you got your answer. This is exactly why I do not bother
You are welcome to make this file "good enough" and commit a patch.
2013/3/7 Ingo Bauersachs <email@example.com>
> Well, then thank you for the patch
> Any reason why it's not in the jitsi repos, other than you not beeing
> a comitter? Did they reject the patch or something?
I can't remember having seen this patch before, but I'd have rejected it
- it's the complete file of an unknown revision and not a patch
- stuffed with comments that cannot stay there
- with an invalid formatting 
- property-strings in the code instead of in constants
- the dual-screen stuff has already a helper in the class
If you send us a clean patch, I'll apply it.