[jitsi-dev] Work on new features


#1

Hi devs

I'm planning to work on 3 specific features on Jitsi very soon.

-- SIP notify caller id and other states --
PBX'es like Asterisk can notify incomming caller id to subscribers. It
would be nice for Jitsi to show this on the contact list. It can also
notify subscribers RINGING, INUSE, HOLD.

-- Incomming call dialog positioning --
It can be anoying for some users to have the incomming call dialog
right in the middle of the screen. It would be nice if it could be
configured to appear elsewhere.

-- Always on top dialog --
Well, its already on your list.
https://jitsi.org/GSOC/AlwaysOnTopCallDialog

I write to you to ask if these suggestions are completely out of order
and ask if anyone is already working on them?

/Martin


#2

Hi Martin,

I just wanted to spare you half an hour of your time, because I have
already implemented feature #2 from your list. If you feel like, you are
welcome to reuse this solution (find attached). Available options are
BOTTOM_RIGHT, BOTTOM_LEFT, TOP_LEFT, TOP_RIGHT, which are set via the
provisioning service in our case. There is also a setting to control the
delay before the window is disposed after the conversation is over.

Regards,
Alexander Fedulov

CallDialog.java (8.85 KB)

···

2013/3/5 Martin Kjær Jørgensen <mkj@gotu.dk>

Hi devs

I'm planning to work on 3 specific features on Jitsi very soon.

-- SIP notify caller id and other states --
PBX'es like Asterisk can notify incomming caller id to subscribers. It
would be nice for Jitsi to show this on the contact list. It can also
notify subscribers RINGING, INUSE, HOLD.

-- Incomming call dialog positioning --
It can be anoying for some users to have the incomming call dialog
right in the middle of the screen. It would be nice if it could be
configured to appear elsewhere.

-- Always on top dialog --
Well, its already on your list.
https://jitsi.org/GSOC/AlwaysOnTopCallDialog

I write to you to ask if these suggestions are completely out of order
and ask if anyone is already working on them?

/Martin


#3

Is the feature commit into mainline sourcebase?

···

On Tue, Mar 05, 2013 at 12:34:01PM +0100, ijustwanttoregister@googlemail.com wrote:

Hi Martin,

I just wanted to spare you half an hour of your time, because I have
already implemented feature #2 from your list. If you feel like, you are
welcome to reuse this solution (find attached). Available options are
BOTTOM_RIGHT, BOTTOM_LEFT, TOP_LEFT, TOP_RIGHT, which are set via the
provisioning service in our case. There is also a setting to control the
delay before the window is disposed after the conversation is over.

Regards,
Alexander Fedulov

2013/3/5 Martin Kjær Jørgensen <mkj@gotu.dk>

> Hi devs
>
> I'm planning to work on 3 specific features on Jitsi very soon.
>
> -- SIP notify caller id and other states --
> PBX'es like Asterisk can notify incomming caller id to subscribers. It
> would be nice for Jitsi to show this on the contact list. It can also
> notify subscribers RINGING, INUSE, HOLD.
>
> -- Incomming call dialog positioning --
> It can be anoying for some users to have the incomming call dialog
> right in the middle of the screen. It would be nice if it could be
> configured to appear elsewhere.
>
> -- Always on top dialog --
> Well, its already on your list.
> https://jitsi.org/GSOC/AlwaysOnTopCallDialog
>
>
> I write to you to ask if these suggestions are completely out of order
> and ask if anyone is already working on them?
>
> /Martin
>


#4

Hi Martin,

nope, I am not a commiter to the jitsi repo. All required changes are in
the attached file.

Regards,
Alexander Fedulov

···

2013/3/6 Martin Kjær Jørgensen <mkj@gotu.dk>

Is the feature commit into mainline sourcebase?

On Tue, Mar 05, 2013 at 12:34:01PM +0100, > ijustwanttoregister@googlemail.com wrote:
> Hi Martin,
>
> I just wanted to spare you half an hour of your time, because I have
> already implemented feature #2 from your list. If you feel like, you are
> welcome to reuse this solution (find attached). Available options are
> BOTTOM_RIGHT, BOTTOM_LEFT, TOP_LEFT, TOP_RIGHT, which are set via the
> provisioning service in our case. There is also a setting to control the
> delay before the window is disposed after the conversation is over.
>
> Regards,
> Alexander Fedulov
>
>
> 2013/3/5 Martin Kjær Jørgensen <mkj@gotu.dk>
>
> > Hi devs
> >
> > I'm planning to work on 3 specific features on Jitsi very soon.
> >
> > -- SIP notify caller id and other states --
> > PBX'es like Asterisk can notify incomming caller id to subscribers. It
> > would be nice for Jitsi to show this on the contact list. It can also
> > notify subscribers RINGING, INUSE, HOLD.
> >
> > -- Incomming call dialog positioning --
> > It can be anoying for some users to have the incomming call dialog
> > right in the middle of the screen. It would be nice if it could be
> > configured to appear elsewhere.
> >
> > -- Always on top dialog --
> > Well, its already on your list.
> > https://jitsi.org/GSOC/AlwaysOnTopCallDialog
> >
> >
> > I write to you to ask if these suggestions are completely out of order
> > and ask if anyone is already working on them?
> >
> > /Martin
> >


#5

Well, then thank you for the patch :slight_smile:

Any reason why it's not in the jitsi repos, other than you not beeing
a comitter? Did they reject the patch or something?

···

On Wed, Mar 06, 2013 at 05:07:00PM +0100, ijustwanttoregister@googlemail.com wrote:

Hi Martin,

nope, I am not a commiter to the jitsi repo. All required changes are in
the attached file.

Regards,
Alexander Fedulov

2013/3/6 Martin Kjær Jørgensen <mkj@gotu.dk>

> Is the feature commit into mainline sourcebase?
>
> On Tue, Mar 05, 2013 at 12:34:01PM +0100, > > ijustwanttoregister@googlemail.com wrote:
> > Hi Martin,
> >
> > I just wanted to spare you half an hour of your time, because I have
> > already implemented feature #2 from your list. If you feel like, you are
> > welcome to reuse this solution (find attached). Available options are
> > BOTTOM_RIGHT, BOTTOM_LEFT, TOP_LEFT, TOP_RIGHT, which are set via the
> > provisioning service in our case. There is also a setting to control the
> > delay before the window is disposed after the conversation is over.
> >
> > Regards,
> > Alexander Fedulov
> >
> >
> > 2013/3/5 Martin Kjær Jørgensen <mkj@gotu.dk>
> >
> > > Hi devs
> > >
> > > I'm planning to work on 3 specific features on Jitsi very soon.
> > >
> > > -- SIP notify caller id and other states --
> > > PBX'es like Asterisk can notify incomming caller id to subscribers. It
> > > would be nice for Jitsi to show this on the contact list. It can also
> > > notify subscribers RINGING, INUSE, HOLD.
> > >
> > > -- Incomming call dialog positioning --
> > > It can be anoying for some users to have the incomming call dialog
> > > right in the middle of the screen. It would be nice if it could be
> > > configured to appear elsewhere.
> > >
> > > -- Always on top dialog --
> > > Well, its already on your list.
> > > https://jitsi.org/GSOC/AlwaysOnTopCallDialog
> > >
> > >
> > > I write to you to ask if these suggestions are completely out of order
> > > and ask if anyone is already working on them?
> > >
> > > /Martin
> > >
>
>
>


#6

Well, then thank you for the patch :slight_smile:

Any reason why it's not in the jitsi repos, other than you not beeing
a comitter? Did they reject the patch or something?

I can't remember having seen this patch before, but I'd have rejected it because
- it's the complete file of an unknown revision and not a patch
- stuffed with comments that cannot stay there
- with an invalid formatting [0]
- property-strings in the code instead of in constants
- the dual-screen stuff has already a helper in the class ScreenInformation

If you send us a clean patch, I'll apply it.

Regards,
Ingo

[0] https://jitsi.org/Documentation/CodeConvention


#7

Hey Martin, you got your answer. This is exactly why I do not bother :wink:
You are welcome to make this file "good enough" and commit a patch.

Regards,
Alex

···

2013/3/7 Ingo Bauersachs <ingo@jitsi.org>

> Well, then thank you for the patch :slight_smile:
>
> Any reason why it's not in the jitsi repos, other than you not beeing
> a comitter? Did they reject the patch or something?

I can't remember having seen this patch before, but I'd have rejected it
because
- it's the complete file of an unknown revision and not a patch
- stuffed with comments that cannot stay there
- with an invalid formatting [0]
- property-strings in the code instead of in constants
- the dual-screen stuff has already a helper in the class ScreenInformation

If you send us a clean patch, I'll apply it.

Regards,
Ingo

[0] https://jitsi.org/Documentation/CodeConvention


#8

Hey Alex,

You seem to be frustrated and I am sorry you feel this way. Still, I am not
sure exactly how you expect things to work. Ingo has taken the time to
review your patch and given you very specific details about things that we
would see as problematic. If you care about your patch being in Jitsi, you
could address them. If you don't have the time or the interest to pursue
this effort you could simply say so. However,you seem to imply some unfair
treatment which I can't quite grasp.

Emil

--sent from my mobile
Hey Martin, you got your answer. This is exactly why I do not bother :wink:
You are welcome to make this file "good enough" and commit a patch.

Regards,
Alex

···

2013/3/7 Ingo Bauersachs <ingo@jitsi.org>

> Well, then thank you for the patch :slight_smile:
>
> Any reason why it's not in the jitsi repos, other than you not beeing
> a comitter? Did they reject the patch or something?

I can't remember having seen this patch before, but I'd have rejected it
because
- it's the complete file of an unknown revision and not a patch
- stuffed with comments that cannot stay there
- with an invalid formatting [0]
- property-strings in the code instead of in constants
- the dual-screen stuff has already a helper in the class ScreenInformation

If you send us a clean patch, I'll apply it.

Regards,
Ingo

[0] https://jitsi.org/Documentation/CodeConvention


#9

Hi Emil,

no no, do not misunderstand me, it was just a joke. First of all I am
thankful for the review - I did not know about the ScreenInformation, I
agree that hardcoded strings comparison is ugly, I do not like Jitsi code
formatting and prefer standard Java code conventions, but hey - your
project, your rules :wink: We have a constant flow of tweaks and modifications
that we apply here and there - hence the specific comments - it is just
easier to trace what was modified by us. I frankly did not consider that
such requirements like positioning the window somewhere will make sense for
the wide audience until it popped up here, on the mailing list as an idea
from someone else (it was required by us because we have call agents
getting calls uninterruptedly and working with other apps in the
foreground, so it just spares a lot of unnecessary windows shifting). I now
have a better picture of what are the conventions for submitting the
patches and will definitely consider doing so for some useful functionality
that we might add (or might have already added).

By the way, yesterday I have sent an email to the dev list describing a
possible fix for what I consider being a bug : "Contact list is not
refreshed when XMPP status message is updated". I will appreciate you input
on that matter (the questions that interest are included in that email) and
will consider patching it, if we find a common ground.

Kind regards,
Alexander Fedulov

···

2013/3/7 Emil Ivov <emcho@jitsi.org>

Hey Alex,

You seem to be frustrated and I am sorry you feel this way. Still, I am
not sure exactly how you expect things to work. Ingo has taken the time to
review your patch and given you very specific details about things that we
would see as problematic. If you care about your patch being in Jitsi, you
could address them. If you don't have the time or the interest to pursue
this effort you could simply say so. However,you seem to imply some unfair
treatment which I can't quite grasp.

Emil

--sent from my mobile
Hey Martin, you got your answer. This is exactly why I do not bother :wink:
You are welcome to make this file "good enough" and commit a patch.

Regards,
Alex

2013/3/7 Ingo Bauersachs <ingo@jitsi.org>

> Well, then thank you for the patch :slight_smile:
>
> Any reason why it's not in the jitsi repos, other than you not beeing
> a comitter? Did they reject the patch or something?

I can't remember having seen this patch before, but I'd have rejected it
because
- it's the complete file of an unknown revision and not a patch
- stuffed with comments that cannot stay there
- with an invalid formatting [0]
- property-strings in the code instead of in constants
- the dual-screen stuff has already a helper in the class
ScreenInformation

If you send us a clean patch, I'll apply it.

Regards,
Ingo

[0] https://jitsi.org/Documentation/CodeConvention