[jitsi-dev] Where's the source of jitsi dependencies?


#1

Hi guys

Where is the source code of org.jitsi:jitsi-protocol?

Could you add to the Github Maven repository not just the compiled jar
files, but also attach the javadoc and source code? (as described in
https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
). That'd make IDE integration a lot easier.

Regards,

  Guus


#2

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

···

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Hi guys

Where is the source code of org.jitsi:jitsi-protocol?

Could you add to the Github Maven repository not just the compiled jar
files, but also attach the javadoc and source code? (as described in
https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
). That'd make IDE integration a lot easier.

Regards,

  Guus

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Gotcha. I've tried building that locally, but it fails. Could you attach
the source code and javadoc artifacts to what we already have in the Maven
repository?

···

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen > <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/
attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

That is the source code, I suppose we need to add building/uploading those
in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in
m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ...
:slight_smile:
I will check it, but I was building it last week.

Regards
damencho

···

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> wrote:

Gotcha. I've tried building that locally, but it fails. Could you attach
the source code and javadoc artifacts to what we already have in the Maven
repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-
source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Ah, I thought you were an expert in *everything*. :slight_smile: Finally something I
can help *you* with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build that
project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source
code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also
include documentation and sources in this manner.

How this is done is easy. It's described in
https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will
generate two extra jar files for each module (-sources and -javadoc should
be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

···

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading those
in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in
m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ...
:slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> > wrote:

Gotcha. I've tried building that locally, but it fails. Could you attach
the source code and javadoc artifacts to what we already have in the Maven
repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-s
ource-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

I'd love to help out with a PR, but the Maven project fails to build for me
(the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies.
How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

···

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Ah, I thought you were an expert in *everything*. :slight_smile: Finally something I
can help *you* with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build
that project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source
code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also
include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/
plugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will
generate two extra jar files for each module (-sources and -javadoc should
be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading
those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in
m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source
... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> >> wrote:

Gotcha. I've tried building that locally, but it fails. Could you attach
the source code and javadoc artifacts to what we already have in the Maven
repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-s
ource-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

The Maven project is completely broken. I've fixed a lot of stuff in the smack4-2 branch, and cherry-picked some of it back (which might have broken something else).

But: please try not to modify these poms in master too much or you'll cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire module tree. And you need to have jitsi-universe next to jitsi checked out (which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

···

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

I'd love to help out with a PR, but the Maven project fails to build for me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:
Ah, I thought you were an expert in everything. :slight_smile: Finally something I can help you with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build that project, but that's besides the point - I really don't want to have to build all Jitsi projects, simply to be able to click through the source code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled code. A very common thing to do is to attach archive files that contain the javadoc and uncompiled source code, and install all of those in the Maven repository (next to the regular .jar file). Most IDEs can automatically download these when available, which means that they do not need to decompile the jar. That is very, very useful, as decompilation rarely works flawlessly, and still does not restore the javadoc. If you have a look, you'll see that most projects in the central Maven repositories also include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html (basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will generate two extra jar files for each module (-sources and -javadoc should be in their name). I believe that those artifacts would then be automatically installed in the repository as well (when you deploy them), although I'm not sure about that. If not, it's probably pretty easy to do that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:
That is the source code, I suppose we need to add building/uploading those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> wrote:
Gotcha. I've tried building that locally, but it fails. Could you attach the source code and javadoc artifacts to what we already have in the Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:
Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#8

The Maven project is completely broken. I've fixed a lot of stuff in the
smack4-2 branch, and cherry-picked some of it back (which might have broken
something else).

But: please try not to modify these poms in master too much or you'll cause
me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire module
tree. And you need to have jitsi-universe next to jitsi checked out (which
is most likely causing the unknown versions errors).

Apparently, it is working for me because of jitsi-universe.

···

On Wed, Aug 9, 2017 at 8:44 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Guus, I'll help you tonight via chat, okay? I have some questions for you as
well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

I'd love to help out with a PR, but the Maven project fails to build for me
(the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies.
How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

Ah, I thought you were an expert in everything. :slight_smile: Finally something I can
help you with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build
that project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source code
of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also include
documentation and sources in this manner.

How this is done is easy. It's described in
https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will
generate two extra jar files for each module (-sources and -javadoc should
be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading
those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in
m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source
... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> >>> wrote:

Gotcha. I've tried building that locally, but it fails. Could you attach
the source code and javadoc artifacts to what we already have in the Maven
repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled
> jar
> files, but also attach the javadoc and source code? (as described in
>
> https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#9

Ingo, thanks. I've just found the same thing. If I checkout
version 21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn clean`
works.

No promises on availability tonight (I have kids to herd) but I'll do my
best. You (all) can add my via XMPP at guus.der.kinderen@igniterealtime.org

- Guus

···

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:

The Maven project is completely broken. I've fixed a lot of stuff in the
smack4-2 branch, and cherry-picked some of it back (which might have broken
something else).

But: please try not to modify these poms in master too much or you'll
cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire
module tree. And you need to have jitsi-universe next to jitsi checked out
(which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you
as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

I'd love to help out with a PR, but the Maven project fails to build for
me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies.
How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar
is missing. @ org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar
is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column
17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar
is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column
17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column
17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar
is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml,
line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column
17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column
17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column
17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-
sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml,
line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/
ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

Ah, I thought you were an expert in *everything*. :slight_smile: Finally something I
can help *you* with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build
that project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source
code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also
include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/pl
ugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now
will generate two extra jar files for each module (-sources and -javadoc
should be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading
those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are
in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source
... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> >>> wrote:

Gotcha. I've tried building that locally, but it fails. Could you
attach the source code and javadoc artifacts to what we already have in the
Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled
jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-s
ource-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#10

Well, more reason for you guys to start attaching the source and javadoc
artifacts. :slight_smile:

···

On 9 August 2017 at 15:52, Damian Minkov <damencho@jitsi.org> wrote:

On Wed, Aug 9, 2017 at 8:44 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:
> The Maven project is completely broken. I've fixed a lot of stuff in the
> smack4-2 branch, and cherry-picked some of it back (which might have
broken
> something else).
>
> But: please try not to modify these poms in master too much or you'll
cause
> me a really hard time with merging.
>
> Building a subcomponent definitely doesn't work, you need the entire
module
> tree. And you need to have jitsi-universe next to jitsi checked out
(which
> is most likely causing the unknown versions errors).
Apparently, it is working for me because of jitsi-universe.

>
> Guus, I'll help you tonight via chat, okay? I have some questions for
you as
> well :slight_smile:
>
> Ingo
>
> Freundliche Grüsse,
> Ingo Bauersachs
>
> -- sent from my mobile
>
> On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> > > wrote:
>
> I'd love to help out with a PR, but the Maven project fails to build for
me
> (the Ant-project builds just fine).
>
> It appears to be missing the version identifier of the Smack
dependencies.
> How do you guys build this with Maven?
>
> guus@guus-laptop:~/github/jitsi/m2$ git status
> On branch master
> Your branch is up-to-date with 'origin/master'.
> nothing to commit, working tree clean
> guus@guus-laptop:~/github/jitsi$ cd m2
> guus@guus-laptop:~/github/jitsi/m2$ mvn clean
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smackx:jar is missing. @
> org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
> [ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
> missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol-sip:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column
17
> @
> [ERROR] The build could not read 3 projects -> [Help 1]
> [ERROR]
> [ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
> (/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
> [ERROR]
> [ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
> (/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smackx:jar is missing. @
> org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
> [ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
> missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
> [ERROR]
> [ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
> (/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
> [ERROR] 'dependencies.dependency.version' for
> org.igniterealtime.smack:smack:jar is missing. @
> org.jitsi:jitsi-protocol-sip:[unknown-version],
> /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column
17
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/
ProjectBuildingException
> guus@guus-laptop:~/github/jitsi/m2$
>
>
> On 9 August 2017 at 14:25, Guus der Kinderen < > guus.der.kinderen@gmail.com> > > wrote:
>>
>> Ah, I thought you were an expert in everything. :slight_smile: Finally something I
can
>> help you with, instead of the other way around. :slight_smile:
>>
>> I probably am missing something in my development environment to build
>> that project, but that's besides the point - I really don't want to
have to
>> build all Jitsi projects, simply to be able to click through the source
code
>> of one project. There are easier ways to do that. :slight_smile:
>>
>> Maven will allow you to "attach" other artifacts than just the compiled
>> code. A very common thing to do is to attach archive files that contain
the
>> javadoc and uncompiled source code, and install all of those in the
Maven
>> repository (next to the regular .jar file). Most IDEs can automatically
>> download these when available, which means that they do not need to
>> decompile the jar. That is very, very useful, as decompilation rarely
works
>> flawlessly, and still does not restore the javadoc. If you have a look,
>> you'll see that most projects in the central Maven repositories also
include
>> documentation and sources in this manner.
>>
>> How this is done is easy. It's described in
>> https://maven.apache.org/plugin-developers/cookbook/
attach-source-javadoc-artifacts.html
>> (basically, you add two plugins).
>>
>> Could you add this to the parent pom file, and see if compilation now
will
>> generate two extra jar files for each module (-sources and -javadoc
should
>> be in their name). I believe that those artifacts would then be
>> automatically installed in the repository as well (when you deploy
them),
>> although I'm not sure about that. If not, it's probably pretty easy to
do
>> that too).
>>
>> On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:
>>>
>>> That is the source code, I suppose we need to add building/uploading
>>> those in that repo in their pom files. I'm not a maven expert.
>>>
>>> You can build them all together or one by one, depends whether you are
in
>>> m2 folder or any of the artefacts subfolder.
>>>
>>> I'm not sure, what you want to send you, other than zipping the source
>>> ... :slight_smile:
>>> I will check it, but I was building it last week.
>>>
>>> Regards
>>> damencho
>>>
>>>
>>> On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com > > > >>> wrote:
>>>>
>>>> Gotcha. I've tried building that locally, but it fails. Could you
attach
>>>> the source code and javadoc artifacts to what we already have in the
Maven
>>>> repository?
>>>>
>>>> On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> This comes from the desktop client:
>>>>> https://github.com/jitsi/jitsi
>>>>> https://github.com/jitsi/jitsi/tree/master/m2
>>>>>
>>>>> Regards
>>>>> damencho
>>>>>
>>>>> On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen > >>>>> <guus.der.kinderen@gmail.com> wrote:
>>>>> > Hi guys
>>>>> >
>>>>> > Where is the source code of org.jitsi:jitsi-protocol?
>>>>> >
>>>>> > Could you add to the Github Maven repository not just the compiled
>>>>> > jar
>>>>> > files, but also attach the javadoc and source code? (as described
in
>>>>> >
>>>>> > https://maven.apache.org/plugin-developers/cookbook/
attach-source-javadoc-artifacts.html
>>>>> > ). That'd make IDE integration a lot easier.
>>>>> >
>>>>> > Regards,
>>>>> >
>>>>> > Guus
>>>>> >
>>>>> > _______________________________________________
>>>>> > dev mailing list
>>>>> > dev@jitsi.org
>>>>> > Unsubscribe instructions and other list options:
>>>>> > http://lists.jitsi.org/mailman/listinfo/dev
>>>>>
>>>>> _______________________________________________
>>>>> dev mailing list
>>>>> dev@jitsi.org
>>>>> Unsubscribe instructions and other list options:
>>>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> dev mailing list
>>>> dev@jitsi.org
>>>> Unsubscribe instructions and other list options:
>>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#11

Ah, the change in m2/pom.xml in 5a6a106 probably shouldn't have come in.

Thanks, I'll see if you're around. :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

···

On 9 Aug 2017, at 15:52, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Ingo, thanks. I've just found the same thing. If I checkout version 21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn clean` works.

No promises on availability tonight (I have kids to herd) but I'll do my best. You (all) can add my via XMPP at guus.der.kinderen@igniterealtime.org

- Guus

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:
The Maven project is completely broken. I've fixed a lot of stuff in the smack4-2 branch, and cherry-picked some of it back (which might have broken something else).

But: please try not to modify these poms in master too much or you'll cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire module tree. And you need to have jitsi-universe next to jitsi checked out (which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

I'd love to help out with a PR, but the Maven project fails to build for me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:
Ah, I thought you were an expert in everything. :slight_smile: Finally something I can help you with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build that project, but that's besides the point - I really don't want to have to build all Jitsi projects, simply to be able to click through the source code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled code. A very common thing to do is to attach archive files that contain the javadoc and uncompiled source code, and install all of those in the Maven repository (next to the regular .jar file). Most IDEs can automatically download these when available, which means that they do not need to decompile the jar. That is very, very useful, as decompilation rarely works flawlessly, and still does not restore the javadoc. If you have a look, you'll see that most projects in the central Maven repositories also include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html (basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will generate two extra jar files for each module (-sources and -javadoc should be in their name). I believe that those artifacts would then be automatically installed in the repository as well (when you deploy them), although I'm not sure about that. If not, it's probably pretty easy to do that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:
That is the source code, I suppose we need to add building/uploading those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> wrote:
Gotcha. I've tried building that locally, but it fails. Could you attach the source code and javadoc artifacts to what we already have in the Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:
Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#12

To avoid confusion: that's 7cc3d5412f1cde8ec50a3af3f392409b25a6a106 - GIT
shortens hashes by using the first few characters, not the last few. :wink:

···

On 9 August 2017 at 15:56, Ingo Bauersachs <ingo@jitsi.org> wrote:

Ah, the change in m2/pom.xml in 5a6a106 probably shouldn't have come in.

Thanks, I'll see if you're around. :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:52, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

Ingo, thanks. I've just found the same thing. If I checkout version
21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn clean` works.

No promises on availability tonight (I have kids to herd) but I'll do my
best. You (all) can add my via XMPP at guus.der.kinderen@
igniterealtime.org

- Guus

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:

The Maven project is completely broken. I've fixed a lot of stuff in the
smack4-2 branch, and cherry-picked some of it back (which might have broken
something else).

But: please try not to modify these poms in master too much or you'll
cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire
module tree. And you need to have jitsi-universe next to jitsi checked out
(which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you
as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> >> wrote:

I'd love to help out with a PR, but the Maven project fails to build for
me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack
dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/conflu
ence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com >> > wrote:

Ah, I thought you were an expert in *everything*. :slight_smile: Finally something
I can help *you* with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build
that project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source
code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also
include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/pl
ugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now
will generate two extra jar files for each module (-sources and -javadoc
should be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading
those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are
in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source
... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> >>>> wrote:

Gotcha. I've tried building that locally, but it fails. Could you
attach the source code and javadoc artifacts to what we already have in the
Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled
jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-s
ource-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#13

That's not the direct cause, by the way. It's this change (the new parent
project):
https://github.com/jitsi/jitsi/commit/7cc3d5412f1cde8ec50a3af3f392409b25a6a106#diff-6ad6737a15664d3b3676e1e89920fd0b

By reverting back to the old parent, I can execute `mvn install` without an
error.

···

On 9 August 2017 at 16:11, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

To avoid confusion: that's 7cc3d5412f1cde8ec50a3af3f392409b25a6a106 - GIT
shortens hashes by using the first few characters, not the last few. :wink:

On 9 August 2017 at 15:56, Ingo Bauersachs <ingo@jitsi.org> wrote:

Ah, the change in m2/pom.xml in 5a6a106 probably shouldn't have come in.

Thanks, I'll see if you're around. :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:52, Guus der Kinderen <guus.der.kinderen@gmail.com> >> wrote:

Ingo, thanks. I've just found the same thing. If I checkout
version 21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn
clean` works.

No promises on availability tonight (I have kids to herd) but I'll do my
best. You (all) can add my via XMPP at guus.der.kinderen@igniterealti
me.org

- Guus

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:

The Maven project is completely broken. I've fixed a lot of stuff in the
smack4-2 branch, and cherry-picked some of it back (which might have broken
something else).

But: please try not to modify these poms in master too much or you'll
cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire
module tree. And you need to have jitsi-universe next to jitsi checked out
(which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for
you as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> >>> wrote:

I'd love to help out with a PR, but the Maven project fails to build for
me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack
dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is
missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column
17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24,
column 17
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smackx:jar is missing. @
org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28,
column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar
is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43,
column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT
(/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for
org.igniterealtime.smack:smack:jar is missing. @
org.jitsi:jitsi-protocol-sip:[unknown-version],
/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column
17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/conflu
ence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen < >>> guus.der.kinderen@gmail.com> wrote:

Ah, I thought you were an expert in *everything*. :slight_smile: Finally something
I can help *you* with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build
that project, but that's besides the point - I really don't want to have to
build all Jitsi projects, simply to be able to click through the source
code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled
code. A very common thing to do is to attach archive files that contain the
javadoc and uncompiled source code, and install all of those in the Maven
repository (next to the regular .jar file). Most IDEs can automatically
download these when available, which means that they do not need to
decompile the jar. That is very, very useful, as decompilation rarely works
flawlessly, and still does not restore the javadoc. If you have a look,
you'll see that most projects in the central Maven repositories also
include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/pl
ugin-developers/cookbook/attach-source-javadoc-artifacts.html
(basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now
will generate two extra jar files for each module (-sources and -javadoc
should be in their name). I believe that those artifacts would then be
automatically installed in the repository as well (when you deploy them),
although I'm not sure about that. If not, it's probably pretty easy to do
that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:

That is the source code, I suppose we need to add building/uploading
those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are
in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source
... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> >>>>> wrote:

Gotcha. I've tried building that locally, but it fails. Could you
attach the source code and javadoc artifacts to what we already have in the
Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled
jar
> files, but also attach the javadoc and source code? (as described
in
> https://maven.apache.org/plugin-developers/cookbook/attach-s
ource-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#14

Right, the mind when you're tired and rushing out of the office :wink:

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

···

On 9 Aug 2017, at 16:13, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

To avoid confusion: that's 7cc3d5412f1cde8ec50a3af3f392409b25a6a106 - GIT shortens hashes by using the first few characters, not the last few. :wink:

On 9 August 2017 at 15:56, Ingo Bauersachs <ingo@jitsi.org> wrote:
Ah, the change in m2/pom.xml in 5a6a106 probably shouldn't have come in.

Thanks, I'll see if you're around. :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:52, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Ingo, thanks. I've just found the same thing. If I checkout version 21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn clean` works.

No promises on availability tonight (I have kids to herd) but I'll do my best. You (all) can add my via XMPP at guus.der.kinderen@igniterealtime.org

- Guus

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:
The Maven project is completely broken. I've fixed a lot of stuff in the smack4-2 branch, and cherry-picked some of it back (which might have broken something else).

But: please try not to modify these poms in master too much or you'll cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire module tree. And you need to have jitsi-universe next to jitsi checked out (which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

I'd love to help out with a PR, but the Maven project fails to build for me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:
Ah, I thought you were an expert in everything. :slight_smile: Finally something I can help you with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build that project, but that's besides the point - I really don't want to have to build all Jitsi projects, simply to be able to click through the source code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled code. A very common thing to do is to attach archive files that contain the javadoc and uncompiled source code, and install all of those in the Maven repository (next to the regular .jar file). Most IDEs can automatically download these when available, which means that they do not need to decompile the jar. That is very, very useful, as decompilation rarely works flawlessly, and still does not restore the javadoc. If you have a look, you'll see that most projects in the central Maven repositories also include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html (basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will generate two extra jar files for each module (-sources and -javadoc should be in their name). I believe that those artifacts would then be automatically installed in the repository as well (when you deploy them), although I'm not sure about that. If not, it's probably pretty easy to do that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:
That is the source code, I suppose we need to add building/uploading those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> wrote:
Gotcha. I've tried building that locally, but it fails. Could you attach the source code and javadoc artifacts to what we already have in the Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:
Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>>>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#15

That's what I meant, thus the ref to the filename in the commit.

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

···

On 9 Aug 2017, at 16:21, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

That's not the direct cause, by the way. It's this change (the new parent project): https://github.com/jitsi/jitsi/commit/7cc3d5412f1cde8ec50a3af3f392409b25a6a106#diff-6ad6737a15664d3b3676e1e89920fd0b

By reverting back to the old parent, I can execute `mvn install` without an error.

On 9 August 2017 at 16:11, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:
To avoid confusion: that's 7cc3d5412f1cde8ec50a3af3f392409b25a6a106 - GIT shortens hashes by using the first few characters, not the last few. :wink:

On 9 August 2017 at 15:56, Ingo Bauersachs <ingo@jitsi.org> wrote:
Ah, the change in m2/pom.xml in 5a6a106 probably shouldn't have come in.

Thanks, I'll see if you're around. :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:52, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Ingo, thanks. I've just found the same thing. If I checkout version 21b560c6ccf46f8414e856c1484acb50d3b03855 then at least `mvn clean` works.

No promises on availability tonight (I have kids to herd) but I'll do my best. You (all) can add my via XMPP at guus.der.kinderen@igniterealtime.org

- Guus

On 9 August 2017 at 15:44, Ingo Bauersachs <ingo@jitsi.org> wrote:
The Maven project is completely broken. I've fixed a lot of stuff in the smack4-2 branch, and cherry-picked some of it back (which might have broken something else).

But: please try not to modify these poms in master too much or you'll cause me a really hard time with merging.

Building a subcomponent definitely doesn't work, you need the entire module tree. And you need to have jitsi-universe next to jitsi checked out (which is most likely causing the unknown versions errors).

Guus, I'll help you tonight via chat, okay? I have some questions for you as well :slight_smile:

Ingo

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

On 9 Aug 2017, at 15:32, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

I'd love to help out with a PR, but the Maven project fails to build for me (the Ant-project builds just fine).

It appears to be missing the version identifier of the Smack dependencies. How do you guys build this with Maven?

guus@guus-laptop:~/github/jitsi/m2$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
guus@guus-laptop:~/github/jitsi$ cd m2
guus@guus-laptop:~/github/jitsi/m2$ mvn clean
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol/pom.xml, line 20, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-jabber:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 24, column 17
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smackx:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 28, column 17
[ERROR] 'dependencies.dependency.version' for org.xmpp:jnsapi:jar is missing. @ org.jitsi:jitsi-protocol-jabber:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-jabber/pom.xml, line 43, column 17
[ERROR]
[ERROR] The project org.jitsi:jitsi-protocol-sip:2.11-SNAPSHOT (/home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.igniterealtime.smack:smack:jar is missing. @ org.jitsi:jitsi-protocol-sip:[unknown-version], /home/guus/github/jitsi/m2/jitsi-protocol-sip/pom.xml, line 52, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
guus@guus-laptop:~/github/jitsi/m2$

On 9 August 2017 at 14:25, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:
Ah, I thought you were an expert in everything. :slight_smile: Finally something I can help you with, instead of the other way around. :slight_smile:

I probably am missing something in my development environment to build that project, but that's besides the point - I really don't want to have to build all Jitsi projects, simply to be able to click through the source code of one project. There are easier ways to do that. :slight_smile:

Maven will allow you to "attach" other artifacts than just the compiled code. A very common thing to do is to attach archive files that contain the javadoc and uncompiled source code, and install all of those in the Maven repository (next to the regular .jar file). Most IDEs can automatically download these when available, which means that they do not need to decompile the jar. That is very, very useful, as decompilation rarely works flawlessly, and still does not restore the javadoc. If you have a look, you'll see that most projects in the central Maven repositories also include documentation and sources in this manner.

How this is done is easy. It's described in https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html (basically, you add two plugins).

Could you add this to the parent pom file, and see if compilation now will generate two extra jar files for each module (-sources and -javadoc should be in their name). I believe that those artifacts would then be automatically installed in the repository as well (when you deploy them), although I'm not sure about that. If not, it's probably pretty easy to do that too).

On 9 August 2017 at 14:06, Damian Minkov <damencho@jitsi.org> wrote:
That is the source code, I suppose we need to add building/uploading those in that repo in their pom files. I'm not a maven expert.

You can build them all together or one by one, depends whether you are in m2 folder or any of the artefacts subfolder.

I'm not sure, what you want to send you, other than zipping the source ... :slight_smile:
I will check it, but I was building it last week.

Regards
damencho

On Aug 9, 2017 14:52, "Guus der Kinderen" <guus.der.kinderen@gmail.com> wrote:
Gotcha. I've tried building that locally, but it fails. Could you attach the source code and javadoc artifacts to what we already have in the Maven repository?

On 9 August 2017 at 12:05, Damian Minkov <damencho@jitsi.org> wrote:
Hi,

This comes from the desktop client:
https://github.com/jitsi/jitsi
https://github.com/jitsi/jitsi/tree/master/m2

Regards
damencho

On Wed, Aug 9, 2017 at 4:58 AM, Guus der Kinderen >>>>>>>>>> <guus.der.kinderen@gmail.com> wrote:
> Hi guys
>
> Where is the source code of org.jitsi:jitsi-protocol?
>
> Could you add to the Github Maven repository not just the compiled jar
> files, but also attach the javadoc and source code? (as described in
> https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html
> ). That'd make IDE integration a lot easier.
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev