[jitsi-dev] weupnp forked?


#1

Dear developers,

We use the library weupnp in the project ice4j. We have a file
weupnp.zip in the project libsrc which I assume is the source code of
the library weupnp that we use. Git log on libsrc/weupnp.zip gives the
following:

commit 43f5d076ae6487befc7651e5b1ac73fe62d817fa
Author: Hristo Terezov <hristo@jitsi.org>

···

Date: Thu Apr 25 14:41:29 2013 +0000

    Adds timeout for reading the response from devices in
GatewayDevice.loadDescription

commit 2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3
Author: Damian Minkov <damencho@jitsi.org>
Date: Thu Jan 17 12:02:30 2013 +0000

    Updates some build targets (and linux cpp and linker flags for jdic)

commit b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87
Author: Damian Minkov <damencho@jitsi.org>
Date: Sat Sep 29 15:03:00 2012 +0000

    Updates library sources.

Checking out libsrc/weupnp.zip from each of these 3 commits and
manually diff-ing gives the following differences:

diff --minimal --recursive
weupnp.zip-b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
62c62,65
< private static final int TIMEOUT = 3000;
---

    private static final int TIMEOUT = 1500;

    private final String stSearch;

73a77,82

        this.stSearch = "upnp:rootdevice";
    }

    public GatewayDiscover(String stSearch)
    {
        this.stSearch = stSearch;

diff --minimal --recursive
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
weupnp.zip-43f5d076ae6487befc7651e5b1ac73fe62d817fa/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
97a98,102

    /**
     * The timeout in milliseconds for receiving response.
     */
    private static final int TIMEOUT = 750;

119c124,125
<
---

        urlConn.setReadTimeout(TIMEOUT);

I don't see the changes above at https://github.com/bitletorg/weupnp.
Am I correct to assume that we've practically "forked" weupnp? If yes,
may I create a repository for the "fork" so that we may easily track
the changes (and facilitate my work on Maven-izing the project ice4j)?

Best regards,
Lyubo Marinov


#2

Lyubo, yes I think you are correct and you can create the fork.

Emil

···

On Thu, Jun 18, 2015 at 6:10 PM, Lyubomir Marinov <lyubomir.marinov@jitsi.org> wrote:

Dear developers,

We use the library weupnp in the project ice4j. We have a file
weupnp.zip in the project libsrc which I assume is the source code of
the library weupnp that we use. Git log on libsrc/weupnp.zip gives the
following:

commit 43f5d076ae6487befc7651e5b1ac73fe62d817fa
Author: Hristo Terezov <hristo@jitsi.org>
Date: Thu Apr 25 14:41:29 2013 +0000

    Adds timeout for reading the response from devices in
GatewayDevice.loadDescription

commit 2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3
Author: Damian Minkov <damencho@jitsi.org>
Date: Thu Jan 17 12:02:30 2013 +0000

    Updates some build targets (and linux cpp and linker flags for jdic)

commit b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87
Author: Damian Minkov <damencho@jitsi.org>
Date: Sat Sep 29 15:03:00 2012 +0000

    Updates library sources.

Checking out libsrc/weupnp.zip from each of these 3 commits and
manually diff-ing gives the following differences:

diff --minimal --recursive
weupnp.zip-b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
62c62,65
< private static final int TIMEOUT = 3000;
---

    private static final int TIMEOUT = 1500;

    private final String stSearch;

73a77,82

        this.stSearch = "upnp:rootdevice";
    }

    public GatewayDiscover(String stSearch)
    {
        this.stSearch = stSearch;

diff --minimal --recursive
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
weupnp.zip-43f5d076ae6487befc7651e5b1ac73fe62d817fa/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
97a98,102

    /**
     * The timeout in milliseconds for receiving response.
     */
    private static final int TIMEOUT = 750;

119c124,125
<
---

        urlConn.setReadTimeout(TIMEOUT);

I don't see the changes above at https://github.com/bitletorg/weupnp.
Am I correct to assume that we've practically "forked" weupnp? If yes,
may I create a repository for the "fork" so that we may easily track
the changes (and facilitate my work on Maven-izing the project ice4j)?

Best regards,
Lyubo Marinov

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#3

Hi Lyubo,

I don't remember what was the status of weupnp but I don't mind to fork it.

Regards,
Hristo.

···

On Jun 18, 2015, at 7:10 PM, Lyubomir Marinov <lyubomir.marinov@jitsi.org> wrote:

Dear developers,

We use the library weupnp in the project ice4j. We have a file
weupnp.zip in the project libsrc which I assume is the source code of
the library weupnp that we use. Git log on libsrc/weupnp.zip gives the
following:

commit 43f5d076ae6487befc7651e5b1ac73fe62d817fa
Author: Hristo Terezov <hristo@jitsi.org>
Date: Thu Apr 25 14:41:29 2013 +0000

   Adds timeout for reading the response from devices in
GatewayDevice.loadDescription

commit 2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3
Author: Damian Minkov <damencho@jitsi.org>
Date: Thu Jan 17 12:02:30 2013 +0000

   Updates some build targets (and linux cpp and linker flags for jdic)

commit b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87
Author: Damian Minkov <damencho@jitsi.org>
Date: Sat Sep 29 15:03:00 2012 +0000

   Updates library sources.

Checking out libsrc/weupnp.zip from each of these 3 commits and
manually diff-ing gives the following differences:

diff --minimal --recursive
weupnp.zip-b7b997d16c9c4dc3cb0e84dba4dd592b01f86f87/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDiscover.java
62c62,65
< private static final int TIMEOUT = 3000;
---

   private static final int TIMEOUT = 1500;

   private final String stSearch;

73a77,82

       this.stSearch = "upnp:rootdevice";
   }

   public GatewayDiscover(String stSearch)
   {
       this.stSearch = stSearch;

diff --minimal --recursive
weupnp.zip-2780bdf12e28e90d20ee1bcabf3f1cb91b33e2a3/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
weupnp.zip-43f5d076ae6487befc7651e5b1ac73fe62d817fa/weupnp/src/main/java/org/bitlet/weupnp/GatewayDevice.java
97a98,102

   /**
    * The timeout in milliseconds for receiving response.
    */
   private static final int TIMEOUT = 750;

119c124,125
<
---

       urlConn.setReadTimeout(TIMEOUT);

I don't see the changes above at https://github.com/bitletorg/weupnp.
Am I correct to assume that we've practically "forked" weupnp? If yes,
may I create a repository for the "fork" so that we may easily track
the changes (and facilitate my work on Maven-izing the project ice4j)?

Best regards,
Lyubo Marinov

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Thank you very much, Emil and Hristo! We now have a jitsi branch in
the jitsi/weupnp fork of the bitletorg/weupnp GitHub project which is
equivalent to the contents of jitsi/libsrc/weupnp.zip.