[jitsi-dev] [VOTE] Tom Denham for committer


#1

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

···

--
https://jitsi.org


#2

[ x ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Ingo


#3

<snip>

A question regarding the vetting process here - how does the Jitsi dev team deal with the issue of trust?

Say I had motives to backdoor Jitsi. Would it only cost me one developer-month fees to get rw access to the codebase?

Obviously this is a general question and has got nothing to do with Tom as a person, as we're not acquainted.

[ ] +1 Accept Tom as a committer.
[ x ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Thanks

Alex

···

On 24/11/12 12:15, Emil Ivov wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.


#4

[ X ] +1 Accept Tom as a committer.

Cheers,
Koos Pol

···

--
http://www.malarianomore.org
Voor $10,= een muskietennet + distributie + voorlichting + nazorg + evaluatie.


#5

+1 Accept Tom as a committer.

Cheers,
Yana

···

On Nov 24, 2012, at 1:15 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#6

[ X ] +1 Accept Tom as a committer.

···

On Sat, Nov 24, 2012 at 2:15 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#7

Hi,

[ X ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Regards,

···

--
Seb

Le 24/11/2012 13:15, Emil Ivov a �crit :

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess


#8

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

+1 (non-binding)

Even though I hardly ever speak up here, I keep following the development, and from what I have observed, he would be a great addition to the team.

Greetings, Marcel


#9

[ V ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Emil

···

On 24.11.12, 13:15, Emil Ivov wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#10

+1 Accept Tom as a committer.

Boris


#11

Hello there,

Even though I'll miss the patches submission flood, I say

[ X ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Cheers,
Jean

···

On Sat, Nov 24, 2012 at 9:15 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#12

+1 Accept Tom as a committer.

···

On 24.11.2012, at 14:15, Emil Ivov <emcho@jitsi.org> wrote:

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.


#13

Hi,

We are now ready to close this vote.

Vote summary:

+1 Accept Tom as a committer: Jean Lorchat, Damian Minkov, Koos Pol,
Yana Stamcheva, Sebastien Vincent, Marcel Offermans, Boris Grozev, Emil
Ivov, Ingo Bauersachs, Dennis Lazreg, Lyubomir Marinov.

0 Does not matter to me: Alexandros Papadopoulos

-1 Reject Tom as a committer: 0

Congratulations Tom, you're now officially part of the Jitsi dev team!
Glad to have you among us!

Cheers,
Emil

···

On 24.11.12, 13:15, Emil Ivov wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#14

Hey Alex,

(Spinning off to a new thread to avoid problems in vote counting.)

Inline.

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

<snip>

A question regarding the vetting process here - how does the Jitsi dev
team deal with the issue of trust?

Say I had motives to backdoor Jitsi. Would it only cost me one
developer-month fees to get rw access to the codebase?

I guess that's one way to put it. There's no specific time frame, it's
mostly a matter of what and how many changes one makes. Eventually
though, anyone who contributes reasonable and useful code would be
invited to join the dev team.

The reason we go through this is to make sure we only allow developers
who are careful, know their way around the code and would not open more
work for other developers once they start committing.

This part of the process does not aim to ensure that developers have no
malicious intentions.

The part that does cover that is everyone's day to day work and scrutiny
of code that gets committed in Jitsi. It is not possible for someone to
just secretly commit something. Once you do commit, your change triggers
commit mails and then every developer would see the change arriving in
their sandbox. Changes are reviewed once when they are committed and
they are then available in our repository for the whole world to see.

Hope this makes things clearer.

Cheers,
Emil

···

On 24.11.12, 14:35, Alexandros Papadopoulos wrote:

On 24/11/12 12:15, Emil Ivov wrote:

Obviously this is a general question and has got nothing to do with Tom
as a person, as we're not acquainted.

[ ] +1 Accept Tom as a committer.
[ x ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Thanks

Alex

--
https://jitsi.org


#15

Hello,

Starting with build 4342.10100 my Jitsi seems to forget my Yahoo
accounts password (the "save password box was checked every time) and
asks for it whenever i restart Jitsi.

···

--
O zi buna,

Kertesz Laszlo


#16

[ X ] +1 Accept Tom as a committer

Cell Phone: +47 913 74 344

···

________________________________
De : Damian Minkov <damencho@jitsi.org>
À : dev@jitsi.java.net
Envoyé le : Samedi 24 novembre 2012 14h31
Objet : [jitsi-dev] Re: [VOTE] Tom Denham for committer
  
[ X ] +1 Accept Tom as a committer.

On Sat, Nov 24, 2012 at 2:15 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a number
of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information is
available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also display
the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am calling
this vote on granting him the java.net Developer role. Please vote on
the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged since
they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org/


#17

Great news! Thanks everyone for voting me in and welcoming me to the dev team. I'm looking forward to making a continued contribution.

A quick bit about myself: I'm a Java software developer based in north London working for a telecoms software company. I've been working with Jitsi since the early summer and I have plenty more useful patches in the pipeline! If anyone would like know more, feel free to contact me directly.

Thanks
Tom

···

-----Original Message-----

From: Emil Ivov [mailto:emcho@jitsi.org]

Sent: 27 November 2012 11:37
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: [VOTE] Tom Denham for committer

Hi,

We are now ready to close this vote.

Vote summary:

+1 Accept Tom as a committer: Jean Lorchat, Damian Minkov, Koos Pol,
Yana Stamcheva, Sebastien Vincent, Marcel Offermans, Boris Grozev, Emil Ivov, Ingo Bauersachs, Dennis Lazreg, Lyubomir Marinov.

0 Does not matter to me: Alexandros Papadopoulos

-1 Reject Tom as a committer: 0

Congratulations Tom, you're now officially part of the Jitsi dev team!
Glad to have you among us!

Cheers,
Emil

On 24.11.12, 13:15, Emil Ivov wrote:

Hello all,

I would like to call a vote for granting commit rights (java.net
Developer role) to Tom Denham.

Tom started contributing exactly a month ago and has submitted a
number of useful and reasonable patches (exactly the way we like them):

* Patched up the case where calls were being wrongly accepted and the
only mutually supported payload type was telephone-event.
* Patched an NPE thrown when a schemeless URL is clicked in the chat
window.
* Added a missing resource and fixed an incorrectly set tooltip.
* Added a property to allow disabling sip messaging.
* Added option for scheduling updates once a day (rather than only at
startup).
* Improved Yahoo login to re-ask for credentials on error.
* Added an option to hide stacktrace from error dialog.
* Added an option to disable videobridge,
* Made sure we did not attempt to show call info when no information
is available.
* Contributed patch to support protocols without wizards.
* Modified the Voicemail notifications GUI so that it would also
display the number of urgent voicemail messages.
* Submitted a patch to avoid dialing empty numbers and option to check
remember password by default.

So therefore, according to the procedure described in [0], I am
calling this vote on granting him the java.net Developer role. Please
vote on the following:

[ ] +1 Accept Tom as a committer.
[ ] 0 Does not matter to me.
[ ] -1 Reject Tom as a committer.

Note: Votes from non-developers (non-binding votes) are encouraged
since they show the general opinion of the Jitsi community.

Cheers,
Emil

[0] Becoming a Jitsi Committer - https://jitsi.org/commitaccess

--
https://jitsi.org


#18

A question regarding the vetting process here - how does the Jitsi dev
team deal with the issue of trust?

Say I had motives to backdoor Jitsi. Would it only cost me one
developer-month fees to get rw access to the codebase?

I guess that's one way to put it. There's no specific time frame, it's
mostly a matter of what and how many changes one makes. Eventually
though, anyone who contributes reasonable and useful code would be
invited to join the dev team.

Also, Emil (or some other developers) usually has also had offlist-contact
to know someone a bit better.

The reason we go through this is to make sure we only allow developers
who are careful, know their way around the code and would not open more
work for other developers once they start committing.

This is not specific to anyone, but I kind of miss some short bio of new
committers. I can of course easily google the E-Mail address to get an
impression, but a three-liner description about the general interest in
Jitsi would be nice.

This part of the process does not aim to ensure that developers have no
malicious intentions.

The part that does cover that is everyone's day to day work and scrutiny
of code that gets committed in Jitsi. It is not possible for someone to
just secretly commit something. Once you do commit, your change triggers
commit mails and then every developer would see the change arriving in
their sandbox. Changes are reviewed once when they are committed and
they are then available in our repository for the whole world to see.

Hope this makes things clearer.

Cheers,
Emil

Regards,
Ingo


#19

Hey Ingo,

A question regarding the vetting process here - how does the Jitsi dev
team deal with the issue of trust?

Say I had motives to backdoor Jitsi. Would it only cost me one
developer-month fees to get rw access to the codebase?

I guess that's one way to put it. There's no specific time frame, it's
mostly a matter of what and how many changes one makes. Eventually
though, anyone who contributes reasonable and useful code would be
invited to join the dev team.

Also, Emil (or some other developers) usually has also had offlist-contact
to know someone a bit better.

The reason we go through this is to make sure we only allow developers
who are careful, know their way around the code and would not open more
work for other developers once they start committing.

This is not specific to anyone, but I kind of miss some short bio of new
committers. I can of course easily google the E-Mail address to get an
impression, but a three-liner description about the general interest in
Jitsi would be nice.

Indeed. Let's try this out in the future. This time we can let Tom
present himself once the vote completes.

Cheers,
Emil

···

On 24.11.12, 17:37, Ingo Bauersachs wrote:

This part of the process does not aim to ensure that developers have no
malicious intentions.

The part that does cover that is everyone's day to day work and scrutiny
of code that gets committed in Jitsi. It is not possible for someone to
just secretly commit something. Once you do commit, your change triggers
commit mails and then every developer would see the change arriving in
their sandbox. Changes are reviewed once when they are committed and
they are then available in our repository for the whole world to see.

Hope this makes things clearer.

Cheers,
Emil

Regards,
Ingo

--
https://jitsi.org


#20

Hi Kertesz,

it is fixed now and will be available in next build.
Thanks for the quick report.

Cheers
damencho

···

On Sat, Nov 24, 2012 at 7:08 PM, Kertesz Laszlo <laszlo.kertesz@gmail.com> wrote:

Hello,

Starting with build 4342.10100 my Jitsi seems to forget my Yahoo
accounts password (the "save password box was checked every time) and
asks for it whenever i restart Jitsi.

--
O zi buna,

Kertesz Laszlo