[jitsi-dev] Version log change


#1

Hi,

I've noticed recently that some people are sending us logs and say
we've updated to version X and we had a problem, here are the previous
logs before the update, and in the logs we cannot see the version.
I wanted to change the logging of version to be info so it goes in the
logs and be visible when they send it to us.
Is it ok? WDYT?

damencho

···

===================================================================
--- src/net/java/sip/communicator/impl/version/VersionActivator.java
(revision
9293)
+++ src/net/java/sip/communicator/impl/version/VersionActivator.java
(revision )
@@ -66,8 +66,10 @@
                    null);
        if (logger.isDebugEnabled())
            logger.debug("SIP Protocol Provider Factory ... [REGISTERED]");
- if (logger.isDebugEnabled())
- logger.debug("SIP Communicator Version: sip-communicator-"
+ if (logger.isInfoEnabled())
+ logger.info("Jitsi Version: "
+ + VersionImpl.currentVersion().getApplicationName()
+ + " "
                     + VersionImpl.currentVersion().toString());

        //register properties for those that would like to use them


#2

Hey

I've noticed recently that some people are sending us logs and say
we've updated to version X and we had a problem, here are the previous
logs before the update, and in the logs we cannot see the version.
I wanted to change the logging of version to be info so it goes in the
logs and be visible when they send it to us.
Is it ok? WDYT?

Sound reasonable.
Could you also change the copy-paste stuff of "SIP Protocol Provider
Factory" when you work on that class anyway? :slight_smile:

damencho

Ingo


#3

Yup agreed!

···

On Friday, January 20, 2012, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

I've noticed recently that some people are sending us logs and say
we've updated to version X and we had a problem, here are the previous
logs before the update, and in the logs we cannot see the version.
I wanted to change the logging of version to be info so it goes in the
logs and be visible when they send it to us.
Is it ok? WDYT?

damencho

===================================================================
--- src/net/java/sip/communicator/impl/version/VersionActivator.java
(revision
9293)
+++ src/net/java/sip/communicator/impl/version/VersionActivator.java
(revision )
@@ -66,8 +66,10 @@
                   null);
       if (logger.isDebugEnabled())
           logger.debug("SIP Protocol Provider Factory ... [REGISTERED]");
- if (logger.isDebugEnabled())
- logger.debug("SIP Communicator Version: sip-communicator-"
+ if (logger.isInfoEnabled())
+ logger.info("Jitsi Version: "
+ + VersionImpl.currentVersion().getApplicationName()
+ + " "
                    + VersionImpl.currentVersion().toString());

       //register properties for those that would like to use them

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
http://jitsi.org FAX: +33.1.77.62.47.31


#4

Haha, I even haven't noticed it :slight_smile: will do,Thanks!

···

On Fri, Jan 20, 2012 at 11:18 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Could you also change the copy-paste stuff of "SIP Protocol Provider
Factory" when you work on that class anyway? :slight_smile: