What do you think about also running jshint as part of the app target in the Makefile?
From: dev [mailto:email@example.com] On Behalf Of Emil Ivov
Sent: Friday, September 11, 2015 8:35 AM
To: Jitsi Developers
Subject: Re: [jitsi-dev] Using jshint in jitsi-meet
On Friday, September 11, 2015, Boris Grozev <firstname.lastname@example.org<mailto:email@example.com>> wrote:
I've created a 'lint' branch in Jitsi-Meet that:
1. Fixes (or disables) all jshint warnings.
2. Includes "precommit-hook" from npm, which runs jshint and doesn't allow you to commit unless it passes cleanly.
I'm not sure that we want to go as far as that second step,
as it may be too inconvenient for daily usage, or even cause some problems (i.e. with pootle, jenkins).
Thanks for commenting Ingo!
I think running jshint one way or another is quite useful. Just going over existing code to fix the warnings revealed a bug, which would have been noticed and fixed right away if we'd used jshint at the time.
Any thoughts about merging either part 1 or both into master?
I say: if no developer objects by tonight, let's just go ahead with it.
dev mailing list
Unsubscribe instructions and other list options:
sent from my mobile
This email message is for the sole use of the intended recipient(s) and may contain information that is privileged, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, copying, disclosure or dissemination is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.