[jitsi-dev] Updating a smack patch


#1

Hey (Damian?)

Do I need to consider something special when I need to replace the
smack-lib?
Am I right that the src-zip already has all patches applied?

(I've replaced 01-xmppconnection.patch to replace Smack's SSLContext instead
of only setting a trust manager.)

Ingo


#2

Hi Ingo,

Do I need to consider something special when I need to replace the
smack-lib?
Am I right that the src-zip already has all patches applied?

yes, the zip file is with patches applied for easy of use (debugging)
and for the deb packaging (I think only the build.xml was modified
when doing the debian package to avoid some not needed dependencies,
there is build.xml and build.xml.orig in the zip file, maybe I need to
document this).
The patches I decided to keep, to track all of the changes.
Some of the patches were already applied to current smack trunk,
others were applied with changes ... but once we decide to upgrade
smack we will come to checking this :slight_smile:

Thanks
damencho

···

On Tue, Apr 9, 2013 at 10:30 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:


#3

Do I need to consider something special when I need to replace the
smack-lib?
Am I right that the src-zip already has all patches applied?

yes, the zip file is with patches applied for easy of use (debugging)
and for the deb packaging (I think only the build.xml was modified
when doing the debian package to avoid some not needed dependencies,
there is build.xml and build.xml.orig in the zip file, maybe I need to
document this).

Okay, thanks, I think I got it right yesterday evening.

The patches I decided to keep, to track all of the changes.
Some of the patches were already applied to current smack trunk,
others were applied with changes ... but once we decide to upgrade
smack we will come to checking this :slight_smile:

Keeping the patches is indeed useful.
I haven't kept track of what was applied to the trunk, but I'm not really
surprised that they changed some patches. At least the trust manager thing
(or now the entire SSLContext) would probably be better placed in one of
their connection configuration classes. So if we try to get all of the
patches into their trunk, we might need to clean them up a bit.

Thanks
damencho

Ingo

···

On Tue, Apr 9, 2013 at 10:30 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:


#4

That indeed was one of their changes when applying that particular
patch :slight_smile: moving the stuff to connection configuration.

···

On Wed, Apr 10, 2013 at 10:06 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:

At least the trust manager thing
(or now the entire SSLContext) would probably be better placed in one of
their connection configuration classes. So if we try to get all of the
patches into their trunk, we might need to clean them up a bit.