[jitsi-dev] Update BouncyCastle to 1.54 (and other PR)


#1

Hi all,

I first submitted my PR to update BouncyCastle on 08/01/16, roughly 3 month
ago.
I know you are busy improving jitsi, but i'd be very happy if my 10+
pending PRs
can be merged or reviewed or even rejected
https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Achamptar

Thanks
Etienne


#2

Hey Etienne,

I apologise for the delay!

We will have them all reviewed and (not counting modification requests) merged this week.

Emil

···

On 4.04.16 г. 8:19, Etienne Champetier wrote:

Hi all,

I first submitted my PR to update BouncyCastle on 08/01/16, roughly 3
month ago.
I know you are busy improving jitsi, but i'd be very happy if my 10+
pending PRs
can be merged or reviewed or even rejected
https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Achamptar

Thanks
Etienne

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#3

Dear Etienne,

Thank you very much for the multitude of excellent contributions!

I'd like to apologize again for the delay.

We do appreciate your work and during the last couple of days we put
significant focus and effort in merging as many of your PRs as
possible. Anyway, there are unmerged PRs left and I'd like to notify
you why I cannot merge them at this time:

- https://github.com/jitsi/bccontrib/pull/2
@ibauersachs has commented: I can't add this until jitsi-universe is
on Maven central. And then it needs pinned versions there.

- https://github.com/jitsi/jitsi-meet/pull/541
I don't understand nginx configuration enough to feel comfortable
merging that. I talked to @damencho and he shared that he's tested it
but he doesn't feel confident either.

- https://github.com/jitsi/libjitsi/pull/110
You've committed to rebasing it after the merge of BouncyCastle. (I'd
also like to share that I prefer standalone PRs that do one thing and
have PR dependencies expressed through comments.)

- https://github.com/jitsi/jitsi/pull/234
@ibauersachs has put it on hold.

- https://github.com/jitsi/libjitsi/pull/80
I've assigned it to myself, I've reviewed it, and I want to merge at
least parts of it. We have an recent and/or ongoing discussion there.
I'll try my best to act on it this week.

- https://github.com/jitsi/smack_3_2_2/pull/1
I'm not sure about this, I need to review it again.

I hope we've managed in the last couple of days to alleviate at least
some of your frustration with the delay we'd caused.

Best regards,
Lyubo


#4

Hi all

Dear Etienne,

Thank you very much for the multitude of excellent contributions!

My pleasure!

I'd like to apologize again for the delay.

We do appreciate your work and during the last couple of days we put
significant focus and effort in merging as many of your PRs as
possible. Anyway, there are unmerged PRs left and I'd like to notify
you why I cannot merge them at this time:

I've seen that, and I meant to write to thank you all guys for the effort.
This really means a lot to me to have my work merged.
(also less maintenance work in the future :slight_smile: )

I'll take care of the PR tomorrow.

- https://github.com/jitsi/bccontrib/pull/2
@ibauersachs has commented: I can't add this until jitsi-universe is
on Maven central. And then it needs pinned versions there.

- https://github.com/jitsi/jitsi-meet/pull/541
I don't understand nginx configuration enough to feel comfortable
merging that. I talked to @damencho and he shared that he's tested it
but he doesn't feel confident either.

- https://github.com/jitsi/libjitsi/pull/110
You've committed to rebasing it after the merge of BouncyCastle. (I'd
also like to share that I prefer standalone PRs that do one thing and
have PR dependencies expressed through comments.)

- https://github.com/jitsi/jitsi/pull/234
@ibauersachs has put it on hold.

- https://github.com/jitsi/libjitsi/pull/80
I've assigned it to myself, I've reviewed it, and I want to merge at
least parts of it. We have an recent and/or ongoing discussion there.
I'll try my best to act on it this week.

- https://github.com/jitsi/smack_3_2_2/pull/1
I'm not sure about this, I need to review it again.

I hope we've managed in the last couple of days to alleviate at least
some of your frustration with the delay we'd caused.

The delay in itself is not a problem, but with time, conflicts or duplicate
modifications come up,
and it already happened to me on another project to rework multiple times
on my patches,
and in the end have them rejected (too intrusive), so I was a bit worried.

Also when I have too many pending PRs I might miss dependencies between
them.
(SecureRandom and BC update)

Thanks again and get ready for more PRs :wink:

···

2016-04-06 18:16 GMT+02:00 Lyubomir Marinov <lyubomir.marinov@jitsi.org>:

Best regards,
Lyubo