[jitsi-dev] Unit tests failing in jitsi-videobridge


#1

I just pulled build 946 of the videobridge into my fork and the build is failing because one of the tests is failing. This commit<https://github.com/jitsi/jitsi-videobridge/commit/53a9ba0245f4fda2183e620869d8940d74f5c0b0> is the culprit but I am not quite sure if the test needs to be updated to fit new behavior or if the logic added has a bug in it. This is the failing test: https://github.com/jitsi/jitsi-videobridge/blob/master/src/test/java/org/jitsi/videobridge/FocusControlTest.java#L153 because the default behavior with no config is now to allow the conference iq. Was that an intentional change or should it still return not authorized by default if no focus jid is specified and there's no authorizedSourcePattern?

Devin Wilson

Disclaimer

The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website.


#2

Hi Devin,

I just pulled build 946 of the videobridge into my fork and the build is
failing because one of the tests is failing. This commit
<https://github.com/jitsi/jitsi-videobridge/commit/53a9ba0245f4fda2183e620869d8940d74f5c0b0>
is the culprit but I am not quite sure if the test needs to be updated
to fit new behavior or if the logic added has a bug in it. This is the
failing test:
https://github.com/jitsi/jitsi-videobridge/blob/master/src/test/java/org/jitsi/videobridge/FocusControlTest.java#L153
because the default behavior with no config is now to allow the
conference iq. Was that an intentional change or should it still return
not authorized by default if no focus jid is specified and there’s no
authorizedSourcePattern?

Thank you for reporting this! I thought these tests ran with the functional tests on each build, but apparently they don't so we missed this.

It isn't clear what behavior we want here, because this is a corner case that is never reached (with XMPP we always have focus != null, and with REST we always have the ALLOW_NO_FOCUS option set). So I've changed to the more strict option: rejecting when focus==null, unless ALLOW_NO_FOCUS is set and this makes the test happy (the PR is here[0]).

Regards,
Boris

[0] https://github.com/jitsi/jitsi-videobridge/pull/469

···

On 09/05/2017 11:12, Devin Wilson wrote: