[jitsi-dev] Thumbnail sometimes is not visible in Chromium


#1

Hi, Jitsi team!

I would like to mention something that I note at times in Chromium.
Sometimes the thumbnail is not on the screen. I'm not sure what could be
the cause because I think this does not happen in Firefox (at least I do
not remember seeing it).

In addition, when this happens, the button to invite people that is
usually under the thumbnail, appears shifted to the right outside the
visible space of the screen. You can barely see the left edge of that
button.

Here you can see a screenshot.

https://ibin.co/3fhBQ50lc4cd.jpg

Can you replicate it?

Thanks in advance.

Kind regards,
Daniel


#2

I may have seen this happen before on beta. When I see it happen, the local
thumbnail appears collapsed and off screen, which looks kind of like what
you see. When I toggle the filmstrip visibility the issue resolves itself.
If that's the case for you, then it may be the same cause, which is a
dependency load order issue. The jitsi-meet javascript does dimension
checks on the dom to resize some elements, including local thumbnail. If it
happens that css finishes loading after the javascript bundle loads and
executes, the resizing will be off and cause visual issues. That load order
issue is on jitsi's radar and hopefully it is the same issue you're
encountering.

···

On Tue, Oct 31, 2017 at 9:00 AM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Jitsi team!

I would like to mention something that I note at times in Chromium.
Sometimes the thumbnail is not on the screen. I'm not sure what could be
the cause because I think this does not happen in Firefox (at least I do
not remember seeing it).

In addition, when this happens, the button to invite people that is
usually under the thumbnail, appears shifted to the right outside the
visible space of the screen. You can barely see the left edge of that
button.

Here you can see a screenshot.

https://ibin.co/3fhBQ50lc4cd.jpg

Can you replicate it?

Thanks in advance.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi, Leonard.

I may have seen this happen before on beta. When I see it happen, the
local thumbnail appears collapsed and off screen, which looks kind of
like what you see. When I toggle the filmstrip visibility the issue
resolves itself. If that's the case for you, then it may be the same
cause, which is a dependency load order issue. The jitsi-meet javascript
does dimension checks on the dom to resize some elements, including
local thumbnail. If it happens that css finishes loading after the
javascript bundle loads and executes, the resizing will be off and cause
visual issues. That load order issue is on jitsi's radar and hopefully
it is the same issue you're encountering.

Thanks for your reply.

So it is a race condition? Maybe that explains why sometimes it happens
and sometimes it does not.

The strange thing is that I have only found this behavior in Chromium
and not in Firefox.

What do you mean by "toggle the filmstrip visibility"? To make some
change in interface_config.js?

Kind regards,
Daniel

···

On 31/10/17 13:23, Leonard Kim wrote:


#4

When I said toggle I meant the little caret looking icon at the end of the
filmstrip or pressing the F key to make the filmstrip either slide off
screen or slide back on screen. That forces recalculations by the
javascript and by that time the css should be loaded.

···

On Tue, Oct 31, 2017 at 11:13 AM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Leonard.

On 31/10/17 13:23, Leonard Kim wrote:

> I may have seen this happen before on beta. When I see it happen, the
> local thumbnail appears collapsed and off screen, which looks kind of
> like what you see. When I toggle the filmstrip visibility the issue
> resolves itself. If that's the case for you, then it may be the same
> cause, which is a dependency load order issue. The jitsi-meet javascript
> does dimension checks on the dom to resize some elements, including
> local thumbnail. If it happens that css finishes loading after the
> javascript bundle loads and executes, the resizing will be off and cause
> visual issues. That load order issue is on jitsi's radar and hopefully
> it is the same issue you're encountering.

Thanks for your reply.

So it is a race condition? Maybe that explains why sometimes it happens
and sometimes it does not.

The strange thing is that I have only found this behavior in Chromium
and not in Firefox.

What do you mean by "toggle the filmstrip visibility"? To make some
change in interface_config.js?

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Hi, Leonard.

···

On 31/10/17 17:10, Leonard Kim wrote:

When I said toggle I meant the little caret looking icon at the end of
the filmstrip or pressing the F key to make the filmstrip either slide
off screen or slide back on screen. That forces recalculations by the
javascript and by that time the css should be loaded.

Ah! Yes, that seems to be a workaround when this problem happens. Thank
you very much.

Do you think that in a next version we could do without that workaround?

Thanks for your time.

Kind regards,
Daniel


#6

I'm not certain which future version would have the issue fixed because as
far as I know there isn't a known fix. When I first discovered the cause of
the problem I gave a quick try to fixing it by changing index.html to load
the css before the javascript bundle, but then there were css specificity
and override issues that caused far more drastic visual issues. What I know
is the jitsi team is aware of the issue and it's on the radar to fix.

···

On Tue, Oct 31, 2017 at 1:37 PM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Leonard.

On 31/10/17 17:10, Leonard Kim wrote:

> When I said toggle I meant the little caret looking icon at the end of
> the filmstrip or pressing the F key to make the filmstrip either slide
> off screen or slide back on screen. That forces recalculations by the
> javascript and by that time the css should be loaded.

Ah! Yes, that seems to be a workaround when this problem happens. Thank
you very much.

Do you think that in a next version we could do without that workaround?

Thanks for your time.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Hi, Leonard.

···

On 31/10/17 20:43, Leonard Kim wrote:

I'm not certain which future version would have the issue fixed because
as far as I know there isn't a known fix. When I first discovered the
cause of the problem I gave a quick try to fixing it by changing
index.html to load the css before the javascript bundle, but then there
were css specificity and override issues that caused far more drastic
visual issues. What I know is the jitsi team is aware of the issue and
it's on the radar to fix.

Thanks for your reply.

I can register an issue on Github if there is currently no open issue
for this. Let me know, please.

Kind regards,
Daniel


#8

There is an internal ticket for it so the issue itself will not get lost
but please feel free to open a ticket if you feel it's good to have public
documentation of it.

···

On Wed, Nov 1, 2017 at 12:30 PM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Leonard.

On 31/10/17 20:43, Leonard Kim wrote:

> I'm not certain which future version would have the issue fixed because
> as far as I know there isn't a known fix. When I first discovered the
> cause of the problem I gave a quick try to fixing it by changing
> index.html to load the css before the javascript bundle, but then there
> were css specificity and override issues that caused far more drastic
> visual issues. What I know is the jitsi team is aware of the issue and
> it's on the radar to fix.

Thanks for your reply.

I can register an issue on Github if there is currently no open issue
for this. Let me know, please.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#9

Hi, Leonard.

···

On 01/11/17 17:19, Leonard Kim wrote:

There is an internal ticket for it so the issue itself will not get lost
but please feel free to open a ticket if you feel it's good to have
public documentation of it.

Thanks for your reply. I will open a ticket in Github to have there also
the updates about this issue so that those of us who are experiencing it
are up to date about the progress on it.

Thanks for your time.

Kind regards,
Daniel