I could finally look at your patch:
- The TLS version and used cipher are okay in the CallInfo-Dialog
- The PEM certificates don't make any sense in there
What about adding the common name and the issue/end-date of the certificate
as a third line, which would be a link opening the X509CertificatePanel? If
you really want to access the raw PEM, then the X509CertificatePanel could
be modified accordingly (e.g. with a "Save As" or "Show PEM" button).
- I'm not so keen on adding three methods to the protocol provider to obtain
information about the socket
We already have providers that don't use TLS and there might be providers
that don't even use a socket. What do you (and the other devs) think about
adding an OpSet TlsConnectionDetails that would provide all these infos?
The socket creation is handled by the JSIP stack. I don't know how to obtain
the created socket without using some ugly reflection, e.g.
Field f = TLSMessageChannel.class.getDeclaredField("mySock");
Socket s =
in SipRegistrarConnection.register() and saving it in a field for future
Emil, do you know of a better way?
From: Markus Kilås [mailto:firstname.lastname@example.org]
Sent: Donnerstag, 31. Oktober 2013 15:09
To: Jitsi Developers; Ingo Bauersachs
Subject: Re: [jitsi-dev] [PATCH] Display TLS information, Was: Re: "The
of TLS on XMPP" by Thijs Alkemade
On 2013-10-30 16:47, Ingo Bauersachs wrote:
Thanks for your contribution!
As a first step towards the support for configuring TLS protocols and
cipher suites, I have created a patch which adds logging of the
available protocols/algorithms and finally the chosen ones. The patch
also adds the ability to access the protocol and algorithm used as well
as the server certificate chain.
At the moment this information will be available in the call information
frame however, in the future it would be great if this information could
be made available in a more central place in the GUI for the user to
inspect the certificate and used algorithm.
Maybe something similar to the pad lock in the web browser and its
security information dialog. As a first step towards that maybe there
could be a "call" information frame also for chats where the signaling
information could be obtained in a similar way as for the call
Currently this patch only implements support for getting the TLS
information from the Jabber ProtocolProviderService. For completeness
I wanted to have this implemented also for SIP however I got lost
somewhere in the source when searching for where this is handled. Also
I am not personally using SIP and only tried using an iptel.org
account but was unable to find any information on how to configure it
to use TLS...
I have created a pull request on Github and patch is attached:
It'll take me some time to review this, but as a first comment/in the
meantime could you please update the request so that it conforms to our
coding guidelines? (Line length is the most apparent)
I have fixed all code convention violations that I could find and
updated the request. I also added internationalizations for some texts
that I forgot that I had added in the GUI.
dev mailing list
Unsubscribe instructions and other list options: