[jitsi-dev] Support for custom placement of toolbar buttons to be removed


#1

This is a heads up for jitsi-meet users. There is currently a pull request
open in jitsi-meet to remove the support for toolbars with custom button
placement, meaning soon there will be no more support for customizing where
in the toolbars various toolbar buttons display. This customization has
been available through the interfaceConfig values TOOLBAR_BUTTONS and
MAIN_TOOLBAR_BUTTONS, by declaring button names in the order of their
desired appearance. Soon only TOOLBAR_BUTTONS will be used and the toolbar
will display a button if its associated button name is declared in the
TOOLBAR_BUTTONS array; placement will be predetermined.


#2

The heads-up is appreciated, thanks. I probably would have ended up with
non-functional configuration code after the next update.

Sideways-related: is it possible to add custom buttons (adding custom
functionality) somehow?

···

On 4 April 2018 at 23:25, Leonard Kim <lkim@atlassian.com> wrote:

This is a heads up for jitsi-meet users. There is currently a pull
request open in jitsi-meet to remove the support for toolbars with custom
button placement, meaning soon there will be no more support for
customizing where in the toolbars various toolbar buttons display. This
customization has been available through the interfaceConfig values
TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS, by declaring button names in the
order of their desired appearance. Soon only TOOLBAR_BUTTONS will be used
and the toolbar will display a button if its associated button name is
declared in the TOOLBAR_BUTTONS array; placement will be predetermined.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

The heads-up is appreciated, thanks. I probably would have ended up with non-functional configuration code after the next update.

Sideways-related: is it possible to add custom buttons (adding custom functionality) somehow?

Nope.

···

On Apr 5, 2018, at 09:47, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

On 4 April 2018 at 23:25, Leonard Kim <lkim@atlassian.com> wrote:
This is a heads up for jitsi-meet users. There is currently a pull request open in jitsi-meet to remove the support for toolbars with custom button placement, meaning soon there will be no more support for customizing where in the toolbars various toolbar buttons display. This customization has been available through the interfaceConfig values TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS, by declaring button names in the order of their desired appearance. Soon only TOOLBAR_BUTTONS will be used and the toolbar will display a button if its associated button name is declared in the TOOLBAR_BUTTONS array; placement will be predetermined.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl


#4

What is the rationale for removing this customization ability? I can see
lots of reasons not to bother adding it if it wasn't there (most of which
are "too much work for too little gain"), but what do we gain now the work
has already been done?

Martin

···

On 5 April 2018 at 15:34, Saúl Ibarra Corretgé <scorretge@atlassian.com> wrote:

> On Apr 5, 2018, at 09:47, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:
>
> The heads-up is appreciated, thanks. I probably would have ended up with
non-functional configuration code after the next update.
>
> Sideways-related: is it possible to add custom buttons (adding custom
functionality) somehow?
>

Nope.

> On 4 April 2018 at 23:25, Leonard Kim <lkim@atlassian.com> wrote:
> This is a heads up for jitsi-meet users. There is currently a pull
request open in jitsi-meet to remove the support for toolbars with custom
button placement, meaning soon there will be no more support for
customizing where in the toolbars various toolbar buttons display. This
customization has been available through the interfaceConfig values
TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS, by declaring button names in the
order of their desired appearance. Soon only TOOLBAR_BUTTONS will be used
and the toolbar will display a button if its associated button name is
declared in the TOOLBAR_BUTTONS array; placement will be predetermined.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

The rationale for removing it is that the web toolbar has been re-written
to better align with the react-native application's toolbar. The web
toolbar was in this state where it was half in react/redux but half wasn't
and ended up with some tacked on functionality (some of which I'm
completely to blame). The result was a chunk of the codebase with high
complexity that didn't seem like it needed to be complex but also strayed
away from the react-native app's implementation. When a web toolbar
redesign was requested, the plan was then to rewrite the web toolbar. So
it's not that the customizability is being removed and the toolbars left
alone; the split toolbar that displays on the left and top are gone
completely along with its accompanying code, and the customization of
toolbar button placement hasn't been implemented on the new toolbar. There
will be continued work on toolbars as redesigns for the react-native
toolbar are currently in progress.

···

On Thu, Apr 5, 2018 at 7:11 AM, Martin Bonner <martingreybeard@gmail.com> wrote:

What is the rationale for removing this customization ability? I can see
lots of reasons not to bother adding it if it wasn't there (most of which
are "too much work for too little gain"), but what do we gain now the work
has already been done?

Martin

On 5 April 2018 at 15:34, Saúl Ibarra Corretgé <scorretge@atlassian.com> > wrote:

> On Apr 5, 2018, at 09:47, Guus der Kinderen < >> guus.der.kinderen@gmail.com> wrote:
>
> The heads-up is appreciated, thanks. I probably would have ended up
with non-functional configuration code after the next update.
>
> Sideways-related: is it possible to add custom buttons (adding custom
functionality) somehow?
>

Nope.

> On 4 April 2018 at 23:25, Leonard Kim <lkim@atlassian.com> wrote:
> This is a heads up for jitsi-meet users. There is currently a pull
request open in jitsi-meet to remove the support for toolbars with custom
button placement, meaning soon there will be no more support for
customizing where in the toolbars various toolbar buttons display. This
customization has been available through the interfaceConfig values
TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS, by declaring button names in the
order of their desired appearance. Soon only TOOLBAR_BUTTONS will be used
and the toolbar will display a button if its associated button name is
declared in the TOOLBAR_BUTTONS array; placement will be predetermined.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Thanks. Unsurprisingly, that doesn't seem barking mad.

Martin

···

On 5 April 2018 at 17:20, Leonard Kim <lkim@atlassian.com> wrote:

The rationale for removing it is that the web toolbar has been re-written
to better align with the react-native application's toolbar. The web
toolbar was in this state where it was half in react/redux but half wasn't
and ended up with some tacked on functionality (some of which I'm
completely to blame). The result was a chunk of the codebase with high
complexity that didn't seem like it needed to be complex but also strayed
away from the react-native app's implementation. When a web toolbar
redesign was requested, the plan was then to rewrite the web toolbar. So
it's not that the customizability is being removed and the toolbars left
alone; the split toolbar that displays on the left and top are gone
completely along with its accompanying code, and the customization of
toolbar button placement hasn't been implemented on the new toolbar. There
will be continued work on toolbars as redesigns for the react-native
toolbar are currently in progress.

On Thu, Apr 5, 2018 at 7:11 AM, Martin Bonner <martingreybeard@gmail.com> > wrote:

What is the rationale for removing this customization ability? I can see
lots of reasons not to bother adding it if it wasn't there (most of which
are "too much work for too little gain"), but what do we gain now the work
has already been done?

Martin

On 5 April 2018 at 15:34, Saúl Ibarra Corretgé <scorretge@atlassian.com> >> wrote:

> On Apr 5, 2018, at 09:47, Guus der Kinderen < >>> guus.der.kinderen@gmail.com> wrote:
>
> The heads-up is appreciated, thanks. I probably would have ended up
with non-functional configuration code after the next update.
>
> Sideways-related: is it possible to add custom buttons (adding custom
functionality) somehow?
>

Nope.

> On 4 April 2018 at 23:25, Leonard Kim <lkim@atlassian.com> wrote:
> This is a heads up for jitsi-meet users. There is currently a pull
request open in jitsi-meet to remove the support for toolbars with custom
button placement, meaning soon there will be no more support for
customizing where in the toolbars various toolbar buttons display. This
customization has been available through the interfaceConfig values
TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS, by declaring button names in the
order of their desired appearance. Soon only TOOLBAR_BUTTONS will be used
and the toolbar will display a button if its associated button name is
declared in the TOOLBAR_BUTTONS array; placement will be predetermined.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev