[jitsi-dev] Submission of several patches


#1

Jitsi devs,
I'd like to submit fixes for the following six issues for inclusion in the Jitsi project. Patches are attached.

* Make whether stack trace is shown in error pop-ups configurable

* Add code to check for updates once a day and config option to control whether this is enabled, and the hour to check

* Add support for displaying urgent voicemail messages

* Add support for disabling messaging over SIP - net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED

* Fix yahoo login failures by changing test for whether we should re-ask the user for credentials when a yahoo login fails.

* Fix up SDP processing to treat telephone-event as a special case - i.e. don't negotiate it as the preferred codec.

Thanks
Tom

Add code to check for updates once a day and config option to control whether this is enabled, and the hour to check.patch (5.61 KB)

Add support for disabling messaging over SIP - net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED.patch (5.95 KB)

Add support for displaying urgent voicemail messages.patch (4.75 KB)

Fix up SDP processing to treat telephone-event as a special case - i.e. don’t negotiate it as the preferred codec.patch (3.65 KB)

Fix yahoo login failures by changing test for whether we should re-ask the user for credentials when a yahoo login fails.patch (2.1 KB)

Make whether stack trace is shown in error pop-ups configurable.patch (4.71 KB)


#2

I've not heard anything about these patches I submitted a couple of weeks ago. Would you prefer that I resubmit them as separate emails with 1 patch per email?

Thanks
Tom

Add code to check for updates once a day and config option to control whether this is enabled, and the hour to check.patch (5.61 KB)

Add support for disabling messaging over SIP - net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED.patch (5.95 KB)

Add support for displaying urgent voicemail messages.patch (4.75 KB)

Fix up SDP processing to treat telephone-event as a special case - i.e. don’t negotiate it as the preferred codec.patch (3.65 KB)

Fix yahoo login failures by changing test for whether we should re-ask the user for credentials when a yahoo login fails.patch (2.1 KB)

Make whether stack trace is shown in error pop-ups configurable.patch (4.71 KB)

···

From: Tom Denham [mailto:Tom.Denham@metaswitch.com]

Sent: 23 October 2012 16:35
To: dev@jitsi.java.net
Subject: [jitsi-dev] Submission of several patches

Jitsi devs,
I'd like to submit fixes for the following six issues for inclusion in the Jitsi project. Patches are attached.

* Make whether stack trace is shown in error pop-ups configurable

* Add code to check for updates once a day and config option to control whether this is enabled, and the hour to check

* Add support for displaying urgent voicemail messages

* Add support for disabling messaging over SIP - net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED

* Fix yahoo login failures by changing test for whether we should re-ask the user for credentials when a yahoo login fails.

* Fix up SDP processing to treat telephone-event as a special case - i.e. don't negotiate it as the preferred codec.

Thanks
Tom


#3

Hi Tom,

the patches for update check, sip messaging disable, yahoo login and
error dialog are committed (in r10087, r10086, r10088, r10089) and
acked on our team and contributors page.
The only modifications applied to the patches were the default values
for the configuration properties to keep the current Jitsi behavior -
sip messaging is enabled by default when presence is enabled and to
show stack trace in error dialog.

Thanks
damencho

···

On Tue, Oct 23, 2012 at 6:35 PM, Tom Denham <Tom.Denham@metaswitch.com> wrote:

Jitsi devs,

I’d like to submit fixes for the following six issues for inclusion in the
Jitsi project. Patches are attached.

· Make whether stack trace is shown in error pop-ups configurable

· Add code to check for updates once a day and config option to
control whether this is enabled, and the hour to check

· Add support for displaying urgent voicemail messages

· Add support for disabling messaging over SIP -
net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED

· Fix yahoo login failures by changing test for whether we should
re-ask the user for credentials when a yahoo login fails.

· Fix up SDP processing to treat telephone-event as a special case -
i.e. don't negotiate it as the preferred codec.

Thanks

Tom


#4

Applied committed and ACKed

Cheers,
Emil

···

On 23.10.12, 17:35, Tom Denham wrote:

· Add support for displaying urgent voicemail messages

--
https://jitsi.org


#5

Hey Tom,

I’ve not heard anything about these patches I submitted a couple of
weeks ago.

One of them is already in (committed in r10032 and acked on our
contributors page). The rest would probably be trickling in through the
following weeks.

Would you prefer that I resubmit them as separate emails with
1 patch per email?

That is indeed preferable in general, but there's no need to resubmit
them now that they are here.

Emil

···

On 08.11.12, 07:17, Tom Denham wrote:

Thanks

Tom

*From:*Tom Denham [mailto:Tom.Denham@metaswitch.com]
*Sent:* 23 October 2012 16:35
*To:* dev@jitsi.java.net
*Subject:* [jitsi-dev] Submission of several patches

Jitsi devs,

I’d like to submit fixes for the following six issues for inclusion in
the Jitsi project. Patches are attached.

· Make whether stack trace is shown in error pop-ups configurable

· Add code to check for updates once a day and config option to
control whether this is enabled, and the hour to check

· Add support for displaying urgent voicemail messages

· Add support for disabling messaging over SIP -
net.java.sip.communicator.impl.protocol.sip.MESSAGING_DISABLED

· Fix yahoo login failures by changing test for whether we
should re-ask the user for credentials when a yahoo login fails.

· Fix up SDP processing to treat telephone-event as a special
case - i.e. don't negotiate it as the preferred codec.

Thanks

Tom

--
https://jitsi.org


#6

Hello,
It seems that the Debian builds are no longer available since version
4336 (the latest Windows nightlies are at 4340.10096).

···

--
O zi buna,

Kertesz Laszlo


#7

Hi,

now they are back again.

Thanks for the report
damencho

···

On Sat, Nov 24, 2012 at 8:09 AM, Kertesz Laszlo <laszlo.kertesz@gmail.com> wrote:

Hello,
It seems that the Debian builds are no longer available since version
4336 (the latest Windows nightlies are at 4340.10096).

--
O zi buna,

Kertesz Laszlo