[jitsi-dev] strophejs package update


#1

Hi Damian,

I started looking at the work you did on this package and the upload on
mentors

Did you start with the Git repository on alioth.debian.org and did you
push a copy of your changes to Github or something? If not, when you
are updating a package that is already maintained in Git, you should

a) clone the repository from alioth
        git clone git://git.debian.org/git/pkg-xmpp/strophejs.git

b) create a personal repository on Github

c) push your changes to the personal repository on Github, e.g.

        cd strophejs
        git-import-orig -u 1.1.3 ../strophejs_1.1.3.orig.tar.gz
        git remote add github git@github.com:dpocock/strophejs.git
        git push -u github master upstream

d) tell the sponsor where you pushed the changes, then they can pull
them from Github and push them into the alioth repository for you

I downloaded the original tar.gz file from
  
https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.tar.gz

and compared it to the orig.tar.gz you submitted on mentors. The
contents of the files don't match. Can you clarify where you downloaded
the orig.tar.gz file or did you create it yourself?

Both files appear to contain some minified JavaScript so in any case you
need to create a repackaged upstream tarball before running the
"git-import-orig" command given in the example above, e.g.

     tar xzf strophejs-1.1.3.tar.gz
     find strophejs-1.1.3 -name '*.min.js' -exec rm {} \;
     tar czf strophejs_1.1.3+dfsg.orig.tar.gz

Regards,

Daniel


#2

Hi,

Hi Damian,

I started looking at the work you did on this package and the upload on
mentors

Did you start with the Git repository on alioth.debian.org and did you
push a copy of your changes to Github or something? If not, when you
are updating a package that is already maintained in Git, you should

a) clone the repository from alioth
        git clone git://git.debian.org/git/pkg-xmpp/strophejs.git

b) create a personal repository on Github

c) push your changes to the personal repository on Github, e.g.

        cd strophejs
        git-import-orig -u 1.1.3 ../strophejs_1.1.3.orig.tar.gz
        git remote add github git@github.com:dpocock/strophejs.git
        git push -u github master upstream

d) tell the sponsor where you pushed the changes, then they can pull
them from Github and push them into the alioth repository for you

Ok, I will do this and will send the location.

I downloaded the original tar.gz file from

https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.tar.gz

I've downloaded the 1.1.3 tagged zip from
https://github.com/strophe/strophejs/releases.
Hey Fippo is this correct, do you know why the two releases differ?

and compared it to the orig.tar.gz you submitted on mentors. The
contents of the files don't match. Can you clarify where you downloaded
the orig.tar.gz file or did you create it yourself?

Both files appear to contain some minified JavaScript so in any case you
need to create a repackaged upstream tarball before running the
"git-import-orig" command given in the example above, e.g.

     tar xzf strophejs-1.1.3.tar.gz
     find strophejs-1.1.3 -name '*.min.js' -exec rm {} \;
     tar czf strophejs_1.1.3+dfsg.orig.tar.gz

Will do.

Thanks
damencho

···

On Fri, Sep 19, 2014 at 10:57 AM, Daniel Pocock <daniel@pocock.pro> wrote:

Regards,

Daniel


#3

Hi,

Hi Damian,

I started looking at the work you did on this package and the upload on
mentors

Did you start with the Git repository on alioth.debian.org and did you
push a copy of your changes to Github or something? If not, when you
are updating a package that is already maintained in Git, you should

a) clone the repository from alioth
        git clone git://git.debian.org/git/pkg-xmpp/strophejs.git

b) create a personal repository on Github

c) push your changes to the personal repository on Github, e.g.

        cd strophejs
        git-import-orig -u 1.1.3 ../strophejs_1.1.3.orig.tar.gz
        git remote add github git@github.com:dpocock/strophejs.git
        git push -u github master upstream

d) tell the sponsor where you pushed the changes, then they can pull
them from Github and push them into the alioth repository for you

Ok, I will do this and will send the location.

I downloaded the original tar.gz file from

https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.tar.gz

I've downloaded the 1.1.3 tagged zip from
https://github.com/strophe/strophejs/releases.
Hey Fippo is this correct, do you know why the two releases differ?

That may explain it

There are two problems with Github releases:

a) some projects don't include everything from their repository in a
release tarball - e.g. many autotools projects run the "make dist"
command to create a release tarball containing just a subset of the
files from their repository. Source files and files listed in
EXTRA_DIST get included, other files don't.

b) Github regenerates those tarballs on the fly - so if you download
from that same link on two different computers, you might find that the
tarballs don't have identical checksums, although their content will be
identical. This is a major hassle for those distributions that record
the upstream checksums.

···

On 19/09/14 10:11, Damian Minkov wrote:

On Fri, Sep 19, 2014 at 10:57 AM, Daniel Pocock <daniel@pocock.pro> wrote:

and compared it to the orig.tar.gz you submitted on mentors. The
contents of the files don't match. Can you clarify where you downloaded
the orig.tar.gz file or did you create it yourself?

Both files appear to contain some minified JavaScript so in any case you
need to create a repackaged upstream tarball before running the
"git-import-orig" command given in the example above, e.g.

     tar xzf strophejs-1.1.3.tar.gz
     find strophejs-1.1.3 -name '*.min.js' -exec rm {} \;
     tar czf strophejs_1.1.3+dfsg.orig.tar.gz

Will do.

Thanks
damencho

Regards,

Daniel


#4

Hi Daniel,

the reason I used version (from https://github.com/strophe/strophejs/releases):
https://github.com/strophe/strophejs/archive/release-1.1.3.zip
rather than (link found on the main page http://strophe.im/strophejs/):
https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.zip
is that when I checkout the branch release-1.1.3 of strophe and make
it. The result file strophe.min.js is equals to the one from the first
link.

Hi,

Hi Damian,

I started looking at the work you did on this package and the upload on
mentors

Did you start with the Git repository on alioth.debian.org and did you
push a copy of your changes to Github or something? If not, when you
are updating a package that is already maintained in Git, you should

a) clone the repository from alioth
        git clone git://git.debian.org/git/pkg-xmpp/strophejs.git

b) create a personal repository on Github

c) push your changes to the personal repository on Github, e.g.

        cd strophejs
        git-import-orig -u 1.1.3 ../strophejs_1.1.3.orig.tar.gz
        git remote add github git@github.com:dpocock/strophejs.git
        git push -u github master upstream

d) tell the sponsor where you pushed the changes, then they can pull
them from Github and push them into the alioth repository for you

Ok, I will do this and will send the location.

The repo is ready and can be found at: https://github.com/damencho/strophejs.

I downloaded the original tar.gz file from

https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.tar.gz

I've downloaded the 1.1.3 tagged zip from
https://github.com/strophe/strophejs/releases.
Hey Fippo is this correct, do you know why the two releases differ?

That may explain it

There are two problems with Github releases:

a) some projects don't include everything from their repository in a
release tarball - e.g. many autotools projects run the "make dist"
command to create a release tarball containing just a subset of the
files from their repository. Source files and files listed in
EXTRA_DIST get included, other files don't.

b) Github regenerates those tarballs on the fly - so if you download
from that same link on two different computers, you might find that the
tarballs don't have identical checksums, although their content will be
identical. This is a major hassle for those distributions that record
the upstream checksums.

and compared it to the orig.tar.gz you submitted on mentors. The
contents of the files don't match. Can you clarify where you downloaded
the orig.tar.gz file or did you create it yourself?

Both files appear to contain some minified JavaScript so in any case you
need to create a repackaged upstream tarball before running the
"git-import-orig" command given in the example above, e.g.

     tar xzf strophejs-1.1.3.tar.gz
     find strophejs-1.1.3 -name '*.min.js' -exec rm {} \;
     tar czf strophejs_1.1.3+dfsg.orig.tar.gz

The '*.min.js' files can be found only in the archive from the second
link. But as I used the first one I didn't need to repackage it.

Regards
damencho

···

On Fri, Sep 19, 2014 at 11:16 AM, Daniel Pocock <daniel@pocock.pro> wrote:

On 19/09/14 10:11, Damian Minkov wrote:

On Fri, Sep 19, 2014 at 10:57 AM, Daniel Pocock <daniel@pocock.pro> wrote:

Will do.

Thanks
damencho

Regards,

Daniel


#5

If the strophe.min.js file differs then that could be some irregularity
in the upstream release process

If you are satisfied that there is a good reason for this, then it is
quite OK not to use the official download ZIP file.

To indicate that you are not using their official download, you can
simply include dfsg in the orig.tar.gz name, just like a repackaged tarball.

You could also include a note about it in debian/README.source
explaining how you create the orig.tar.gz

For an example very similar to this, see:

http://code.google.com/p/libphonenumber/source/browse/#svn%2Ftrunk%2Fdebian

and maybe make a script like this:

#!/bin/bash

VERSION=1.1.3

echo "*.min.js export-ignore" > .gitattributes

# assumes there is a tag named "$VERSION"
git archive --worktree-attributes --format tar --prefix
strophejs-$VERSION/ -o ../strophejs_${VERSION}+dfsg.orig.tar $VERSION

cd ..

bzip2 strophejs_${VERSION}+dfsg.orig.tar

···

On 19/09/14 11:52, Damian Minkov wrote:

Hi Daniel,

the reason I used version (from https://github.com/strophe/strophejs/releases):
https://github.com/strophe/strophejs/archive/release-1.1.3.zip
rather than (link found on the main page http://strophe.im/strophejs/):
https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.zip
is that when I checkout the branch release-1.1.3 of strophe and make
it. The result file strophe.min.js is equals to the one from the first
link.


#6

Hi again,

Committed the changes to github, and added the new package to mentors.
http://mentors.debian.net/debian/pool/main/s/strophejs/strophejs_1.1.3+dfsg-0.1.dsc
Contains debian/README.source and the package is now dfsg.

Regards
damencho

···

On Fri, Sep 19, 2014 at 1:16 PM, Daniel Pocock <daniel@pocock.pro> wrote:

On 19/09/14 11:52, Damian Minkov wrote:

Hi Daniel,

the reason I used version (from https://github.com/strophe/strophejs/releases):
https://github.com/strophe/strophejs/archive/release-1.1.3.zip
rather than (link found on the main page http://strophe.im/strophejs/):
https://raw.github.com/strophe/strophe.im/gh-pages/strophejs/downloads/strophejs-1.1.3.zip
is that when I checkout the branch release-1.1.3 of strophe and make
it. The result file strophe.min.js is equals to the one from the first
link.

If the strophe.min.js file differs then that could be some irregularity
in the upstream release process

If you are satisfied that there is a good reason for this, then it is
quite OK not to use the official download ZIP file.

To indicate that you are not using their official download, you can
simply include dfsg in the orig.tar.gz name, just like a repackaged tarball.

You could also include a note about it in debian/README.source
explaining how you create the orig.tar.gz

For an example very similar to this, see:

http://code.google.com/p/libphonenumber/source/browse/#svn%2Ftrunk%2Fdebian

and maybe make a script like this:

#!/bin/bash

VERSION=1.1.3

echo "*.min.js export-ignore" > .gitattributes

# assumes there is a tag named "$VERSION"
git archive --worktree-attributes --format tar --prefix
strophejs-$VERSION/ -o ../strophejs_${VERSION}+dfsg.orig.tar $VERSION

cd ..

bzip2 strophejs_${VERSION}+dfsg.orig.tar


#7

Great, I sponsored this upload for you and pushed your changes to the
repository on alioth

You could ask to join pkg-xmpp on alioth.debian.org and then add
yourself to the Uploaders in debian/control and then if we upload again
you don't need to call it an NMU

Regards,

Daniel

···

On 19/09/14 14:29, Damian Minkov wrote:

Hi again,

Committed the changes to github, and added the new package to mentors.
http://mentors.debian.net/debian/pool/main/s/strophejs/strophejs_1.1.3+dfsg-0.1.dsc
Contains debian/README.source and the package is now dfsg.