[jitsi-dev] Starvation when using a master password and provisioning


#1

Dear all

I'm using manually configured provisioning that requires authentication and now tested whether this combination still works when the password is saved and a master password is being used - it doesn't.

The starvation comes due to the CredentialsStorageService explicitly waiting for the UIService (felix start level 66) - which is loaded only after the provisioning has already occurred (on felix level 49).

My attempt to fix this would be to move the MasterPasswordInputDialog class from the gui bundle to the credentialsstorage bundle. As far as I can see there are no GUI dependencies.

I'd be happy to create a patch with my proposal if this sounds reasonable, or any other way if you let me know how you would like to have it.

Regards,
Ingo


#2

Hey all, (especially Yana),

Ingo and I have just had a chat about this and thought that the
simplest, and most proper way to address this would be to have the look
and feel and part of the GUI (i.e. the password dialog) load before
provisioning.

The rest should remain for later so that it would be influenced by
whatever changes are made to the configuration by the provisioning.

Yana, how does this sound to you?

Cheers,
Emil

На 08.02.11 19:38, Bauersachs Ingo написа:

···

Dear all

I'm using manually configured provisioning that requires
authentication and now tested whether this combination still works
when the password is saved and a master password is being used - it
doesn't.

The starvation comes due to the CredentialsStorageService explicitly
waiting for the UIService (felix start level 66) - which is loaded
only after the provisioning has already occurred (on felix level
49).

My attempt to fix this would be to move the MasterPasswordInputDialog
class from the gui bundle to the credentialsstorage bundle. As far as
I can see there are no GUI dependencies.

I'd be happy to create a patch with my proposal if this sounds
reasonable, or any other way if you let me know how you would like to
have it.

Regards, Ingo

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#3

Hi Ingo, Emil,

Hey all, (especially Yana),

Ingo and I have just had a chat about this and thought that the
simplest, and most proper way to address this would be to have the look
and feel and part of the GUI (i.e. the password dialog) load before
provisioning.

The rest should remain for later so that it would be influenced by
whatever changes are made to the configuration by the provisioning.

Yana, how does this sound to you?

Sounds good! I'll try to take care of this in the following week.

Ingo, could you please enter an issue for this one? I'll let you all know as soon as I commit the changes.

Cheers,
Yana

···

On Feb 11, 2011, at 11:14 AM, Emil Ivov wrote:

Cheers,
Emil

На 08.02.11 19:38, Bauersachs Ingo написа:

Dear all

I'm using manually configured provisioning that requires
authentication and now tested whether this combination still works
when the password is saved and a master password is being used - it
doesn't.

The starvation comes due to the CredentialsStorageService explicitly
waiting for the UIService (felix start level 66) - which is loaded
only after the provisioning has already occurred (on felix level
49).

My attempt to fix this would be to move the MasterPasswordInputDialog
class from the gui bundle to the credentialsstorage bundle. As far as
I can see there are no GUI dependencies.

I'd be happy to create a patch with my proposal if this sounds
reasonable, or any other way if you let me know how you would like to
have it.

Regards, Ingo

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#4

Revision 8387 should remove any dependencies between the credential
storage package and the UIService. Could you please let me know if this
solves the problem?

I can only speak for the Provisioning Service: it works there.

Thanks!
Ingo