[jitsi-dev] Smileys patch


#1

Hi,

At the moment Smileys are converted into HTML incorrectly:

</PLAINTEXT><IMG src="..." alt=":)" /><PLAINTEXT>

Note: PLAINTEXT tag in reverse order.

This results in Smileys being rendered incorrectly in Chat panel.

Below small patch which fixes this issue (by removing PLAINTEXT tag,
as it is not needed here at all?):
http://dl.dropbox.com/u/3182365/Jitsi-Smileys.patch

Regards,
Chris


#2

By looking at it from another angle, the closing PLAINTEXT at the
start closes a previous PLAINTEXT expected to be there already and the
opening PLAINTEXT at the end reopens the PLAINTEXT closed by the
closing one at the beginning i.e. it attempts to escape IMG from
PLAINTEXT. Anyway, I haven't looked at the code where this piece is
constructed.

···

On Thu, Jul 7, 2011 at 4:58 PM, Chris Maciejewski <chris@wima.co.uk> wrote:

</PLAINTEXT><IMG src="..." alt=":)" /><PLAINTEXT>

Note: PLAINTEXT tag in reverse order.


#3

Yes, I see it now... however the trouble with Outgoing message is it
can be plain text or html (if bold, underline fonts etc. are used for
example).

···

On 7 July 2011 15:31, Lyubomir Marinov <lubo@jitsi.org> wrote:

On Thu, Jul 7, 2011 at 4:58 PM, Chris Maciejewski <chris@wima.co.uk> wrote:

</PLAINTEXT><IMG src="..." alt=":)" /><PLAINTEXT>

Note: PLAINTEXT tag in reverse order.

By looking at it from another angle, the closing PLAINTEXT at the
start closes a previous PLAINTEXT expected to be there already and the
opening PLAINTEXT at the end reopens the PLAINTEXT closed by the
closing one at the beginning i.e. it attempts to escape IMG from
PLAINTEXT. Anyway, I haven't looked at the code where this piece is
constructed.