[jitsi-dev] SIP Security configuration form


#1

Hey Ingo,

I've just tried to disable the security for one of my SIP accounts and experienced some problems with the form. When I disable the checkbox "Enable support to encrypt calls" all the below checkboxes become disabled (see the screenshot), but it seems that the configurations stay the same and are not cleared, which results in incorrect configuration after finishing the setup. Actually in order to get back to the default config I should explicitly uncheck each check box and set the RTP/SAVP to "Off". In addition even if I do that I should restart Jitsi in order this to take effect. Should I enter an issue for this one or you prefer to have a look first?

Thanks!
Yana


#2

Hey Yana

I've just tried to disable the security for one of my SIP accounts and
experienced some problems with the form. When I disable the checkbox "Enable
support to encrypt calls" all the below checkboxes become disabled (see the
screenshot), but it seems that the configurations stay the same and are not
cleared,

Well, I kind of expect not lose already configured settings just because some parent setting is disabled.

which results in incorrect configuration after finishing the setup.

What exactly is incorrect? I mean, if encryption is not enabled, then neither ZRTP nor SDES start any encrypted call, regardless of any detailed configuration. (Or at least it should be that way... :slight_smile: )

Actually in order to get back to the default config I should explicitly
uncheck each check box and set the RTP/SAVP to "Off".

Do you mean you have to (instead of should)?

In addition even if I
do that I should restart Jitsi in order this to take effect.

s/should/have to ?
Could you please explain a bit further when a restart is required/desired?

Should I enter
an issue for this one or you prefer to have a look first?

I'll look at it, but you can enter an issue anyway if you like.

Thanks!
Yana

Regards,
Ingo


#3

Hey Ingo,

На 14.11.11 16:55, Bauersachs Ingo написа:

Hey Yana

I've just tried to disable the security for one of my SIP accounts
and experienced some problems with the form. When I disable the
checkbox "Enable support to encrypt calls" all the below checkboxes
become disabled (see the screenshot), but it seems that the
configurations stay the same and are not cleared,

Well, I kind of expect not lose already configured settings just
because some parent setting is disabled.

which results in incorrect configuration after finishing the
setup.

What exactly is incorrect? I mean, if encryption is not enabled, then
neither ZRTP nor SDES start any encrypted call, regardless of any
detailed configuration. (Or at least it should be that way... :slight_smile: )

I think the point was that we currently keep offering SDES streams if we
first enable them, make them mandatory, then disable security globally.

Actually in order to get back to the default config I should
explicitly uncheck each check box and set the RTP/SAVP to "Off".

Do you mean you have to (instead of should)?

In addition even if I do that I should restart Jitsi in order this
to take effect.

s/should/have to ? Could you please explain a bit further when a
restart is required/desired?

I believe both of the above were descriptions of behaviour that is
currently required from the user while it would be better if it weren't.

Cheers,
Emil

···

Should I enter an issue for this one or you prefer to have a look
first?

I'll look at it, but you can enter an issue anyway if you like.

Thanks! Yana

Regards, Ingo


#4

Hey

I commited a fix that ignores the SAVP setting when the call encryption is disabled. It should have been like this from the beginning, thanks for pointing it out!
However I couldn't reproduce/follow the restart issue. Does it still occur with the newest build?

-> r9105/b3775

Regards,
Ingo

···

-----Original Message-----
From: Emil Ivov [mailto:emcho@jitsi.org]
Sent: Montag, 14. November 2011 17:03
To: dev@jitsi.java.net
Cc: Bauersachs Ingo
Subject: Re: [jitsi-dev] Re: SIP Security configuration form
Hey Ingo,

На 14.11.11 16:55, Bauersachs Ingo написа:

Hey Yana

I've just tried to disable the security for one of my SIP accounts
and experienced some problems with the form. When I disable the
checkbox "Enable support to encrypt calls" all the below checkboxes
become disabled (see the screenshot), but it seems that the
configurations stay the same and are not cleared,

Well, I kind of expect not lose already configured settings just
because some parent setting is disabled.

which results in incorrect configuration after finishing the
setup.

What exactly is incorrect? I mean, if encryption is not enabled, then
neither ZRTP nor SDES start any encrypted call, regardless of any
detailed configuration. (Or at least it should be that way... :slight_smile: )

I think the point was that we currently keep offering SDES streams if we
first enable them, make them mandatory, then disable security globally.

Actually in order to get back to the default config I should
explicitly uncheck each check box and set the RTP/SAVP to "Off".

Do you mean you have to (instead of should)?

In addition even if I do that I should restart Jitsi in order this
to take effect.

s/should/have to ? Could you please explain a bit further when a
restart is required/desired?

I believe both of the above were descriptions of behaviour that is
currently required from the user while it would be better if it weren't.

Cheers,
Emil

Should I enter an issue for this one or you prefer to have a look
first?

I'll look at it, but you can enter an issue anyway if you like.

Thanks! Yana

Regards, Ingo


#5

Hey Ingo,

It works perfect now! I don't need to restart after changing the settings and even if I disable only the top checkbox the security is disabled.

Thanks for fixing it so fast!!!

Cheers,
Yana

···

On Nov 14, 2011, at 7:54 PM, Bauersachs Ingo wrote:

Hey

I commited a fix that ignores the SAVP setting when the call encryption is disabled. It should have been like this from the beginning, thanks for pointing it out!
However I couldn't reproduce/follow the restart issue. Does it still occur with the newest build?

-> r9105/b3775

Regards,
Ingo

-----Original Message-----
From: Emil Ivov [mailto:emcho@jitsi.org]
Sent: Montag, 14. November 2011 17:03
To: dev@jitsi.java.net
Cc: Bauersachs Ingo
Subject: Re: [jitsi-dev] Re: SIP Security configuration form
Hey Ingo,

На 14.11.11 16:55, Bauersachs Ingo написа:

Hey Yana

I've just tried to disable the security for one of my SIP accounts
and experienced some problems with the form. When I disable the
checkbox "Enable support to encrypt calls" all the below checkboxes
become disabled (see the screenshot), but it seems that the
configurations stay the same and are not cleared,

Well, I kind of expect not lose already configured settings just
because some parent setting is disabled.

which results in incorrect configuration after finishing the
setup.

What exactly is incorrect? I mean, if encryption is not enabled, then
neither ZRTP nor SDES start any encrypted call, regardless of any
detailed configuration. (Or at least it should be that way... :slight_smile: )

I think the point was that we currently keep offering SDES streams if we
first enable them, make them mandatory, then disable security globally.

Actually in order to get back to the default config I should
explicitly uncheck each check box and set the RTP/SAVP to "Off".

Do you mean you have to (instead of should)?

In addition even if I do that I should restart Jitsi in order this
to take effect.

s/should/have to ? Could you please explain a bit further when a
restart is required/desired?

I believe both of the above were descriptions of behaviour that is
currently required from the user while it would be better if it weren't.

Cheers,
Emil

Should I enter an issue for this one or you prefer to have a look
first?

I'll look at it, but you can enter an issue anyway if you like.

Thanks! Yana

Regards, Ingo