[jitsi-dev] SIP contact comparison


#1

Hi,

Question regarding the "equals()" method in ContactSipImpl.java.

Should something like:

   aContact.equals("sip:<user>@<host>:<port>")

produce a match when user and host are the same?
I think that is the intention but it doesn't match right now because the
port is factored in.

Please enlighten me.

Thanks in advance,
    Tom Uijldert.


#2

Hey Tom,

Hi,

Question regarding the "equals()" method in ContactSipImpl.java.

Should something like:

   aContact.equals("sip:<user>@<host>:<port>")

produce a match when user and host are the same?
I think that is the intention but it doesn't match right now because the
port is factored in.

Please enlighten me.

Yes, I believe you are right. We need to strip the port the way we strip
"sip:" (we also need to strip "sips:" for that matter).

Emil

···

On 21.05.13, 18:26, Tom Uijldert wrote:

Thanks in advance,
    Tom Uijldert.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#3

OK, same "sips"-stuff holds for "SipAccountID.java".

Do I create an issue or just commit and produce pull-requests?

Cheers,
    Tom.

···

-----Original Message-----
From: Emil Ivov [mailto:emcho@jitsi.org]

Hey Tom,

On 21.05.13, 18:26, Tom Uijldert wrote:
> Hi,
>
> Question regarding the "equals()" method in ContactSipImpl.java.
>
> Should something like:
>
> aContact.equals("sip:<user>@<host>:<port>")
>
> produce a match when user and host are the same?
> I think that is the intention but it doesn't match right now because
> the port is factored in.
>
> Please enlighten me.

Yes, I believe you are right. We need to strip the port the way we
strip "sip:" (we also need to strip "sips:" for that matter).