[jitsi-dev] single call and presence status


#1

Hi,

in SingleCallInProgressPolicy.java handleCallEvent can reject a call when the user's presence is:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
                        && presenceStatus <= PresenceStatus.AWAY_THRESHOLD)

As I understand it this means that it should reject calls if the user's presence is AWAY.

I set the user presence to AWAY on the GUI and a Jitsi debug shows that:
presence status = 40 (when PresenceStatus.AWAY_THRESHOLD is 31)

This means that the condition is not met.

If I change it to:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
                        && presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD)

then I am getting the expected behavior (at least that's what I want...) and calls are rejected when the Jitsi GUI general presence is set to AWAY.

Vieri


#2

Hi,

yes this one is intentional as the comment above those lines says:
                    // between AVAILABLE and AWAY (>20, <= 31) are the busy
                    // statuses as DND and On the phone
So when the user is set to DND (and this is also the name of the
property RejectIncomingCallsWhenDnD) calls are been rejected.

It seems natural to me that setting DND will be intentional by the
user and rejecting calls also, but when autoway is turned on you will
get calls rejected now and then without realizing it, like reading
some stuff in front of the computer without touching the mouse you can
get calls rejected, right?
WDYT?

Regards
damencho

···

On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> wrote:

Hi,

in SingleCallInProgressPolicy.java handleCallEvent can reject a call when the user's presence is:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
                        && presenceStatus <= PresenceStatus.AWAY_THRESHOLD)

As I understand it this means that it should reject calls if the user's presence is AWAY.

I set the user presence to AWAY on the GUI and a Jitsi debug shows that:
presence status = 40 (when PresenceStatus.AWAY_THRESHOLD is 31)

This means that the condition is not met.

If I change it to:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
                        && presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD)

then I am getting the expected behavior (at least that's what I want...) and calls are rejected when the Jitsi GUI general presence is set to AWAY.

Vieri


#3

You have a point there, Damian.
However, most of the users I install a softphone are usually quite active and "auto-away" never kicks in. Besides, one could disable auto-away. However, some users like to purposely set "away" instead of "dnd" so that other users can differentiate a "busy" user from a user that just went away (as in lunch break or whatever).
Of course in this case, calls should be rejected when "away" is set.

Anyway, not a big deal. I'm just explaining our situation which could apply to others. I just modified the code to match that condition so it meets our requirements.

Thanks!

Vieri

···

--- On Fri, 4/19/13, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

yes this one is intentional as the comment above those lines
says:

// between AVAILABLE and AWAY \(&gt;20, &lt;=

31) are the busy

// statuses as DND and On the phone

So when the user is set to DND (and this is also the name of
the
property RejectIncomingCallsWhenDnD) calls are been
rejected.

It seems natural to me that setting DND will be intentional
by the
user and rejecting calls also, but when autoway is turned on
you will
get calls rejected now and then without realizing it, like
reading
some stuff in front of the computer without touching the
mouse you can
get calls rejected, right?
WDYT?

Regards
damencho

On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> > wrote:
> Hi,
>
> in SingleCallInProgressPolicy.java handleCallEvent can
reject a call when the user's presence is:
>
> (presenceStatus > PresenceStatus.ONLINE_THRESHOLD
>
&&
presenceStatus <= PresenceStatus.AWAY_THRESHOLD)
>
> As I understand it this means that it should reject
calls if the user's presence is AWAY.
>
> I set the user presence to AWAY on the GUI and a Jitsi
debug shows that:
> presence status = 40 (when
PresenceStatus.AWAY_THRESHOLD is 31)
>
> This means that the condition is not met.
>
> If I change it to:
>
> (presenceStatus > PresenceStatus.ONLINE_THRESHOLD
>
&&
presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD)
>
> then I am getting the expected behavior (at least
that's what I want...) and calls are rejected when the Jitsi
GUI general presence is set to AWAY.
>
> Vieri
>


#4

maybe do something like:

if (auto-away enabled) then
  use "presenceStatus <= PresenceStatus.AWAY_THRESHOLD"
else
  use "presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD"

Just a thought...

···

--- On Fri, 4/19/13, Vieri <rentorbuy@yahoo.com> wrote:

You have a point there, Damian.
However, most of the users I install a softphone are usually
quite active and "auto-away" never kicks in. Besides, one
could disable auto-away. However, some users like to
purposely set "away" instead of "dnd" so that other users
can differentiate a "busy" user from a user that just went
away (as in lunch break or whatever).
Of course in this case, calls should be rejected when "away"
is set.

Anyway, not a big deal. I'm just explaining our situation
which could apply to others. I just modified the code to
match that condition so it meets our requirements.

Thanks!

Vieri

--- On Fri, 4/19/13, Damian Minkov <damencho@jitsi.org> > wrote:

> Hi,
>
> yes this one is intentional as the comment above those
lines
> says:
>
> // between AVAILABLE and AWAY (>20, <=
> 31) are the busy
>
> // statuses as DND and On the phone
> So when the user is set to DND (and this is also the
name of
> the
> property RejectIncomingCallsWhenDnD) calls are been
> rejected.
>
> It seems natural to me that setting DND will be
intentional
> by the
> user and rejecting calls also, but when autoway is
turned on
> you will
> get calls rejected now and then without realizing it,
like
> reading
> some stuff in front of the computer without touching
the
> mouse you can
> get calls rejected, right?
> WDYT?
>
> Regards
> damencho
>
>
>
> On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> > > wrote:
> > Hi,
> >
> > in SingleCallInProgressPolicy.java handleCallEvent
can
> reject a call when the user's presence is:
> >
> > (presenceStatus >
PresenceStatus.ONLINE_THRESHOLD
> >
> &&
> presenceStatus <= PresenceStatus.AWAY_THRESHOLD)
> >
> > As I understand it this means that it should
reject
> calls if the user's presence is AWAY.
> >
> > I set the user presence to AWAY on the GUI and a
Jitsi
> debug shows that:
> > presence status = 40 (when
> PresenceStatus.AWAY_THRESHOLD is 31)
> >
> > This means that the condition is not met.
> >
> > If I change it to:
> >
> > (presenceStatus >
PresenceStatus.ONLINE_THRESHOLD
> >
> &&
> presenceStatus <
PresenceStatus.AVAILABLE_THRESHOLD)
> >
> > then I am getting the expected behavior (at least
> that's what I want...) and calls are rejected when the
Jitsi
> GUI general presence is set to AWAY.
> >
> > Vieri
> >
>


#5

Hey Vieri,

You have a point there, Damian.
However, most of the users I install a softphone are usually quite active and "auto-away" never kicks in. Besides, one could disable auto-away. However, some users like to purposely set "away" instead of "dnd" so that other users can differentiate a "busy" user from a user that just went away (as in lunch break or whatever).
Of course in this case, calls should be rejected when "away" is set.

Since we have a discussion going: This all sounds to me like misuse of
the "away". DND means what it says: do not disturb. Calls can be
disturbing so they are blocked.

Away means I am not at the computer, so I may not be there to answer
your calls and messages. But I'll be back at some point and I'll see
your tried to reach me. I don't see how this would mean "prevent people
from calling me". On the contrary, you may not be at the computer but
you can still potentially hear calls. If there's a chance for that, then
why not give it a try? You are not bothering. And then, after some time,
you would expect the server to send you to voicemail.

Most applications would behave this way.

Cheers,
Emil

···

On 19.04.13, 23:18, Vieri wrote:

Anyway, not a big deal. I'm just explaining our situation which could apply to others. I just modified the code to match that condition so it meets our requirements.

Thanks!

Vieri

--- On Fri, 4/19/13, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

yes this one is intentional as the comment above those lines
says:
               
    // between AVAILABLE and AWAY (>20, <=
31) are the busy
               
    // statuses as DND and On the phone
So when the user is set to DND (and this is also the name of
the
property RejectIncomingCallsWhenDnD) calls are been
rejected.

It seems natural to me that setting DND will be intentional
by the
user and rejecting calls also, but when autoway is turned on
you will
get calls rejected now and then without realizing it, like
reading
some stuff in front of the computer without touching the
mouse you can
get calls rejected, right?
WDYT?

Regards
damencho

On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> >> wrote:

Hi,

in SingleCallInProgressPolicy.java handleCallEvent can

reject a call when the user's presence is:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
               

         &&
presenceStatus <= PresenceStatus.AWAY_THRESHOLD)

As I understand it this means that it should reject

calls if the user's presence is AWAY.

I set the user presence to AWAY on the GUI and a Jitsi

debug shows that:

presence status = 40 (when

PresenceStatus.AWAY_THRESHOLD is 31)

This means that the condition is not met.

If I change it to:

(presenceStatus > PresenceStatus.ONLINE_THRESHOLD
               

         &&
presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD)

then I am getting the expected behavior (at least

that's what I want...) and calls are rejected when the Jitsi
GUI general presence is set to AWAY.

Vieri

--
https://jitsi.org


#6

Well again, this seems to me like an effort to turn the AWAY state into
something that it is not. It is courtesy message to others explaining
that you may not be there. It is not a means to tell people that you do
not want to be disturbed. "Do Not Disturb" is the state for that.

Emil

···

On 19.04.13, 23:27, Vieri wrote:

maybe do something like:

if (auto-away enabled) then
  use "presenceStatus <= PresenceStatus.AWAY_THRESHOLD"
else
  use "presenceStatus < PresenceStatus.AVAILABLE_THRESHOLD"

Just a thought...

--- On Fri, 4/19/13, Vieri <rentorbuy@yahoo.com> wrote:

You have a point there, Damian.
However, most of the users I install a softphone are usually
quite active and "auto-away" never kicks in. Besides, one
could disable auto-away. However, some users like to
purposely set "away" instead of "dnd" so that other users
can differentiate a "busy" user from a user that just went
away (as in lunch break or whatever).
Of course in this case, calls should be rejected when "away"
is set.

Anyway, not a big deal. I'm just explaining our situation
which could apply to others. I just modified the code to
match that condition so it meets our requirements.

Thanks!

Vieri

--- On Fri, 4/19/13, Damian Minkov <damencho@jitsi.org> >> wrote:

Hi,

yes this one is intentional as the comment above those

lines

says:
               
    // between AVAILABLE and AWAY (>20, <=
31) are the busy
               
    // statuses as DND and On the phone
So when the user is set to DND (and this is also the

name of

the
property RejectIncomingCallsWhenDnD) calls are been
rejected.

It seems natural to me that setting DND will be

intentional

by the
user and rejecting calls also, but when autoway is

turned on

you will
get calls rejected now and then without realizing it,

like

reading
some stuff in front of the computer without touching

the

mouse you can
get calls rejected, right?
WDYT?

Regards
damencho

On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> >>> wrote:

Hi,

in SingleCallInProgressPolicy.java handleCallEvent

can

reject a call when the user's presence is:

(presenceStatus >

PresenceStatus.ONLINE_THRESHOLD

               

         &&
presenceStatus <= PresenceStatus.AWAY_THRESHOLD)

As I understand it this means that it should

reject

calls if the user's presence is AWAY.

I set the user presence to AWAY on the GUI and a

Jitsi

debug shows that:

presence status = 40 (when

PresenceStatus.AWAY_THRESHOLD is 31)

This means that the condition is not met.

If I change it to:

(presenceStatus >

PresenceStatus.ONLINE_THRESHOLD

               

         &&
presenceStatus <

PresenceStatus.AVAILABLE_THRESHOLD)

then I am getting the expected behavior (at least

that's what I want...) and calls are rejected when the

Jitsi

GUI general presence is set to AWAY.

Vieri

--
https://jitsi.org


#7

Hi Emil,

OK, never mind.
I guess it's just that people here in my network want something a little off-standards I suppose.
THe DND state is clear to them and they will usually set it when they're near the PC or working with it but they just can't attend anyone on the phone.
The AWAY state is considered as "I'm not necessarily BUSY AT WORK but I'm somewhere in the building - maybe having a coffee or on my lunch break - and will be coming back soon (but don't bother calling because I won't hear it and it might bother my colleagues)". If someone still wants to contact the user who's in the BUSY or AWAY state then the PBX can forward the call to voicemail. The call will also appear in Jitsi's call history.

Anyway, this seems to be what most of my softphone users here think about AWAY.
Personally I agree more with how you see it (and most people) but I suppose it's just a question of how the company wants it.

Thanks for your thoughts!

Vieri

···

--- On Fri, 4/19/13, Emil Ivov <emcho@jitsi.org> wrote:

Well again, this seems to me like an
effort to turn the AWAY state into
something that it is not. It is courtesy message to others
explaining
that you may not be there. It is not a means to tell people
that you do
not want to be disturbed. "Do Not Disturb" is the state for
that.

Emil

On 19.04.13, 23:27, Vieri wrote:
> maybe do something like:
>
> if (auto-away enabled) then
> use "presenceStatus <=
PresenceStatus.AWAY_THRESHOLD"
> else
> use "presenceStatus <
PresenceStatus.AVAILABLE_THRESHOLD"
>
> Just a thought...
>
> --- On Fri, 4/19/13, Vieri <rentorbuy@yahoo.com> > wrote:
>
>> You have a point there, Damian.
>> However, most of the users I install a softphone
are usually
>> quite active and "auto-away" never kicks in.
Besides, one
>> could disable auto-away. However, some users like
to
>> purposely set "away" instead of "dnd" so that other
users
>> can differentiate a "busy" user from a user that
just went
>> away (as in lunch break or whatever).
>> Of course in this case, calls should be rejected
when "away"
>> is set.
>>
>> Anyway, not a big deal. I'm just explaining our
situation
>> which could apply to others. I just modified the
code to
>> match that condition so it meets our requirements.
>>
>> Thanks!
>>
>> Vieri
>>
>> --- On Fri, 4/19/13, Damian Minkov <damencho@jitsi.org> > >> wrote:
>>
>>> Hi,
>>>
>>> yes this one is intentional as the comment
above those
>> lines
>>> says:
>>>

>>> // between AVAILABLE
and AWAY (>20, <=
>>> 31) are the busy
>>>

>>> // statuses as DND and
On the phone
>>> So when the user is set to DND (and this is
also the
>> name of
>>> the
>>> property RejectIncomingCallsWhenDnD) calls are
been
>>> rejected.
>>>
>>> It seems natural to me that setting DND will
be
>> intentional
>>> by the
>>> user and rejecting calls also, but when autoway
is
>> turned on
>>> you will
>>> get calls rejected now and then without
realizing it,
>> like
>>> reading
>>> some stuff in front of the computer without
touching
>> the
>>> mouse you can
>>> get calls rejected, right?
>>> WDYT?
>>>
>>> Regards
>>> damencho
>>>
>>>
>>>
>>> On Thu, Apr 18, 2013 at 2:08 PM, Vieri <rentorbuy@yahoo.com> > >>> wrote:
>>>> Hi,
>>>>
>>>> in SingleCallInProgressPolicy.java
handleCallEvent
>> can
>>> reject a call when the user's presence is:
>>>>
>>>> (presenceStatus >
>> PresenceStatus.ONLINE_THRESHOLD
>>>>

>>> &&
>>> presenceStatus <=
PresenceStatus.AWAY_THRESHOLD)
>>>>
>>>> As I understand it this means that it
should
>> reject
>>> calls if the user's presence is AWAY.
>>>>
>>>> I set the user presence to AWAY on the GUI
and a
>> Jitsi
>>> debug shows that:
>>>> presence status = 40 (when
>>> PresenceStatus.AWAY_THRESHOLD is 31)
>>>>
>>>> This means that the condition is not met.
>>>>
>>>> If I change it to:
>>>>
>>>> (presenceStatus >
>> PresenceStatus.ONLINE_THRESHOLD
>>>>

>>> &&
>>> presenceStatus <
>> PresenceStatus.AVAILABLE_THRESHOLD)
>>>>
>>>> then I am getting the expected behavior (at
least
>>> that's what I want...) and calls are rejected
when the
>> Jitsi
>>> GUI general presence is set to AWAY.
>>>>
>>>> Vieri
>>>>
>>>
>>
>

--
https://jitsi.org