[jitsi-dev] REST and Endpoints


#1

I think the focus issue has something to do with the bridge not sending anything.

This part crashes:

     * {@inheritDoc}
      */
     @Override
     protected void dominantSpeakerChanged()
     {
         Endpoint dominantEndpoint = conferenceSpeechActivity.getDominantEndpoint();

         if (getEndpoint().equals(dominantEndpoint))
         {
             // We are the new dominant speaker. We expect other endpoints to
             // mark us as a selected endpoint as soon as they receive the
             // notification.

             if (getContent().getChannelCount() < 3)
             {

In the class VideoChannel.

Because the value of this.endpoint has not been set for the VideoChannel.

It is a bit odd with only one speaker as that has to be the dominant speaker.

I will look to see why endpoint isn't set, but I have other things to do today as well. I have done a bodge to tell it that a null endpoint means that "we are not the new dominant speaker" and see what happens. It doesn't crash then, but still does not transmit anything (almost certainly related to there being a null endpoint).

Any hints?

In both patches I set the endpoint to be the same value as the channel-bundle-id as is the case in:

https://github.com/jitsi/jitsi-videobridge/blob/master/doc/rest-videobridge.md

I have written a status http/html page to easily look at the live conferences and I get this:

  Status

number of conferences 1 id:7ded4f6ec28a5a06
audiochannels:2
Endpoint: null Id:a95ddf13377356e2 cbidnull Endpoint: null Id:6e2c693b5289055 cbidnull videochannels:2
Endpoint: null Id:7485af9a067c35c2 cbidnull Endpoint: null Id:8e6cd9cb51826ad1 cbidnull

before patching and this

  Status

number of conferences 1 id:7ded4f6ec28a5a06
audiochannels:4
Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:92314a753fd84dc1 cbid4e100ae Endpoint: null Id:a95ddf13377356e2 cbidnull Endpoint: null Id:6e2c693b5289055 cbidnull Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:eb9e34abfe57429d cbid4e100ae videochannels:4
Endpoint: null Id:7485af9a067c35c2 cbidnull Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:65b76a92161746aa cbid4e100ae Endpoint: null Id:8e6cd9cb51826ad1 cbidnull Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:59b8e3a6dbae3225 cbid4e100ae datachannels:2
Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:c58a90ae6146d87 cbid4e100ae Endpoint: org.jitsi.videobridge.Endpoint 4e100ae Id:e3e505518ba7647e cbid4e100ae

After patching. It is a bit messy, but it lists the content and channels within the content for each conference with Ids, and endpoints.

I am not really sure why it has created 2 more audio channels and 2 more video channels for one patch. Is that a channel in and a channel out?